Reimplement {EVP_CIPHER,EVP_MD,OBJ_NAME}_do_all{,_sorted}(3)

This implements the do_all API by simple loops over the tables of
digests and ciphers. Since some ciphers are only available on some
platforms, we need to skip them if necessary. We use loops in each
of the functions rather the convoluted way of reducing some of the
loops to others.

Since the tables are sorted, as ensured by regress, both do_all() and
do_all_sorted() walk the lists in order. In particular, we no longer
need to allocate to be able to sort hash tables by name on the fly in a
void function that may end up doing nothing because allocation failed.
We still need to do an unchecked OPENSSL_init_crypto() call. But that's
what prayer and clean living are there for (as beck put it).

The OBJ_NAME API is completely misnamed. It has little to do with objects
and a lot to do with EVP. Therefore we implement what will remain from
its saner replacement in the evp directory, i.e., evp_names.c.

ok jsing

1 files changed, 1 insertions, 92 deletions

diff --git a/src/lib/libcrypto/evp/names.c b/src/lib/libcrypto/evp/names.c
index a96301ed56..7f5b455088 100644
--- a/src/lib/libcrypto/evp/names.c
+++ b/src/lib/libcrypto/evp/names.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: names.c,v 1.22 2023/12/15 14:22:10 tb Exp $ */
+/* $OpenBSD: names.c,v 1.23 2024/01/13 11:08:39 tb Exp $ */
 /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
  * All rights reserved.
  *
@@ -146,94 +146,3 @@ EVP_cleanup(void)
                 OBJ_cleanup();
         }
 }
-
-struct doall_cipher {
-        void *arg;
-        void (*fn)(const EVP_CIPHER *ciph, const char *from, const char *to,
-            void *arg);
-};
-
-static void
-do_all_cipher_fn(const OBJ_NAME *nm, void *arg)
-{
-        struct doall_cipher *dc = arg;
-
-        if (nm->alias)
-                dc->fn(NULL, nm->name, nm->data, dc->arg);
-        else
-                dc->fn((const EVP_CIPHER *)nm->data, nm->name, NULL, dc->arg);
-}
-
-void
-EVP_CIPHER_do_all(void (*fn)(const EVP_CIPHER *ciph, const char *from,
-    const char *to, void *x), void *arg)
-{
-        struct doall_cipher dc;
-
-        /* Prayer and clean living lets you ignore errors, OpenSSL style */
-        (void) OPENSSL_init_crypto(0, NULL);
-
-        dc.fn = fn;
-        dc.arg = arg;
-        OBJ_NAME_do_all(OBJ_NAME_TYPE_CIPHER_METH, do_all_cipher_fn, &dc);
-}
-
-void
-EVP_CIPHER_do_all_sorted(void (*fn)(const EVP_CIPHER *ciph, const char *from,
-    const char *to, void *x), void *arg)
-{
-        struct doall_cipher dc;
-
-        /* Prayer and clean living lets you ignore errors, OpenSSL style */
-        (void) OPENSSL_init_crypto(0, NULL);
-
-        dc.fn = fn;
-        dc.arg = arg;
-        OBJ_NAME_do_all_sorted(OBJ_NAME_TYPE_CIPHER_METH,
-            do_all_cipher_fn, &dc);
-}
-
-struct doall_md {
-        void *arg;
-        void (*fn)(const EVP_MD *ciph, const char *from, const char *to,
-            void *arg);
-};
-
-static void
-do_all_md_fn(const OBJ_NAME *nm, void *arg)
-{
-        struct doall_md *dc = arg;
-
-        if (nm->alias)
-                dc->fn(NULL, nm->name, nm->data, dc->arg);
-        else
-                dc->fn((const EVP_MD *)nm->data, nm->name, NULL, dc->arg);
-}
-
-void
-EVP_MD_do_all(void (*fn)(const EVP_MD *md, const char *from, const char *to,
-    void *x), void *arg)
-{
-        struct doall_md dc;
-
-        /* Prayer and clean living lets you ignore errors, OpenSSL style */
-        (void) OPENSSL_init_crypto(0, NULL);
-
-        dc.fn = fn;
-        dc.arg = arg;
-        OBJ_NAME_do_all(OBJ_NAME_TYPE_MD_METH, do_all_md_fn, &dc);
-}
-
-void
-EVP_MD_do_all_sorted(void (*fn)(const EVP_MD *md,
-    const char *from, const char *to, void *x), void *arg)
-{
-        struct doall_md dc;
-
-        /* Prayer and clean living lets you ignore errors, OpenSSL style */
-        (void) OPENSSL_init_crypto(0, NULL);
-
-        dc.fn = fn;
-        dc.arg = arg;
-        OBJ_NAME_do_all_sorted(OBJ_NAME_TYPE_MD_METH, do_all_md_fn, &dc);
-}