Make LHASH_OF() and STACK_OF() use opaque structs

This removes internals of these two special snowflakes and will allow
further simplifications. Unfortunately, there are some pieces of
software that actually use LHASH_OF() (looking at you, pound, Ruby, and
openssl(1)), so we get to keep exposing this garbage, at least for now.

Expose lh_error() as a symbol to replace a macro reaching into _LHASH.
lh_down_load() is no longer available. _LHASH and _STACK are now opaque,
LHASH_NODE becomes internal-only.

from jsing

1 files changed, 2 insertions, 1 deletions

diff --git a/src/lib/libcrypto/hidden/openssl/lhash.h b/src/lib/libcrypto/hidden/openssl/lhash.h
index eee272cf46..2cf5b2dc5a 100644
--- a/src/lib/libcrypto/hidden/openssl/lhash.h
+++ b/src/lib/libcrypto/hidden/openssl/lhash.h
@@ -1,4 +1,4 @@
-/* $OpenBSD: lhash.h,v 1.3 2024/03/02 11:04:51 tb Exp $ */
+/* $OpenBSD: lhash.h,v 1.4 2024/03/02 11:11:11 tb Exp $ */
 /*
  * Copyright (c) 2023 Bob Beck <beck@openbsd.org>
  *
@@ -27,6 +27,7 @@
 
 LCRYPTO_USED(lh_new);
 LCRYPTO_USED(lh_free);
+LCRYPTO_USED(lh_error);
 LCRYPTO_USED(lh_insert);
 LCRYPTO_USED(lh_delete);
 LCRYPTO_USED(lh_retrieve);