summaryrefslogtreecommitdiff
path: root/src/lib/libcrypto/man
diff options
context:
space:
mode:
authortb <>2025-03-25 11:54:34 +0000
committertb <>2025-03-25 11:54:34 +0000
commit6f92495acd179d025b8f561a930cab91a2c821b7 (patch)
tree8896dfbd0d7e47f51c6f03db41243178e148cbb0 /src/lib/libcrypto/man
parent70275e713454e731b5cbf6545eff93592d1d9872 (diff)
downloadopenbsd-master.tar.gz
openbsd-master.tar.bz2
openbsd-master.zip
Fix RETURN VALUES for EVP_CIPHER_CTX_ctrl(3)HEADmaster
The current documentation was clearly incorrect since a return of -1 from the methods is explicitly intercepted and translated to 0. schwarze and I both audited the tree and concluded that only 0 and 1 is possible. OpenSSL 3 broke this API contract and now has explicit return -1 in the convoluted 200-line maze this simple function has become with recent provider improvements. So add a small sentence hinting at that. Nobody will be surprised to read that with OpenSSL's characteristic penchant for needless inconsistency the return value checks in their tree are all over the place and sometimes incorrect. ok schwarze (with two tweaks)
Diffstat (limited to '')
-rw-r--r--src/lib/libcrypto/man/EVP_CIPHER_CTX_ctrl.313
1 files changed, 4 insertions, 9 deletions
diff --git a/src/lib/libcrypto/man/EVP_CIPHER_CTX_ctrl.3 b/src/lib/libcrypto/man/EVP_CIPHER_CTX_ctrl.3
index a75b722cd4..d7ab36e711 100644
--- a/src/lib/libcrypto/man/EVP_CIPHER_CTX_ctrl.3
+++ b/src/lib/libcrypto/man/EVP_CIPHER_CTX_ctrl.3
@@ -1,4 +1,4 @@
1.\" $OpenBSD: EVP_CIPHER_CTX_ctrl.3,v 1.3 2024/12/08 17:41:23 schwarze Exp $ 1.\" $OpenBSD: EVP_CIPHER_CTX_ctrl.3,v 1.4 2025/03/25 11:54:34 tb Exp $
2.\" full merge up to: OpenSSL 5211e094 Nov 11 14:39:11 2014 -0800 2.\" full merge up to: OpenSSL 5211e094 Nov 11 14:39:11 2014 -0800
3.\" 3.\"
4.\" This file is a derived work. 4.\" This file is a derived work.
@@ -67,7 +67,7 @@
67.\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED 67.\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
68.\" OF THE POSSIBILITY OF SUCH DAMAGE. 68.\" OF THE POSSIBILITY OF SUCH DAMAGE.
69.\" 69.\"
70.Dd $Mdocdate: December 8 2024 $ 70.Dd $Mdocdate: March 25 2025 $
71.Dt EVP_CIPHER_CTX_CTRL 3 71.Dt EVP_CIPHER_CTX_CTRL 3
72.Os 72.Os
73.Sh NAME 73.Sh NAME
@@ -198,13 +198,8 @@ IV length for the context as returned by
198.Fn EVP_CIPHER_CTX_iv_length . 198.Fn EVP_CIPHER_CTX_iv_length .
199.Sh RETURN VALUES 199.Sh RETURN VALUES
200.Fn EVP_CIPHER_CTX_ctrl 200.Fn EVP_CIPHER_CTX_ctrl
201usually returns 1 for success, 0 for failure, or \-1 if the 201returns 1 for success or 0 for failure.
202.Fa type 202Some implementations may return negative values for some errors.
203is not supported by the
204.Fa ctx ,
205but there may be exceptions for some
206.Fa type
207arguments.
208.Pp 203.Pp
209.Fn EVP_CIPHER_CTX_set_padding 204.Fn EVP_CIPHER_CTX_set_padding
210always returns 1. 205always returns 1.