diff options
author | deraadt <> | 2015-04-11 16:03:21 +0000 |
---|---|---|
committer | deraadt <> | 2015-04-11 16:03:21 +0000 |
commit | 3f6d0024da68bdf5d0f128537ac3ed536e6e6a6c (patch) | |
tree | 02ee416418c40719cf48cd968d4b546afbaf642a /src/lib/libcrypto/x509/x509_vfy.c | |
parent | 0a2c31c8f577b7611e81418bbe11b6a748f005ca (diff) | |
download | openbsd-3f6d0024da68bdf5d0f128537ac3ed536e6e6a6c.tar.gz openbsd-3f6d0024da68bdf5d0f128537ac3ed536e6e6a6c.tar.bz2 openbsd-3f6d0024da68bdf5d0f128537ac3ed536e6e6a6c.zip |
Remove all getenv() calls, especially those wrapped by issetugid().
getenv()'s wrapped by issetugid() are safe, but issetugid() is correct
difficult to impliment on many operating systems. By accident, a grand
experiment was run over the last year, where issetugid() returned 1 (the
safe value) on a few operating systems. Noone noticed & complained that
certain environment variables were not working.......
ok doug beck jsing, discussion with others
Diffstat (limited to 'src/lib/libcrypto/x509/x509_vfy.c')
-rw-r--r-- | src/lib/libcrypto/x509/x509_vfy.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/src/lib/libcrypto/x509/x509_vfy.c b/src/lib/libcrypto/x509/x509_vfy.c index c383fda4f2..442035625a 100644 --- a/src/lib/libcrypto/x509/x509_vfy.c +++ b/src/lib/libcrypto/x509/x509_vfy.c | |||
@@ -1,4 +1,4 @@ | |||
1 | /* $OpenBSD: x509_vfy.c,v 1.40 2015/02/11 02:17:59 jsing Exp $ */ | 1 | /* $OpenBSD: x509_vfy.c,v 1.41 2015/04/11 16:03:21 deraadt Exp $ */ |
2 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) | 2 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) |
3 | * All rights reserved. | 3 | * All rights reserved. |
4 | * | 4 | * |
@@ -483,12 +483,6 @@ check_chain_extensions(X509_STORE_CTX *ctx) | |||
483 | } else { | 483 | } else { |
484 | allow_proxy_certs = | 484 | allow_proxy_certs = |
485 | !!(ctx->param->flags & X509_V_FLAG_ALLOW_PROXY_CERTS); | 485 | !!(ctx->param->flags & X509_V_FLAG_ALLOW_PROXY_CERTS); |
486 | #if 0 | ||
487 | /* A hack to keep people who don't want to modify their | ||
488 | software happy */ | ||
489 | if (issetugid() == 0 && getenv("OPENSSL_ALLOW_PROXY_CERTS")) | ||
490 | allow_proxy_certs = 1; | ||
491 | #endif | ||
492 | purpose = ctx->param->purpose; | 486 | purpose = ctx->param->purpose; |
493 | } | 487 | } |
494 | 488 | ||