Replace all use of ERR_add_error_data with ERR_asprintf_error_data.

This avoids a lot of ugly gymnastics to do snprintfs before sending the
bag of strings to ERR, and eliminates at least one place in dso_dlfctn.c
where it was being called with the incorrect number of arguments and
using random things off the stack as addresses of strings.
ok krw@, jsing@

1 files changed, 1 insertions, 1 deletions

diff --git a/src/lib/libcrypto/x509/x509name.c b/src/lib/libcrypto/x509/x509name.c
index 3d90fd67fe..32fce2debb 100644
--- a/src/lib/libcrypto/x509/x509name.c
+++ b/src/lib/libcrypto/x509/x509name.c
@@ -298,7 +298,7 @@ X509_NAME_ENTRY_create_by_txt(X509_NAME_ENTRY **ne,
         if (obj == NULL) {
                 X509err(X509_F_X509_NAME_ENTRY_CREATE_BY_TXT,
                     X509_R_INVALID_FIELD_NAME);
-                ERR_add_error_data(2, "name=", field);
+                ERR_asprintf_error_data("name=%s", field);
                 return (NULL);
         }
         nentry = X509_NAME_ENTRY_create_by_OBJ(ne, obj, type, bytes, len);