no need for null check before free. from Brendan MacDonell

2 files changed, 2 insertions, 4 deletions

diff --git a/src/lib/libcrypto/x509/by_dir.c b/src/lib/libcrypto/x509/by_dir.c
index fdfca6140a..554f6600dc 100644
--- a/src/lib/libcrypto/x509/by_dir.c
+++ b/src/lib/libcrypto/x509/by_dir.c
@@ -184,8 +184,7 @@ by_dir_hash_cmp(const BY_DIR_HASH * const *a,
 static void
 by_dir_entry_free(BY_DIR_ENTRY *ent)
 {
-        if (ent->dir)
-                free(ent->dir);
+        free(ent->dir);
         if (ent->hashes)
                 sk_BY_DIR_HASH_pop_free(ent->hashes, by_dir_hash_free);
         free(ent);
diff --git a/src/lib/libcrypto/x509/x509_vpm.c b/src/lib/libcrypto/x509/x509_vpm.c
index c2cebd936f..3ee3116ac1 100644
--- a/src/lib/libcrypto/x509/x509_vpm.c
+++ b/src/lib/libcrypto/x509/x509_vpm.c
@@ -212,8 +212,7 @@ X509_VERIFY_PARAM_set1(X509_VERIFY_PARAM *to, const X509_VERIFY_PARAM *from)
 int
 X509_VERIFY_PARAM_set1_name(X509_VERIFY_PARAM *param, const char *name)
 {
-        if (param->name)
-                free(param->name);
+        free(param->name);
         param->name = BUF_strdup(name);
         if (param->name)
                 return 1;