Ok, there was a need for OPENSSL_cleanse() instead of bzero() to prevent

supposedly smart compilers from optimizing memory cleanups away. Understood.

Ok, in case of an hypothetically super smart compiler, OPENSSL_cleanse() had
to be convoluted enough for the compiler not to recognize that this was
actually bzero() in disguise. Understood.

But then why there had been optimized assembler versions of OPENSSL_cleanse()
is beyond me. Did someone not trust the C obfuscation?

1 files changed, 0 insertions, 34 deletions

diff --git a/src/lib/libcrypto/x86cpuid.pl b/src/lib/libcrypto/x86cpuid.pl
index b270b44337..0da613f697 100644
--- a/src/lib/libcrypto/x86cpuid.pl
+++ b/src/lib/libcrypto/x86cpuid.pl
@@ -307,40 +307,6 @@ for (@ARGV) { $sse2=1 if (/-DOPENSSL_IA32_SSE2/); }
         }
 &function_end_B("OPENSSL_indirect_call");
 
-&function_begin_B("OPENSSL_cleanse");
-        &mov    ("edx",&wparam(0));
-        &mov    ("ecx",&wparam(1));
-        &xor    ("eax","eax");
-        &cmp    ("ecx",7);
-        &jae    (&label("lot"));
-        &cmp    ("ecx",0);
-        &je     (&label("ret"));
-&set_label("little");
-        &mov    (&BP(0,"edx"),"al");
-        &sub    ("ecx",1);
-        &lea    ("edx",&DWP(1,"edx"));
-        &jnz    (&label("little"));
-&set_label("ret");
-        &ret    ();
-
-&set_label("lot",16);
-        &test   ("edx",3);
-        &jz     (&label("aligned"));
-        &mov    (&BP(0,"edx"),"al");
-        &lea    ("ecx",&DWP(-1,"ecx"));
-        &lea    ("edx",&DWP(1,"edx"));
-        &jmp    (&label("lot"));
-&set_label("aligned");
-        &mov    (&DWP(0,"edx"),"eax");
-        &lea    ("ecx",&DWP(-4,"ecx"));
-        &test   ("ecx",-4);
-        &lea    ("edx",&DWP(4,"edx"));
-        &jnz    (&label("aligned"));
-        &cmp    ("ecx",0);
-        &jne    (&label("little"));
-        &ret    ();
-&function_end_B("OPENSSL_cleanse");
-
 &function_begin_B("OPENSSL_ia32_rdrand");
         &mov    ("ecx",8);
 &set_label("loop");