summaryrefslogtreecommitdiff
path: root/src/lib/libcrypto
diff options
context:
space:
mode:
authorbcook <>2026-02-07 17:12:47 +0000
committerbcook <>2026-02-07 17:12:47 +0000
commit36d1f52b62304ee4c3c58e4d9e76e912f868d8cc (patch)
tree8e36e4155f1340372dfdb4f68eee121e6f3be42d /src/lib/libcrypto
parent9d653fe05875a7749100f123952b96016a687b23 (diff)
downloadopenbsd-36d1f52b62304ee4c3c58e4d9e76e912f868d8cc.tar.gz
openbsd-36d1f52b62304ee4c3c58e4d9e76e912f868d8cc.tar.bz2
openbsd-36d1f52b62304ee4c3c58e4d9e76e912f868d8cc.zip
replace buggy strncmp with strcmp found with clang-tidyHEADmaster
Found the same fix from davidben in BoringSSL as well (https://boringssl-review.googlesource.com/c/boringssl/+/87927). OpenSSL appears to have accidentally changed the semantics here with the HAS_PREFIX macro, which appears to be incorrect. discussed w/ tb@ & beck@
Diffstat (limited to 'src/lib/libcrypto')
-rw-r--r--src/lib/libcrypto/x509/x509_crld.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/libcrypto/x509/x509_crld.c b/src/lib/libcrypto/x509/x509_crld.c
index 75afcefca8..40cbbbdc2c 100644
--- a/src/lib/libcrypto/x509/x509_crld.c
+++ b/src/lib/libcrypto/x509/x509_crld.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: x509_crld.c,v 1.10 2025/05/10 05:54:39 tb Exp $ */ 1/* $OpenBSD: x509_crld.c,v 1.11 2026/02/07 17:12:47 bcook Exp $ */
2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL 2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
3 * project 1999. 3 * project 1999.
4 */ 4 */
@@ -144,7 +144,7 @@ set_dist_point_name(DIST_POINT_NAME **pdp, X509V3_CTX *ctx, CONF_VALUE *cnf)
144 STACK_OF(GENERAL_NAME) *fnm = NULL; 144 STACK_OF(GENERAL_NAME) *fnm = NULL;
145 STACK_OF(X509_NAME_ENTRY) *rnm = NULL; 145 STACK_OF(X509_NAME_ENTRY) *rnm = NULL;
146 146
147 if (!strncmp(cnf->name, "fullname", 9)) { 147 if (!strcmp(cnf->name, "fullname")) {
148 fnm = gnames_from_sectname(ctx, cnf->value); 148 fnm = gnames_from_sectname(ctx, cnf->value);
149 if (!fnm) 149 if (!fnm)
150 goto err; 150 goto err;