There is no point in checking if a pointer is non-NULL before calling free,

since free already does this for us. Also remove some pointless NULL
assignments, where the result from malloc(3) is immediately assigned to the
same variable.

ok miod@

1 files changed, 2 insertions, 4 deletions

diff --git a/src/lib/libssl/d1_pkt.c b/src/lib/libssl/d1_pkt.c
index c855d0e2a6..db898f507a 100644
--- a/src/lib/libssl/d1_pkt.c
+++ b/src/lib/libssl/d1_pkt.c
@@ -197,8 +197,7 @@ dtls1_copy_record(SSL *s, pitem *item)
 
         rdata = (DTLS1_RECORD_DATA *)item->data;
 
-        if (s->s3->rbuf.buf != NULL)
-                free(s->s3->rbuf.buf);
+        free(s->s3->rbuf.buf);
 
         s->packet = rdata->packet;
         s->packet_length = rdata->packet_length;
@@ -349,8 +348,7 @@ dtls1_get_buffered_record(SSL *s)
                 item = pqueue_pop(s->d1->rcvd_records);
                 rdata = (DTLS1_RECORD_DATA *)item->data;
 
-                if (s->s3->rbuf.buf != NULL)
-                        free(s->s3->rbuf.buf);
+                free(s->s3->rbuf.buf);
 
                 s->packet = rdata->packet;
                 s->packet_length = rdata->packet_length;