There is no point in checking if a pointer is non-NULL before calling free,

since free already does this for us. Also remove some pointless NULL
assignments, where the result from malloc(3) is immediately assigned to the
same variable.

ok miod@

1 files changed, 4 insertions, 8 deletions

diff --git a/src/lib/libssl/s3_both.c b/src/lib/libssl/s3_both.c
index 9dcdd7b998..f1d686b56f 100644
--- a/src/lib/libssl/s3_both.c
+++ b/src/lib/libssl/s3_both.c
@@ -719,20 +719,16 @@ ssl3_setup_buffers(SSL *s)
 int
 ssl3_release_write_buffer(SSL *s)
 {
-        if (s->s3->wbuf.buf != NULL) {
-                free(s->s3->wbuf.buf);
-                s->s3->wbuf.buf = NULL;
-        }
+        free(s->s3->wbuf.buf);
+        s->s3->wbuf.buf = NULL;
         return 1;
 }
 
 int
 ssl3_release_read_buffer(SSL *s)
 {
-        if (s->s3->rbuf.buf != NULL) {
-                free(s->s3->rbuf.buf);
-                s->s3->rbuf.buf = NULL;
-        }
+        free(s->s3->rbuf.buf);
+        s->s3->rbuf.buf = NULL;
         return 1;
 }