Replace all use of ERR_add_error_data with ERR_asprintf_error_data.

This avoids a lot of ugly gymnastics to do snprintfs before sending the
bag of strings to ERR, and eliminates at least one place in dso_dlfctn.c
where it was being called with the incorrect number of arguments and
using random things off the stack as addresses of strings.
ok krw@, jsing@

1 files changed, 2 insertions, 4 deletions

diff --git a/src/lib/libssl/s3_pkt.c b/src/lib/libssl/s3_pkt.c
index 68c3f1cb2b..4a8462ecb9 100644
--- a/src/lib/libssl/s3_pkt.c
+++ b/src/lib/libssl/s3_pkt.c
@@ -1169,13 +1169,11 @@ start:
 #endif
                 } else if (alert_level == 2) {
                         /* fatal */
-                        char tmp[16];
-
                         s->rwstate = SSL_NOTHING;
                         s->s3->fatal_alert = alert_descr;
                         SSLerr(SSL_F_SSL3_READ_BYTES, SSL_AD_REASON_OFFSET + alert_descr);
-                        (void) snprintf(tmp, sizeof tmp, "%d", alert_descr);
-                        ERR_add_error_data(2, "SSL alert number ", tmp);
+                        ERR_asprintf_error_data("SSL alert number %d",
+                            alert_descr);
                         s->shutdown|=SSL_RECEIVED_SHUTDOWN;
                         SSL_CTX_remove_session(s->ctx, s->session);
                         return (0);