bio_err is initialised in main, hence there is no need to initialise it

in each application (since there is no longer a non-monolithic mode).

In typical OpenSSL fashion, the code is inconsistent and there are multiple
ways that bio_err was initialised - none of them actually checked to see if
the initialisation actually succeeded. Additionally, it is worth noting
that in at least two cases bio_err was also being used before it would have
been initialised.

ok miod@

1 files changed, 1 insertions, 4 deletions

diff --git a/src/lib/libssl/src/apps/genrsa.c b/src/lib/libssl/src/apps/genrsa.c
index 643e20da2f..7e5dd2b239 100644
--- a/src/lib/libssl/src/apps/genrsa.c
+++ b/src/lib/libssl/src/apps/genrsa.c
@@ -112,12 +112,9 @@ genrsa_main(int argc, char **argv)
         signal(SIGPIPE, SIG_IGN);
         BN_GENCB_set(&cb, genrsa_cb, bio_err);
 
-        if (bio_err == NULL)
-                if ((bio_err = BIO_new(BIO_s_file())) != NULL)
-                        BIO_set_fp(bio_err, stderr, BIO_NOCLOSE | BIO_FP_TEXT);
-
         if (!load_config(bio_err, NULL))
                 goto err;
+
         if ((out = BIO_new(BIO_s_file())) == NULL) {
                 BIO_printf(bio_err, "unable to create BIO for output\n");
                 goto err;