summaryrefslogtreecommitdiff
path: root/src/lib
diff options
context:
space:
mode:
authormiod <>2014-10-12 20:47:12 +0000
committermiod <>2014-10-12 20:47:12 +0000
commit022613399be0ed34a64e17cb6526e4ead636bf23 (patch)
tree9c3008e895dddc5c8439683d0f7c4e795f152692 /src/lib
parent82b7f378b6907ab315a6e50322d2a0a8794a0aa9 (diff)
downloadopenbsd-022613399be0ed34a64e17cb6526e4ead636bf23.tar.gz
openbsd-022613399be0ed34a64e17cb6526e4ead636bf23.tar.bz2
openbsd-022613399be0ed34a64e17cb6526e4ead636bf23.zip
Paranoia: in ASN1_mbstring_ncopy(), check for len < 0 instead of len == -1,
in order to catch all negative sizes.
Diffstat (limited to 'src/lib')
-rw-r--r--src/lib/libcrypto/asn1/a_mbstr.c4
-rw-r--r--src/lib/libssl/src/crypto/asn1/a_mbstr.c4
2 files changed, 4 insertions, 4 deletions
diff --git a/src/lib/libcrypto/asn1/a_mbstr.c b/src/lib/libcrypto/asn1/a_mbstr.c
index 985d29824d..9ce0a000fe 100644
--- a/src/lib/libcrypto/asn1/a_mbstr.c
+++ b/src/lib/libcrypto/asn1/a_mbstr.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: a_mbstr.c,v 1.20 2014/09/21 12:14:34 miod Exp $ */ 1/* $OpenBSD: a_mbstr.c,v 1.21 2014/10/12 20:47:12 miod Exp $ */
2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL 2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
3 * project 1999. 3 * project 1999.
4 */ 4 */
@@ -104,7 +104,7 @@ ASN1_mbstring_ncopy(ASN1_STRING **out, const unsigned char *in, int len,
104 int nchar; 104 int nchar;
105 int (*cpyfunc)(unsigned long, void *) = NULL; 105 int (*cpyfunc)(unsigned long, void *) = NULL;
106 106
107 if (len == -1) 107 if (len < 0)
108 len = strlen((const char *)in); 108 len = strlen((const char *)in);
109 if (!mask) 109 if (!mask)
110 mask = DIRSTRING_TYPE; 110 mask = DIRSTRING_TYPE;
diff --git a/src/lib/libssl/src/crypto/asn1/a_mbstr.c b/src/lib/libssl/src/crypto/asn1/a_mbstr.c
index 985d29824d..9ce0a000fe 100644
--- a/src/lib/libssl/src/crypto/asn1/a_mbstr.c
+++ b/src/lib/libssl/src/crypto/asn1/a_mbstr.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: a_mbstr.c,v 1.20 2014/09/21 12:14:34 miod Exp $ */ 1/* $OpenBSD: a_mbstr.c,v 1.21 2014/10/12 20:47:12 miod Exp $ */
2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL 2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
3 * project 1999. 3 * project 1999.
4 */ 4 */
@@ -104,7 +104,7 @@ ASN1_mbstring_ncopy(ASN1_STRING **out, const unsigned char *in, int len,
104 int nchar; 104 int nchar;
105 int (*cpyfunc)(unsigned long, void *) = NULL; 105 int (*cpyfunc)(unsigned long, void *) = NULL;
106 106
107 if (len == -1) 107 if (len < 0)
108 len = strlen((const char *)in); 108 len = strlen((const char *)in);
109 if (!mask) 109 if (!mask)
110 mask = DIRSTRING_TYPE; 110 mask = DIRSTRING_TYPE;