diff options
| author | tb <> | 2026-01-01 12:47:52 +0000 |
|---|---|---|
| committer | tb <> | 2026-01-01 12:47:52 +0000 |
| commit | 10bebbca92ef87af97bc15c6337afbbe050bb96e (patch) | |
| tree | d3acb74022a43d2d8b4ffdd98d504717b91d7139 /src/regress | |
| parent | 632157bcbfb0f5031f0b5a0f3f3277c98c5cc846 (diff) | |
| download | openbsd-10bebbca92ef87af97bc15c6337afbbe050bb96e.tar.gz openbsd-10bebbca92ef87af97bc15c6337afbbe050bb96e.tar.bz2 openbsd-10bebbca92ef87af97bc15c6337afbbe050bb96e.zip | |
Rename RANK{768,1024} to MLKEM{768,1024}_RANK
RANK768 and RANK1024 are awfully short and generic names for public
constants. Before we make it worse with similarly named constants for
ML-DSA, let's fix this. This follows the naming convention used by the
other macros in the mlkem code.
ok kenjiro jsing
Diffstat (limited to 'src/regress')
4 files changed, 22 insertions, 22 deletions
diff --git a/src/regress/lib/libcrypto/mlkem/mlkem_iteration_tests.c b/src/regress/lib/libcrypto/mlkem/mlkem_iteration_tests.c index 053f8e1222..d6451fafb8 100644 --- a/src/regress/lib/libcrypto/mlkem/mlkem_iteration_tests.c +++ b/src/regress/lib/libcrypto/mlkem/mlkem_iteration_tests.c | |||
| @@ -1,4 +1,4 @@ | |||
| 1 | /* $OpenBSD: mlkem_iteration_tests.c,v 1.8 2025/08/17 19:26:35 tb Exp $ */ | 1 | /* $OpenBSD: mlkem_iteration_tests.c,v 1.9 2026/01/01 12:47:52 tb Exp $ */ |
| 2 | /* | 2 | /* |
| 3 | * Copyright (c) 2024 Google Inc. | 3 | * Copyright (c) 2024 Google Inc. |
| 4 | * Copyright (c) 2024 Bob Beck <beck@obtuse.com> | 4 | * Copyright (c) 2024 Bob Beck <beck@obtuse.com> |
| @@ -78,10 +78,10 @@ MlkemIterativeTest(int rank) | |||
| 78 | start = kExpectedSeedStart; | 78 | start = kExpectedSeedStart; |
| 79 | start_len = sizeof(kExpectedSeedStart); | 79 | start_len = sizeof(kExpectedSeedStart); |
| 80 | switch(rank){ | 80 | switch(rank){ |
| 81 | case RANK768: | 81 | case MLKEM768_RANK: |
| 82 | expected = kExpectedAdam768; | 82 | expected = kExpectedAdam768; |
| 83 | break; | 83 | break; |
| 84 | case RANK1024: | 84 | case MLKEM1024_RANK: |
| 85 | expected = kExpectedAdam1024; | 85 | expected = kExpectedAdam1024; |
| 86 | break; | 86 | break; |
| 87 | default: | 87 | default: |
| @@ -196,8 +196,8 @@ main(void) | |||
| 196 | { | 196 | { |
| 197 | int failed = 0; | 197 | int failed = 0; |
| 198 | 198 | ||
| 199 | failed |= MlkemIterativeTest(RANK768); | 199 | failed |= MlkemIterativeTest(MLKEM768_RANK); |
| 200 | failed |= MlkemIterativeTest(RANK1024); | 200 | failed |= MlkemIterativeTest(MLKEM1024_RANK); |
| 201 | 201 | ||
| 202 | return failed; | 202 | return failed; |
| 203 | } | 203 | } |
diff --git a/src/regress/lib/libcrypto/mlkem/mlkem_tests.c b/src/regress/lib/libcrypto/mlkem/mlkem_tests.c index 361467afd0..5e8441307c 100644 --- a/src/regress/lib/libcrypto/mlkem/mlkem_tests.c +++ b/src/regress/lib/libcrypto/mlkem/mlkem_tests.c | |||
| @@ -1,4 +1,4 @@ | |||
| 1 | /* $OpenBSD: mlkem_tests.c,v 1.10 2025/08/15 21:47:39 tb Exp $ */ | 1 | /* $OpenBSD: mlkem_tests.c,v 1.11 2026/01/01 12:47:52 tb Exp $ */ |
| 2 | /* | 2 | /* |
| 3 | * Copyright (c) 2024 Google Inc. | 3 | * Copyright (c) 2024 Google Inc. |
| 4 | * Copyright (c) 2024 Theo Buehler <tb@openbsd.org> | 4 | * Copyright (c) 2024 Theo Buehler <tb@openbsd.org> |
| @@ -686,27 +686,27 @@ static int | |||
| 686 | run_mlkem_test(const char *test, const char *fn) | 686 | run_mlkem_test(const char *test, const char *fn) |
| 687 | { | 687 | { |
| 688 | if (strcmp(test, "mlkem768_decap_tests") == 0) | 688 | if (strcmp(test, "mlkem768_decap_tests") == 0) |
| 689 | return mlkem_decap_tests(fn, RANK768, TEST_TYPE_NORMAL); | 689 | return mlkem_decap_tests(fn, MLKEM768_RANK, TEST_TYPE_NORMAL); |
| 690 | if (strcmp(test, "mlkem768_nist_decap_tests") == 0) | 690 | if (strcmp(test, "mlkem768_nist_decap_tests") == 0) |
| 691 | return mlkem_decap_tests(fn, RANK768, TEST_TYPE_NIST); | 691 | return mlkem_decap_tests(fn, MLKEM768_RANK, TEST_TYPE_NIST); |
| 692 | if (strcmp(test, "mlkem1024_decap_tests") == 0) | 692 | if (strcmp(test, "mlkem1024_decap_tests") == 0) |
| 693 | return mlkem_decap_tests(fn, RANK1024, TEST_TYPE_NORMAL); | 693 | return mlkem_decap_tests(fn, MLKEM1024_RANK, TEST_TYPE_NORMAL); |
| 694 | if (strcmp(test, "mlkem1024_nist_decap_tests") == 0) | 694 | if (strcmp(test, "mlkem1024_nist_decap_tests") == 0) |
| 695 | return mlkem_decap_tests(fn, RANK1024, TEST_TYPE_NIST); | 695 | return mlkem_decap_tests(fn, MLKEM1024_RANK, TEST_TYPE_NIST); |
| 696 | 696 | ||
| 697 | if (strcmp(test, "mlkem768_encap_tests") == 0) | 697 | if (strcmp(test, "mlkem768_encap_tests") == 0) |
| 698 | return mlkem_encap_tests(fn, RANK768); | 698 | return mlkem_encap_tests(fn, MLKEM768_RANK); |
| 699 | if (strcmp(test, "mlkem1024_encap_tests") == 0) | 699 | if (strcmp(test, "mlkem1024_encap_tests") == 0) |
| 700 | return mlkem_encap_tests(fn, RANK1024); | 700 | return mlkem_encap_tests(fn, MLKEM1024_RANK); |
| 701 | 701 | ||
| 702 | if (strcmp(test, "mlkem768_keygen_tests") == 0) | 702 | if (strcmp(test, "mlkem768_keygen_tests") == 0) |
| 703 | return mlkem_keygen_tests(fn, RANK768, TEST_TYPE_NORMAL); | 703 | return mlkem_keygen_tests(fn, MLKEM768_RANK, TEST_TYPE_NORMAL); |
| 704 | if (strcmp(test, "mlkem768_nist_keygen_tests") == 0) | 704 | if (strcmp(test, "mlkem768_nist_keygen_tests") == 0) |
| 705 | return mlkem_keygen_tests(fn, RANK768, TEST_TYPE_NIST); | 705 | return mlkem_keygen_tests(fn, MLKEM768_RANK, TEST_TYPE_NIST); |
| 706 | if (strcmp(test, "mlkem1024_keygen_tests") == 0) | 706 | if (strcmp(test, "mlkem1024_keygen_tests") == 0) |
| 707 | return mlkem_keygen_tests(fn, RANK1024, TEST_TYPE_NORMAL); | 707 | return mlkem_keygen_tests(fn, MLKEM1024_RANK, TEST_TYPE_NORMAL); |
| 708 | if (strcmp(test, "mlkem1024_nist_keygen_tests") == 0) | 708 | if (strcmp(test, "mlkem1024_nist_keygen_tests") == 0) |
| 709 | return mlkem_keygen_tests(fn, RANK1024, TEST_TYPE_NIST); | 709 | return mlkem_keygen_tests(fn, MLKEM1024_RANK, TEST_TYPE_NIST); |
| 710 | 710 | ||
| 711 | errx(1, "unknown test %s (test file %s)", test, fn); | 711 | errx(1, "unknown test %s (test file %s)", test, fn); |
| 712 | } | 712 | } |
diff --git a/src/regress/lib/libcrypto/mlkem/mlkem_unittest.c b/src/regress/lib/libcrypto/mlkem/mlkem_unittest.c index f802324189..1d8149b523 100644 --- a/src/regress/lib/libcrypto/mlkem/mlkem_unittest.c +++ b/src/regress/lib/libcrypto/mlkem/mlkem_unittest.c | |||
| @@ -1,4 +1,4 @@ | |||
| 1 | /* $OpenBSD: mlkem_unittest.c,v 1.15 2025/08/17 19:26:35 tb Exp $ */ | 1 | /* $OpenBSD: mlkem_unittest.c,v 1.16 2026/01/01 12:47:52 tb Exp $ */ |
| 2 | /* | 2 | /* |
| 3 | * Copyright (c) 2024 Google Inc. | 3 | * Copyright (c) 2024 Google Inc. |
| 4 | * Copyright (c) 2024 Bob Beck <beck@obtuse.com> | 4 | * Copyright (c) 2024 Bob Beck <beck@obtuse.com> |
| @@ -300,8 +300,8 @@ main(void) | |||
| 300 | { | 300 | { |
| 301 | int failed = 0; | 301 | int failed = 0; |
| 302 | 302 | ||
| 303 | failed |= MlKemUnitTest(RANK768); | 303 | failed |= MlKemUnitTest(MLKEM768_RANK); |
| 304 | failed |= MlKemUnitTest(RANK1024); | 304 | failed |= MlKemUnitTest(MLKEM1024_RANK); |
| 305 | 305 | ||
| 306 | return failed; | 306 | return failed; |
| 307 | } | 307 | } |
diff --git a/src/regress/lib/libcrypto/wycheproof/wycheproof.go b/src/regress/lib/libcrypto/wycheproof/wycheproof.go index 907f58d5f8..397958ac15 100644 --- a/src/regress/lib/libcrypto/wycheproof/wycheproof.go +++ b/src/regress/lib/libcrypto/wycheproof/wycheproof.go | |||
| @@ -1,4 +1,4 @@ | |||
| 1 | /* $OpenBSD: wycheproof.go,v 1.195 2025/12/27 03:23:57 tb Exp $ */ | 1 | /* $OpenBSD: wycheproof.go,v 1.196 2026/01/01 12:47:52 tb Exp $ */ |
| 2 | /* | 2 | /* |
| 3 | * Copyright (c) 2018,2023 Joel Sing <jsing@openbsd.org> | 3 | * Copyright (c) 2018,2023 Joel Sing <jsing@openbsd.org> |
| 4 | * Copyright (c) 2018,2019,2022-2025 Theo Buehler <tb@openbsd.org> | 4 | * Copyright (c) 2018,2019,2022-2025 Theo Buehler <tb@openbsd.org> |
| @@ -2460,9 +2460,9 @@ func (wtg *wycheproofTestGroupMLKEM) run(algorithm string, variant testVariant) | |||
| 2460 | fmt.Printf("INFO: skipping %v test group of type %v for %s\n", algorithm, wtg.Type, wtg.ParameterSet) | 2460 | fmt.Printf("INFO: skipping %v test group of type %v for %s\n", algorithm, wtg.Type, wtg.ParameterSet) |
| 2461 | return true | 2461 | return true |
| 2462 | case "ML-KEM-768": | 2462 | case "ML-KEM-768": |
| 2463 | rank = C.RANK768 | 2463 | rank = C.MLKEM768_RANK |
| 2464 | case "ML-KEM-1024": | 2464 | case "ML-KEM-1024": |
| 2465 | rank = C.RANK1024 | 2465 | rank = C.MLKEM1024_RANK |
| 2466 | default: | 2466 | default: |
| 2467 | log.Fatalf("Unknown ML-KEM parameterSet %v", wtg.ParameterSet) | 2467 | log.Fatalf("Unknown ML-KEM parameterSet %v", wtg.ParameterSet) |
| 2468 | } | 2468 | } |
