diff options
author | bcook <> | 2015-09-10 06:36:45 +0000 |
---|---|---|
committer | bcook <> | 2015-09-10 06:36:45 +0000 |
commit | 042de14de6bff7126905d195e21ff1dc271dd087 (patch) | |
tree | d2c2a560bc3dd50c82a09168e7588faf83e87fdc /src/usr.bin/openssl/s_time.c | |
parent | c143c9d71e4795a5b3f6992198aabc7c22335b59 (diff) | |
download | openbsd-042de14de6bff7126905d195e21ff1dc271dd087.tar.gz openbsd-042de14de6bff7126905d195e21ff1dc271dd087.tar.bz2 openbsd-042de14de6bff7126905d195e21ff1dc271dd087.zip |
Fix shadowed verify_error in s_server by removing the unused global.
's_time -verify 1' will now actually verify the peer certificate.
ok beck@
Diffstat (limited to 'src/usr.bin/openssl/s_time.c')
-rw-r--r-- | src/usr.bin/openssl/s_time.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/usr.bin/openssl/s_time.c b/src/usr.bin/openssl/s_time.c index 87a0a20382..ee4e584bd9 100644 --- a/src/usr.bin/openssl/s_time.c +++ b/src/usr.bin/openssl/s_time.c | |||
@@ -1,4 +1,4 @@ | |||
1 | /* $OpenBSD: s_time.c,v 1.9 2015/08/22 16:36:05 jsing Exp $ */ | 1 | /* $OpenBSD: s_time.c,v 1.10 2015/09/10 06:36:45 bcook Exp $ */ |
2 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) | 2 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) |
3 | * All rights reserved. | 3 | * All rights reserved. |
4 | * | 4 | * |
@@ -256,7 +256,6 @@ s_time_main(int argc, char **argv) | |||
256 | s_time_meth = SSLv23_client_method(); | 256 | s_time_meth = SSLv23_client_method(); |
257 | 257 | ||
258 | verify_depth = 0; | 258 | verify_depth = 0; |
259 | verify_error = X509_V_OK; | ||
260 | 259 | ||
261 | memset(&s_time_config, 0, sizeof(s_time_config)); | 260 | memset(&s_time_config, 0, sizeof(s_time_config)); |
262 | 261 | ||
@@ -299,6 +298,8 @@ s_time_main(int argc, char **argv) | |||
299 | } | 298 | } |
300 | } | 299 | } |
301 | 300 | ||
301 | SSL_CTX_set_verify(tm_ctx, s_time_config.verify, NULL); | ||
302 | |||
302 | if (!set_cert_stuff(tm_ctx, s_time_config.certfile, | 303 | if (!set_cert_stuff(tm_ctx, s_time_config.certfile, |
303 | s_time_config.keyfile)) | 304 | s_time_config.keyfile)) |
304 | goto end; | 305 | goto end; |
@@ -491,6 +492,7 @@ doConnection(SSL * scon) | |||
491 | struct pollfd pfd[1]; | 492 | struct pollfd pfd[1]; |
492 | SSL *serverCon; | 493 | SSL *serverCon; |
493 | BIO *conn; | 494 | BIO *conn; |
495 | long verify_error; | ||
494 | int i; | 496 | int i; |
495 | 497 | ||
496 | if ((conn = BIO_new(BIO_s_connect())) == NULL) | 498 | if ((conn = BIO_new(BIO_s_connect())) == NULL) |
@@ -524,6 +526,7 @@ doConnection(SSL * scon) | |||
524 | } | 526 | } |
525 | if (i <= 0) { | 527 | if (i <= 0) { |
526 | BIO_printf(bio_err, "ERROR\n"); | 528 | BIO_printf(bio_err, "ERROR\n"); |
529 | verify_error = SSL_get_verify_result(serverCon); | ||
527 | if (verify_error != X509_V_OK) | 530 | if (verify_error != X509_V_OK) |
528 | BIO_printf(bio_err, "verify error:%s\n", | 531 | BIO_printf(bio_err, "verify error:%s\n", |
529 | X509_verify_cert_error_string(verify_error)); | 532 | X509_verify_cert_error_string(verify_error)); |