diff options
author | bcook <> | 2014-07-08 16:36:45 +0000 |
---|---|---|
committer | bcook <> | 2014-07-08 16:36:45 +0000 |
commit | 47cdcd13ec3b3ad445c0834e7ba8042f6e58640b (patch) | |
tree | 77bb2646568bc46fbc145aeeb574843070d26730 /src | |
parent | 104f19cdd623c310b70d51cb0cce105d13262608 (diff) | |
download | openbsd-47cdcd13ec3b3ad445c0834e7ba8042f6e58640b.tar.gz openbsd-47cdcd13ec3b3ad445c0834e7ba8042f6e58640b.tar.bz2 openbsd-47cdcd13ec3b3ad445c0834e7ba8042f6e58640b.zip |
replace malloc(strlen())/strlcpy with strdup
ok beck@ jsing@
Diffstat (limited to 'src')
-rw-r--r-- | src/lib/libcrypto/conf/conf_def.c | 5 | ||||
-rw-r--r-- | src/lib/libssl/src/crypto/conf/conf_def.c | 5 |
2 files changed, 4 insertions, 6 deletions
diff --git a/src/lib/libcrypto/conf/conf_def.c b/src/lib/libcrypto/conf/conf_def.c index c4703d883b..a5cfd86ae2 100644 --- a/src/lib/libcrypto/conf/conf_def.c +++ b/src/lib/libcrypto/conf/conf_def.c | |||
@@ -1,4 +1,4 @@ | |||
1 | /* $OpenBSD: conf_def.c,v 1.24 2014/06/12 15:49:28 deraadt Exp $ */ | 1 | /* $OpenBSD: conf_def.c,v 1.25 2014/07/08 16:36:45 bcook Exp $ */ |
2 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) | 2 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) |
3 | * All rights reserved. | 3 | * All rights reserved. |
4 | * | 4 | * |
@@ -368,14 +368,13 @@ again: | |||
368 | } | 368 | } |
369 | if (psection == NULL) | 369 | if (psection == NULL) |
370 | psection = section; | 370 | psection = section; |
371 | v->name = malloc(strlen(pname) + 1); | 371 | v->name = strdup(pname); |
372 | v->value = NULL; | 372 | v->value = NULL; |
373 | if (v->name == NULL) { | 373 | if (v->name == NULL) { |
374 | CONFerr(CONF_F_DEF_LOAD_BIO, | 374 | CONFerr(CONF_F_DEF_LOAD_BIO, |
375 | ERR_R_MALLOC_FAILURE); | 375 | ERR_R_MALLOC_FAILURE); |
376 | goto err; | 376 | goto err; |
377 | } | 377 | } |
378 | strlcpy(v->name, pname, strlen(pname) + 1); | ||
379 | if (!str_copy(conf, psection, &(v->value), start)) | 378 | if (!str_copy(conf, psection, &(v->value), start)) |
380 | goto err; | 379 | goto err; |
381 | 380 | ||
diff --git a/src/lib/libssl/src/crypto/conf/conf_def.c b/src/lib/libssl/src/crypto/conf/conf_def.c index c4703d883b..a5cfd86ae2 100644 --- a/src/lib/libssl/src/crypto/conf/conf_def.c +++ b/src/lib/libssl/src/crypto/conf/conf_def.c | |||
@@ -1,4 +1,4 @@ | |||
1 | /* $OpenBSD: conf_def.c,v 1.24 2014/06/12 15:49:28 deraadt Exp $ */ | 1 | /* $OpenBSD: conf_def.c,v 1.25 2014/07/08 16:36:45 bcook Exp $ */ |
2 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) | 2 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) |
3 | * All rights reserved. | 3 | * All rights reserved. |
4 | * | 4 | * |
@@ -368,14 +368,13 @@ again: | |||
368 | } | 368 | } |
369 | if (psection == NULL) | 369 | if (psection == NULL) |
370 | psection = section; | 370 | psection = section; |
371 | v->name = malloc(strlen(pname) + 1); | 371 | v->name = strdup(pname); |
372 | v->value = NULL; | 372 | v->value = NULL; |
373 | if (v->name == NULL) { | 373 | if (v->name == NULL) { |
374 | CONFerr(CONF_F_DEF_LOAD_BIO, | 374 | CONFerr(CONF_F_DEF_LOAD_BIO, |
375 | ERR_R_MALLOC_FAILURE); | 375 | ERR_R_MALLOC_FAILURE); |
376 | goto err; | 376 | goto err; |
377 | } | 377 | } |
378 | strlcpy(v->name, pname, strlen(pname) + 1); | ||
379 | if (!str_copy(conf, psection, &(v->value), start)) | 378 | if (!str_copy(conf, psection, &(v->value), start)) |
380 | goto err; | 379 | goto err; |
381 | 380 | ||