diff options
author | mmcc <> | 2016-03-27 00:55:38 +0000 |
---|---|---|
committer | mmcc <> | 2016-03-27 00:55:38 +0000 |
commit | 6b10601e1e787194a445062733084548302d8eb4 (patch) | |
tree | 8ea0a3fa231ab14242d60ad3fa04149c53c989dd /src | |
parent | 1bdc8093d2e2a5723b31a9aca5d37c999bcabb77 (diff) | |
download | openbsd-6b10601e1e787194a445062733084548302d8eb4.tar.gz openbsd-6b10601e1e787194a445062733084548302d8eb4.tar.bz2 openbsd-6b10601e1e787194a445062733084548302d8eb4.zip |
Merge a memleak fix from BoringSSL 6b6e0b2:
https://boringssl.googlesource.com/boringssl/+/6b6e0b20893e2be0e68af605a60ffa2cbb0ffa64%5E!/#F0
ok millert@, beck@
Diffstat (limited to 'src')
-rw-r--r-- | src/lib/libssl/s3_clnt.c | 4 | ||||
-rw-r--r-- | src/lib/libssl/src/ssl/s3_clnt.c | 4 |
2 files changed, 6 insertions, 2 deletions
diff --git a/src/lib/libssl/s3_clnt.c b/src/lib/libssl/s3_clnt.c index af3ba50072..264cb012d5 100644 --- a/src/lib/libssl/s3_clnt.c +++ b/src/lib/libssl/s3_clnt.c | |||
@@ -1,4 +1,4 @@ | |||
1 | /* $OpenBSD: s3_clnt.c,v 1.137 2016/03/11 07:08:45 mmcc Exp $ */ | 1 | /* $OpenBSD: s3_clnt.c,v 1.138 2016/03/27 00:55:38 mmcc Exp $ */ |
2 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) | 2 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) |
3 | * All rights reserved. | 3 | * All rights reserved. |
4 | * | 4 | * |
@@ -1641,6 +1641,7 @@ ssl3_get_certificate_request(SSL *s) | |||
1641 | ERR_R_MALLOC_FAILURE); | 1641 | ERR_R_MALLOC_FAILURE); |
1642 | goto err; | 1642 | goto err; |
1643 | } | 1643 | } |
1644 | xn = NULL; /* avoid free in err block */ | ||
1644 | } | 1645 | } |
1645 | 1646 | ||
1646 | /* we should setup a certificate to return.... */ | 1647 | /* we should setup a certificate to return.... */ |
@@ -1658,6 +1659,7 @@ truncated: | |||
1658 | SSL_R_BAD_PACKET_LENGTH); | 1659 | SSL_R_BAD_PACKET_LENGTH); |
1659 | } | 1660 | } |
1660 | err: | 1661 | err: |
1662 | X509_NAME_free(xn); | ||
1661 | if (ca_sk != NULL) | 1663 | if (ca_sk != NULL) |
1662 | sk_X509_NAME_pop_free(ca_sk, X509_NAME_free); | 1664 | sk_X509_NAME_pop_free(ca_sk, X509_NAME_free); |
1663 | return (ret); | 1665 | return (ret); |
diff --git a/src/lib/libssl/src/ssl/s3_clnt.c b/src/lib/libssl/src/ssl/s3_clnt.c index af3ba50072..264cb012d5 100644 --- a/src/lib/libssl/src/ssl/s3_clnt.c +++ b/src/lib/libssl/src/ssl/s3_clnt.c | |||
@@ -1,4 +1,4 @@ | |||
1 | /* $OpenBSD: s3_clnt.c,v 1.137 2016/03/11 07:08:45 mmcc Exp $ */ | 1 | /* $OpenBSD: s3_clnt.c,v 1.138 2016/03/27 00:55:38 mmcc Exp $ */ |
2 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) | 2 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) |
3 | * All rights reserved. | 3 | * All rights reserved. |
4 | * | 4 | * |
@@ -1641,6 +1641,7 @@ ssl3_get_certificate_request(SSL *s) | |||
1641 | ERR_R_MALLOC_FAILURE); | 1641 | ERR_R_MALLOC_FAILURE); |
1642 | goto err; | 1642 | goto err; |
1643 | } | 1643 | } |
1644 | xn = NULL; /* avoid free in err block */ | ||
1644 | } | 1645 | } |
1645 | 1646 | ||
1646 | /* we should setup a certificate to return.... */ | 1647 | /* we should setup a certificate to return.... */ |
@@ -1658,6 +1659,7 @@ truncated: | |||
1658 | SSL_R_BAD_PACKET_LENGTH); | 1659 | SSL_R_BAD_PACKET_LENGTH); |
1659 | } | 1660 | } |
1660 | err: | 1661 | err: |
1662 | X509_NAME_free(xn); | ||
1661 | if (ca_sk != NULL) | 1663 | if (ca_sk != NULL) |
1662 | sk_X509_NAME_pop_free(ca_sk, X509_NAME_free); | 1664 | sk_X509_NAME_pop_free(ca_sk, X509_NAME_free); |
1663 | return (ret); | 1665 | return (ret); |