summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorjsing <>2021-12-25 13:17:48 +0000
committerjsing <>2021-12-25 13:17:48 +0000
commit6be80228ce6e3d007c240fd309c7e08520677576 (patch)
treec2ad177e48af592ac305ef1bf2b4bbc9395b8897 /src
parent69f80604f574c80b09c77c793ad058bbdb4ea21a (diff)
downloadopenbsd-6be80228ce6e3d007c240fd309c7e08520677576.tar.gz
openbsd-6be80228ce6e3d007c240fd309c7e08520677576.tar.bz2
openbsd-6be80228ce6e3d007c240fd309c7e08520677576.zip
Indent goto labels for diffability.
Whitespace change only.
Diffstat (limited to 'src')
-rw-r--r--src/lib/libcrypto/asn1/a_enum.c10
-rw-r--r--src/lib/libcrypto/asn1/a_int.c14
-rw-r--r--src/lib/libcrypto/asn1/a_mbstr.c4
-rw-r--r--src/lib/libcrypto/asn1/a_object.c8
-rw-r--r--src/lib/libcrypto/asn1/a_pkey.c4
-rw-r--r--src/lib/libcrypto/asn1/a_pubkey.c4
-rw-r--r--src/lib/libcrypto/asn1/a_string.c8
-rw-r--r--src/lib/libcrypto/asn1/asn1_gen.c10
-rw-r--r--src/lib/libcrypto/asn1/asn1_item.c12
-rw-r--r--src/lib/libcrypto/asn1/asn1_old.c4
-rw-r--r--src/lib/libcrypto/asn1/asn1_par.c6
-rw-r--r--src/lib/libcrypto/asn1/asn_mime.c10
-rw-r--r--src/lib/libcrypto/asn1/bio_asn1.c4
-rw-r--r--src/lib/libcrypto/asn1/bio_ndef.c4
-rw-r--r--src/lib/libcrypto/asn1/n_pkey.c8
-rw-r--r--src/lib/libcrypto/asn1/p5_pbe.c4
-rw-r--r--src/lib/libcrypto/asn1/p5_pbev2.c8
-rw-r--r--src/lib/libcrypto/asn1/t_crl.c4
-rw-r--r--src/lib/libcrypto/asn1/t_req.c6
-rw-r--r--src/lib/libcrypto/asn1/t_x509.c12
-rw-r--r--src/lib/libcrypto/asn1/tasn_dec.c12
-rw-r--r--src/lib/libcrypto/asn1/tasn_new.c8
-rw-r--r--src/lib/libcrypto/asn1/tasn_utl.c4
-rw-r--r--src/lib/libcrypto/asn1/x_attrib.c4
-rw-r--r--src/lib/libcrypto/asn1/x_name.c10
-rw-r--r--src/lib/libcrypto/asn1/x_pkey.c4
-rw-r--r--src/lib/libcrypto/asn1/x_pubkey.c6
-rw-r--r--src/lib/libcrypto/asn1/x_x509.c4
-rw-r--r--src/lib/libcrypto/asn1/x_x509a.c6
29 files changed, 101 insertions, 101 deletions
diff --git a/src/lib/libcrypto/asn1/a_enum.c b/src/lib/libcrypto/asn1/a_enum.c
index f48543ef3f..007a421849 100644
--- a/src/lib/libcrypto/asn1/a_enum.c
+++ b/src/lib/libcrypto/asn1/a_enum.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: a_enum.c,v 1.22 2021/12/25 08:52:44 jsing Exp $ */ 1/* $OpenBSD: a_enum.c,v 1.23 2021/12/25 13:17:48 jsing Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) 2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
@@ -195,7 +195,7 @@ BN_to_ASN1_ENUMERATED(const BIGNUM *bn, ASN1_ENUMERATED *ai)
195 } 195 }
196 return (ret); 196 return (ret);
197 197
198err: 198 err:
199 if (ret != ai) 199 if (ret != ai)
200 ASN1_ENUMERATED_free(ret); 200 ASN1_ENUMERATED_free(ret);
201 return (NULL); 201 return (NULL);
@@ -245,7 +245,7 @@ i2a_ASN1_ENUMERATED(BIO *bp, const ASN1_ENUMERATED *a)
245 } 245 }
246 return (n); 246 return (n);
247 247
248err: 248 err:
249 return (-1); 249 return (-1);
250} 250}
251 251
@@ -333,9 +333,9 @@ a2i_ASN1_ENUMERATED(BIO *bp, ASN1_ENUMERATED *bs, char *buf, int size)
333 bs->data = s; 333 bs->data = s;
334 return (1); 334 return (1);
335 335
336err_sl: 336 err_sl:
337 ASN1error(ASN1_R_SHORT_LINE); 337 ASN1error(ASN1_R_SHORT_LINE);
338err: 338 err:
339 free(s); 339 free(s);
340 return (ret); 340 return (ret);
341} 341}
diff --git a/src/lib/libcrypto/asn1/a_int.c b/src/lib/libcrypto/asn1/a_int.c
index eac7546eac..c4b40ff7a4 100644
--- a/src/lib/libcrypto/asn1/a_int.c
+++ b/src/lib/libcrypto/asn1/a_int.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: a_int.c,v 1.37 2021/12/25 08:52:44 jsing Exp $ */ 1/* $OpenBSD: a_int.c,v 1.38 2021/12/25 13:17:48 jsing Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) 2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
@@ -242,7 +242,7 @@ BN_to_ASN1_INTEGER(const BIGNUM *bn, ASN1_INTEGER *ai)
242 } 242 }
243 return (ret); 243 return (ret);
244 244
245err: 245 err:
246 if (ret != ai) 246 if (ret != ai)
247 ASN1_INTEGER_free(ret); 247 ASN1_INTEGER_free(ret);
248 return (NULL); 248 return (NULL);
@@ -299,7 +299,7 @@ i2a_ASN1_INTEGER(BIO *bp, const ASN1_INTEGER *a)
299 } 299 }
300 return (n); 300 return (n);
301 301
302err: 302 err:
303 return (-1); 303 return (-1);
304} 304}
305 305
@@ -385,9 +385,9 @@ a2i_ASN1_INTEGER(BIO *bp, ASN1_INTEGER *bs, char *buf, int size)
385 bs->data = s; 385 bs->data = s;
386 return (1); 386 return (1);
387 387
388err_sl: 388 err_sl:
389 ASN1error(ASN1_R_SHORT_LINE); 389 ASN1error(ASN1_R_SHORT_LINE);
390err: 390 err:
391 free(s); 391 free(s);
392 return (ret); 392 return (ret);
393} 393}
@@ -579,7 +579,7 @@ c2i_ASN1_INTEGER(ASN1_INTEGER **a, const unsigned char **pp, long len)
579 *pp = pend; 579 *pp = pend;
580 return (ret); 580 return (ret);
581 581
582err: 582 err:
583 ASN1error(i); 583 ASN1error(i);
584 if (a == NULL || *a != ret) 584 if (a == NULL || *a != ret)
585 ASN1_INTEGER_free(ret); 585 ASN1_INTEGER_free(ret);
@@ -666,7 +666,7 @@ d2i_ASN1_UINTEGER(ASN1_INTEGER **a, const unsigned char **pp, long length)
666 *pp = p; 666 *pp = p;
667 return (ret); 667 return (ret);
668 668
669err: 669 err:
670 ASN1error(i); 670 ASN1error(i);
671 if (a == NULL || *a != ret) 671 if (a == NULL || *a != ret)
672 ASN1_INTEGER_free(ret); 672 ASN1_INTEGER_free(ret);
diff --git a/src/lib/libcrypto/asn1/a_mbstr.c b/src/lib/libcrypto/asn1/a_mbstr.c
index b7cfba379a..8cff3ae1ca 100644
--- a/src/lib/libcrypto/asn1/a_mbstr.c
+++ b/src/lib/libcrypto/asn1/a_mbstr.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: a_mbstr.c,v 1.23 2017/01/29 17:49:22 beck Exp $ */ 1/* $OpenBSD: a_mbstr.c,v 1.24 2021/12/25 13:17:48 jsing Exp $ */
2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL 2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
3 * project 1999. 3 * project 1999.
4 */ 4 */
@@ -248,7 +248,7 @@ ASN1_mbstring_ncopy(ASN1_STRING **out, const unsigned char *in, int len,
248 traverse_string(in, len, inform, cpyfunc, &p); 248 traverse_string(in, len, inform, cpyfunc, &p);
249 return str_type; 249 return str_type;
250 250
251err: 251 err:
252 if (free_out) { 252 if (free_out) {
253 ASN1_STRING_free(dest); 253 ASN1_STRING_free(dest);
254 *out = NULL; 254 *out = NULL;
diff --git a/src/lib/libcrypto/asn1/a_object.c b/src/lib/libcrypto/asn1/a_object.c
index a029a12fd8..5d91806ba4 100644
--- a/src/lib/libcrypto/asn1/a_object.c
+++ b/src/lib/libcrypto/asn1/a_object.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: a_object.c,v 1.35 2021/12/25 08:52:44 jsing Exp $ */ 1/* $OpenBSD: a_object.c,v 1.36 2021/12/25 13:17:48 jsing Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) 2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
@@ -261,7 +261,7 @@ a2d_ASN1_OBJECT(unsigned char *out, int olen, const char *buf, int num)
261 BN_free(bl); 261 BN_free(bl);
262 return (len); 262 return (len);
263 263
264err: 264 err:
265 if (tmp != ftmp) 265 if (tmp != ftmp)
266 free(tmp); 266 free(tmp);
267 BN_free(bl); 267 BN_free(bl);
@@ -326,7 +326,7 @@ d2i_ASN1_OBJECT(ASN1_OBJECT **a, const unsigned char **pp, long length)
326 *pp = p; 326 *pp = p;
327 return ret; 327 return ret;
328 328
329err: 329 err:
330 ASN1error(i); 330 ASN1error(i);
331 return (NULL); 331 return (NULL);
332} 332}
@@ -401,7 +401,7 @@ c2i_ASN1_OBJECT(ASN1_OBJECT **a, const unsigned char **pp, long len)
401 *pp = p; 401 *pp = p;
402 return (ret); 402 return (ret);
403 403
404err: 404 err:
405 if (a == NULL || ret != *a) 405 if (a == NULL || ret != *a)
406 ASN1_OBJECT_free(ret); 406 ASN1_OBJECT_free(ret);
407 return (NULL); 407 return (NULL);
diff --git a/src/lib/libcrypto/asn1/a_pkey.c b/src/lib/libcrypto/asn1/a_pkey.c
index 2e97d32ab4..3b8dea7db5 100644
--- a/src/lib/libcrypto/asn1/a_pkey.c
+++ b/src/lib/libcrypto/asn1/a_pkey.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: a_pkey.c,v 1.2 2021/12/12 21:30:13 tb Exp $ */ 1/* $OpenBSD: a_pkey.c,v 1.3 2021/12/25 13:17:48 jsing Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) 2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
@@ -118,7 +118,7 @@ d2i_PrivateKey(int type, EVP_PKEY **a, const unsigned char **pp, long length)
118 (*a) = ret; 118 (*a) = ret;
119 return (ret); 119 return (ret);
120 120
121err: 121 err:
122 if (a == NULL || *a != ret) 122 if (a == NULL || *a != ret)
123 EVP_PKEY_free(ret); 123 EVP_PKEY_free(ret);
124 return (NULL); 124 return (NULL);
diff --git a/src/lib/libcrypto/asn1/a_pubkey.c b/src/lib/libcrypto/asn1/a_pubkey.c
index 7ad13e9761..f3bb5d81a6 100644
--- a/src/lib/libcrypto/asn1/a_pubkey.c
+++ b/src/lib/libcrypto/asn1/a_pubkey.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: a_pubkey.c,v 1.2 2021/12/12 21:30:13 tb Exp $ */ 1/* $OpenBSD: a_pubkey.c,v 1.3 2021/12/25 13:17:48 jsing Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) 2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
@@ -131,7 +131,7 @@ d2i_PublicKey(int type, EVP_PKEY **a, const unsigned char **pp, long length)
131 (*a) = ret; 131 (*a) = ret;
132 return (ret); 132 return (ret);
133 133
134err: 134 err:
135 if (a == NULL || *a != ret) 135 if (a == NULL || *a != ret)
136 EVP_PKEY_free(ret); 136 EVP_PKEY_free(ret);
137 return (NULL); 137 return (NULL);
diff --git a/src/lib/libcrypto/asn1/a_string.c b/src/lib/libcrypto/asn1/a_string.c
index 7a9eabe6c6..6d227f3688 100644
--- a/src/lib/libcrypto/asn1/a_string.c
+++ b/src/lib/libcrypto/asn1/a_string.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: a_string.c,v 1.3 2021/12/25 12:11:57 jsing Exp $ */ 1/* $OpenBSD: a_string.c,v 1.4 2021/12/25 13:17:48 jsing Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) 2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
@@ -298,7 +298,7 @@ i2a_ASN1_STRING(BIO *bp, const ASN1_STRING *a, int type)
298 } 298 }
299 return (n); 299 return (n);
300 300
301err: 301 err:
302 return (-1); 302 return (-1);
303} 303}
304 304
@@ -384,9 +384,9 @@ a2i_ASN1_STRING(BIO *bp, ASN1_STRING *bs, char *buf, int size)
384 bs->data = s; 384 bs->data = s;
385 return (1); 385 return (1);
386 386
387err_sl: 387 err_sl:
388 ASN1error(ASN1_R_SHORT_LINE); 388 ASN1error(ASN1_R_SHORT_LINE);
389err: 389 err:
390 free(s); 390 free(s);
391 return (ret); 391 return (ret);
392} 392}
diff --git a/src/lib/libcrypto/asn1/asn1_gen.c b/src/lib/libcrypto/asn1/asn1_gen.c
index ad7802cb11..d800b77a6a 100644
--- a/src/lib/libcrypto/asn1/asn1_gen.c
+++ b/src/lib/libcrypto/asn1/asn1_gen.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: asn1_gen.c,v 1.17 2018/04/25 11:48:21 tb Exp $ */ 1/* $OpenBSD: asn1_gen.c,v 1.18 2021/12/25 13:17:48 jsing Exp $ */
2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL 2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
3 * project 2002. 3 * project 2002.
4 */ 4 */
@@ -258,7 +258,7 @@ ASN1_generate_v3(const char *str, X509V3_CTX *cnf)
258 /* Obtain new ASN1_TYPE structure */ 258 /* Obtain new ASN1_TYPE structure */
259 ret = d2i_ASN1_TYPE(NULL, &cp, len); 259 ret = d2i_ASN1_TYPE(NULL, &cp, len);
260 260
261err: 261 err:
262 free(orig_der); 262 free(orig_der);
263 free(new_der); 263 free(new_der);
264 264
@@ -478,7 +478,7 @@ asn1_multi(int utype, const char *section, X509V3_CTX *cnf)
478 478
479 der = NULL; 479 der = NULL;
480 480
481bad: 481 bad:
482 free(der); 482 free(der);
483 if (sk) 483 if (sk)
484 sk_ASN1_TYPE_pop_free(sk, ASN1_TYPE_free); 484 sk_ASN1_TYPE_pop_free(sk, ASN1_TYPE_free);
@@ -771,9 +771,9 @@ asn1_str2type(const char *str, int format, int utype)
771 atmp->type = utype; 771 atmp->type = utype;
772 return atmp; 772 return atmp;
773 773
774bad_str: 774 bad_str:
775 ERR_asprintf_error_data("string=%s", str); 775 ERR_asprintf_error_data("string=%s", str);
776bad_form: 776 bad_form:
777 ASN1_TYPE_free(atmp); 777 ASN1_TYPE_free(atmp);
778 return NULL; 778 return NULL;
779} 779}
diff --git a/src/lib/libcrypto/asn1/asn1_item.c b/src/lib/libcrypto/asn1/asn1_item.c
index d2819dbb96..7dad8e0df1 100644
--- a/src/lib/libcrypto/asn1/asn1_item.c
+++ b/src/lib/libcrypto/asn1/asn1_item.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: asn1_item.c,v 1.2 2021/12/25 12:21:36 jsing Exp $ */ 1/* $OpenBSD: asn1_item.c,v 1.3 2021/12/25 13:17:48 jsing Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) 2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
@@ -195,7 +195,7 @@ ASN1_item_pack(void *obj, const ASN1_ITEM *it, ASN1_STRING **oct)
195 if (oct) 195 if (oct)
196 *oct = octmp; 196 *oct = octmp;
197 return octmp; 197 return octmp;
198err: 198 err:
199 if (!oct || octmp != *oct) 199 if (!oct || octmp != *oct)
200 ASN1_STRING_free(octmp); 200 ASN1_STRING_free(octmp);
201 return NULL; 201 return NULL;
@@ -314,7 +314,7 @@ ASN1_item_sign_ctx(const ASN1_ITEM *it, X509_ALGOR *algor1, X509_ALGOR *algor2,
314 signature->flags &= ~(ASN1_STRING_FLAG_BITS_LEFT|0x07); 314 signature->flags &= ~(ASN1_STRING_FLAG_BITS_LEFT|0x07);
315 signature->flags |= ASN1_STRING_FLAG_BITS_LEFT; 315 signature->flags |= ASN1_STRING_FLAG_BITS_LEFT;
316 316
317err: 317 err:
318 EVP_MD_CTX_cleanup(ctx); 318 EVP_MD_CTX_cleanup(ctx);
319 freezero((char *)buf_in, inl); 319 freezero((char *)buf_in, inl);
320 freezero((char *)buf_out, outll); 320 freezero((char *)buf_out, outll);
@@ -411,7 +411,7 @@ ASN1_item_verify(const ASN1_ITEM *it, X509_ALGOR *a,
411 /* memset(&ctx,0,sizeof(ctx)); */ 411 /* memset(&ctx,0,sizeof(ctx)); */
412 ret = 1; 412 ret = 1;
413 413
414err: 414 err:
415 EVP_MD_CTX_cleanup(&ctx); 415 EVP_MD_CTX_cleanup(&ctx);
416 return (ret); 416 return (ret);
417} 417}
@@ -555,7 +555,7 @@ asn1_d2i_read_bio(BIO *in, BUF_MEM **pb)
555 *pb = b; 555 *pb = b;
556 return off; 556 return off;
557 557
558err: 558 err:
559 if (b != NULL) 559 if (b != NULL)
560 BUF_MEM_free(b); 560 BUF_MEM_free(b);
561 return -1; 561 return -1;
@@ -576,7 +576,7 @@ ASN1_item_d2i_bio(const ASN1_ITEM *it, BIO *in, void *x)
576 p = (const unsigned char *)b->data; 576 p = (const unsigned char *)b->data;
577 ret = ASN1_item_d2i(x, &p, len, it); 577 ret = ASN1_item_d2i(x, &p, len, it);
578 578
579err: 579 err:
580 if (b != NULL) 580 if (b != NULL)
581 BUF_MEM_free(b); 581 BUF_MEM_free(b);
582 return (ret); 582 return (ret);
diff --git a/src/lib/libcrypto/asn1/asn1_old.c b/src/lib/libcrypto/asn1/asn1_old.c
index d23cae06fb..59e9cdb101 100644
--- a/src/lib/libcrypto/asn1/asn1_old.c
+++ b/src/lib/libcrypto/asn1/asn1_old.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: asn1_old.c,v 1.1 2021/12/25 12:00:22 jsing Exp $ */ 1/* $OpenBSD: asn1_old.c,v 1.2 2021/12/25 13:17:48 jsing Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) 2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
@@ -123,7 +123,7 @@ ASN1_d2i_bio(void *(*xnew)(void), d2i_of_void *d2i, BIO *in, void **x)
123 p = (unsigned char *)b->data; 123 p = (unsigned char *)b->data;
124 ret = d2i(x, &p, len); 124 ret = d2i(x, &p, len);
125 125
126err: 126 err:
127 if (b != NULL) 127 if (b != NULL)
128 BUF_MEM_free(b); 128 BUF_MEM_free(b);
129 return (ret); 129 return (ret);
diff --git a/src/lib/libcrypto/asn1/asn1_par.c b/src/lib/libcrypto/asn1/asn1_par.c
index 4604930593..aec71d3be9 100644
--- a/src/lib/libcrypto/asn1/asn1_par.c
+++ b/src/lib/libcrypto/asn1/asn1_par.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: asn1_par.c,v 1.30 2021/12/14 17:35:21 jsing Exp $ */ 1/* $OpenBSD: asn1_par.c,v 1.31 2021/12/25 13:17:48 jsing Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) 2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
@@ -97,7 +97,7 @@ asn1_print_info(BIO *bp, int tag, int xclass, int constructed,
97 if (BIO_printf(bp, "%-18s", p) <= 0) 97 if (BIO_printf(bp, "%-18s", p) <= 0)
98 goto err; 98 goto err;
99 return (1); 99 return (1);
100err: 100 err:
101 return (0); 101 return (0);
102} 102}
103 103
@@ -371,7 +371,7 @@ asn1_parse2(BIO *bp, const unsigned char **pp, long length, int offset,
371 } 371 }
372 ret = 1; 372 ret = 1;
373 373
374end: 374 end:
375 if (o != NULL) 375 if (o != NULL)
376 ASN1_OBJECT_free(o); 376 ASN1_OBJECT_free(o);
377 ASN1_OCTET_STRING_free(os); 377 ASN1_OCTET_STRING_free(os);
diff --git a/src/lib/libcrypto/asn1/asn_mime.c b/src/lib/libcrypto/asn1/asn_mime.c
index 7a51808631..3150214378 100644
--- a/src/lib/libcrypto/asn1/asn_mime.c
+++ b/src/lib/libcrypto/asn1/asn_mime.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: asn_mime.c,v 1.28 2021/12/12 21:30:13 tb Exp $ */ 1/* $OpenBSD: asn_mime.c,v 1.29 2021/12/25 13:17:48 jsing Exp $ */
2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL 2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
3 * project. 3 * project.
4 */ 4 */
@@ -268,7 +268,7 @@ asn1_write_micalg(BIO *out, STACK_OF(X509_ALGOR) *mdalgs)
268 268
269 ret = 1; 269 ret = 1;
270 270
271err: 271 err:
272 return ret; 272 return ret;
273} 273}
274 274
@@ -779,7 +779,7 @@ STACK_OF(MIME_HEADER) *mime_parse_hdr(BIO *bio)
779 779
780 return headers; 780 return headers;
781 781
782merr: 782 merr:
783 if (mhdr != NULL) 783 if (mhdr != NULL)
784 mime_hdr_free(mhdr); 784 mime_hdr_free(mhdr);
785 sk_MIME_HEADER_pop_free(headers, mime_hdr_free); 785 sk_MIME_HEADER_pop_free(headers, mime_hdr_free);
@@ -867,7 +867,7 @@ mime_hdr_new(char *name, char *value)
867 goto err; 867 goto err;
868 } 868 }
869 return mhdr; 869 return mhdr;
870err: 870 err:
871 free(tmpname); 871 free(tmpname);
872 free(tmpval); 872 free(tmpval);
873 return NULL; 873 return NULL;
@@ -902,7 +902,7 @@ mime_hdr_addparam(MIME_HEADER *mhdr, char *name, char *value)
902 goto err; 902 goto err;
903 } 903 }
904 return 1; 904 return 1;
905err: 905 err:
906 free(tmpname); 906 free(tmpname);
907 free(tmpval); 907 free(tmpval);
908 return 0; 908 return 0;
diff --git a/src/lib/libcrypto/asn1/bio_asn1.c b/src/lib/libcrypto/asn1/bio_asn1.c
index 9a14d2bb84..016e570480 100644
--- a/src/lib/libcrypto/asn1/bio_asn1.c
+++ b/src/lib/libcrypto/asn1/bio_asn1.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: bio_asn1.c,v 1.14 2021/11/27 13:10:33 schwarze Exp $ */ 1/* $OpenBSD: bio_asn1.c,v 1.15 2021/12/25 13:17:48 jsing Exp $ */
2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL 2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
3 * project. 3 * project.
4 */ 4 */
@@ -271,7 +271,7 @@ asn1_bio_write(BIO *b, const char *in , int inl)
271 271
272 } 272 }
273 273
274done: 274 done:
275 BIO_clear_retry_flags(b); 275 BIO_clear_retry_flags(b);
276 BIO_copy_next_retry(b); 276 BIO_copy_next_retry(b);
277 277
diff --git a/src/lib/libcrypto/asn1/bio_ndef.c b/src/lib/libcrypto/asn1/bio_ndef.c
index 890b141304..88b204e8aa 100644
--- a/src/lib/libcrypto/asn1/bio_ndef.c
+++ b/src/lib/libcrypto/asn1/bio_ndef.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: bio_ndef.c,v 1.10 2017/01/29 17:49:22 beck Exp $ */ 1/* $OpenBSD: bio_ndef.c,v 1.11 2021/12/25 13:17:48 jsing Exp $ */
2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL 2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
3 * project. 3 * project.
4 */ 4 */
@@ -143,7 +143,7 @@ BIO_new_NDEF(BIO *out, ASN1_VALUE *val, const ASN1_ITEM *it)
143 143
144 return sarg.ndef_bio; 144 return sarg.ndef_bio;
145 145
146err: 146 err:
147 BIO_free(asn_bio); 147 BIO_free(asn_bio);
148 free(ndef_aux); 148 free(ndef_aux);
149 return NULL; 149 return NULL;
diff --git a/src/lib/libcrypto/asn1/n_pkey.c b/src/lib/libcrypto/asn1/n_pkey.c
index cfc00887e5..40d8fa4240 100644
--- a/src/lib/libcrypto/asn1/n_pkey.c
+++ b/src/lib/libcrypto/asn1/n_pkey.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: n_pkey.c,v 1.34 2021/12/12 21:30:13 tb Exp $ */ 1/* $OpenBSD: n_pkey.c,v 1.35 2021/12/25 13:17:48 jsing Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) 2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
@@ -316,7 +316,7 @@ i2d_RSA_NET(const RSA *a, unsigned char **pp,
316 goto err; 316 goto err;
317 317
318 ret = i2d_NETSCAPE_ENCRYPTED_PKEY(enckey, pp); 318 ret = i2d_NETSCAPE_ENCRYPTED_PKEY(enckey, pp);
319err: 319 err:
320 EVP_CIPHER_CTX_cleanup(&ctx); 320 EVP_CIPHER_CTX_cleanup(&ctx);
321 NETSCAPE_ENCRYPTED_PKEY_free(enckey); 321 NETSCAPE_ENCRYPTED_PKEY_free(enckey);
322 NETSCAPE_PKEY_free(pkey); 322 NETSCAPE_PKEY_free(pkey);
@@ -365,7 +365,7 @@ d2i_RSA_NET(RSA **a, const unsigned char **pp, long length,
365 365
366 *pp = p; 366 *pp = p;
367 367
368err: 368 err:
369 NETSCAPE_ENCRYPTED_PKEY_free(enckey); 369 NETSCAPE_ENCRYPTED_PKEY_free(enckey);
370 return ret; 370 return ret;
371 371
@@ -424,7 +424,7 @@ d2i_RSA_NET_2(RSA **a, ASN1_OCTET_STRING *os,
424 goto err; 424 goto err;
425 } 425 }
426 426
427err: 427 err:
428 EVP_CIPHER_CTX_cleanup(&ctx); 428 EVP_CIPHER_CTX_cleanup(&ctx);
429 NETSCAPE_PKEY_free(pkey); 429 NETSCAPE_PKEY_free(pkey);
430 return (ret); 430 return (ret);
diff --git a/src/lib/libcrypto/asn1/p5_pbe.c b/src/lib/libcrypto/asn1/p5_pbe.c
index 8fd416a3e5..a150b20bcd 100644
--- a/src/lib/libcrypto/asn1/p5_pbe.c
+++ b/src/lib/libcrypto/asn1/p5_pbe.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: p5_pbe.c,v 1.22 2017/01/29 17:49:22 beck Exp $ */ 1/* $OpenBSD: p5_pbe.c,v 1.23 2021/12/25 13:17:48 jsing Exp $ */
2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL 2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
3 * project 1999. 3 * project 1999.
4 */ 4 */
@@ -159,7 +159,7 @@ PKCS5_pbe_set0_algor(X509_ALGOR *algor, int alg, int iter,
159 if (X509_ALGOR_set0(algor, OBJ_nid2obj(alg), V_ASN1_SEQUENCE, pbe_str)) 159 if (X509_ALGOR_set0(algor, OBJ_nid2obj(alg), V_ASN1_SEQUENCE, pbe_str))
160 return 1; 160 return 1;
161 161
162err: 162 err:
163 if (pbe != NULL) 163 if (pbe != NULL)
164 PBEPARAM_free(pbe); 164 PBEPARAM_free(pbe);
165 ASN1_STRING_free(pbe_str); 165 ASN1_STRING_free(pbe_str);
diff --git a/src/lib/libcrypto/asn1/p5_pbev2.c b/src/lib/libcrypto/asn1/p5_pbev2.c
index 54dd1eb614..d88a4dfc64 100644
--- a/src/lib/libcrypto/asn1/p5_pbev2.c
+++ b/src/lib/libcrypto/asn1/p5_pbev2.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: p5_pbev2.c,v 1.26 2021/12/12 21:30:13 tb Exp $ */ 1/* $OpenBSD: p5_pbev2.c,v 1.27 2021/12/25 13:17:48 jsing Exp $ */
2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL 2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
3 * project 1999-2004. 3 * project 1999-2004.
4 */ 4 */
@@ -274,10 +274,10 @@ PKCS5_pbe2_set_iv(const EVP_CIPHER *cipher, int iter, unsigned char *salt,
274 274
275 return ret; 275 return ret;
276 276
277merr: 277 merr:
278 ASN1error(ERR_R_MALLOC_FAILURE); 278 ASN1error(ERR_R_MALLOC_FAILURE);
279 279
280err: 280 err:
281 PBE2PARAM_free(pbe2); 281 PBE2PARAM_free(pbe2);
282 /* Note 'scheme' is freed as part of pbe2 */ 282 /* Note 'scheme' is freed as part of pbe2 */
283 X509_ALGOR_free(kalg); 283 X509_ALGOR_free(kalg);
@@ -366,7 +366,7 @@ PKCS5_pbkdf2_set(int iter, unsigned char *salt, int saltlen, int prf_nid,
366 PBKDF2PARAM_free(kdf); 366 PBKDF2PARAM_free(kdf);
367 return keyfunc; 367 return keyfunc;
368 368
369merr: 369 merr:
370 ASN1error(ERR_R_MALLOC_FAILURE); 370 ASN1error(ERR_R_MALLOC_FAILURE);
371 PBKDF2PARAM_free(kdf); 371 PBKDF2PARAM_free(kdf);
372 X509_ALGOR_free(keyfunc); 372 X509_ALGOR_free(keyfunc);
diff --git a/src/lib/libcrypto/asn1/t_crl.c b/src/lib/libcrypto/asn1/t_crl.c
index b7f94a8644..3ded015d2f 100644
--- a/src/lib/libcrypto/asn1/t_crl.c
+++ b/src/lib/libcrypto/asn1/t_crl.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: t_crl.c,v 1.19 2021/11/01 20:53:08 tb Exp $ */ 1/* $OpenBSD: t_crl.c,v 1.20 2021/12/25 13:17:48 jsing Exp $ */
2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL 2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
3 * project 1999. 3 * project 1999.
4 */ 4 */
@@ -140,6 +140,6 @@ X509_CRL_print(BIO *out, X509_CRL *x)
140 140
141 return 1; 141 return 1;
142 142
143err: 143 err:
144 return 0; 144 return 0;
145} 145}
diff --git a/src/lib/libcrypto/asn1/t_req.c b/src/lib/libcrypto/asn1/t_req.c
index 320eaff9c0..cc9da46439 100644
--- a/src/lib/libcrypto/asn1/t_req.c
+++ b/src/lib/libcrypto/asn1/t_req.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: t_req.c,v 1.20 2021/11/01 20:53:08 tb Exp $ */ 1/* $OpenBSD: t_req.c,v 1.21 2021/12/25 13:17:48 jsing Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) 2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
@@ -194,7 +194,7 @@ X509_REQ_print_ex(BIO *bp, X509_REQ *x, unsigned long nmflags,
194 ii = 0; 194 ii = 0;
195 count = sk_ASN1_TYPE_num( 195 count = sk_ASN1_TYPE_num(
196 a->value.set); 196 a->value.set);
197get_next: 197 get_next:
198 at = sk_ASN1_TYPE_value( 198 at = sk_ASN1_TYPE_value(
199 a->value.set, ii); 199 a->value.set, ii);
200 type = at->type; 200 type = at->type;
@@ -257,7 +257,7 @@ get_next:
257 257
258 return (1); 258 return (1);
259 259
260err: 260 err:
261 X509error(ERR_R_BUF_LIB); 261 X509error(ERR_R_BUF_LIB);
262 return (0); 262 return (0);
263} 263}
diff --git a/src/lib/libcrypto/asn1/t_x509.c b/src/lib/libcrypto/asn1/t_x509.c
index ff7871cd06..563edac074 100644
--- a/src/lib/libcrypto/asn1/t_x509.c
+++ b/src/lib/libcrypto/asn1/t_x509.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: t_x509.c,v 1.36 2021/12/25 12:11:57 jsing Exp $ */ 1/* $OpenBSD: t_x509.c,v 1.37 2021/12/25 13:17:48 jsing Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) 2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
@@ -244,7 +244,7 @@ X509_print_ex(BIO *bp, X509 *x, unsigned long nmflags, unsigned long cflag)
244 } 244 }
245 ret = 1; 245 ret = 1;
246 246
247err: 247 err:
248 free(m); 248 free(m);
249 return (ret); 249 return (ret);
250} 250}
@@ -295,7 +295,7 @@ X509_ocspid_print(BIO *bp, X509 *x)
295 295
296 return (1); 296 return (1);
297 297
298err: 298 err:
299 free(der); 299 free(der);
300 return (0); 300 return (0);
301} 301}
@@ -416,7 +416,7 @@ ASN1_GENERALIZEDTIME_print(BIO *bp, const ASN1_GENERALIZEDTIME *tm)
416 else 416 else
417 return (1); 417 return (1);
418 418
419err: 419 err:
420 BIO_write(bp, "Bad time value", 14); 420 BIO_write(bp, "Bad time value", 14);
421 return (0); 421 return (0);
422} 422}
@@ -459,7 +459,7 @@ ASN1_UTCTIME_print(BIO *bp, const ASN1_UTCTIME *tm)
459 else 459 else
460 return (1); 460 return (1);
461 461
462err: 462 err:
463 BIO_write(bp, "Bad time value", 14); 463 BIO_write(bp, "Bad time value", 14);
464 return (0); 464 return (0);
465} 465}
@@ -505,7 +505,7 @@ X509_NAME_print(BIO *bp, const X509_NAME *name, int obase)
505 505
506 ret = 1; 506 ret = 1;
507 if (0) { 507 if (0) {
508err: 508 err:
509 X509error(ERR_R_BUF_LIB); 509 X509error(ERR_R_BUF_LIB);
510 } 510 }
511 free(b); 511 free(b);
diff --git a/src/lib/libcrypto/asn1/tasn_dec.c b/src/lib/libcrypto/asn1/tasn_dec.c
index e207691e2e..21602f1ee6 100644
--- a/src/lib/libcrypto/asn1/tasn_dec.c
+++ b/src/lib/libcrypto/asn1/tasn_dec.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: tasn_dec.c,v 1.46 2021/12/14 17:35:21 jsing Exp $ */ 1/* $OpenBSD: tasn_dec.c,v 1.47 2021/12/25 13:17:48 jsing Exp $ */
2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL 2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
3 * project 2000. 3 * project 2000.
4 */ 4 */
@@ -444,9 +444,9 @@ asn1_item_ex_d2i(ASN1_VALUE **pval, const unsigned char **in, long len,
444 return 0; 444 return 0;
445 } 445 }
446 446
447auxerr: 447 auxerr:
448 ASN1error(ASN1_R_AUX_ERROR); 448 ASN1error(ASN1_R_AUX_ERROR);
449err: 449 err:
450 if (combine == 0) 450 if (combine == 0)
451 ASN1_item_ex_free(pval, it); 451 ASN1_item_ex_free(pval, it);
452 if (errtt) 452 if (errtt)
@@ -533,7 +533,7 @@ asn1_template_ex_d2i(ASN1_VALUE **val, const unsigned char **in, long inlen,
533 *in = p; 533 *in = p;
534 return 1; 534 return 1;
535 535
536err: 536 err:
537 ASN1_template_free(val, tt); 537 ASN1_template_free(val, tt);
538 return 0; 538 return 0;
539} 539}
@@ -650,7 +650,7 @@ asn1_template_noexp_d2i(ASN1_VALUE **val, const unsigned char **in, long len,
650 *in = p; 650 *in = p;
651 return 1; 651 return 1;
652 652
653err: 653 err:
654 ASN1_template_free(val, tt); 654 ASN1_template_free(val, tt);
655 return 0; 655 return 0;
656} 656}
@@ -924,7 +924,7 @@ asn1_ex_c2i(ASN1_VALUE **pval, const unsigned char *cont, int len, int utype,
924 924
925 ret = 1; 925 ret = 1;
926 926
927err: 927 err:
928 if (!ret) { 928 if (!ret) {
929 ASN1_TYPE_free(typ); 929 ASN1_TYPE_free(typ);
930 if (opval) 930 if (opval)
diff --git a/src/lib/libcrypto/asn1/tasn_new.c b/src/lib/libcrypto/asn1/tasn_new.c
index 231d5f66ce..24145c73ac 100644
--- a/src/lib/libcrypto/asn1/tasn_new.c
+++ b/src/lib/libcrypto/asn1/tasn_new.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: tasn_new.c,v 1.19 2021/12/15 17:53:36 jsing Exp $ */ 1/* $OpenBSD: tasn_new.c,v 1.20 2021/12/25 13:17:48 jsing Exp $ */
2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL 2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
3 * project 2000. 3 * project 2000.
4 */ 4 */
@@ -173,11 +173,11 @@ asn1_item_ex_combine_new(ASN1_VALUE **pval, const ASN1_ITEM *it, int combine)
173 } 173 }
174 return 1; 174 return 1;
175 175
176memerr: 176 memerr:
177 ASN1error(ERR_R_MALLOC_FAILURE); 177 ASN1error(ERR_R_MALLOC_FAILURE);
178 return 0; 178 return 0;
179 179
180auxerr: 180 auxerr:
181 ASN1error(ASN1_R_AUX_ERROR); 181 ASN1error(ASN1_R_AUX_ERROR);
182 ASN1_item_ex_free(pval, it); 182 ASN1_item_ex_free(pval, it);
183 return 0; 183 return 0;
@@ -248,7 +248,7 @@ ASN1_template_new(ASN1_VALUE **pval, const ASN1_TEMPLATE *tt)
248 } 248 }
249 /* Otherwise pass it back to the item routine */ 249 /* Otherwise pass it back to the item routine */
250 ret = asn1_item_ex_combine_new(pval, it, tt->flags & ASN1_TFLG_COMBINE); 250 ret = asn1_item_ex_combine_new(pval, it, tt->flags & ASN1_TFLG_COMBINE);
251done: 251 done:
252 return ret; 252 return ret;
253} 253}
254 254
diff --git a/src/lib/libcrypto/asn1/tasn_utl.c b/src/lib/libcrypto/asn1/tasn_utl.c
index 391ef01a57..e64bbe1f1a 100644
--- a/src/lib/libcrypto/asn1/tasn_utl.c
+++ b/src/lib/libcrypto/asn1/tasn_utl.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: tasn_utl.c,v 1.12 2017/01/29 17:49:22 beck Exp $ */ 1/* $OpenBSD: tasn_utl.c,v 1.13 2021/12/25 13:17:48 jsing Exp $ */
2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL 2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
3 * project 2000. 3 * project 2000.
4 */ 4 */
@@ -272,7 +272,7 @@ asn1_do_adb(ASN1_VALUE **pval, const ASN1_TEMPLATE *tt, int nullerr)
272 goto err; 272 goto err;
273 return adb->default_tt; 273 return adb->default_tt;
274 274
275err: 275 err:
276 /* FIXME: should log the value or OID of unsupported type */ 276 /* FIXME: should log the value or OID of unsupported type */
277 if (nullerr) 277 if (nullerr)
278 ASN1error(ASN1_R_UNSUPPORTED_ANY_DEFINED_BY_TYPE); 278 ASN1error(ASN1_R_UNSUPPORTED_ANY_DEFINED_BY_TYPE);
diff --git a/src/lib/libcrypto/asn1/x_attrib.c b/src/lib/libcrypto/asn1/x_attrib.c
index a40edc1f1d..47b5afd95d 100644
--- a/src/lib/libcrypto/asn1/x_attrib.c
+++ b/src/lib/libcrypto/asn1/x_attrib.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: x_attrib.c,v 1.15 2021/11/01 20:53:08 tb Exp $ */ 1/* $OpenBSD: x_attrib.c,v 1.16 2021/12/25 13:17:48 jsing Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) 2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
@@ -194,7 +194,7 @@ X509_ATTRIBUTE_create(int nid, int atrtype, void *value)
194 ASN1_TYPE_set(val, atrtype, value); 194 ASN1_TYPE_set(val, atrtype, value);
195 return (ret); 195 return (ret);
196 196
197err: 197 err:
198 if (ret != NULL) 198 if (ret != NULL)
199 X509_ATTRIBUTE_free(ret); 199 X509_ATTRIBUTE_free(ret);
200 if (val != NULL) 200 if (val != NULL)
diff --git a/src/lib/libcrypto/asn1/x_name.c b/src/lib/libcrypto/asn1/x_name.c
index 4563a51348..4c698ac2f0 100644
--- a/src/lib/libcrypto/asn1/x_name.c
+++ b/src/lib/libcrypto/asn1/x_name.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: x_name.c,v 1.36 2021/11/01 20:53:08 tb Exp $ */ 1/* $OpenBSD: x_name.c,v 1.37 2021/12/25 13:17:48 jsing Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) 2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
@@ -257,7 +257,7 @@ x509_name_ex_new(ASN1_VALUE **val, const ASN1_ITEM *it)
257 *val = (ASN1_VALUE *)ret; 257 *val = (ASN1_VALUE *)ret;
258 return 1; 258 return 1;
259 259
260memerr: 260 memerr:
261 ASN1error(ERR_R_MALLOC_FAILURE); 261 ASN1error(ERR_R_MALLOC_FAILURE);
262 if (ret) { 262 if (ret) {
263 if (ret->entries) 263 if (ret->entries)
@@ -337,7 +337,7 @@ x509_name_ex_d2i(ASN1_VALUE **val, const unsigned char **in, long len,
337 *in = p; 337 *in = p;
338 return ret; 338 return ret;
339 339
340err: 340 err:
341 if (nm.x != NULL) 341 if (nm.x != NULL)
342 X509_NAME_free(nm.x); 342 X509_NAME_free(nm.x);
343 ASN1error(ERR_R_NESTED_ASN1_ERROR); 343 ASN1error(ERR_R_NESTED_ASN1_ERROR);
@@ -422,7 +422,7 @@ x509_name_encode(X509_NAME *a)
422 a->modified = 0; 422 a->modified = 0;
423 return len; 423 return len;
424 424
425memerr: 425 memerr:
426 sk_STACK_OF_X509_NAME_ENTRY_pop_free(intname.s, 426 sk_STACK_OF_X509_NAME_ENTRY_pop_free(intname.s,
427 local_sk_X509_NAME_ENTRY_free); 427 local_sk_X509_NAME_ENTRY_free);
428 ASN1error(ERR_R_MALLOC_FAILURE); 428 ASN1error(ERR_R_MALLOC_FAILURE);
@@ -512,7 +512,7 @@ x509_name_canon(X509_NAME *a)
512 i2d_name_canon(intname, &p); 512 i2d_name_canon(intname, &p);
513 ret = 1; 513 ret = 1;
514 514
515err: 515 err:
516 if (tmpentry) 516 if (tmpentry)
517 X509_NAME_ENTRY_free(tmpentry); 517 X509_NAME_ENTRY_free(tmpentry);
518 if (intname) 518 if (intname)
diff --git a/src/lib/libcrypto/asn1/x_pkey.c b/src/lib/libcrypto/asn1/x_pkey.c
index c946281f4a..fdf0e002f1 100644
--- a/src/lib/libcrypto/asn1/x_pkey.c
+++ b/src/lib/libcrypto/asn1/x_pkey.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: x_pkey.c,v 1.20 2017/01/29 17:49:22 beck Exp $ */ 1/* $OpenBSD: x_pkey.c,v 1.21 2021/12/25 13:17:48 jsing Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) 2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
@@ -91,7 +91,7 @@ X509_PKEY_new(void)
91 ret->references = 1; 91 ret->references = 1;
92 return (ret); 92 return (ret);
93 93
94err: 94 err:
95 if (ret) { 95 if (ret) {
96 X509_ALGOR_free(ret->enc_algor); 96 X509_ALGOR_free(ret->enc_algor);
97 free(ret); 97 free(ret);
diff --git a/src/lib/libcrypto/asn1/x_pubkey.c b/src/lib/libcrypto/asn1/x_pubkey.c
index fecd6c97e3..69be6ed1f9 100644
--- a/src/lib/libcrypto/asn1/x_pubkey.c
+++ b/src/lib/libcrypto/asn1/x_pubkey.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: x_pubkey.c,v 1.30 2021/12/12 21:30:13 tb Exp $ */ 1/* $OpenBSD: x_pubkey.c,v 1.31 2021/12/25 13:17:48 jsing Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) 2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
@@ -169,7 +169,7 @@ X509_PUBKEY_set(X509_PUBKEY **x, EVP_PKEY *pkey)
169 169
170 return 1; 170 return 1;
171 171
172error: 172 error:
173 if (pk != NULL) 173 if (pk != NULL)
174 X509_PUBKEY_free(pk); 174 X509_PUBKEY_free(pk);
175 return 0; 175 return 0;
@@ -222,7 +222,7 @@ X509_PUBKEY_get0(X509_PUBKEY *key)
222 222
223 return ret; 223 return ret;
224 224
225error: 225 error:
226 EVP_PKEY_free(ret); 226 EVP_PKEY_free(ret);
227 return (NULL); 227 return (NULL);
228} 228}
diff --git a/src/lib/libcrypto/asn1/x_x509.c b/src/lib/libcrypto/asn1/x_x509.c
index 713ffbbb11..7147069e83 100644
--- a/src/lib/libcrypto/asn1/x_x509.c
+++ b/src/lib/libcrypto/asn1/x_x509.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: x_x509.c,v 1.29 2021/11/01 20:53:08 tb Exp $ */ 1/* $OpenBSD: x_x509.c,v 1.30 2021/12/25 13:17:48 jsing Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) 2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
@@ -339,7 +339,7 @@ d2i_X509_AUX(X509 **a, const unsigned char **pp, long length)
339 } 339 }
340 return ret; 340 return ret;
341 341
342err: 342 err:
343 X509_free(ret); 343 X509_free(ret);
344 return NULL; 344 return NULL;
345} 345}
diff --git a/src/lib/libcrypto/asn1/x_x509a.c b/src/lib/libcrypto/asn1/x_x509a.c
index 572178157a..87dc045a5f 100644
--- a/src/lib/libcrypto/asn1/x_x509a.c
+++ b/src/lib/libcrypto/asn1/x_x509a.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: x_x509a.c,v 1.17 2021/11/01 20:53:08 tb Exp $ */ 1/* $OpenBSD: x_x509a.c,v 1.18 2021/12/25 13:17:48 jsing Exp $ */
2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL 2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
3 * project 1999. 3 * project 1999.
4 */ 4 */
@@ -228,7 +228,7 @@ X509_add1_trust_object(X509 *x, const ASN1_OBJECT *obj)
228 if (rc != 0) 228 if (rc != 0)
229 return rc; 229 return rc;
230 230
231err: 231 err:
232 ASN1_OBJECT_free(objtmp); 232 ASN1_OBJECT_free(objtmp);
233 return 0; 233 return 0;
234} 234}
@@ -250,7 +250,7 @@ X509_add1_reject_object(X509 *x, const ASN1_OBJECT *obj)
250 if (rc != 0) 250 if (rc != 0)
251 return rc; 251 return rc;
252 252
253err: 253 err:
254 ASN1_OBJECT_free(objtmp); 254 ASN1_OBJECT_free(objtmp);
255 return 0; 255 return 0;
256} 256}