Commit this before the head-scratching leads to premature baldness:

    memset(a->data, 0, (unsigned int)a->max);
but the decl is:
    size_t max;
size_t could be larger than int, especially in some of the systems OpenSSL
purports to support.

How do _intentionally truncating_ casts like enter into a codebase?
Lack of understanding of C, at a minimum.  Generally the objects are
small, but this code is _intentionally unready_ for large objects.
ok miod

2 files changed, 2 insertions, 2 deletions

diff --git a/src/lib/libcrypto/buffer/buffer.c b/src/lib/libcrypto/buffer/buffer.c
index 486d6fef14..71784693be 100644
--- a/src/lib/libcrypto/buffer/buffer.c
+++ b/src/lib/libcrypto/buffer/buffer.c
@@ -88,7 +88,7 @@ BUF_MEM_free(BUF_MEM *a)
                 return;
 
         if (a->data != NULL) {
-                memset(a->data, 0, (unsigned int)a->max);
+                memset(a->data, 0, a->max);
                 free(a->data);
         }
         free(a);
diff --git a/src/lib/libssl/src/crypto/buffer/buffer.c b/src/lib/libssl/src/crypto/buffer/buffer.c
index 486d6fef14..71784693be 100644
--- a/src/lib/libssl/src/crypto/buffer/buffer.c
+++ b/src/lib/libssl/src/crypto/buffer/buffer.c
@@ -88,7 +88,7 @@ BUF_MEM_free(BUF_MEM *a)
                 return;
 
         if (a->data != NULL) {
-                memset(a->data, 0, (unsigned int)a->max);
+                memset(a->data, 0, a->max);
                 free(a->data);
         }
         free(a);