summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorguenther <>2014-04-19 08:52:32 +0000
committerguenther <>2014-04-19 08:52:32 +0000
commit9e60d35ac1ade619b0d44538f7f50f62c1514194 (patch)
tree1c8e1f947cd7380525a7312a9e96fad2690b90fa /src
parent8ffabaf4eba42faf2565cf746f06a82adf194000 (diff)
downloadopenbsd-9e60d35ac1ade619b0d44538f7f50f62c1514194.tar.gz
openbsd-9e60d35ac1ade619b0d44538f7f50f62c1514194.tar.bz2
openbsd-9e60d35ac1ade619b0d44538f7f50f62c1514194.zip
More KNF and style consistency tweaks
Diffstat (limited to 'src')
-rw-r--r--src/lib/libssl/d1_clnt.c7
-rw-r--r--src/lib/libssl/d1_lib.c4
-rw-r--r--src/lib/libssl/d1_meth.c7
-rw-r--r--src/lib/libssl/d1_srtp.c18
-rw-r--r--src/lib/libssl/d1_srvr.c7
-rw-r--r--src/lib/libssl/s23_clnt.c13
-rw-r--r--src/lib/libssl/s23_lib.c10
-rw-r--r--src/lib/libssl/s23_srvr.c9
-rw-r--r--src/lib/libssl/s3_clnt.c7
-rw-r--r--src/lib/libssl/s3_lib.c17
-rw-r--r--src/lib/libssl/s3_pkt.c4
-rw-r--r--src/lib/libssl/s3_srvr.c7
-rw-r--r--src/lib/libssl/src/ssl/d1_clnt.c7
-rw-r--r--src/lib/libssl/src/ssl/d1_lib.c4
-rw-r--r--src/lib/libssl/src/ssl/d1_meth.c7
-rw-r--r--src/lib/libssl/src/ssl/d1_srtp.c18
-rw-r--r--src/lib/libssl/src/ssl/d1_srvr.c7
-rw-r--r--src/lib/libssl/src/ssl/kssl.c16
-rw-r--r--src/lib/libssl/src/ssl/s23_clnt.c13
-rw-r--r--src/lib/libssl/src/ssl/s23_lib.c10
-rw-r--r--src/lib/libssl/src/ssl/s23_meth.c13
-rw-r--r--src/lib/libssl/src/ssl/s23_srvr.c9
-rw-r--r--src/lib/libssl/src/ssl/s3_clnt.c7
-rw-r--r--src/lib/libssl/src/ssl/s3_lib.c17
-rw-r--r--src/lib/libssl/src/ssl/s3_meth.c7
-rw-r--r--src/lib/libssl/src/ssl/s3_pkt.c4
-rw-r--r--src/lib/libssl/src/ssl/s3_srvr.c7
-rw-r--r--src/lib/libssl/src/ssl/srtp.h10
-rw-r--r--src/lib/libssl/src/ssl/ssl.h5
-rw-r--r--src/lib/libssl/src/ssl/ssl_asn1.c5
-rw-r--r--src/lib/libssl/src/ssl/ssl_cert.c28
-rw-r--r--src/lib/libssl/src/ssl/ssl_ciph.c36
-rw-r--r--src/lib/libssl/src/ssl/ssl_lib.c140
-rw-r--r--src/lib/libssl/src/ssl/ssl_sess.c24
-rw-r--r--src/lib/libssl/src/ssl/ssl_stat.c32
-rw-r--r--src/lib/libssl/src/ssl/ssltest.c16
-rw-r--r--src/lib/libssl/src/ssl/t1_clnt.c12
-rw-r--r--src/lib/libssl/src/ssl/t1_lib.c12
-rw-r--r--src/lib/libssl/src/ssl/t1_meth.c12
-rw-r--r--src/lib/libssl/src/ssl/t1_srvr.c12
-rw-r--r--src/lib/libssl/src/ssl/tls_srp.c16
-rw-r--r--src/lib/libssl/srtp.h10
-rw-r--r--src/lib/libssl/ssl.h5
-rw-r--r--src/lib/libssl/ssl_asn1.c5
-rw-r--r--src/lib/libssl/ssl_cert.c28
-rw-r--r--src/lib/libssl/ssl_ciph.c36
-rw-r--r--src/lib/libssl/ssl_lib.c140
-rw-r--r--src/lib/libssl/ssl_sess.c24
-rw-r--r--src/lib/libssl/ssl_stat.c32
-rw-r--r--src/lib/libssl/t1_clnt.c12
-rw-r--r--src/lib/libssl/t1_lib.c12
-rw-r--r--src/lib/libssl/t1_meth.c12
-rw-r--r--src/lib/libssl/t1_srvr.c12
53 files changed, 465 insertions, 479 deletions
diff --git a/src/lib/libssl/d1_clnt.c b/src/lib/libssl/d1_clnt.c
index b919baf7fa..6bceeea55b 100644
--- a/src/lib/libssl/d1_clnt.c
+++ b/src/lib/libssl/d1_clnt.c
@@ -131,13 +131,12 @@
131static const SSL_METHOD *dtls1_get_client_method(int ver); 131static const SSL_METHOD *dtls1_get_client_method(int ver);
132static int dtls1_get_hello_verify(SSL *s); 132static int dtls1_get_hello_verify(SSL *s);
133 133
134static const SSL_METHOD 134static const SSL_METHOD *
135*dtls1_get_client_method(int ver) 135dtls1_get_client_method(int ver)
136{ 136{
137 if (ver == DTLS1_VERSION || ver == DTLS1_BAD_VER) 137 if (ver == DTLS1_VERSION || ver == DTLS1_BAD_VER)
138 return (DTLSv1_client_method()); 138 return (DTLSv1_client_method());
139 else 139 return (NULL);
140 return (NULL);
141} 140}
142 141
143IMPLEMENT_dtls1_meth_func(DTLSv1_client_method, 142IMPLEMENT_dtls1_meth_func(DTLSv1_client_method,
diff --git a/src/lib/libssl/d1_lib.c b/src/lib/libssl/d1_lib.c
index 7da57b0a36..0217b68928 100644
--- a/src/lib/libssl/d1_lib.c
+++ b/src/lib/libssl/d1_lib.c
@@ -277,8 +277,8 @@ dtls1_ctrl(SSL *s, int cmd, long larg, void *parg)
277 * to explicitly list their SSL_* codes. Currently RC4 is the only one 277 * to explicitly list their SSL_* codes. Currently RC4 is the only one
278 * available, but if new ones emerge, they will have to be added... 278 * available, but if new ones emerge, they will have to be added...
279 */ 279 */
280const SSL_CIPHER 280const SSL_CIPHER *
281*dtls1_get_cipher(unsigned int u) 281dtls1_get_cipher(unsigned int u)
282{ 282{
283 const SSL_CIPHER *ciph = ssl3_get_cipher(u); 283 const SSL_CIPHER *ciph = ssl3_get_cipher(u);
284 284
diff --git a/src/lib/libssl/d1_meth.c b/src/lib/libssl/d1_meth.c
index 2d3f3920ec..1140da6825 100644
--- a/src/lib/libssl/d1_meth.c
+++ b/src/lib/libssl/d1_meth.c
@@ -62,13 +62,12 @@
62#include "ssl_locl.h" 62#include "ssl_locl.h"
63 63
64static const SSL_METHOD *dtls1_get_method(int ver); 64static const SSL_METHOD *dtls1_get_method(int ver);
65static const SSL_METHOD 65static const SSL_METHOD *
66*dtls1_get_method(int ver) 66dtls1_get_method(int ver)
67{ 67{
68 if (ver == DTLS1_VERSION) 68 if (ver == DTLS1_VERSION)
69 return (DTLSv1_method()); 69 return (DTLSv1_method());
70 else 70 return (NULL);
71 return (NULL);
72} 71}
73 72
74IMPLEMENT_dtls1_meth_func(DTLSv1_method, 73IMPLEMENT_dtls1_meth_func(DTLSv1_method,
diff --git a/src/lib/libssl/d1_srtp.c b/src/lib/libssl/d1_srtp.c
index fadd9f381f..146ce321c8 100644
--- a/src/lib/libssl/d1_srtp.c
+++ b/src/lib/libssl/d1_srtp.c
@@ -109,11 +109,11 @@
109 * 109 *
110 */ 110 */
111/* 111/*
112 DTLS code by Eric Rescorla <ekr@rtfm.com> 112 * DTLS code by Eric Rescorla <ekr@rtfm.com>
113 113 *
114 Copyright (C) 2006, Network Resonance, Inc. 114 * Copyright (C) 2006, Network Resonance, Inc.
115 Copyright (C) 2011, RTFM, Inc. 115 * Copyright (C) 2011, RTFM, Inc.
116*/ 116 */
117 117
118#include <stdio.h> 118#include <stdio.h>
119#include <openssl/objects.h> 119#include <openssl/objects.h>
@@ -232,8 +232,8 @@ SSL_set_tlsext_use_srtp(SSL *s, const char *profiles)
232} 232}
233 233
234 234
235STACK_OF(SRTP_PROTECTION_PROFILE) 235STACK_OF(SRTP_PROTECTION_PROFILE) *
236*SSL_get_srtp_profiles(SSL *s) 236SSL_get_srtp_profiles(SSL *s)
237{ 237{
238 if (s != NULL) { 238 if (s != NULL) {
239 if (s->srtp_profiles != NULL) { 239 if (s->srtp_profiles != NULL) {
@@ -247,8 +247,8 @@ STACK_OF(SRTP_PROTECTION_PROFILE)
247 return NULL; 247 return NULL;
248} 248}
249 249
250SRTP_PROTECTION_PROFILE 250SRTP_PROTECTION_PROFILE *
251*SSL_get_selected_srtp_profile(SSL *s) 251SSL_get_selected_srtp_profile(SSL *s)
252{ 252{
253 return s->srtp_profile; 253 return s->srtp_profile;
254} 254}
diff --git a/src/lib/libssl/d1_srvr.c b/src/lib/libssl/d1_srvr.c
index 6a10f7a3dd..fc475485ba 100644
--- a/src/lib/libssl/d1_srvr.c
+++ b/src/lib/libssl/d1_srvr.c
@@ -129,13 +129,12 @@
129static const SSL_METHOD *dtls1_get_server_method(int ver); 129static const SSL_METHOD *dtls1_get_server_method(int ver);
130static int dtls1_send_hello_verify_request(SSL *s); 130static int dtls1_send_hello_verify_request(SSL *s);
131 131
132static const SSL_METHOD 132static const SSL_METHOD *
133*dtls1_get_server_method(int ver) 133dtls1_get_server_method(int ver)
134{ 134{
135 if (ver == DTLS1_VERSION) 135 if (ver == DTLS1_VERSION)
136 return (DTLSv1_server_method()); 136 return (DTLSv1_server_method());
137 else 137 return (NULL);
138 return (NULL);
139} 138}
140 139
141IMPLEMENT_dtls1_meth_func(DTLSv1_server_method, 140IMPLEMENT_dtls1_meth_func(DTLSv1_server_method,
diff --git a/src/lib/libssl/s23_clnt.c b/src/lib/libssl/s23_clnt.c
index 196ef1dfad..65e2be0c8c 100644
--- a/src/lib/libssl/s23_clnt.c
+++ b/src/lib/libssl/s23_clnt.c
@@ -119,19 +119,18 @@
119static const SSL_METHOD *ssl23_get_client_method(int ver); 119static const SSL_METHOD *ssl23_get_client_method(int ver);
120static int ssl23_client_hello(SSL *s); 120static int ssl23_client_hello(SSL *s);
121static int ssl23_get_server_hello(SSL *s); 121static int ssl23_get_server_hello(SSL *s);
122static const SSL_METHOD 122static const SSL_METHOD *
123*ssl23_get_client_method(int ver) 123ssl23_get_client_method(int ver)
124{ 124{
125 if (ver == SSL3_VERSION) 125 if (ver == SSL3_VERSION)
126 return (SSLv3_client_method()); 126 return (SSLv3_client_method());
127 else if (ver == TLS1_VERSION) 127 if (ver == TLS1_VERSION)
128 return (TLSv1_client_method()); 128 return (TLSv1_client_method());
129 else if (ver == TLS1_1_VERSION) 129 if (ver == TLS1_1_VERSION)
130 return (TLSv1_1_client_method()); 130 return (TLSv1_1_client_method());
131 else if (ver == TLS1_2_VERSION) 131 if (ver == TLS1_2_VERSION)
132 return (TLSv1_2_client_method()); 132 return (TLSv1_2_client_method());
133 else 133 return (NULL);
134 return (NULL);
135} 134}
136 135
137IMPLEMENT_ssl23_meth_func(SSLv23_client_method, 136IMPLEMENT_ssl23_meth_func(SSLv23_client_method,
diff --git a/src/lib/libssl/s23_lib.c b/src/lib/libssl/s23_lib.c
index 74afe01d94..226af4b3cb 100644
--- a/src/lib/libssl/s23_lib.c
+++ b/src/lib/libssl/s23_lib.c
@@ -69,11 +69,11 @@ ssl23_default_timeout(void)
69int 69int
70ssl23_num_ciphers(void) 70ssl23_num_ciphers(void)
71{ 71{
72 return(ssl3_num_ciphers()); 72 return (ssl3_num_ciphers());
73} 73}
74 74
75const SSL_CIPHER 75const SSL_CIPHER *
76*ssl23_get_cipher(unsigned int u) 76ssl23_get_cipher(unsigned int u)
77{ 77{
78 unsigned int uu = ssl3_num_ciphers(); 78 unsigned int uu = ssl3_num_ciphers();
79 79
@@ -85,8 +85,8 @@ const SSL_CIPHER
85 85
86/* This function needs to check if the ciphers required are actually 86/* This function needs to check if the ciphers required are actually
87 * available */ 87 * available */
88const SSL_CIPHER 88const SSL_CIPHER *
89*ssl23_get_cipher_by_char(const unsigned char *p) 89ssl23_get_cipher_by_char(const unsigned char *p)
90{ 90{
91 const SSL_CIPHER *cp; 91 const SSL_CIPHER *cp;
92 92
diff --git a/src/lib/libssl/s23_srvr.c b/src/lib/libssl/s23_srvr.c
index c63ede8680..665907ee12 100644
--- a/src/lib/libssl/s23_srvr.c
+++ b/src/lib/libssl/s23_srvr.c
@@ -123,14 +123,13 @@ ssl23_get_server_method(int ver)
123{ 123{
124 if (ver == SSL3_VERSION) 124 if (ver == SSL3_VERSION)
125 return (SSLv3_server_method()); 125 return (SSLv3_server_method());
126 else if (ver == TLS1_VERSION) 126 if (ver == TLS1_VERSION)
127 return (TLSv1_server_method()); 127 return (TLSv1_server_method());
128 else if (ver == TLS1_1_VERSION) 128 if (ver == TLS1_1_VERSION)
129 return (TLSv1_1_server_method()); 129 return (TLSv1_1_server_method());
130 else if (ver == TLS1_2_VERSION) 130 if (ver == TLS1_2_VERSION)
131 return (TLSv1_2_server_method()); 131 return (TLSv1_2_server_method());
132 else 132 return (NULL);
133 return (NULL);
134} 133}
135 134
136IMPLEMENT_ssl23_meth_func(SSLv23_server_method, 135IMPLEMENT_ssl23_meth_func(SSLv23_server_method,
diff --git a/src/lib/libssl/s3_clnt.c b/src/lib/libssl/s3_clnt.c
index 8aef4b4f3d..10546ee848 100644
--- a/src/lib/libssl/s3_clnt.c
+++ b/src/lib/libssl/s3_clnt.c
@@ -167,13 +167,12 @@
167static const SSL_METHOD *ssl3_get_client_method(int ver); 167static const SSL_METHOD *ssl3_get_client_method(int ver);
168static int ca_dn_cmp(const X509_NAME * const *a, const X509_NAME * const *b); 168static int ca_dn_cmp(const X509_NAME * const *a, const X509_NAME * const *b);
169 169
170static const SSL_METHOD 170static const SSL_METHOD *
171*ssl3_get_client_method(int ver) 171ssl3_get_client_method(int ver)
172{ 172{
173 if (ver == SSL3_VERSION) 173 if (ver == SSL3_VERSION)
174 return (SSLv3_client_method()); 174 return (SSLv3_client_method());
175 else 175 return (NULL);
176 return (NULL);
177} 176}
178 177
179IMPLEMENT_ssl3_meth_func(SSLv3_client_method, 178IMPLEMENT_ssl3_meth_func(SSLv3_client_method,
diff --git a/src/lib/libssl/s3_lib.c b/src/lib/libssl/s3_lib.c
index fe638e84a9..95e5c903ec 100644
--- a/src/lib/libssl/s3_lib.c
+++ b/src/lib/libssl/s3_lib.c
@@ -2754,8 +2754,8 @@ ssl3_num_ciphers(void)
2754 return (SSL3_NUM_CIPHERS); 2754 return (SSL3_NUM_CIPHERS);
2755} 2755}
2756 2756
2757const SSL_CIPHER 2757const SSL_CIPHER *
2758*ssl3_get_cipher(unsigned int u) 2758ssl3_get_cipher(unsigned int u)
2759{ 2759{
2760 if (u < SSL3_NUM_CIPHERS) 2760 if (u < SSL3_NUM_CIPHERS)
2761 return (&(ssl3_ciphers[SSL3_NUM_CIPHERS - 1 - u])); 2761 return (&(ssl3_ciphers[SSL3_NUM_CIPHERS - 1 - u]));
@@ -3470,8 +3470,8 @@ ssl3_ctx_callback_ctrl(SSL_CTX *ctx, int cmd, void (*fp)(void))
3470 3470
3471/* This function needs to check if the ciphers required are actually 3471/* This function needs to check if the ciphers required are actually
3472 * available */ 3472 * available */
3473const SSL_CIPHER 3473const SSL_CIPHER *
3474*ssl3_get_cipher_by_char(const unsigned char *p) 3474ssl3_get_cipher_by_char(const unsigned char *p)
3475{ 3475{
3476 SSL_CIPHER c; 3476 SSL_CIPHER c;
3477 const SSL_CIPHER *cp; 3477 const SSL_CIPHER *cp;
@@ -3954,10 +3954,11 @@ ssl3_renegotiate_check(SSL *s)
3954 if (s->s3->renegotiate) { 3954 if (s->s3->renegotiate) {
3955 if ((s->s3->rbuf.left == 0) && (s->s3->wbuf.left == 0) && 3955 if ((s->s3->rbuf.left == 0) && (s->s3->wbuf.left == 0) &&
3956 !SSL_in_init(s)) { 3956 !SSL_in_init(s)) {
3957/* 3957 /*
3958if we are the server, and we have sent a 'RENEGOTIATE' message, we 3958 * If we are the server, and we have sent
3959need to go to SSL_ST_ACCEPT. 3959 * a 'RENEGOTIATE' message, we need to go
3960*/ 3960 * to SSL_ST_ACCEPT.
3961 */
3961 /* SSL_ST_ACCEPT */ 3962 /* SSL_ST_ACCEPT */
3962 s->state = SSL_ST_RENEGOTIATE; 3963 s->state = SSL_ST_RENEGOTIATE;
3963 s->s3->renegotiate = 0; 3964 s->s3->renegotiate = 0;
diff --git a/src/lib/libssl/s3_pkt.c b/src/lib/libssl/s3_pkt.c
index ec73ef50bd..52c48e945e 100644
--- a/src/lib/libssl/s3_pkt.c
+++ b/src/lib/libssl/s3_pkt.c
@@ -756,9 +756,9 @@ do_ssl3_write(SSL *s, int type, const unsigned char *buf,
756 wr->data = p; 756 wr->data = p;
757 757
758 if (eivlen) { 758 if (eivlen) {
759 /* if (RAND_pseudo_bytes(p, eivlen) <= 0) 759 /* if (RAND_pseudo_bytes(p, eivlen) <= 0)
760 goto err; 760 goto err;
761*/ 761 */
762 wr->length += eivlen; 762 wr->length += eivlen;
763 } 763 }
764 764
diff --git a/src/lib/libssl/s3_srvr.c b/src/lib/libssl/s3_srvr.c
index 79b89d7e95..8416eb7042 100644
--- a/src/lib/libssl/s3_srvr.c
+++ b/src/lib/libssl/s3_srvr.c
@@ -171,13 +171,12 @@
171 171
172static const SSL_METHOD *ssl3_get_server_method(int ver); 172static const SSL_METHOD *ssl3_get_server_method(int ver);
173 173
174static const SSL_METHOD 174static const SSL_METHOD *
175*ssl3_get_server_method(int ver) 175ssl3_get_server_method(int ver)
176{ 176{
177 if (ver == SSL3_VERSION) 177 if (ver == SSL3_VERSION)
178 return (SSLv3_server_method()); 178 return (SSLv3_server_method());
179 else 179 return (NULL);
180 return (NULL);
181} 180}
182 181
183#ifndef OPENSSL_NO_SRP 182#ifndef OPENSSL_NO_SRP
diff --git a/src/lib/libssl/src/ssl/d1_clnt.c b/src/lib/libssl/src/ssl/d1_clnt.c
index b919baf7fa..6bceeea55b 100644
--- a/src/lib/libssl/src/ssl/d1_clnt.c
+++ b/src/lib/libssl/src/ssl/d1_clnt.c
@@ -131,13 +131,12 @@
131static const SSL_METHOD *dtls1_get_client_method(int ver); 131static const SSL_METHOD *dtls1_get_client_method(int ver);
132static int dtls1_get_hello_verify(SSL *s); 132static int dtls1_get_hello_verify(SSL *s);
133 133
134static const SSL_METHOD 134static const SSL_METHOD *
135*dtls1_get_client_method(int ver) 135dtls1_get_client_method(int ver)
136{ 136{
137 if (ver == DTLS1_VERSION || ver == DTLS1_BAD_VER) 137 if (ver == DTLS1_VERSION || ver == DTLS1_BAD_VER)
138 return (DTLSv1_client_method()); 138 return (DTLSv1_client_method());
139 else 139 return (NULL);
140 return (NULL);
141} 140}
142 141
143IMPLEMENT_dtls1_meth_func(DTLSv1_client_method, 142IMPLEMENT_dtls1_meth_func(DTLSv1_client_method,
diff --git a/src/lib/libssl/src/ssl/d1_lib.c b/src/lib/libssl/src/ssl/d1_lib.c
index 7da57b0a36..0217b68928 100644
--- a/src/lib/libssl/src/ssl/d1_lib.c
+++ b/src/lib/libssl/src/ssl/d1_lib.c
@@ -277,8 +277,8 @@ dtls1_ctrl(SSL *s, int cmd, long larg, void *parg)
277 * to explicitly list their SSL_* codes. Currently RC4 is the only one 277 * to explicitly list their SSL_* codes. Currently RC4 is the only one
278 * available, but if new ones emerge, they will have to be added... 278 * available, but if new ones emerge, they will have to be added...
279 */ 279 */
280const SSL_CIPHER 280const SSL_CIPHER *
281*dtls1_get_cipher(unsigned int u) 281dtls1_get_cipher(unsigned int u)
282{ 282{
283 const SSL_CIPHER *ciph = ssl3_get_cipher(u); 283 const SSL_CIPHER *ciph = ssl3_get_cipher(u);
284 284
diff --git a/src/lib/libssl/src/ssl/d1_meth.c b/src/lib/libssl/src/ssl/d1_meth.c
index 2d3f3920ec..1140da6825 100644
--- a/src/lib/libssl/src/ssl/d1_meth.c
+++ b/src/lib/libssl/src/ssl/d1_meth.c
@@ -62,13 +62,12 @@
62#include "ssl_locl.h" 62#include "ssl_locl.h"
63 63
64static const SSL_METHOD *dtls1_get_method(int ver); 64static const SSL_METHOD *dtls1_get_method(int ver);
65static const SSL_METHOD 65static const SSL_METHOD *
66*dtls1_get_method(int ver) 66dtls1_get_method(int ver)
67{ 67{
68 if (ver == DTLS1_VERSION) 68 if (ver == DTLS1_VERSION)
69 return (DTLSv1_method()); 69 return (DTLSv1_method());
70 else 70 return (NULL);
71 return (NULL);
72} 71}
73 72
74IMPLEMENT_dtls1_meth_func(DTLSv1_method, 73IMPLEMENT_dtls1_meth_func(DTLSv1_method,
diff --git a/src/lib/libssl/src/ssl/d1_srtp.c b/src/lib/libssl/src/ssl/d1_srtp.c
index fadd9f381f..146ce321c8 100644
--- a/src/lib/libssl/src/ssl/d1_srtp.c
+++ b/src/lib/libssl/src/ssl/d1_srtp.c
@@ -109,11 +109,11 @@
109 * 109 *
110 */ 110 */
111/* 111/*
112 DTLS code by Eric Rescorla <ekr@rtfm.com> 112 * DTLS code by Eric Rescorla <ekr@rtfm.com>
113 113 *
114 Copyright (C) 2006, Network Resonance, Inc. 114 * Copyright (C) 2006, Network Resonance, Inc.
115 Copyright (C) 2011, RTFM, Inc. 115 * Copyright (C) 2011, RTFM, Inc.
116*/ 116 */
117 117
118#include <stdio.h> 118#include <stdio.h>
119#include <openssl/objects.h> 119#include <openssl/objects.h>
@@ -232,8 +232,8 @@ SSL_set_tlsext_use_srtp(SSL *s, const char *profiles)
232} 232}
233 233
234 234
235STACK_OF(SRTP_PROTECTION_PROFILE) 235STACK_OF(SRTP_PROTECTION_PROFILE) *
236*SSL_get_srtp_profiles(SSL *s) 236SSL_get_srtp_profiles(SSL *s)
237{ 237{
238 if (s != NULL) { 238 if (s != NULL) {
239 if (s->srtp_profiles != NULL) { 239 if (s->srtp_profiles != NULL) {
@@ -247,8 +247,8 @@ STACK_OF(SRTP_PROTECTION_PROFILE)
247 return NULL; 247 return NULL;
248} 248}
249 249
250SRTP_PROTECTION_PROFILE 250SRTP_PROTECTION_PROFILE *
251*SSL_get_selected_srtp_profile(SSL *s) 251SSL_get_selected_srtp_profile(SSL *s)
252{ 252{
253 return s->srtp_profile; 253 return s->srtp_profile;
254} 254}
diff --git a/src/lib/libssl/src/ssl/d1_srvr.c b/src/lib/libssl/src/ssl/d1_srvr.c
index 6a10f7a3dd..fc475485ba 100644
--- a/src/lib/libssl/src/ssl/d1_srvr.c
+++ b/src/lib/libssl/src/ssl/d1_srvr.c
@@ -129,13 +129,12 @@
129static const SSL_METHOD *dtls1_get_server_method(int ver); 129static const SSL_METHOD *dtls1_get_server_method(int ver);
130static int dtls1_send_hello_verify_request(SSL *s); 130static int dtls1_send_hello_verify_request(SSL *s);
131 131
132static const SSL_METHOD 132static const SSL_METHOD *
133*dtls1_get_server_method(int ver) 133dtls1_get_server_method(int ver)
134{ 134{
135 if (ver == DTLS1_VERSION) 135 if (ver == DTLS1_VERSION)
136 return (DTLSv1_server_method()); 136 return (DTLSv1_server_method());
137 else 137 return (NULL);
138 return (NULL);
139} 138}
140 139
141IMPLEMENT_dtls1_meth_func(DTLSv1_server_method, 140IMPLEMENT_dtls1_meth_func(DTLSv1_server_method,
diff --git a/src/lib/libssl/src/ssl/kssl.c b/src/lib/libssl/src/ssl/kssl.c
index 163079de20..a0beabe753 100644
--- a/src/lib/libssl/src/ssl/kssl.c
+++ b/src/lib/libssl/src/ssl/kssl.c
@@ -104,8 +104,8 @@ kssl_calloc(size_t nmemb, size_t size)
104#define kssl_free(ptr) free((ptr)) 104#define kssl_free(ptr) free((ptr))
105 105
106 106
107char 107char *
108*kstring(char *string) 108kstring(char *string)
109{ 109{
110 static char *null = "[NULL]"; 110 static char *null = "[NULL]";
111 111
@@ -207,8 +207,8 @@ kssl_test_confound(unsigned char *p)
207** what the highest assigned CKSUMTYPE_ constant is. As of 1.2.2 207** what the highest assigned CKSUMTYPE_ constant is. As of 1.2.2
208** it is 0x000c (CKSUMTYPE_HMAC_SHA1_DES3). So we will use 0x0010. 208** it is 0x000c (CKSUMTYPE_HMAC_SHA1_DES3). So we will use 0x0010.
209*/ 209*/
210static size_t 210static size_t *
211*populate_cksumlens(void) 211populate_cksumlens(void)
212{ 212{
213 int i, j, n; 213 int i, j, n;
214 static size_t *cklens = NULL; 214 static size_t *cklens = NULL;
@@ -250,8 +250,8 @@ static size_t
250** This hackery wouldn't be necessary if MIT KRB5 1.0.6 had the 250** This hackery wouldn't be necessary if MIT KRB5 1.0.6 had the
251** krb5_auth_con_getcksumtype() function advertised in its krb5.h. 251** krb5_auth_con_getcksumtype() function advertised in its krb5.h.
252*/ 252*/
253unsigned char 253unsigned char *
254*kssl_skip_confound(krb5_enctype etype, unsigned char *a) 254kssl_skip_confound(krb5_enctype etype, unsigned char *a)
255{ 255{
256 int i, conlen; 256 int i, conlen;
257 size_t cklen; 257 size_t cklen;
@@ -1213,8 +1213,8 @@ kssl_krb5_free_data_contents(krb5_context context, krb5_data *data)
1213** Return pointer to the (partially) filled in struct tm on success, 1213** Return pointer to the (partially) filled in struct tm on success,
1214** return NULL on failure. 1214** return NULL on failure.
1215*/ 1215*/
1216static struct tm 1216static struct tm *
1217*k_gmtime(ASN1_GENERALIZEDTIME *gtime, struct tm *k_tm) { 1217k_gmtime(ASN1_GENERALIZEDTIME *gtime, struct tm *k_tm) {
1218 char c, *p; 1218 char c, *p;
1219 1219
1220 if (!k_tm) 1220 if (!k_tm)
diff --git a/src/lib/libssl/src/ssl/s23_clnt.c b/src/lib/libssl/src/ssl/s23_clnt.c
index 196ef1dfad..65e2be0c8c 100644
--- a/src/lib/libssl/src/ssl/s23_clnt.c
+++ b/src/lib/libssl/src/ssl/s23_clnt.c
@@ -119,19 +119,18 @@
119static const SSL_METHOD *ssl23_get_client_method(int ver); 119static const SSL_METHOD *ssl23_get_client_method(int ver);
120static int ssl23_client_hello(SSL *s); 120static int ssl23_client_hello(SSL *s);
121static int ssl23_get_server_hello(SSL *s); 121static int ssl23_get_server_hello(SSL *s);
122static const SSL_METHOD 122static const SSL_METHOD *
123*ssl23_get_client_method(int ver) 123ssl23_get_client_method(int ver)
124{ 124{
125 if (ver == SSL3_VERSION) 125 if (ver == SSL3_VERSION)
126 return (SSLv3_client_method()); 126 return (SSLv3_client_method());
127 else if (ver == TLS1_VERSION) 127 if (ver == TLS1_VERSION)
128 return (TLSv1_client_method()); 128 return (TLSv1_client_method());
129 else if (ver == TLS1_1_VERSION) 129 if (ver == TLS1_1_VERSION)
130 return (TLSv1_1_client_method()); 130 return (TLSv1_1_client_method());
131 else if (ver == TLS1_2_VERSION) 131 if (ver == TLS1_2_VERSION)
132 return (TLSv1_2_client_method()); 132 return (TLSv1_2_client_method());
133 else 133 return (NULL);
134 return (NULL);
135} 134}
136 135
137IMPLEMENT_ssl23_meth_func(SSLv23_client_method, 136IMPLEMENT_ssl23_meth_func(SSLv23_client_method,
diff --git a/src/lib/libssl/src/ssl/s23_lib.c b/src/lib/libssl/src/ssl/s23_lib.c
index 74afe01d94..226af4b3cb 100644
--- a/src/lib/libssl/src/ssl/s23_lib.c
+++ b/src/lib/libssl/src/ssl/s23_lib.c
@@ -69,11 +69,11 @@ ssl23_default_timeout(void)
69int 69int
70ssl23_num_ciphers(void) 70ssl23_num_ciphers(void)
71{ 71{
72 return(ssl3_num_ciphers()); 72 return (ssl3_num_ciphers());
73} 73}
74 74
75const SSL_CIPHER 75const SSL_CIPHER *
76*ssl23_get_cipher(unsigned int u) 76ssl23_get_cipher(unsigned int u)
77{ 77{
78 unsigned int uu = ssl3_num_ciphers(); 78 unsigned int uu = ssl3_num_ciphers();
79 79
@@ -85,8 +85,8 @@ const SSL_CIPHER
85 85
86/* This function needs to check if the ciphers required are actually 86/* This function needs to check if the ciphers required are actually
87 * available */ 87 * available */
88const SSL_CIPHER 88const SSL_CIPHER *
89*ssl23_get_cipher_by_char(const unsigned char *p) 89ssl23_get_cipher_by_char(const unsigned char *p)
90{ 90{
91 const SSL_CIPHER *cp; 91 const SSL_CIPHER *cp;
92 92
diff --git a/src/lib/libssl/src/ssl/s23_meth.c b/src/lib/libssl/src/ssl/s23_meth.c
index f7d9910b8a..ad9a513fd4 100644
--- a/src/lib/libssl/src/ssl/s23_meth.c
+++ b/src/lib/libssl/src/ssl/s23_meth.c
@@ -61,19 +61,18 @@
61#include "ssl_locl.h" 61#include "ssl_locl.h"
62 62
63static const SSL_METHOD *ssl23_get_method(int ver); 63static const SSL_METHOD *ssl23_get_method(int ver);
64static const SSL_METHOD 64static const SSL_METHOD *
65*ssl23_get_method(int ver) 65ssl23_get_method(int ver)
66{ 66{
67 if (ver == SSL3_VERSION) 67 if (ver == SSL3_VERSION)
68 return (SSLv3_method()); 68 return (SSLv3_method());
69 else if (ver == TLS1_VERSION) 69 if (ver == TLS1_VERSION)
70 return (TLSv1_method()); 70 return (TLSv1_method());
71 else if (ver == TLS1_1_VERSION) 71 if (ver == TLS1_1_VERSION)
72 return (TLSv1_1_method()); 72 return (TLSv1_1_method());
73 else if (ver == TLS1_2_VERSION) 73 if (ver == TLS1_2_VERSION)
74 return (TLSv1_2_method()); 74 return (TLSv1_2_method());
75 else 75 return (NULL);
76 return (NULL);
77} 76}
78 77
79IMPLEMENT_ssl23_meth_func(SSLv23_method, 78IMPLEMENT_ssl23_meth_func(SSLv23_method,
diff --git a/src/lib/libssl/src/ssl/s23_srvr.c b/src/lib/libssl/src/ssl/s23_srvr.c
index c63ede8680..665907ee12 100644
--- a/src/lib/libssl/src/ssl/s23_srvr.c
+++ b/src/lib/libssl/src/ssl/s23_srvr.c
@@ -123,14 +123,13 @@ ssl23_get_server_method(int ver)
123{ 123{
124 if (ver == SSL3_VERSION) 124 if (ver == SSL3_VERSION)
125 return (SSLv3_server_method()); 125 return (SSLv3_server_method());
126 else if (ver == TLS1_VERSION) 126 if (ver == TLS1_VERSION)
127 return (TLSv1_server_method()); 127 return (TLSv1_server_method());
128 else if (ver == TLS1_1_VERSION) 128 if (ver == TLS1_1_VERSION)
129 return (TLSv1_1_server_method()); 129 return (TLSv1_1_server_method());
130 else if (ver == TLS1_2_VERSION) 130 if (ver == TLS1_2_VERSION)
131 return (TLSv1_2_server_method()); 131 return (TLSv1_2_server_method());
132 else 132 return (NULL);
133 return (NULL);
134} 133}
135 134
136IMPLEMENT_ssl23_meth_func(SSLv23_server_method, 135IMPLEMENT_ssl23_meth_func(SSLv23_server_method,
diff --git a/src/lib/libssl/src/ssl/s3_clnt.c b/src/lib/libssl/src/ssl/s3_clnt.c
index 8aef4b4f3d..10546ee848 100644
--- a/src/lib/libssl/src/ssl/s3_clnt.c
+++ b/src/lib/libssl/src/ssl/s3_clnt.c
@@ -167,13 +167,12 @@
167static const SSL_METHOD *ssl3_get_client_method(int ver); 167static const SSL_METHOD *ssl3_get_client_method(int ver);
168static int ca_dn_cmp(const X509_NAME * const *a, const X509_NAME * const *b); 168static int ca_dn_cmp(const X509_NAME * const *a, const X509_NAME * const *b);
169 169
170static const SSL_METHOD 170static const SSL_METHOD *
171*ssl3_get_client_method(int ver) 171ssl3_get_client_method(int ver)
172{ 172{
173 if (ver == SSL3_VERSION) 173 if (ver == SSL3_VERSION)
174 return (SSLv3_client_method()); 174 return (SSLv3_client_method());
175 else 175 return (NULL);
176 return (NULL);
177} 176}
178 177
179IMPLEMENT_ssl3_meth_func(SSLv3_client_method, 178IMPLEMENT_ssl3_meth_func(SSLv3_client_method,
diff --git a/src/lib/libssl/src/ssl/s3_lib.c b/src/lib/libssl/src/ssl/s3_lib.c
index fe638e84a9..95e5c903ec 100644
--- a/src/lib/libssl/src/ssl/s3_lib.c
+++ b/src/lib/libssl/src/ssl/s3_lib.c
@@ -2754,8 +2754,8 @@ ssl3_num_ciphers(void)
2754 return (SSL3_NUM_CIPHERS); 2754 return (SSL3_NUM_CIPHERS);
2755} 2755}
2756 2756
2757const SSL_CIPHER 2757const SSL_CIPHER *
2758*ssl3_get_cipher(unsigned int u) 2758ssl3_get_cipher(unsigned int u)
2759{ 2759{
2760 if (u < SSL3_NUM_CIPHERS) 2760 if (u < SSL3_NUM_CIPHERS)
2761 return (&(ssl3_ciphers[SSL3_NUM_CIPHERS - 1 - u])); 2761 return (&(ssl3_ciphers[SSL3_NUM_CIPHERS - 1 - u]));
@@ -3470,8 +3470,8 @@ ssl3_ctx_callback_ctrl(SSL_CTX *ctx, int cmd, void (*fp)(void))
3470 3470
3471/* This function needs to check if the ciphers required are actually 3471/* This function needs to check if the ciphers required are actually
3472 * available */ 3472 * available */
3473const SSL_CIPHER 3473const SSL_CIPHER *
3474*ssl3_get_cipher_by_char(const unsigned char *p) 3474ssl3_get_cipher_by_char(const unsigned char *p)
3475{ 3475{
3476 SSL_CIPHER c; 3476 SSL_CIPHER c;
3477 const SSL_CIPHER *cp; 3477 const SSL_CIPHER *cp;
@@ -3954,10 +3954,11 @@ ssl3_renegotiate_check(SSL *s)
3954 if (s->s3->renegotiate) { 3954 if (s->s3->renegotiate) {
3955 if ((s->s3->rbuf.left == 0) && (s->s3->wbuf.left == 0) && 3955 if ((s->s3->rbuf.left == 0) && (s->s3->wbuf.left == 0) &&
3956 !SSL_in_init(s)) { 3956 !SSL_in_init(s)) {
3957/* 3957 /*
3958if we are the server, and we have sent a 'RENEGOTIATE' message, we 3958 * If we are the server, and we have sent
3959need to go to SSL_ST_ACCEPT. 3959 * a 'RENEGOTIATE' message, we need to go
3960*/ 3960 * to SSL_ST_ACCEPT.
3961 */
3961 /* SSL_ST_ACCEPT */ 3962 /* SSL_ST_ACCEPT */
3962 s->state = SSL_ST_RENEGOTIATE; 3963 s->state = SSL_ST_RENEGOTIATE;
3963 s->s3->renegotiate = 0; 3964 s->s3->renegotiate = 0;
diff --git a/src/lib/libssl/src/ssl/s3_meth.c b/src/lib/libssl/src/ssl/s3_meth.c
index ff3b0d3303..b6d6771a21 100644
--- a/src/lib/libssl/src/ssl/s3_meth.c
+++ b/src/lib/libssl/src/ssl/s3_meth.c
@@ -61,13 +61,12 @@
61#include "ssl_locl.h" 61#include "ssl_locl.h"
62 62
63static const SSL_METHOD *ssl3_get_method(int ver); 63static const SSL_METHOD *ssl3_get_method(int ver);
64static const SSL_METHOD 64static const SSL_METHOD *
65*ssl3_get_method(int ver) 65ssl3_get_method(int ver)
66{ 66{
67 if (ver == SSL3_VERSION) 67 if (ver == SSL3_VERSION)
68 return (SSLv3_method()); 68 return (SSLv3_method());
69 else 69 return (NULL);
70 return (NULL);
71} 70}
72 71
73IMPLEMENT_ssl3_meth_func(SSLv3_method, 72IMPLEMENT_ssl3_meth_func(SSLv3_method,
diff --git a/src/lib/libssl/src/ssl/s3_pkt.c b/src/lib/libssl/src/ssl/s3_pkt.c
index ec73ef50bd..52c48e945e 100644
--- a/src/lib/libssl/src/ssl/s3_pkt.c
+++ b/src/lib/libssl/src/ssl/s3_pkt.c
@@ -756,9 +756,9 @@ do_ssl3_write(SSL *s, int type, const unsigned char *buf,
756 wr->data = p; 756 wr->data = p;
757 757
758 if (eivlen) { 758 if (eivlen) {
759 /* if (RAND_pseudo_bytes(p, eivlen) <= 0) 759 /* if (RAND_pseudo_bytes(p, eivlen) <= 0)
760 goto err; 760 goto err;
761*/ 761 */
762 wr->length += eivlen; 762 wr->length += eivlen;
763 } 763 }
764 764
diff --git a/src/lib/libssl/src/ssl/s3_srvr.c b/src/lib/libssl/src/ssl/s3_srvr.c
index 79b89d7e95..8416eb7042 100644
--- a/src/lib/libssl/src/ssl/s3_srvr.c
+++ b/src/lib/libssl/src/ssl/s3_srvr.c
@@ -171,13 +171,12 @@
171 171
172static const SSL_METHOD *ssl3_get_server_method(int ver); 172static const SSL_METHOD *ssl3_get_server_method(int ver);
173 173
174static const SSL_METHOD 174static const SSL_METHOD *
175*ssl3_get_server_method(int ver) 175ssl3_get_server_method(int ver)
176{ 176{
177 if (ver == SSL3_VERSION) 177 if (ver == SSL3_VERSION)
178 return (SSLv3_server_method()); 178 return (SSLv3_server_method());
179 else 179 return (NULL);
180 return (NULL);
181} 180}
182 181
183#ifndef OPENSSL_NO_SRP 182#ifndef OPENSSL_NO_SRP
diff --git a/src/lib/libssl/src/ssl/srtp.h b/src/lib/libssl/src/ssl/srtp.h
index 06075f2c86..e2dfee5426 100644
--- a/src/lib/libssl/src/ssl/srtp.h
+++ b/src/lib/libssl/src/ssl/srtp.h
@@ -109,11 +109,11 @@
109 * 109 *
110 */ 110 */
111/* 111/*
112 DTLS code by Eric Rescorla <ekr@rtfm.com> 112 * DTLS code by Eric Rescorla <ekr@rtfm.com>
113 113 *
114 Copyright (C) 2006, Network Resonance, Inc. 114 * Copyright (C) 2006, Network Resonance, Inc.
115 Copyright (C) 2011, RTFM, Inc. 115 * Copyright (C) 2011, RTFM, Inc.
116*/ 116 */
117 117
118#ifndef HEADER_D1_SRTP_H 118#ifndef HEADER_D1_SRTP_H
119#define HEADER_D1_SRTP_H 119#define HEADER_D1_SRTP_H
diff --git a/src/lib/libssl/src/ssl/ssl.h b/src/lib/libssl/src/ssl/ssl.h
index ef829797b7..f3ca8c5c4e 100644
--- a/src/lib/libssl/src/ssl/ssl.h
+++ b/src/lib/libssl/src/ssl/ssl.h
@@ -1728,9 +1728,8 @@ SSL_SESSION_set1_id_context(SSL_SESSION *s, const unsigned char *sid_ctx,
1728unsigned int sid_ctx_len); 1728unsigned int sid_ctx_len);
1729 1729
1730SSL_SESSION *SSL_SESSION_new(void); 1730SSL_SESSION *SSL_SESSION_new(void);
1731const unsigned char 1731const unsigned char *SSL_SESSION_get_id(const SSL_SESSION *s,
1732*SSL_SESSION_get_id(const SSL_SESSION *s, 1732 unsigned int *len);
1733unsigned int *len);
1734unsigned int SSL_SESSION_get_compress_id(const SSL_SESSION *s); 1733unsigned int SSL_SESSION_get_compress_id(const SSL_SESSION *s);
1735#ifndef OPENSSL_NO_FP_API 1734#ifndef OPENSSL_NO_FP_API
1736int SSL_SESSION_print_fp(FILE *fp, const SSL_SESSION *ses); 1735int SSL_SESSION_print_fp(FILE *fp, const SSL_SESSION *ses);
diff --git a/src/lib/libssl/src/ssl/ssl_asn1.c b/src/lib/libssl/src/ssl/ssl_asn1.c
index 60ee189f29..c551ec4877 100644
--- a/src/lib/libssl/src/ssl/ssl_asn1.c
+++ b/src/lib/libssl/src/ssl/ssl_asn1.c
@@ -355,9 +355,8 @@ i2d_SSL_SESSION(SSL_SESSION *in, unsigned char **pp)
355 M_ASN1_I2D_finish(); 355 M_ASN1_I2D_finish();
356} 356}
357 357
358SSL_SESSION 358SSL_SESSION *
359*d2i_SSL_SESSION(SSL_SESSION **a, const unsigned char **pp, 359d2i_SSL_SESSION(SSL_SESSION **a, const unsigned char **pp, long length)
360long length)
361{ 360{
362 int ssl_version = 0, i; 361 int ssl_version = 0, i;
363 long id; 362 long id;
diff --git a/src/lib/libssl/src/ssl/ssl_cert.c b/src/lib/libssl/src/ssl/ssl_cert.c
index a823c16edf..389d47408c 100644
--- a/src/lib/libssl/src/ssl/ssl_cert.c
+++ b/src/lib/libssl/src/ssl/ssl_cert.c
@@ -171,8 +171,8 @@ ssl_cert_set_default_md(CERT *cert)
171#endif 171#endif
172} 172}
173 173
174CERT 174CERT *
175*ssl_cert_new(void) 175ssl_cert_new(void)
176{ 176{
177 CERT *ret; 177 CERT *ret;
178 178
@@ -189,8 +189,8 @@ CERT
189 return (ret); 189 return (ret);
190} 190}
191 191
192CERT 192CERT *
193*ssl_cert_dup(CERT *cert) 193ssl_cert_dup(CERT *cert)
194{ 194{
195 CERT *ret; 195 CERT *ret;
196 int i; 196 int i;
@@ -398,8 +398,8 @@ ssl_cert_inst(CERT **o)
398} 398}
399 399
400 400
401SESS_CERT 401SESS_CERT *
402*ssl_sess_cert_new(void) 402ssl_sess_cert_new(void)
403{ 403{
404 SESS_CERT *ret; 404 SESS_CERT *ret;
405 405
@@ -531,8 +531,8 @@ set_client_CA_list(STACK_OF(X509_NAME) **ca_list, STACK_OF(X509_NAME) *name_list
531 *ca_list = name_list; 531 *ca_list = name_list;
532} 532}
533 533
534STACK_OF(X509_NAME) 534STACK_OF(X509_NAME) *
535*SSL_dup_CA_list(STACK_OF(X509_NAME) *sk) 535SSL_dup_CA_list(STACK_OF(X509_NAME) *sk)
536{ 536{
537 int i; 537 int i;
538 STACK_OF(X509_NAME) *ret; 538 STACK_OF(X509_NAME) *ret;
@@ -561,14 +561,14 @@ SSL_CTX_set_client_CA_list(SSL_CTX *ctx, STACK_OF(X509_NAME) *name_list)
561 set_client_CA_list(&(ctx->client_CA), name_list); 561 set_client_CA_list(&(ctx->client_CA), name_list);
562} 562}
563 563
564STACK_OF(X509_NAME) 564STACK_OF(X509_NAME) *
565*SSL_CTX_get_client_CA_list(const SSL_CTX *ctx) 565SSL_CTX_get_client_CA_list(const SSL_CTX *ctx)
566{ 566{
567 return (ctx->client_CA); 567 return (ctx->client_CA);
568} 568}
569 569
570STACK_OF(X509_NAME) 570STACK_OF(X509_NAME) *
571*SSL_get_client_CA_list(const SSL *s) 571SSL_get_client_CA_list(const SSL *s)
572{ 572{
573 if (s->type == SSL_ST_CONNECT) 573 if (s->type == SSL_ST_CONNECT)
574 { /* we are in the client */ 574 { /* we are in the client */
@@ -632,8 +632,8 @@ xname_cmp(const X509_NAME * const *a, const X509_NAME * const *b)
632 * \param file the file containing one or more certs. 632 * \param file the file containing one or more certs.
633 * \return a ::STACK containing the certs. 633 * \return a ::STACK containing the certs.
634 */ 634 */
635STACK_OF(X509_NAME) 635STACK_OF(X509_NAME) *
636*SSL_load_client_CA_file(const char *file) 636SSL_load_client_CA_file(const char *file)
637{ 637{
638 BIO *in; 638 BIO *in;
639 X509 *x = NULL; 639 X509 *x = NULL;
diff --git a/src/lib/libssl/src/ssl/ssl_ciph.c b/src/lib/libssl/src/ssl/ssl_ciph.c
index 140a00ceca..7d2ea6c481 100644
--- a/src/lib/libssl/src/ssl/ssl_ciph.c
+++ b/src/lib/libssl/src/ssl/ssl_ciph.c
@@ -1295,8 +1295,8 @@ const SSL_CIPHER **ca_list)
1295 return (retval); 1295 return (retval);
1296} 1296}
1297 1297
1298STACK_OF(SSL_CIPHER) 1298STACK_OF(SSL_CIPHER) *
1299*ssl_create_cipher_list(const SSL_METHOD *ssl_method, 1299ssl_create_cipher_list(const SSL_METHOD *ssl_method,
1300 STACK_OF(SSL_CIPHER) **cipher_list, 1300 STACK_OF(SSL_CIPHER) **cipher_list,
1301 STACK_OF(SSL_CIPHER) **cipher_list_by_id, 1301 STACK_OF(SSL_CIPHER) **cipher_list_by_id,
1302 const char *rule_str) 1302 const char *rule_str)
@@ -1466,8 +1466,8 @@ STACK_OF(SSL_CIPHER)
1466 return (cipherstack); 1466 return (cipherstack);
1467} 1467}
1468 1468
1469char 1469char *
1470*SSL_CIPHER_description(const SSL_CIPHER *cipher, char *buf, int len) 1470SSL_CIPHER_description(const SSL_CIPHER *cipher, char *buf, int len)
1471{ 1471{
1472 int is_export, pkl, kl, l; 1472 int is_export, pkl, kl, l;
1473 const char *ver, *exp_str; 1473 const char *ver, *exp_str;
@@ -1652,8 +1652,8 @@ char
1652 return (buf); 1652 return (buf);
1653} 1653}
1654 1654
1655char 1655char *
1656*SSL_CIPHER_get_version(const SSL_CIPHER *c) 1656SSL_CIPHER_get_version(const SSL_CIPHER *c)
1657{ 1657{
1658 int i; 1658 int i;
1659 1659
@@ -1669,8 +1669,8 @@ char
1669} 1669}
1670 1670
1671/* return the actual cipher being used */ 1671/* return the actual cipher being used */
1672const char 1672const char *
1673*SSL_CIPHER_get_name(const SSL_CIPHER *c) 1673SSL_CIPHER_get_name(const SSL_CIPHER *c)
1674{ 1674{
1675 if (c != NULL) 1675 if (c != NULL)
1676 return (c->name); 1676 return (c->name);
@@ -1697,8 +1697,8 @@ SSL_CIPHER_get_id(const SSL_CIPHER *c)
1697 return c->id; 1697 return c->id;
1698} 1698}
1699 1699
1700SSL_COMP 1700SSL_COMP *
1701*ssl3_comp_find(STACK_OF(SSL_COMP) *sk, int n) 1701ssl3_comp_find(STACK_OF(SSL_COMP) *sk, int n)
1702{ 1702{
1703 SSL_COMP *ctmp; 1703 SSL_COMP *ctmp;
1704 int i, nn; 1704 int i, nn;
@@ -1715,8 +1715,8 @@ SSL_COMP
1715} 1715}
1716 1716
1717#ifdef OPENSSL_NO_COMP 1717#ifdef OPENSSL_NO_COMP
1718void 1718void *
1719*SSL_COMP_get_compression_methods(void) 1719SSL_COMP_get_compression_methods(void)
1720{ 1720{
1721 return NULL; 1721 return NULL;
1722} 1722}
@@ -1727,14 +1727,14 @@ SSL_COMP_add_compression_method(int id, void *cm)
1727 return 1; 1727 return 1;
1728} 1728}
1729 1729
1730const char 1730const char *
1731*SSL_COMP_get_name(const void *comp) 1731SSL_COMP_get_name(const void *comp)
1732{ 1732{
1733 return NULL; 1733 return NULL;
1734} 1734}
1735#else 1735#else
1736STACK_OF(SSL_COMP) 1736STACK_OF(SSL_COMP) *
1737*SSL_COMP_get_compression_methods(void) 1737SSL_COMP_get_compression_methods(void)
1738{ 1738{
1739 load_builtin_compressions(); 1739 load_builtin_compressions();
1740 return (ssl_comp_methods); 1740 return (ssl_comp_methods);
@@ -1782,8 +1782,8 @@ SSL_COMP_add_compression_method(int id, COMP_METHOD *cm)
1782 } 1782 }
1783} 1783}
1784 1784
1785const char 1785const char *
1786*SSL_COMP_get_name(const COMP_METHOD *comp) 1786SSL_COMP_get_name(const COMP_METHOD *comp)
1787{ 1787{
1788 if (comp) 1788 if (comp)
1789 return comp->name; 1789 return comp->name;
diff --git a/src/lib/libssl/src/ssl/ssl_lib.c b/src/lib/libssl/src/ssl/ssl_lib.c
index dc36747833..3ab353b8eb 100644
--- a/src/lib/libssl/src/ssl/ssl_lib.c
+++ b/src/lib/libssl/src/ssl/ssl_lib.c
@@ -256,8 +256,8 @@ SSL_CTX_set_ssl_version(SSL_CTX *ctx, const SSL_METHOD *meth)
256 return (1); 256 return (1);
257} 257}
258 258
259SSL 259SSL *
260*SSL_new(SSL_CTX *ctx) 260SSL_new(SSL_CTX *ctx)
261{ 261{
262 SSL *s; 262 SSL *s;
263 263
@@ -604,14 +604,16 @@ SSL_set_bio(SSL *s, BIO *rbio, BIO *wbio)
604 s->wbio = wbio; 604 s->wbio = wbio;
605} 605}
606 606
607BIO 607BIO *
608*SSL_get_rbio(const SSL *s) 608SSL_get_rbio(const SSL *s)
609 { return (s->rbio); 609{
610 return (s->rbio);
610} 611}
611 612
612BIO 613BIO *
613*SSL_get_wbio(const SSL *s) 614SSL_get_wbio(const SSL *s)
614 { return (s->wbio); 615{
616 return (s->wbio);
615} 617}
616 618
617int 619int
@@ -819,8 +821,8 @@ SSL_pending(const SSL *s)
819 return (s->method->ssl_pending(s)); 821 return (s->method->ssl_pending(s));
820} 822}
821 823
822X509 824X509 *
823*SSL_get_peer_certificate(const SSL *s) 825SSL_get_peer_certificate(const SSL *s)
824{ 826{
825 X509 *r; 827 X509 *r;
826 828
@@ -837,8 +839,8 @@ X509
837 return (r); 839 return (r);
838} 840}
839 841
840STACK_OF(X509) 842STACK_OF(X509) *
841*SSL_get_peer_cert_chain(const SSL *s) 843SSL_get_peer_cert_chain(const SSL *s)
842{ 844{
843 STACK_OF(X509) *r; 845 STACK_OF(X509) *r;
844 846
@@ -1115,8 +1117,8 @@ SSL_callback_ctrl(SSL *s, int cmd, void (*fp)(void))
1115 } 1117 }
1116} 1118}
1117 1119
1118LHASH_OF(SSL_SESSION) 1120LHASH_OF(SSL_SESSION) *
1119*SSL_CTX_sessions(SSL_CTX *ctx) 1121SSL_CTX_sessions(SSL_CTX *ctx)
1120{ 1122{
1121 return ctx->sessions; 1123 return ctx->sessions;
1122} 1124}
@@ -1240,8 +1242,8 @@ ssl_cipher_ptr_id_cmp(const SSL_CIPHER * const *ap,
1240 1242
1241/** return a STACK of the ciphers available for the SSL and in order of 1243/** return a STACK of the ciphers available for the SSL and in order of
1242 * preference */ 1244 * preference */
1243STACK_OF(SSL_CIPHER) 1245STACK_OF(SSL_CIPHER) *
1244*SSL_get_ciphers(const SSL *s) 1246SSL_get_ciphers(const SSL *s)
1245{ 1247{
1246 if (s != NULL) { 1248 if (s != NULL) {
1247 if (s->cipher_list != NULL) { 1249 if (s->cipher_list != NULL) {
@@ -1256,8 +1258,8 @@ STACK_OF(SSL_CIPHER)
1256 1258
1257/** return a STACK of the ciphers available for the SSL and in order of 1259/** return a STACK of the ciphers available for the SSL and in order of
1258 * algorithm id */ 1260 * algorithm id */
1259STACK_OF(SSL_CIPHER) 1261STACK_OF(SSL_CIPHER) *
1260*ssl_get_ciphers_by_id(SSL *s) 1262ssl_get_ciphers_by_id(SSL *s)
1261{ 1263{
1262 if (s != NULL) { 1264 if (s != NULL) {
1263 if (s->cipher_list_by_id != NULL) { 1265 if (s->cipher_list_by_id != NULL) {
@@ -1271,8 +1273,8 @@ STACK_OF(SSL_CIPHER)
1271} 1273}
1272 1274
1273/** The old interface to get the same thing as SSL_get_ciphers() */ 1275/** The old interface to get the same thing as SSL_get_ciphers() */
1274const char 1276const char *
1275*SSL_get_cipher_list(const SSL *s, int n) 1277SSL_get_cipher_list(const SSL *s, int n)
1276{ 1278{
1277 SSL_CIPHER *c; 1279 SSL_CIPHER *c;
1278 STACK_OF(SSL_CIPHER) *sk; 1280 STACK_OF(SSL_CIPHER) *sk;
@@ -1331,8 +1333,8 @@ SSL_set_cipher_list(SSL *s, const char *str)
1331} 1333}
1332 1334
1333/* works well for SSLv2, not so good for SSLv3 */ 1335/* works well for SSLv2, not so good for SSLv3 */
1334char 1336char *
1335*SSL_get_shared_ciphers(const SSL *s, char *buf, int len) 1337SSL_get_shared_ciphers(const SSL *s, char *buf, int len)
1336{ 1338{
1337 char *end; 1339 char *end;
1338 STACK_OF(SSL_CIPHER) *sk; 1340 STACK_OF(SSL_CIPHER) *sk;
@@ -1414,9 +1416,9 @@ ssl_cipher_list_to_bytes(SSL *s, STACK_OF(SSL_CIPHER) *sk, unsigned char *p,
1414 return (p - q); 1416 return (p - q);
1415} 1417}
1416 1418
1417STACK_OF(SSL_CIPHER) 1419STACK_OF(SSL_CIPHER) *
1418*ssl_bytes_to_cipher_list(SSL *s, unsigned char *p, int num, 1420ssl_bytes_to_cipher_list(SSL *s, unsigned char *p, int num,
1419STACK_OF(SSL_CIPHER) **skp) 1421 STACK_OF(SSL_CIPHER) **skp)
1420{ 1422{
1421 const SSL_CIPHER *c; 1423 const SSL_CIPHER *c;
1422 STACK_OF(SSL_CIPHER) *sk; 1424 STACK_OF(SSL_CIPHER) *sk;
@@ -1481,8 +1483,8 @@ err:
1481 * So far, only host_name types are defined (RFC 3546). 1483 * So far, only host_name types are defined (RFC 3546).
1482 */ 1484 */
1483 1485
1484const char 1486const char *
1485*SSL_get_servername(const SSL *s, const int type) 1487SSL_get_servername(const SSL *s, const int type)
1486{ 1488{
1487 if (type != TLSEXT_NAMETYPE_host_name) 1489 if (type != TLSEXT_NAMETYPE_host_name)
1488 return NULL; 1490 return NULL;
@@ -1669,8 +1671,8 @@ IMPLEMENT_LHASH_HASH_FN(ssl_session, SSL_SESSION)
1669static 1671static
1670IMPLEMENT_LHASH_COMP_FN(ssl_session, SSL_SESSION) 1672IMPLEMENT_LHASH_COMP_FN(ssl_session, SSL_SESSION)
1671 1673
1672SSL_CTX 1674SSL_CTX *
1673*SSL_CTX_new(const SSL_METHOD *meth) 1675SSL_CTX_new(const SSL_METHOD *meth)
1674{ 1676{
1675 SSL_CTX *ret = NULL; 1677 SSL_CTX *ret = NULL;
1676 1678
@@ -2217,8 +2219,8 @@ ssl_check_srvr_ecc_cert_and_alg(X509 *x, SSL *s)
2217#endif 2219#endif
2218 2220
2219/* THIS NEEDS CLEANING UP */ 2221/* THIS NEEDS CLEANING UP */
2220CERT_PKEY 2222CERT_PKEY *
2221*ssl_get_server_send_pkey(const SSL *s) 2223ssl_get_server_send_pkey(const SSL *s)
2222{ 2224{
2223 unsigned long alg_k, alg_a; 2225 unsigned long alg_k, alg_a;
2224 CERT *c; 2226 CERT *c;
@@ -2272,8 +2274,8 @@ CERT_PKEY
2272 return c->pkeys + i; 2274 return c->pkeys + i;
2273} 2275}
2274 2276
2275X509 2277X509 *
2276*ssl_get_server_send_cert(const SSL *s) 2278ssl_get_server_send_cert(const SSL *s)
2277{ 2279{
2278 CERT_PKEY *cpk; 2280 CERT_PKEY *cpk;
2279 cpk = ssl_get_server_send_pkey(s); 2281 cpk = ssl_get_server_send_pkey(s);
@@ -2282,8 +2284,8 @@ X509
2282 return cpk->x509; 2284 return cpk->x509;
2283} 2285}
2284 2286
2285EVP_PKEY 2287EVP_PKEY *
2286*ssl_get_sign_pkey(SSL *s, const SSL_CIPHER *cipher, const EVP_MD **pmd) 2288ssl_get_sign_pkey(SSL *s, const SSL_CIPHER *cipher, const EVP_MD **pmd)
2287{ 2289{
2288 unsigned long alg_a; 2290 unsigned long alg_a;
2289 CERT *c; 2291 CERT *c;
@@ -2343,8 +2345,8 @@ ssl_update_cache(SSL *s, int mode)
2343 } 2345 }
2344} 2346}
2345 2347
2346const SSL_METHOD 2348const SSL_METHOD *
2347*SSL_get_ssl_method(SSL *s) 2349SSL_get_ssl_method(SSL *s)
2348{ 2350{
2349 return (s->method); 2351 return (s->method);
2350} 2352}
@@ -2684,8 +2686,8 @@ ssl_clear_cipher_ctx(SSL *s)
2684} 2686}
2685 2687
2686/* Fix this function so that it takes an optional type parameter */ 2688/* Fix this function so that it takes an optional type parameter */
2687X509 2689X509 *
2688*SSL_get_certificate(const SSL *s) 2690SSL_get_certificate(const SSL *s)
2689{ 2691{
2690 if (s->cert != NULL) 2692 if (s->cert != NULL)
2691 return (s->cert->key->x509); 2693 return (s->cert->key->x509);
@@ -2694,8 +2696,8 @@ X509
2694} 2696}
2695 2697
2696/* Fix this function so that it takes an optional type parameter */ 2698/* Fix this function so that it takes an optional type parameter */
2697EVP_PKEY 2699EVP_PKEY *
2698*SSL_get_privatekey(SSL *s) 2700SSL_get_privatekey(SSL *s)
2699{ 2701{
2700 if (s->cert != NULL) 2702 if (s->cert != NULL)
2701 return (s->cert->key->privatekey); 2703 return (s->cert->key->privatekey);
@@ -2703,37 +2705,37 @@ EVP_PKEY
2703 return (NULL); 2705 return (NULL);
2704} 2706}
2705 2707
2706const SSL_CIPHER 2708const SSL_CIPHER *
2707*SSL_get_current_cipher(const SSL *s) 2709SSL_get_current_cipher(const SSL *s)
2708{ 2710{
2709 if ((s->session != NULL) && (s->session->cipher != NULL)) 2711 if ((s->session != NULL) && (s->session->cipher != NULL))
2710 return (s->session->cipher); 2712 return (s->session->cipher);
2711 return (NULL); 2713 return (NULL);
2712} 2714}
2713#ifdef OPENSSL_NO_COMP 2715#ifdef OPENSSL_NO_COMP
2714const void 2716const void *
2715*SSL_get_current_compression(SSL *s) 2717SSL_get_current_compression(SSL *s)
2716{ 2718{
2717 return NULL; 2719 return NULL;
2718} 2720}
2719 2721
2720const void 2722const void *
2721*SSL_get_current_expansion(SSL *s) 2723SSL_get_current_expansion(SSL *s)
2722{ 2724{
2723 return NULL; 2725 return NULL;
2724} 2726}
2725#else 2727#else
2726 2728
2727const COMP_METHOD 2729const COMP_METHOD *
2728*SSL_get_current_compression(SSL *s) 2730SSL_get_current_compression(SSL *s)
2729{ 2731{
2730 if (s->compress != NULL) 2732 if (s->compress != NULL)
2731 return (s->compress->meth); 2733 return (s->compress->meth);
2732 return (NULL); 2734 return (NULL);
2733} 2735}
2734 2736
2735const COMP_METHOD 2737const COMP_METHOD *
2736*SSL_get_current_expansion(SSL *s) 2738SSL_get_current_expansion(SSL *s)
2737{ 2739{
2738 if (s->expand != NULL) 2740 if (s->expand != NULL)
2739 return (s->expand->meth); 2741 return (s->expand->meth);
@@ -2828,14 +2830,14 @@ SSL_version(const SSL *s)
2828 return (s->version); 2830 return (s->version);
2829} 2831}
2830 2832
2831SSL_CTX 2833SSL_CTX *
2832*SSL_get_SSL_CTX(const SSL *ssl) 2834SSL_get_SSL_CTX(const SSL *ssl)
2833{ 2835{
2834 return (ssl->ctx); 2836 return (ssl->ctx);
2835} 2837}
2836 2838
2837SSL_CTX 2839SSL_CTX *
2838*SSL_set_SSL_CTX(SSL *ssl, SSL_CTX* ctx) 2840SSL_set_SSL_CTX(SSL *ssl, SSL_CTX* ctx)
2839{ 2841{
2840 if (ssl->ctx == ctx) 2842 if (ssl->ctx == ctx)
2841 return ssl->ctx; 2843 return ssl->ctx;
@@ -2920,8 +2922,8 @@ SSL_set_ex_data(SSL *s, int idx, void *arg)
2920 return (CRYPTO_set_ex_data(&s->ex_data, idx, arg)); 2922 return (CRYPTO_set_ex_data(&s->ex_data, idx, arg));
2921} 2923}
2922 2924
2923void 2925void *
2924*SSL_get_ex_data(const SSL *s, int idx) 2926SSL_get_ex_data(const SSL *s, int idx)
2925{ 2927{
2926 return (CRYPTO_get_ex_data(&s->ex_data, idx)); 2928 return (CRYPTO_get_ex_data(&s->ex_data, idx));
2927} 2929}
@@ -2940,8 +2942,8 @@ SSL_CTX_set_ex_data(SSL_CTX *s, int idx, void *arg)
2940 return (CRYPTO_set_ex_data(&s->ex_data, idx, arg)); 2942 return (CRYPTO_set_ex_data(&s->ex_data, idx, arg));
2941} 2943}
2942 2944
2943void 2945void *
2944*SSL_CTX_get_ex_data(const SSL_CTX *s, int idx) 2946SSL_CTX_get_ex_data(const SSL_CTX *s, int idx)
2945{ 2947{
2946 return (CRYPTO_get_ex_data(&s->ex_data, idx)); 2948 return (CRYPTO_get_ex_data(&s->ex_data, idx));
2947} 2949}
@@ -2952,8 +2954,8 @@ ssl_ok(SSL *s)
2952 return (1); 2954 return (1);
2953} 2955}
2954 2956
2955X509_STORE 2957X509_STORE *
2956*SSL_CTX_get_cert_store(const SSL_CTX *ctx) 2958SSL_CTX_get_cert_store(const SSL_CTX *ctx)
2957{ 2959{
2958 return (ctx->cert_store); 2960 return (ctx->cert_store);
2959} 2961}
@@ -3005,8 +3007,8 @@ int keylength))
3005 * \sa SSL_CTX_set_tmp_rsa_callback, SSL_set_tmp_rsa_callback 3007 * \sa SSL_CTX_set_tmp_rsa_callback, SSL_set_tmp_rsa_callback
3006 */ 3008 */
3007 3009
3008RSA 3010RSA *
3009*cb(SSL *ssl, int is_export, int keylength) 3011cb(SSL *ssl, int is_export, int keylength)
3010{} 3012{}
3011#endif 3013#endif
3012 3014
@@ -3091,16 +3093,16 @@ SSL_use_psk_identity_hint(SSL *s, const char *identity_hint)
3091 return 1; 3093 return 1;
3092} 3094}
3093 3095
3094const char 3096const char *
3095*SSL_get_psk_identity_hint(const SSL *s) 3097SSL_get_psk_identity_hint(const SSL *s)
3096{ 3098{
3097 if (s == NULL || s->session == NULL) 3099 if (s == NULL || s->session == NULL)
3098 return NULL; 3100 return NULL;
3099 return (s->session->psk_identity_hint); 3101 return (s->session->psk_identity_hint);
3100} 3102}
3101 3103
3102const char 3104const char *
3103*SSL_get_psk_identity(const SSL *s) 3105SSL_get_psk_identity(const SSL *s)
3104{ 3106{
3105 if (s == NULL || s->session == NULL) 3107 if (s == NULL || s->session == NULL)
3106 return NULL; 3108 return NULL;
@@ -3160,8 +3162,8 @@ SSL_set_msg_callback(SSL *ssl, void (*cb)(int write_p, int version, int content_
3160 * Returns newly allocated ctx; 3162 * Returns newly allocated ctx;
3161 */ 3163 */
3162 3164
3163EVP_MD_CTX 3165EVP_MD_CTX *
3164*ssl_replace_hash(EVP_MD_CTX **hash, const EVP_MD *md) 3166ssl_replace_hash(EVP_MD_CTX **hash, const EVP_MD *md)
3165{ 3167{
3166 ssl_clear_hash_ctx(hash); 3168 ssl_clear_hash_ctx(hash);
3167 *hash = EVP_MD_CTX_create(); 3169 *hash = EVP_MD_CTX_create();
diff --git a/src/lib/libssl/src/ssl/ssl_sess.c b/src/lib/libssl/src/ssl/ssl_sess.c
index cbfff0b398..c67ae1c22f 100644
--- a/src/lib/libssl/src/ssl/ssl_sess.c
+++ b/src/lib/libssl/src/ssl/ssl_sess.c
@@ -147,16 +147,16 @@ static void SSL_SESSION_list_remove(SSL_CTX *ctx, SSL_SESSION *s);
147static void SSL_SESSION_list_add(SSL_CTX *ctx, SSL_SESSION *s); 147static void SSL_SESSION_list_add(SSL_CTX *ctx, SSL_SESSION *s);
148static int remove_session_lock(SSL_CTX *ctx, SSL_SESSION *c, int lck); 148static int remove_session_lock(SSL_CTX *ctx, SSL_SESSION *c, int lck);
149 149
150SSL_SESSION
151*SSL_get_session(const SSL *ssl)
152/* aka SSL_get0_session; gets 0 objects, just returns a copy of the pointer */ 150/* aka SSL_get0_session; gets 0 objects, just returns a copy of the pointer */
151SSL_SESSION *
152SSL_get_session(const SSL *ssl)
153{ 153{
154 return (ssl->session); 154 return (ssl->session);
155} 155}
156 156
157SSL_SESSION
158*SSL_get1_session(SSL *ssl)
159/* variant of SSL_get_session: caller really gets something */ 157/* variant of SSL_get_session: caller really gets something */
158SSL_SESSION *
159SSL_get1_session(SSL *ssl)
160{ 160{
161 SSL_SESSION *sess; 161 SSL_SESSION *sess;
162 /* Need to lock this all up rather than just use CRYPTO_add so that 162 /* Need to lock this all up rather than just use CRYPTO_add so that
@@ -184,14 +184,14 @@ SSL_SESSION_set_ex_data(SSL_SESSION *s, int idx, void *arg)
184 return (CRYPTO_set_ex_data(&s->ex_data, idx, arg)); 184 return (CRYPTO_set_ex_data(&s->ex_data, idx, arg));
185} 185}
186 186
187void 187void *
188*SSL_SESSION_get_ex_data(const SSL_SESSION *s, int idx) 188SSL_SESSION_get_ex_data(const SSL_SESSION *s, int idx)
189{ 189{
190 return (CRYPTO_get_ex_data(&s->ex_data, idx)); 190 return (CRYPTO_get_ex_data(&s->ex_data, idx));
191} 191}
192 192
193SSL_SESSION 193SSL_SESSION *
194*SSL_SESSION_new(void) 194SSL_SESSION_new(void)
195{ 195{
196 SSL_SESSION *ss; 196 SSL_SESSION *ss;
197 197
@@ -230,8 +230,8 @@ SSL_SESSION
230 return (ss); 230 return (ss);
231} 231}
232 232
233const unsigned char 233const unsigned char *
234*SSL_SESSION_get_id(const SSL_SESSION *s, unsigned int *len) 234SSL_SESSION_get_id(const SSL_SESSION *s, unsigned int *len)
235{ 235{
236 if (len) 236 if (len)
237 *len = s->session_id_length; 237 *len = s->session_id_length;
@@ -824,8 +824,8 @@ SSL_SESSION_set_time(SSL_SESSION *s, long t)
824 return (t); 824 return (t);
825} 825}
826 826
827X509 827X509 *
828*SSL_SESSION_get0_peer(SSL_SESSION *s) 828SSL_SESSION_get0_peer(SSL_SESSION *s)
829{ 829{
830 return s->peer; 830 return s->peer;
831} 831}
diff --git a/src/lib/libssl/src/ssl/ssl_stat.c b/src/lib/libssl/src/ssl/ssl_stat.c
index da55c92de2..0dae5694b4 100644
--- a/src/lib/libssl/src/ssl/ssl_stat.c
+++ b/src/lib/libssl/src/ssl/ssl_stat.c
@@ -85,8 +85,8 @@
85#include <stdio.h> 85#include <stdio.h>
86#include "ssl_locl.h" 86#include "ssl_locl.h"
87 87
88const char 88const char *
89*SSL_state_string_long(const SSL *s) 89SSL_state_string_long(const SSL *s)
90{ 90{
91 const char *str; 91 const char *str;
92 92
@@ -249,8 +249,8 @@ const char
249 return (str); 249 return (str);
250} 250}
251 251
252const char 252const char *
253*SSL_rstate_string_long(const SSL *s) 253SSL_rstate_string_long(const SSL *s)
254{ 254{
255 const char *str; 255 const char *str;
256 256
@@ -267,8 +267,8 @@ const char
267 return (str); 267 return (str);
268} 268}
269 269
270const char 270const char *
271*SSL_state_string(const SSL *s) 271SSL_state_string(const SSL *s)
272{ 272{
273 const char *str; 273 const char *str;
274 274
@@ -412,8 +412,8 @@ const char
412 return (str); 412 return (str);
413} 413}
414 414
415const char 415const char *
416*SSL_alert_type_string_long(int value) 416SSL_alert_type_string_long(int value)
417{ 417{
418 value>>=8; 418 value>>=8;
419 if (value == SSL3_AL_WARNING) 419 if (value == SSL3_AL_WARNING)
@@ -424,8 +424,8 @@ const char
424 return("unknown"); 424 return("unknown");
425} 425}
426 426
427const char 427const char *
428*SSL_alert_type_string(int value) 428SSL_alert_type_string(int value)
429{ 429{
430 value>>=8; 430 value>>=8;
431 if (value == SSL3_AL_WARNING) 431 if (value == SSL3_AL_WARNING)
@@ -436,8 +436,8 @@ const char
436 return("U"); 436 return("U");
437} 437}
438 438
439const char 439const char *
440*SSL_alert_desc_string(int value) 440SSL_alert_desc_string(int value)
441{ 441{
442 const char *str; 442 const char *str;
443 443
@@ -508,8 +508,8 @@ const char
508 return (str); 508 return (str);
509} 509}
510 510
511const char 511const char *
512*SSL_alert_desc_string_long(int value) 512SSL_alert_desc_string_long(int value)
513{ 513{
514 const char *str; 514 const char *str;
515 515
@@ -610,8 +610,8 @@ const char
610 return (str); 610 return (str);
611} 611}
612 612
613const char 613const char *
614*SSL_rstate_string(const SSL *s) 614SSL_rstate_string(const SSL *s)
615{ 615{
616 const char *str; 616 const char *str;
617 617
diff --git a/src/lib/libssl/src/ssl/ssltest.c b/src/lib/libssl/src/ssl/ssltest.c
index cee5834fef..1f5014baf3 100644
--- a/src/lib/libssl/src/ssl/ssltest.c
+++ b/src/lib/libssl/src/ssl/ssltest.c
@@ -2069,8 +2069,8 @@ app_verify_callback(X509_STORE_CTX *ctx, void *arg)
2069 2069
2070static RSA *rsa_tmp = NULL; 2070static RSA *rsa_tmp = NULL;
2071 2071
2072static RSA 2072static RSA *
2073*tmp_rsa_cb(SSL *s, int is_export, int keylength) 2073tmp_rsa_cb(SSL *s, int is_export, int keylength)
2074{ 2074{
2075 BIGNUM *bn = NULL; 2075 BIGNUM *bn = NULL;
2076 if (rsa_tmp == NULL) { 2076 if (rsa_tmp == NULL) {
@@ -2112,8 +2112,8 @@ free_tmp_rsa(void)
2112 * $ openssl dhparam -C -noout -dsaparam 1024 2112 * $ openssl dhparam -C -noout -dsaparam 1024
2113 * (The third function has been renamed to avoid name conflicts.) 2113 * (The third function has been renamed to avoid name conflicts.)
2114 */ 2114 */
2115static DH 2115static DH *
2116*get_dh512() 2116get_dh512()
2117{ 2117{
2118 static unsigned char dh512_p[] = { 2118 static unsigned char dh512_p[] = {
2119 0xCB, 0xC8, 0xE1, 0x86, 0xD0, 0x1F, 0x94, 0x17, 0xA6, 0x99, 0xF0, 0xC6, 2119 0xCB, 0xC8, 0xE1, 0x86, 0xD0, 0x1F, 0x94, 0x17, 0xA6, 0x99, 0xF0, 0xC6,
@@ -2138,8 +2138,8 @@ static DH
2138 return (dh); 2138 return (dh);
2139} 2139}
2140 2140
2141static DH 2141static DH *
2142*get_dh1024() 2142get_dh1024()
2143{ 2143{
2144 static unsigned char dh1024_p[] = { 2144 static unsigned char dh1024_p[] = {
2145 0xF8, 0x81, 0x89, 0x7D, 0x14, 0x24, 0xC5, 0xD1, 0xE6, 0xF7, 0xBF, 0x3A, 2145 0xF8, 0x81, 0x89, 0x7D, 0x14, 0x24, 0xC5, 0xD1, 0xE6, 0xF7, 0xBF, 0x3A,
@@ -2169,8 +2169,8 @@ static DH
2169 return (dh); 2169 return (dh);
2170} 2170}
2171 2171
2172static DH 2172static DH *
2173*get_dh1024dsa() 2173get_dh1024dsa()
2174{ 2174{
2175 static unsigned char dh1024_p[] = { 2175 static unsigned char dh1024_p[] = {
2176 0xC8, 0x00, 0xF7, 0x08, 0x07, 0x89, 0x4D, 0x90, 0x53, 0xF3, 0xD5, 0x00, 2176 0xC8, 0x00, 0xF7, 0x08, 0x07, 0x89, 0x4D, 0x90, 0x53, 0xF3, 0xD5, 0x00,
diff --git a/src/lib/libssl/src/ssl/t1_clnt.c b/src/lib/libssl/src/ssl/t1_clnt.c
index ac8ff7309f..fa333259ae 100644
--- a/src/lib/libssl/src/ssl/t1_clnt.c
+++ b/src/lib/libssl/src/ssl/t1_clnt.c
@@ -65,16 +65,16 @@
65 65
66static const SSL_METHOD *tls1_get_client_method(int ver); 66static const SSL_METHOD *tls1_get_client_method(int ver);
67 67
68static const SSL_METHOD 68static const SSL_METHOD *
69*tls1_get_client_method(int ver) 69tls1_get_client_method(int ver)
70{ 70{
71 if (ver == TLS1_2_VERSION) 71 if (ver == TLS1_2_VERSION)
72 return TLSv1_2_client_method(); 72 return (TLSv1_2_client_method());
73 if (ver == TLS1_1_VERSION) 73 if (ver == TLS1_1_VERSION)
74 return TLSv1_1_client_method(); 74 return (TLSv1_1_client_method());
75 if (ver == TLS1_VERSION) 75 if (ver == TLS1_VERSION)
76 return TLSv1_client_method(); 76 return (TLSv1_client_method());
77 return NULL; 77 return (NULL);
78} 78}
79 79
80IMPLEMENT_tls_meth_func(TLS1_2_VERSION, TLSv1_2_client_method, 80IMPLEMENT_tls_meth_func(TLS1_2_VERSION, TLSv1_2_client_method,
diff --git a/src/lib/libssl/src/ssl/t1_lib.c b/src/lib/libssl/src/ssl/t1_lib.c
index f6cfb508f6..85d0fa4970 100644
--- a/src/lib/libssl/src/ssl/t1_lib.c
+++ b/src/lib/libssl/src/ssl/t1_lib.c
@@ -343,8 +343,8 @@ tls12_get_req_sig_algs(SSL *s, unsigned char *p)
343 return (int)slen; 343 return (int)slen;
344} 344}
345 345
346unsigned char 346unsigned char *
347*ssl_add_clienthello_tlsext(SSL *s, unsigned char *p, unsigned char *limit) 347ssl_add_clienthello_tlsext(SSL *s, unsigned char *p, unsigned char *limit)
348{ 348{
349 int extdatalen = 0; 349 int extdatalen = 0;
350 unsigned char *ret = p; 350 unsigned char *ret = p;
@@ -671,8 +671,8 @@ skip_ext:
671 return ret; 671 return ret;
672} 672}
673 673
674unsigned char 674unsigned char *
675*ssl_add_serverhello_tlsext(SSL *s, unsigned char *p, unsigned char *limit) 675ssl_add_serverhello_tlsext(SSL *s, unsigned char *p, unsigned char *limit)
676{ 676{
677 int extdatalen = 0; 677 int extdatalen = 0;
678 unsigned char *ret = p; 678 unsigned char *ret = p;
@@ -2249,8 +2249,8 @@ tls12_get_sigid(const EVP_PKEY *pk)
2249 sizeof(tls12_sig)/sizeof(tls12_lookup)); 2249 sizeof(tls12_sig)/sizeof(tls12_lookup));
2250} 2250}
2251 2251
2252const EVP_MD 2252const EVP_MD *
2253*tls12_get_hash(unsigned char hash_alg) 2253tls12_get_hash(unsigned char hash_alg)
2254{ 2254{
2255 switch (hash_alg) { 2255 switch (hash_alg) {
2256 case TLSEXT_hash_sha1: 2256 case TLSEXT_hash_sha1:
diff --git a/src/lib/libssl/src/ssl/t1_meth.c b/src/lib/libssl/src/ssl/t1_meth.c
index ab2d789e59..cf62fe5c3d 100644
--- a/src/lib/libssl/src/ssl/t1_meth.c
+++ b/src/lib/libssl/src/ssl/t1_meth.c
@@ -60,16 +60,16 @@
60#include <openssl/objects.h> 60#include <openssl/objects.h>
61#include "ssl_locl.h" 61#include "ssl_locl.h"
62 62
63static const SSL_METHOD 63static const SSL_METHOD *
64*tls1_get_method(int ver) 64tls1_get_method(int ver)
65{ 65{
66 if (ver == TLS1_2_VERSION) 66 if (ver == TLS1_2_VERSION)
67 return TLSv1_2_method(); 67 return (TLSv1_2_method());
68 if (ver == TLS1_1_VERSION) 68 if (ver == TLS1_1_VERSION)
69 return TLSv1_1_method(); 69 return (TLSv1_1_method());
70 if (ver == TLS1_VERSION) 70 if (ver == TLS1_VERSION)
71 return TLSv1_method(); 71 return (TLSv1_method());
72 return NULL; 72 return (NULL);
73} 73}
74 74
75IMPLEMENT_tls_meth_func(TLS1_2_VERSION, TLSv1_2_method, 75IMPLEMENT_tls_meth_func(TLS1_2_VERSION, TLSv1_2_method,
diff --git a/src/lib/libssl/src/ssl/t1_srvr.c b/src/lib/libssl/src/ssl/t1_srvr.c
index 776bcabc46..c0d186e425 100644
--- a/src/lib/libssl/src/ssl/t1_srvr.c
+++ b/src/lib/libssl/src/ssl/t1_srvr.c
@@ -66,16 +66,16 @@
66 66
67static const SSL_METHOD *tls1_get_server_method(int ver); 67static const SSL_METHOD *tls1_get_server_method(int ver);
68 68
69static const SSL_METHOD 69static const SSL_METHOD *
70*tls1_get_server_method(int ver) 70tls1_get_server_method(int ver)
71{ 71{
72 if (ver == TLS1_2_VERSION) 72 if (ver == TLS1_2_VERSION)
73 return TLSv1_2_server_method(); 73 return (TLSv1_2_server_method());
74 if (ver == TLS1_1_VERSION) 74 if (ver == TLS1_1_VERSION)
75 return TLSv1_1_server_method(); 75 return (TLSv1_1_server_method());
76 if (ver == TLS1_VERSION) 76 if (ver == TLS1_VERSION)
77 return TLSv1_server_method(); 77 return (TLSv1_server_method());
78 return NULL; 78 return (NULL);
79} 79}
80 80
81IMPLEMENT_tls_meth_func(TLS1_2_VERSION, TLSv1_2_server_method, 81IMPLEMENT_tls_meth_func(TLS1_2_VERSION, TLSv1_2_server_method,
diff --git a/src/lib/libssl/src/ssl/tls_srp.c b/src/lib/libssl/src/ssl/tls_srp.c
index a3acb6fd14..c585211cd0 100644
--- a/src/lib/libssl/src/ssl/tls_srp.c
+++ b/src/lib/libssl/src/ssl/tls_srp.c
@@ -426,32 +426,32 @@ SRP_Calc_A_param(SSL *s)
426 return 1; 426 return 1;
427} 427}
428 428
429BIGNUM 429BIGNUM *
430*SSL_get_srp_g(SSL *s) 430SSL_get_srp_g(SSL *s)
431{ 431{
432 if (s->srp_ctx.g != NULL) 432 if (s->srp_ctx.g != NULL)
433 return s->srp_ctx.g; 433 return s->srp_ctx.g;
434 return s->ctx->srp_ctx.g; 434 return s->ctx->srp_ctx.g;
435} 435}
436 436
437BIGNUM 437BIGNUM *
438*SSL_get_srp_N(SSL *s) 438SSL_get_srp_N(SSL *s)
439{ 439{
440 if (s->srp_ctx.N != NULL) 440 if (s->srp_ctx.N != NULL)
441 return s->srp_ctx.N; 441 return s->srp_ctx.N;
442 return s->ctx->srp_ctx.N; 442 return s->ctx->srp_ctx.N;
443} 443}
444 444
445char 445char *
446*SSL_get_srp_username(SSL *s) 446SSL_get_srp_username(SSL *s)
447{ 447{
448 if (s->srp_ctx.login != NULL) 448 if (s->srp_ctx.login != NULL)
449 return s->srp_ctx.login; 449 return s->srp_ctx.login;
450 return s->ctx->srp_ctx.login; 450 return s->ctx->srp_ctx.login;
451} 451}
452 452
453char 453char *
454*SSL_get_srp_userinfo(SSL *s) 454SSL_get_srp_userinfo(SSL *s)
455{ 455{
456 if (s->srp_ctx.info != NULL) 456 if (s->srp_ctx.info != NULL)
457 return s->srp_ctx.info; 457 return s->srp_ctx.info;
diff --git a/src/lib/libssl/srtp.h b/src/lib/libssl/srtp.h
index 06075f2c86..e2dfee5426 100644
--- a/src/lib/libssl/srtp.h
+++ b/src/lib/libssl/srtp.h
@@ -109,11 +109,11 @@
109 * 109 *
110 */ 110 */
111/* 111/*
112 DTLS code by Eric Rescorla <ekr@rtfm.com> 112 * DTLS code by Eric Rescorla <ekr@rtfm.com>
113 113 *
114 Copyright (C) 2006, Network Resonance, Inc. 114 * Copyright (C) 2006, Network Resonance, Inc.
115 Copyright (C) 2011, RTFM, Inc. 115 * Copyright (C) 2011, RTFM, Inc.
116*/ 116 */
117 117
118#ifndef HEADER_D1_SRTP_H 118#ifndef HEADER_D1_SRTP_H
119#define HEADER_D1_SRTP_H 119#define HEADER_D1_SRTP_H
diff --git a/src/lib/libssl/ssl.h b/src/lib/libssl/ssl.h
index ef829797b7..f3ca8c5c4e 100644
--- a/src/lib/libssl/ssl.h
+++ b/src/lib/libssl/ssl.h
@@ -1728,9 +1728,8 @@ SSL_SESSION_set1_id_context(SSL_SESSION *s, const unsigned char *sid_ctx,
1728unsigned int sid_ctx_len); 1728unsigned int sid_ctx_len);
1729 1729
1730SSL_SESSION *SSL_SESSION_new(void); 1730SSL_SESSION *SSL_SESSION_new(void);
1731const unsigned char 1731const unsigned char *SSL_SESSION_get_id(const SSL_SESSION *s,
1732*SSL_SESSION_get_id(const SSL_SESSION *s, 1732 unsigned int *len);
1733unsigned int *len);
1734unsigned int SSL_SESSION_get_compress_id(const SSL_SESSION *s); 1733unsigned int SSL_SESSION_get_compress_id(const SSL_SESSION *s);
1735#ifndef OPENSSL_NO_FP_API 1734#ifndef OPENSSL_NO_FP_API
1736int SSL_SESSION_print_fp(FILE *fp, const SSL_SESSION *ses); 1735int SSL_SESSION_print_fp(FILE *fp, const SSL_SESSION *ses);
diff --git a/src/lib/libssl/ssl_asn1.c b/src/lib/libssl/ssl_asn1.c
index 60ee189f29..c551ec4877 100644
--- a/src/lib/libssl/ssl_asn1.c
+++ b/src/lib/libssl/ssl_asn1.c
@@ -355,9 +355,8 @@ i2d_SSL_SESSION(SSL_SESSION *in, unsigned char **pp)
355 M_ASN1_I2D_finish(); 355 M_ASN1_I2D_finish();
356} 356}
357 357
358SSL_SESSION 358SSL_SESSION *
359*d2i_SSL_SESSION(SSL_SESSION **a, const unsigned char **pp, 359d2i_SSL_SESSION(SSL_SESSION **a, const unsigned char **pp, long length)
360long length)
361{ 360{
362 int ssl_version = 0, i; 361 int ssl_version = 0, i;
363 long id; 362 long id;
diff --git a/src/lib/libssl/ssl_cert.c b/src/lib/libssl/ssl_cert.c
index a823c16edf..389d47408c 100644
--- a/src/lib/libssl/ssl_cert.c
+++ b/src/lib/libssl/ssl_cert.c
@@ -171,8 +171,8 @@ ssl_cert_set_default_md(CERT *cert)
171#endif 171#endif
172} 172}
173 173
174CERT 174CERT *
175*ssl_cert_new(void) 175ssl_cert_new(void)
176{ 176{
177 CERT *ret; 177 CERT *ret;
178 178
@@ -189,8 +189,8 @@ CERT
189 return (ret); 189 return (ret);
190} 190}
191 191
192CERT 192CERT *
193*ssl_cert_dup(CERT *cert) 193ssl_cert_dup(CERT *cert)
194{ 194{
195 CERT *ret; 195 CERT *ret;
196 int i; 196 int i;
@@ -398,8 +398,8 @@ ssl_cert_inst(CERT **o)
398} 398}
399 399
400 400
401SESS_CERT 401SESS_CERT *
402*ssl_sess_cert_new(void) 402ssl_sess_cert_new(void)
403{ 403{
404 SESS_CERT *ret; 404 SESS_CERT *ret;
405 405
@@ -531,8 +531,8 @@ set_client_CA_list(STACK_OF(X509_NAME) **ca_list, STACK_OF(X509_NAME) *name_list
531 *ca_list = name_list; 531 *ca_list = name_list;
532} 532}
533 533
534STACK_OF(X509_NAME) 534STACK_OF(X509_NAME) *
535*SSL_dup_CA_list(STACK_OF(X509_NAME) *sk) 535SSL_dup_CA_list(STACK_OF(X509_NAME) *sk)
536{ 536{
537 int i; 537 int i;
538 STACK_OF(X509_NAME) *ret; 538 STACK_OF(X509_NAME) *ret;
@@ -561,14 +561,14 @@ SSL_CTX_set_client_CA_list(SSL_CTX *ctx, STACK_OF(X509_NAME) *name_list)
561 set_client_CA_list(&(ctx->client_CA), name_list); 561 set_client_CA_list(&(ctx->client_CA), name_list);
562} 562}
563 563
564STACK_OF(X509_NAME) 564STACK_OF(X509_NAME) *
565*SSL_CTX_get_client_CA_list(const SSL_CTX *ctx) 565SSL_CTX_get_client_CA_list(const SSL_CTX *ctx)
566{ 566{
567 return (ctx->client_CA); 567 return (ctx->client_CA);
568} 568}
569 569
570STACK_OF(X509_NAME) 570STACK_OF(X509_NAME) *
571*SSL_get_client_CA_list(const SSL *s) 571SSL_get_client_CA_list(const SSL *s)
572{ 572{
573 if (s->type == SSL_ST_CONNECT) 573 if (s->type == SSL_ST_CONNECT)
574 { /* we are in the client */ 574 { /* we are in the client */
@@ -632,8 +632,8 @@ xname_cmp(const X509_NAME * const *a, const X509_NAME * const *b)
632 * \param file the file containing one or more certs. 632 * \param file the file containing one or more certs.
633 * \return a ::STACK containing the certs. 633 * \return a ::STACK containing the certs.
634 */ 634 */
635STACK_OF(X509_NAME) 635STACK_OF(X509_NAME) *
636*SSL_load_client_CA_file(const char *file) 636SSL_load_client_CA_file(const char *file)
637{ 637{
638 BIO *in; 638 BIO *in;
639 X509 *x = NULL; 639 X509 *x = NULL;
diff --git a/src/lib/libssl/ssl_ciph.c b/src/lib/libssl/ssl_ciph.c
index 140a00ceca..7d2ea6c481 100644
--- a/src/lib/libssl/ssl_ciph.c
+++ b/src/lib/libssl/ssl_ciph.c
@@ -1295,8 +1295,8 @@ const SSL_CIPHER **ca_list)
1295 return (retval); 1295 return (retval);
1296} 1296}
1297 1297
1298STACK_OF(SSL_CIPHER) 1298STACK_OF(SSL_CIPHER) *
1299*ssl_create_cipher_list(const SSL_METHOD *ssl_method, 1299ssl_create_cipher_list(const SSL_METHOD *ssl_method,
1300 STACK_OF(SSL_CIPHER) **cipher_list, 1300 STACK_OF(SSL_CIPHER) **cipher_list,
1301 STACK_OF(SSL_CIPHER) **cipher_list_by_id, 1301 STACK_OF(SSL_CIPHER) **cipher_list_by_id,
1302 const char *rule_str) 1302 const char *rule_str)
@@ -1466,8 +1466,8 @@ STACK_OF(SSL_CIPHER)
1466 return (cipherstack); 1466 return (cipherstack);
1467} 1467}
1468 1468
1469char 1469char *
1470*SSL_CIPHER_description(const SSL_CIPHER *cipher, char *buf, int len) 1470SSL_CIPHER_description(const SSL_CIPHER *cipher, char *buf, int len)
1471{ 1471{
1472 int is_export, pkl, kl, l; 1472 int is_export, pkl, kl, l;
1473 const char *ver, *exp_str; 1473 const char *ver, *exp_str;
@@ -1652,8 +1652,8 @@ char
1652 return (buf); 1652 return (buf);
1653} 1653}
1654 1654
1655char 1655char *
1656*SSL_CIPHER_get_version(const SSL_CIPHER *c) 1656SSL_CIPHER_get_version(const SSL_CIPHER *c)
1657{ 1657{
1658 int i; 1658 int i;
1659 1659
@@ -1669,8 +1669,8 @@ char
1669} 1669}
1670 1670
1671/* return the actual cipher being used */ 1671/* return the actual cipher being used */
1672const char 1672const char *
1673*SSL_CIPHER_get_name(const SSL_CIPHER *c) 1673SSL_CIPHER_get_name(const SSL_CIPHER *c)
1674{ 1674{
1675 if (c != NULL) 1675 if (c != NULL)
1676 return (c->name); 1676 return (c->name);
@@ -1697,8 +1697,8 @@ SSL_CIPHER_get_id(const SSL_CIPHER *c)
1697 return c->id; 1697 return c->id;
1698} 1698}
1699 1699
1700SSL_COMP 1700SSL_COMP *
1701*ssl3_comp_find(STACK_OF(SSL_COMP) *sk, int n) 1701ssl3_comp_find(STACK_OF(SSL_COMP) *sk, int n)
1702{ 1702{
1703 SSL_COMP *ctmp; 1703 SSL_COMP *ctmp;
1704 int i, nn; 1704 int i, nn;
@@ -1715,8 +1715,8 @@ SSL_COMP
1715} 1715}
1716 1716
1717#ifdef OPENSSL_NO_COMP 1717#ifdef OPENSSL_NO_COMP
1718void 1718void *
1719*SSL_COMP_get_compression_methods(void) 1719SSL_COMP_get_compression_methods(void)
1720{ 1720{
1721 return NULL; 1721 return NULL;
1722} 1722}
@@ -1727,14 +1727,14 @@ SSL_COMP_add_compression_method(int id, void *cm)
1727 return 1; 1727 return 1;
1728} 1728}
1729 1729
1730const char 1730const char *
1731*SSL_COMP_get_name(const void *comp) 1731SSL_COMP_get_name(const void *comp)
1732{ 1732{
1733 return NULL; 1733 return NULL;
1734} 1734}
1735#else 1735#else
1736STACK_OF(SSL_COMP) 1736STACK_OF(SSL_COMP) *
1737*SSL_COMP_get_compression_methods(void) 1737SSL_COMP_get_compression_methods(void)
1738{ 1738{
1739 load_builtin_compressions(); 1739 load_builtin_compressions();
1740 return (ssl_comp_methods); 1740 return (ssl_comp_methods);
@@ -1782,8 +1782,8 @@ SSL_COMP_add_compression_method(int id, COMP_METHOD *cm)
1782 } 1782 }
1783} 1783}
1784 1784
1785const char 1785const char *
1786*SSL_COMP_get_name(const COMP_METHOD *comp) 1786SSL_COMP_get_name(const COMP_METHOD *comp)
1787{ 1787{
1788 if (comp) 1788 if (comp)
1789 return comp->name; 1789 return comp->name;
diff --git a/src/lib/libssl/ssl_lib.c b/src/lib/libssl/ssl_lib.c
index dc36747833..3ab353b8eb 100644
--- a/src/lib/libssl/ssl_lib.c
+++ b/src/lib/libssl/ssl_lib.c
@@ -256,8 +256,8 @@ SSL_CTX_set_ssl_version(SSL_CTX *ctx, const SSL_METHOD *meth)
256 return (1); 256 return (1);
257} 257}
258 258
259SSL 259SSL *
260*SSL_new(SSL_CTX *ctx) 260SSL_new(SSL_CTX *ctx)
261{ 261{
262 SSL *s; 262 SSL *s;
263 263
@@ -604,14 +604,16 @@ SSL_set_bio(SSL *s, BIO *rbio, BIO *wbio)
604 s->wbio = wbio; 604 s->wbio = wbio;
605} 605}
606 606
607BIO 607BIO *
608*SSL_get_rbio(const SSL *s) 608SSL_get_rbio(const SSL *s)
609 { return (s->rbio); 609{
610 return (s->rbio);
610} 611}
611 612
612BIO 613BIO *
613*SSL_get_wbio(const SSL *s) 614SSL_get_wbio(const SSL *s)
614 { return (s->wbio); 615{
616 return (s->wbio);
615} 617}
616 618
617int 619int
@@ -819,8 +821,8 @@ SSL_pending(const SSL *s)
819 return (s->method->ssl_pending(s)); 821 return (s->method->ssl_pending(s));
820} 822}
821 823
822X509 824X509 *
823*SSL_get_peer_certificate(const SSL *s) 825SSL_get_peer_certificate(const SSL *s)
824{ 826{
825 X509 *r; 827 X509 *r;
826 828
@@ -837,8 +839,8 @@ X509
837 return (r); 839 return (r);
838} 840}
839 841
840STACK_OF(X509) 842STACK_OF(X509) *
841*SSL_get_peer_cert_chain(const SSL *s) 843SSL_get_peer_cert_chain(const SSL *s)
842{ 844{
843 STACK_OF(X509) *r; 845 STACK_OF(X509) *r;
844 846
@@ -1115,8 +1117,8 @@ SSL_callback_ctrl(SSL *s, int cmd, void (*fp)(void))
1115 } 1117 }
1116} 1118}
1117 1119
1118LHASH_OF(SSL_SESSION) 1120LHASH_OF(SSL_SESSION) *
1119*SSL_CTX_sessions(SSL_CTX *ctx) 1121SSL_CTX_sessions(SSL_CTX *ctx)
1120{ 1122{
1121 return ctx->sessions; 1123 return ctx->sessions;
1122} 1124}
@@ -1240,8 +1242,8 @@ ssl_cipher_ptr_id_cmp(const SSL_CIPHER * const *ap,
1240 1242
1241/** return a STACK of the ciphers available for the SSL and in order of 1243/** return a STACK of the ciphers available for the SSL and in order of
1242 * preference */ 1244 * preference */
1243STACK_OF(SSL_CIPHER) 1245STACK_OF(SSL_CIPHER) *
1244*SSL_get_ciphers(const SSL *s) 1246SSL_get_ciphers(const SSL *s)
1245{ 1247{
1246 if (s != NULL) { 1248 if (s != NULL) {
1247 if (s->cipher_list != NULL) { 1249 if (s->cipher_list != NULL) {
@@ -1256,8 +1258,8 @@ STACK_OF(SSL_CIPHER)
1256 1258
1257/** return a STACK of the ciphers available for the SSL and in order of 1259/** return a STACK of the ciphers available for the SSL and in order of
1258 * algorithm id */ 1260 * algorithm id */
1259STACK_OF(SSL_CIPHER) 1261STACK_OF(SSL_CIPHER) *
1260*ssl_get_ciphers_by_id(SSL *s) 1262ssl_get_ciphers_by_id(SSL *s)
1261{ 1263{
1262 if (s != NULL) { 1264 if (s != NULL) {
1263 if (s->cipher_list_by_id != NULL) { 1265 if (s->cipher_list_by_id != NULL) {
@@ -1271,8 +1273,8 @@ STACK_OF(SSL_CIPHER)
1271} 1273}
1272 1274
1273/** The old interface to get the same thing as SSL_get_ciphers() */ 1275/** The old interface to get the same thing as SSL_get_ciphers() */
1274const char 1276const char *
1275*SSL_get_cipher_list(const SSL *s, int n) 1277SSL_get_cipher_list(const SSL *s, int n)
1276{ 1278{
1277 SSL_CIPHER *c; 1279 SSL_CIPHER *c;
1278 STACK_OF(SSL_CIPHER) *sk; 1280 STACK_OF(SSL_CIPHER) *sk;
@@ -1331,8 +1333,8 @@ SSL_set_cipher_list(SSL *s, const char *str)
1331} 1333}
1332 1334
1333/* works well for SSLv2, not so good for SSLv3 */ 1335/* works well for SSLv2, not so good for SSLv3 */
1334char 1336char *
1335*SSL_get_shared_ciphers(const SSL *s, char *buf, int len) 1337SSL_get_shared_ciphers(const SSL *s, char *buf, int len)
1336{ 1338{
1337 char *end; 1339 char *end;
1338 STACK_OF(SSL_CIPHER) *sk; 1340 STACK_OF(SSL_CIPHER) *sk;
@@ -1414,9 +1416,9 @@ ssl_cipher_list_to_bytes(SSL *s, STACK_OF(SSL_CIPHER) *sk, unsigned char *p,
1414 return (p - q); 1416 return (p - q);
1415} 1417}
1416 1418
1417STACK_OF(SSL_CIPHER) 1419STACK_OF(SSL_CIPHER) *
1418*ssl_bytes_to_cipher_list(SSL *s, unsigned char *p, int num, 1420ssl_bytes_to_cipher_list(SSL *s, unsigned char *p, int num,
1419STACK_OF(SSL_CIPHER) **skp) 1421 STACK_OF(SSL_CIPHER) **skp)
1420{ 1422{
1421 const SSL_CIPHER *c; 1423 const SSL_CIPHER *c;
1422 STACK_OF(SSL_CIPHER) *sk; 1424 STACK_OF(SSL_CIPHER) *sk;
@@ -1481,8 +1483,8 @@ err:
1481 * So far, only host_name types are defined (RFC 3546). 1483 * So far, only host_name types are defined (RFC 3546).
1482 */ 1484 */
1483 1485
1484const char 1486const char *
1485*SSL_get_servername(const SSL *s, const int type) 1487SSL_get_servername(const SSL *s, const int type)
1486{ 1488{
1487 if (type != TLSEXT_NAMETYPE_host_name) 1489 if (type != TLSEXT_NAMETYPE_host_name)
1488 return NULL; 1490 return NULL;
@@ -1669,8 +1671,8 @@ IMPLEMENT_LHASH_HASH_FN(ssl_session, SSL_SESSION)
1669static 1671static
1670IMPLEMENT_LHASH_COMP_FN(ssl_session, SSL_SESSION) 1672IMPLEMENT_LHASH_COMP_FN(ssl_session, SSL_SESSION)
1671 1673
1672SSL_CTX 1674SSL_CTX *
1673*SSL_CTX_new(const SSL_METHOD *meth) 1675SSL_CTX_new(const SSL_METHOD *meth)
1674{ 1676{
1675 SSL_CTX *ret = NULL; 1677 SSL_CTX *ret = NULL;
1676 1678
@@ -2217,8 +2219,8 @@ ssl_check_srvr_ecc_cert_and_alg(X509 *x, SSL *s)
2217#endif 2219#endif
2218 2220
2219/* THIS NEEDS CLEANING UP */ 2221/* THIS NEEDS CLEANING UP */
2220CERT_PKEY 2222CERT_PKEY *
2221*ssl_get_server_send_pkey(const SSL *s) 2223ssl_get_server_send_pkey(const SSL *s)
2222{ 2224{
2223 unsigned long alg_k, alg_a; 2225 unsigned long alg_k, alg_a;
2224 CERT *c; 2226 CERT *c;
@@ -2272,8 +2274,8 @@ CERT_PKEY
2272 return c->pkeys + i; 2274 return c->pkeys + i;
2273} 2275}
2274 2276
2275X509 2277X509 *
2276*ssl_get_server_send_cert(const SSL *s) 2278ssl_get_server_send_cert(const SSL *s)
2277{ 2279{
2278 CERT_PKEY *cpk; 2280 CERT_PKEY *cpk;
2279 cpk = ssl_get_server_send_pkey(s); 2281 cpk = ssl_get_server_send_pkey(s);
@@ -2282,8 +2284,8 @@ X509
2282 return cpk->x509; 2284 return cpk->x509;
2283} 2285}
2284 2286
2285EVP_PKEY 2287EVP_PKEY *
2286*ssl_get_sign_pkey(SSL *s, const SSL_CIPHER *cipher, const EVP_MD **pmd) 2288ssl_get_sign_pkey(SSL *s, const SSL_CIPHER *cipher, const EVP_MD **pmd)
2287{ 2289{
2288 unsigned long alg_a; 2290 unsigned long alg_a;
2289 CERT *c; 2291 CERT *c;
@@ -2343,8 +2345,8 @@ ssl_update_cache(SSL *s, int mode)
2343 } 2345 }
2344} 2346}
2345 2347
2346const SSL_METHOD 2348const SSL_METHOD *
2347*SSL_get_ssl_method(SSL *s) 2349SSL_get_ssl_method(SSL *s)
2348{ 2350{
2349 return (s->method); 2351 return (s->method);
2350} 2352}
@@ -2684,8 +2686,8 @@ ssl_clear_cipher_ctx(SSL *s)
2684} 2686}
2685 2687
2686/* Fix this function so that it takes an optional type parameter */ 2688/* Fix this function so that it takes an optional type parameter */
2687X509 2689X509 *
2688*SSL_get_certificate(const SSL *s) 2690SSL_get_certificate(const SSL *s)
2689{ 2691{
2690 if (s->cert != NULL) 2692 if (s->cert != NULL)
2691 return (s->cert->key->x509); 2693 return (s->cert->key->x509);
@@ -2694,8 +2696,8 @@ X509
2694} 2696}
2695 2697
2696/* Fix this function so that it takes an optional type parameter */ 2698/* Fix this function so that it takes an optional type parameter */
2697EVP_PKEY 2699EVP_PKEY *
2698*SSL_get_privatekey(SSL *s) 2700SSL_get_privatekey(SSL *s)
2699{ 2701{
2700 if (s->cert != NULL) 2702 if (s->cert != NULL)
2701 return (s->cert->key->privatekey); 2703 return (s->cert->key->privatekey);
@@ -2703,37 +2705,37 @@ EVP_PKEY
2703 return (NULL); 2705 return (NULL);
2704} 2706}
2705 2707
2706const SSL_CIPHER 2708const SSL_CIPHER *
2707*SSL_get_current_cipher(const SSL *s) 2709SSL_get_current_cipher(const SSL *s)
2708{ 2710{
2709 if ((s->session != NULL) && (s->session->cipher != NULL)) 2711 if ((s->session != NULL) && (s->session->cipher != NULL))
2710 return (s->session->cipher); 2712 return (s->session->cipher);
2711 return (NULL); 2713 return (NULL);
2712} 2714}
2713#ifdef OPENSSL_NO_COMP 2715#ifdef OPENSSL_NO_COMP
2714const void 2716const void *
2715*SSL_get_current_compression(SSL *s) 2717SSL_get_current_compression(SSL *s)
2716{ 2718{
2717 return NULL; 2719 return NULL;
2718} 2720}
2719 2721
2720const void 2722const void *
2721*SSL_get_current_expansion(SSL *s) 2723SSL_get_current_expansion(SSL *s)
2722{ 2724{
2723 return NULL; 2725 return NULL;
2724} 2726}
2725#else 2727#else
2726 2728
2727const COMP_METHOD 2729const COMP_METHOD *
2728*SSL_get_current_compression(SSL *s) 2730SSL_get_current_compression(SSL *s)
2729{ 2731{
2730 if (s->compress != NULL) 2732 if (s->compress != NULL)
2731 return (s->compress->meth); 2733 return (s->compress->meth);
2732 return (NULL); 2734 return (NULL);
2733} 2735}
2734 2736
2735const COMP_METHOD 2737const COMP_METHOD *
2736*SSL_get_current_expansion(SSL *s) 2738SSL_get_current_expansion(SSL *s)
2737{ 2739{
2738 if (s->expand != NULL) 2740 if (s->expand != NULL)
2739 return (s->expand->meth); 2741 return (s->expand->meth);
@@ -2828,14 +2830,14 @@ SSL_version(const SSL *s)
2828 return (s->version); 2830 return (s->version);
2829} 2831}
2830 2832
2831SSL_CTX 2833SSL_CTX *
2832*SSL_get_SSL_CTX(const SSL *ssl) 2834SSL_get_SSL_CTX(const SSL *ssl)
2833{ 2835{
2834 return (ssl->ctx); 2836 return (ssl->ctx);
2835} 2837}
2836 2838
2837SSL_CTX 2839SSL_CTX *
2838*SSL_set_SSL_CTX(SSL *ssl, SSL_CTX* ctx) 2840SSL_set_SSL_CTX(SSL *ssl, SSL_CTX* ctx)
2839{ 2841{
2840 if (ssl->ctx == ctx) 2842 if (ssl->ctx == ctx)
2841 return ssl->ctx; 2843 return ssl->ctx;
@@ -2920,8 +2922,8 @@ SSL_set_ex_data(SSL *s, int idx, void *arg)
2920 return (CRYPTO_set_ex_data(&s->ex_data, idx, arg)); 2922 return (CRYPTO_set_ex_data(&s->ex_data, idx, arg));
2921} 2923}
2922 2924
2923void 2925void *
2924*SSL_get_ex_data(const SSL *s, int idx) 2926SSL_get_ex_data(const SSL *s, int idx)
2925{ 2927{
2926 return (CRYPTO_get_ex_data(&s->ex_data, idx)); 2928 return (CRYPTO_get_ex_data(&s->ex_data, idx));
2927} 2929}
@@ -2940,8 +2942,8 @@ SSL_CTX_set_ex_data(SSL_CTX *s, int idx, void *arg)
2940 return (CRYPTO_set_ex_data(&s->ex_data, idx, arg)); 2942 return (CRYPTO_set_ex_data(&s->ex_data, idx, arg));
2941} 2943}
2942 2944
2943void 2945void *
2944*SSL_CTX_get_ex_data(const SSL_CTX *s, int idx) 2946SSL_CTX_get_ex_data(const SSL_CTX *s, int idx)
2945{ 2947{
2946 return (CRYPTO_get_ex_data(&s->ex_data, idx)); 2948 return (CRYPTO_get_ex_data(&s->ex_data, idx));
2947} 2949}
@@ -2952,8 +2954,8 @@ ssl_ok(SSL *s)
2952 return (1); 2954 return (1);
2953} 2955}
2954 2956
2955X509_STORE 2957X509_STORE *
2956*SSL_CTX_get_cert_store(const SSL_CTX *ctx) 2958SSL_CTX_get_cert_store(const SSL_CTX *ctx)
2957{ 2959{
2958 return (ctx->cert_store); 2960 return (ctx->cert_store);
2959} 2961}
@@ -3005,8 +3007,8 @@ int keylength))
3005 * \sa SSL_CTX_set_tmp_rsa_callback, SSL_set_tmp_rsa_callback 3007 * \sa SSL_CTX_set_tmp_rsa_callback, SSL_set_tmp_rsa_callback
3006 */ 3008 */
3007 3009
3008RSA 3010RSA *
3009*cb(SSL *ssl, int is_export, int keylength) 3011cb(SSL *ssl, int is_export, int keylength)
3010{} 3012{}
3011#endif 3013#endif
3012 3014
@@ -3091,16 +3093,16 @@ SSL_use_psk_identity_hint(SSL *s, const char *identity_hint)
3091 return 1; 3093 return 1;
3092} 3094}
3093 3095
3094const char 3096const char *
3095*SSL_get_psk_identity_hint(const SSL *s) 3097SSL_get_psk_identity_hint(const SSL *s)
3096{ 3098{
3097 if (s == NULL || s->session == NULL) 3099 if (s == NULL || s->session == NULL)
3098 return NULL; 3100 return NULL;
3099 return (s->session->psk_identity_hint); 3101 return (s->session->psk_identity_hint);
3100} 3102}
3101 3103
3102const char 3104const char *
3103*SSL_get_psk_identity(const SSL *s) 3105SSL_get_psk_identity(const SSL *s)
3104{ 3106{
3105 if (s == NULL || s->session == NULL) 3107 if (s == NULL || s->session == NULL)
3106 return NULL; 3108 return NULL;
@@ -3160,8 +3162,8 @@ SSL_set_msg_callback(SSL *ssl, void (*cb)(int write_p, int version, int content_
3160 * Returns newly allocated ctx; 3162 * Returns newly allocated ctx;
3161 */ 3163 */
3162 3164
3163EVP_MD_CTX 3165EVP_MD_CTX *
3164*ssl_replace_hash(EVP_MD_CTX **hash, const EVP_MD *md) 3166ssl_replace_hash(EVP_MD_CTX **hash, const EVP_MD *md)
3165{ 3167{
3166 ssl_clear_hash_ctx(hash); 3168 ssl_clear_hash_ctx(hash);
3167 *hash = EVP_MD_CTX_create(); 3169 *hash = EVP_MD_CTX_create();
diff --git a/src/lib/libssl/ssl_sess.c b/src/lib/libssl/ssl_sess.c
index cbfff0b398..c67ae1c22f 100644
--- a/src/lib/libssl/ssl_sess.c
+++ b/src/lib/libssl/ssl_sess.c
@@ -147,16 +147,16 @@ static void SSL_SESSION_list_remove(SSL_CTX *ctx, SSL_SESSION *s);
147static void SSL_SESSION_list_add(SSL_CTX *ctx, SSL_SESSION *s); 147static void SSL_SESSION_list_add(SSL_CTX *ctx, SSL_SESSION *s);
148static int remove_session_lock(SSL_CTX *ctx, SSL_SESSION *c, int lck); 148static int remove_session_lock(SSL_CTX *ctx, SSL_SESSION *c, int lck);
149 149
150SSL_SESSION
151*SSL_get_session(const SSL *ssl)
152/* aka SSL_get0_session; gets 0 objects, just returns a copy of the pointer */ 150/* aka SSL_get0_session; gets 0 objects, just returns a copy of the pointer */
151SSL_SESSION *
152SSL_get_session(const SSL *ssl)
153{ 153{
154 return (ssl->session); 154 return (ssl->session);
155} 155}
156 156
157SSL_SESSION
158*SSL_get1_session(SSL *ssl)
159/* variant of SSL_get_session: caller really gets something */ 157/* variant of SSL_get_session: caller really gets something */
158SSL_SESSION *
159SSL_get1_session(SSL *ssl)
160{ 160{
161 SSL_SESSION *sess; 161 SSL_SESSION *sess;
162 /* Need to lock this all up rather than just use CRYPTO_add so that 162 /* Need to lock this all up rather than just use CRYPTO_add so that
@@ -184,14 +184,14 @@ SSL_SESSION_set_ex_data(SSL_SESSION *s, int idx, void *arg)
184 return (CRYPTO_set_ex_data(&s->ex_data, idx, arg)); 184 return (CRYPTO_set_ex_data(&s->ex_data, idx, arg));
185} 185}
186 186
187void 187void *
188*SSL_SESSION_get_ex_data(const SSL_SESSION *s, int idx) 188SSL_SESSION_get_ex_data(const SSL_SESSION *s, int idx)
189{ 189{
190 return (CRYPTO_get_ex_data(&s->ex_data, idx)); 190 return (CRYPTO_get_ex_data(&s->ex_data, idx));
191} 191}
192 192
193SSL_SESSION 193SSL_SESSION *
194*SSL_SESSION_new(void) 194SSL_SESSION_new(void)
195{ 195{
196 SSL_SESSION *ss; 196 SSL_SESSION *ss;
197 197
@@ -230,8 +230,8 @@ SSL_SESSION
230 return (ss); 230 return (ss);
231} 231}
232 232
233const unsigned char 233const unsigned char *
234*SSL_SESSION_get_id(const SSL_SESSION *s, unsigned int *len) 234SSL_SESSION_get_id(const SSL_SESSION *s, unsigned int *len)
235{ 235{
236 if (len) 236 if (len)
237 *len = s->session_id_length; 237 *len = s->session_id_length;
@@ -824,8 +824,8 @@ SSL_SESSION_set_time(SSL_SESSION *s, long t)
824 return (t); 824 return (t);
825} 825}
826 826
827X509 827X509 *
828*SSL_SESSION_get0_peer(SSL_SESSION *s) 828SSL_SESSION_get0_peer(SSL_SESSION *s)
829{ 829{
830 return s->peer; 830 return s->peer;
831} 831}
diff --git a/src/lib/libssl/ssl_stat.c b/src/lib/libssl/ssl_stat.c
index da55c92de2..0dae5694b4 100644
--- a/src/lib/libssl/ssl_stat.c
+++ b/src/lib/libssl/ssl_stat.c
@@ -85,8 +85,8 @@
85#include <stdio.h> 85#include <stdio.h>
86#include "ssl_locl.h" 86#include "ssl_locl.h"
87 87
88const char 88const char *
89*SSL_state_string_long(const SSL *s) 89SSL_state_string_long(const SSL *s)
90{ 90{
91 const char *str; 91 const char *str;
92 92
@@ -249,8 +249,8 @@ const char
249 return (str); 249 return (str);
250} 250}
251 251
252const char 252const char *
253*SSL_rstate_string_long(const SSL *s) 253SSL_rstate_string_long(const SSL *s)
254{ 254{
255 const char *str; 255 const char *str;
256 256
@@ -267,8 +267,8 @@ const char
267 return (str); 267 return (str);
268} 268}
269 269
270const char 270const char *
271*SSL_state_string(const SSL *s) 271SSL_state_string(const SSL *s)
272{ 272{
273 const char *str; 273 const char *str;
274 274
@@ -412,8 +412,8 @@ const char
412 return (str); 412 return (str);
413} 413}
414 414
415const char 415const char *
416*SSL_alert_type_string_long(int value) 416SSL_alert_type_string_long(int value)
417{ 417{
418 value>>=8; 418 value>>=8;
419 if (value == SSL3_AL_WARNING) 419 if (value == SSL3_AL_WARNING)
@@ -424,8 +424,8 @@ const char
424 return("unknown"); 424 return("unknown");
425} 425}
426 426
427const char 427const char *
428*SSL_alert_type_string(int value) 428SSL_alert_type_string(int value)
429{ 429{
430 value>>=8; 430 value>>=8;
431 if (value == SSL3_AL_WARNING) 431 if (value == SSL3_AL_WARNING)
@@ -436,8 +436,8 @@ const char
436 return("U"); 436 return("U");
437} 437}
438 438
439const char 439const char *
440*SSL_alert_desc_string(int value) 440SSL_alert_desc_string(int value)
441{ 441{
442 const char *str; 442 const char *str;
443 443
@@ -508,8 +508,8 @@ const char
508 return (str); 508 return (str);
509} 509}
510 510
511const char 511const char *
512*SSL_alert_desc_string_long(int value) 512SSL_alert_desc_string_long(int value)
513{ 513{
514 const char *str; 514 const char *str;
515 515
@@ -610,8 +610,8 @@ const char
610 return (str); 610 return (str);
611} 611}
612 612
613const char 613const char *
614*SSL_rstate_string(const SSL *s) 614SSL_rstate_string(const SSL *s)
615{ 615{
616 const char *str; 616 const char *str;
617 617
diff --git a/src/lib/libssl/t1_clnt.c b/src/lib/libssl/t1_clnt.c
index ac8ff7309f..fa333259ae 100644
--- a/src/lib/libssl/t1_clnt.c
+++ b/src/lib/libssl/t1_clnt.c
@@ -65,16 +65,16 @@
65 65
66static const SSL_METHOD *tls1_get_client_method(int ver); 66static const SSL_METHOD *tls1_get_client_method(int ver);
67 67
68static const SSL_METHOD 68static const SSL_METHOD *
69*tls1_get_client_method(int ver) 69tls1_get_client_method(int ver)
70{ 70{
71 if (ver == TLS1_2_VERSION) 71 if (ver == TLS1_2_VERSION)
72 return TLSv1_2_client_method(); 72 return (TLSv1_2_client_method());
73 if (ver == TLS1_1_VERSION) 73 if (ver == TLS1_1_VERSION)
74 return TLSv1_1_client_method(); 74 return (TLSv1_1_client_method());
75 if (ver == TLS1_VERSION) 75 if (ver == TLS1_VERSION)
76 return TLSv1_client_method(); 76 return (TLSv1_client_method());
77 return NULL; 77 return (NULL);
78} 78}
79 79
80IMPLEMENT_tls_meth_func(TLS1_2_VERSION, TLSv1_2_client_method, 80IMPLEMENT_tls_meth_func(TLS1_2_VERSION, TLSv1_2_client_method,
diff --git a/src/lib/libssl/t1_lib.c b/src/lib/libssl/t1_lib.c
index f6cfb508f6..85d0fa4970 100644
--- a/src/lib/libssl/t1_lib.c
+++ b/src/lib/libssl/t1_lib.c
@@ -343,8 +343,8 @@ tls12_get_req_sig_algs(SSL *s, unsigned char *p)
343 return (int)slen; 343 return (int)slen;
344} 344}
345 345
346unsigned char 346unsigned char *
347*ssl_add_clienthello_tlsext(SSL *s, unsigned char *p, unsigned char *limit) 347ssl_add_clienthello_tlsext(SSL *s, unsigned char *p, unsigned char *limit)
348{ 348{
349 int extdatalen = 0; 349 int extdatalen = 0;
350 unsigned char *ret = p; 350 unsigned char *ret = p;
@@ -671,8 +671,8 @@ skip_ext:
671 return ret; 671 return ret;
672} 672}
673 673
674unsigned char 674unsigned char *
675*ssl_add_serverhello_tlsext(SSL *s, unsigned char *p, unsigned char *limit) 675ssl_add_serverhello_tlsext(SSL *s, unsigned char *p, unsigned char *limit)
676{ 676{
677 int extdatalen = 0; 677 int extdatalen = 0;
678 unsigned char *ret = p; 678 unsigned char *ret = p;
@@ -2249,8 +2249,8 @@ tls12_get_sigid(const EVP_PKEY *pk)
2249 sizeof(tls12_sig)/sizeof(tls12_lookup)); 2249 sizeof(tls12_sig)/sizeof(tls12_lookup));
2250} 2250}
2251 2251
2252const EVP_MD 2252const EVP_MD *
2253*tls12_get_hash(unsigned char hash_alg) 2253tls12_get_hash(unsigned char hash_alg)
2254{ 2254{
2255 switch (hash_alg) { 2255 switch (hash_alg) {
2256 case TLSEXT_hash_sha1: 2256 case TLSEXT_hash_sha1:
diff --git a/src/lib/libssl/t1_meth.c b/src/lib/libssl/t1_meth.c
index ab2d789e59..cf62fe5c3d 100644
--- a/src/lib/libssl/t1_meth.c
+++ b/src/lib/libssl/t1_meth.c
@@ -60,16 +60,16 @@
60#include <openssl/objects.h> 60#include <openssl/objects.h>
61#include "ssl_locl.h" 61#include "ssl_locl.h"
62 62
63static const SSL_METHOD 63static const SSL_METHOD *
64*tls1_get_method(int ver) 64tls1_get_method(int ver)
65{ 65{
66 if (ver == TLS1_2_VERSION) 66 if (ver == TLS1_2_VERSION)
67 return TLSv1_2_method(); 67 return (TLSv1_2_method());
68 if (ver == TLS1_1_VERSION) 68 if (ver == TLS1_1_VERSION)
69 return TLSv1_1_method(); 69 return (TLSv1_1_method());
70 if (ver == TLS1_VERSION) 70 if (ver == TLS1_VERSION)
71 return TLSv1_method(); 71 return (TLSv1_method());
72 return NULL; 72 return (NULL);
73} 73}
74 74
75IMPLEMENT_tls_meth_func(TLS1_2_VERSION, TLSv1_2_method, 75IMPLEMENT_tls_meth_func(TLS1_2_VERSION, TLSv1_2_method,
diff --git a/src/lib/libssl/t1_srvr.c b/src/lib/libssl/t1_srvr.c
index 776bcabc46..c0d186e425 100644
--- a/src/lib/libssl/t1_srvr.c
+++ b/src/lib/libssl/t1_srvr.c
@@ -66,16 +66,16 @@
66 66
67static const SSL_METHOD *tls1_get_server_method(int ver); 67static const SSL_METHOD *tls1_get_server_method(int ver);
68 68
69static const SSL_METHOD 69static const SSL_METHOD *
70*tls1_get_server_method(int ver) 70tls1_get_server_method(int ver)
71{ 71{
72 if (ver == TLS1_2_VERSION) 72 if (ver == TLS1_2_VERSION)
73 return TLSv1_2_server_method(); 73 return (TLSv1_2_server_method());
74 if (ver == TLS1_1_VERSION) 74 if (ver == TLS1_1_VERSION)
75 return TLSv1_1_server_method(); 75 return (TLSv1_1_server_method());
76 if (ver == TLS1_VERSION) 76 if (ver == TLS1_VERSION)
77 return TLSv1_server_method(); 77 return (TLSv1_server_method());
78 return NULL; 78 return (NULL);
79} 79}
80 80
81IMPLEMENT_tls_meth_func(TLS1_2_VERSION, TLSv1_2_server_method, 81IMPLEMENT_tls_meth_func(TLS1_2_VERSION, TLSv1_2_server_method,