diff options
author | mmcc <> | 2015-12-28 22:08:18 +0000 |
---|---|---|
committer | mmcc <> | 2015-12-28 22:08:18 +0000 |
commit | 9e67b1ca8fdb8e810325cc171f048a1d4c4648e9 (patch) | |
tree | 1860cbfc8bdfdfe53a1d01eda36d86441b206e73 /src | |
parent | e487dc535564430c2d0a72004b0f1100261d25a4 (diff) | |
download | openbsd-9e67b1ca8fdb8e810325cc171f048a1d4c4648e9.tar.gz openbsd-9e67b1ca8fdb8e810325cc171f048a1d4c4648e9.tar.bz2 openbsd-9e67b1ca8fdb8e810325cc171f048a1d4c4648e9.zip |
Remove NULL-checks before free() and a few related dead assignments.
ok and valuable input from millert@
Diffstat (limited to 'src')
-rw-r--r-- | src/lib/libc/net/freeaddrinfo.c | 5 | ||||
-rw-r--r-- | src/lib/libc/stdlib/ecvt.c | 8 |
2 files changed, 5 insertions, 8 deletions
diff --git a/src/lib/libc/net/freeaddrinfo.c b/src/lib/libc/net/freeaddrinfo.c index 5efb97db92..2ac84a31f3 100644 --- a/src/lib/libc/net/freeaddrinfo.c +++ b/src/lib/libc/net/freeaddrinfo.c | |||
@@ -1,4 +1,4 @@ | |||
1 | /* $OpenBSD: freeaddrinfo.c,v 1.7 2015/09/14 07:38:38 guenther Exp $ */ | 1 | /* $OpenBSD: freeaddrinfo.c,v 1.8 2015/12/28 22:08:18 mmcc Exp $ */ |
2 | 2 | ||
3 | /* | 3 | /* |
4 | * Copyright (c) 1996, 1997, 1998, 1999, Craig Metz, All rights reserved. | 4 | * Copyright (c) 1996, 1997, 1998, 1999, Craig Metz, All rights reserved. |
@@ -43,8 +43,7 @@ freeaddrinfo(struct addrinfo *ai) | |||
43 | do { | 43 | do { |
44 | p = ai; | 44 | p = ai; |
45 | ai = ai->ai_next; | 45 | ai = ai->ai_next; |
46 | if (p->ai_canonname) | 46 | free(p->ai_canonname); |
47 | free(p->ai_canonname); | ||
48 | free((void *)p); | 47 | free((void *)p); |
49 | } while (ai); | 48 | } while (ai); |
50 | } | 49 | } |
diff --git a/src/lib/libc/stdlib/ecvt.c b/src/lib/libc/stdlib/ecvt.c index a0bbbec073..dfcf45fe6c 100644 --- a/src/lib/libc/stdlib/ecvt.c +++ b/src/lib/libc/stdlib/ecvt.c | |||
@@ -1,4 +1,4 @@ | |||
1 | /* $OpenBSD: ecvt.c,v 1.9 2015/08/20 21:49:29 deraadt Exp $ */ | 1 | /* $OpenBSD: ecvt.c,v 1.10 2015/12/28 22:08:18 mmcc Exp $ */ |
2 | 2 | ||
3 | /* | 3 | /* |
4 | * Copyright (c) 2002, 2006 Todd C. Miller <Todd.Miller@courtesan.com> | 4 | * Copyright (c) 2002, 2006 Todd C. Miller <Todd.Miller@courtesan.com> |
@@ -40,10 +40,8 @@ __cvt(double value, int ndigit, int *decpt, int *sign, int fmode, int pad) | |||
40 | return (""); | 40 | return (""); |
41 | } | 41 | } |
42 | 42 | ||
43 | if (s) { | 43 | free(s); |
44 | free(s); | 44 | s = NULL; |
45 | s = NULL; | ||
46 | } | ||
47 | 45 | ||
48 | if (ndigit < 0) | 46 | if (ndigit < 0) |
49 | siz = -ndigit + 1; | 47 | siz = -ndigit + 1; |