summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authortb <>2024-12-10 08:43:17 +0000
committertb <>2024-12-10 08:43:17 +0000
commita28d0e7a9f7ed16331aba8ac0879a39feecc3f60 (patch)
tree7e846147638ae2a5a5cc0748d2e26e0a22efefcc /src
parentaef083f7c077d78ca91f506558203279c7aa7309 (diff)
downloadopenbsd-a28d0e7a9f7ed16331aba8ac0879a39feecc3f60.tar.gz
openbsd-a28d0e7a9f7ed16331aba8ac0879a39feecc3f60.tar.bz2
openbsd-a28d0e7a9f7ed16331aba8ac0879a39feecc3f60.zip
Add regress coverage for tls_peer_cert_common_name()
Diffstat (limited to 'src')
-rw-r--r--src/regress/lib/libtls/gotls/tls.go9
-rw-r--r--src/regress/lib/libtls/gotls/tls_test.go8
2 files changed, 17 insertions, 0 deletions
diff --git a/src/regress/lib/libtls/gotls/tls.go b/src/regress/lib/libtls/gotls/tls.go
index cf3e84c030..3601828884 100644
--- a/src/regress/lib/libtls/gotls/tls.go
+++ b/src/regress/lib/libtls/gotls/tls.go
@@ -202,6 +202,15 @@ func (t *TLS) PeerCertIssuer() (string, error) {
202 return C.GoString(issuer), nil 202 return C.GoString(issuer), nil
203} 203}
204 204
205// PeerCertCommonName returns the common name of the peer certificate.
206func (t *TLS) PeerCertCommonName() (string, error) {
207 commonName := C.tls_peer_cert_common_name(t.ctx)
208 if commonName == nil {
209 return "", errors.New("no peer cert common name returned")
210 }
211 return C.GoString(commonName), nil
212}
213
205// PeerCertSubject returns the subject of the peer certificate. 214// PeerCertSubject returns the subject of the peer certificate.
206func (t *TLS) PeerCertSubject() (string, error) { 215func (t *TLS) PeerCertSubject() (string, error) {
207 subject := C.tls_peer_cert_subject(t.ctx) 216 subject := C.tls_peer_cert_subject(t.ctx)
diff --git a/src/regress/lib/libtls/gotls/tls_test.go b/src/regress/lib/libtls/gotls/tls_test.go
index 2b7ce2c19e..20240e0580 100644
--- a/src/regress/lib/libtls/gotls/tls_test.go
+++ b/src/regress/lib/libtls/gotls/tls_test.go
@@ -418,6 +418,9 @@ func TestTLSInfo(t *testing.T) {
418 if _, err := tls.PeerCertSubject(); err == nil { 418 if _, err := tls.PeerCertSubject(); err == nil {
419 t.Error("PeerCertSubject() returned nil error, want error") 419 t.Error("PeerCertSubject() returned nil error, want error")
420 } 420 }
421 if _, err := tls.PeerCertCommonName(); err == nil {
422 t.Error("PeerCertCommonName() returned nil error, want error")
423 }
421 if _, err := tls.PeerCertHash(); err == nil { 424 if _, err := tls.PeerCertHash(); err == nil {
422 t.Error("PeerCertHash() returned nil error, want error") 425 t.Error("PeerCertHash() returned nil error, want error")
423 } 426 }
@@ -468,6 +471,11 @@ func TestTLSInfo(t *testing.T) {
468 } else { 471 } else {
469 t.Logf("Subject: %v", subject) 472 t.Logf("Subject: %v", subject)
470 } 473 }
474 if commonName, err := tls.PeerCertCommonName(); err != nil {
475 t.Errorf("PeerCertCommonName() returned error: %v", err)
476 } else {
477 t.Logf("Subject: %v", commonName)
478 }
471 if hash, err := tls.PeerCertHash(); err != nil { 479 if hash, err := tls.PeerCertHash(); err != nil {
472 t.Errorf("PeerCertHash() returned error: %v", err) 480 t.Errorf("PeerCertHash() returned error: %v", err)
473 } else if hash != certHash { 481 } else if hash != certHash {