summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authordoug <>2015-04-29 01:39:32 +0000
committerdoug <>2015-04-29 01:39:32 +0000
commitad295b09e02c647432a14dd6245cf051f32da8f1 (patch)
tree2a6d610cc61538bdb4ea332b70710288962df060 /src
parent13d43193f71b7edb914494bf473db7b23b1bd381 (diff)
downloadopenbsd-ad295b09e02c647432a14dd6245cf051f32da8f1.tar.gz
openbsd-ad295b09e02c647432a14dd6245cf051f32da8f1.tar.bz2
openbsd-ad295b09e02c647432a14dd6245cf051f32da8f1.zip
Added len_len error checking for internal cbb_buffer_add_u().
ok jsing@
Diffstat (limited to 'src')
-rw-r--r--src/lib/libssl/bs_cbb.c5
-rw-r--r--src/lib/libssl/src/ssl/bs_cbb.c5
2 files changed, 8 insertions, 2 deletions
diff --git a/src/lib/libssl/bs_cbb.c b/src/lib/libssl/bs_cbb.c
index 5546fac97f..7f0e474ded 100644
--- a/src/lib/libssl/bs_cbb.c
+++ b/src/lib/libssl/bs_cbb.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: bs_cbb.c,v 1.5 2015/02/07 06:10:32 doug Exp $ */ 1/* $OpenBSD: bs_cbb.c,v 1.6 2015/04/29 01:39:32 doug Exp $ */
2/* 2/*
3 * Copyright (c) 2014, Google Inc. 3 * Copyright (c) 2014, Google Inc.
4 * 4 *
@@ -127,6 +127,9 @@ cbb_buffer_add_u(struct cbb_buffer_st *base, uint32_t v, size_t len_len)
127 if (len_len == 0) 127 if (len_len == 0)
128 return 1; 128 return 1;
129 129
130 if (len_len > 4)
131 return 0;
132
130 if (!cbb_buffer_add(base, &buf, len_len)) 133 if (!cbb_buffer_add(base, &buf, len_len))
131 return 0; 134 return 0;
132 135
diff --git a/src/lib/libssl/src/ssl/bs_cbb.c b/src/lib/libssl/src/ssl/bs_cbb.c
index 5546fac97f..7f0e474ded 100644
--- a/src/lib/libssl/src/ssl/bs_cbb.c
+++ b/src/lib/libssl/src/ssl/bs_cbb.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: bs_cbb.c,v 1.5 2015/02/07 06:10:32 doug Exp $ */ 1/* $OpenBSD: bs_cbb.c,v 1.6 2015/04/29 01:39:32 doug Exp $ */
2/* 2/*
3 * Copyright (c) 2014, Google Inc. 3 * Copyright (c) 2014, Google Inc.
4 * 4 *
@@ -127,6 +127,9 @@ cbb_buffer_add_u(struct cbb_buffer_st *base, uint32_t v, size_t len_len)
127 if (len_len == 0) 127 if (len_len == 0)
128 return 1; 128 return 1;
129 129
130 if (len_len > 4)
131 return 0;
132
130 if (!cbb_buffer_add(base, &buf, len_len)) 133 if (!cbb_buffer_add(base, &buf, len_len))
131 return 0; 134 return 0;
132 135