diff options
author | tb <> | 2024-01-27 17:20:20 +0000 |
---|---|---|
committer | tb <> | 2024-01-27 17:20:20 +0000 |
commit | b7d6d9e4cc18d54b64c1ade2d9e658dd3a7164fe (patch) | |
tree | ce10c04663c5213fecb9d331c08f824f44e2063f /src | |
parent | 282547129442bcb72f9be8786b1c02a10cfc330d (diff) | |
download | openbsd-b7d6d9e4cc18d54b64c1ade2d9e658dd3a7164fe.tar.gz openbsd-b7d6d9e4cc18d54b64c1ade2d9e658dd3a7164fe.tar.bz2 openbsd-b7d6d9e4cc18d54b64c1ade2d9e658dd3a7164fe.zip |
Use ret instead of rv in a few keyivgen functions
Diffstat (limited to 'src')
-rw-r--r-- | src/lib/libcrypto/evp/evp_pbe.c | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/src/lib/libcrypto/evp/evp_pbe.c b/src/lib/libcrypto/evp/evp_pbe.c index dd06a768b3..d34fc7053e 100644 --- a/src/lib/libcrypto/evp/evp_pbe.c +++ b/src/lib/libcrypto/evp/evp_pbe.c | |||
@@ -1,4 +1,4 @@ | |||
1 | /* $OpenBSD: evp_pbe.c,v 1.39 2024/01/27 17:14:33 tb Exp $ */ | 1 | /* $OpenBSD: evp_pbe.c,v 1.40 2024/01/27 17:20:20 tb Exp $ */ |
2 | /* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL | 2 | /* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL |
3 | * project 1999. | 3 | * project 1999. |
4 | */ | 4 | */ |
@@ -352,7 +352,7 @@ PKCS5_PBE_keyivgen(EVP_CIPHER_CTX *cctx, const char *pass, int passlen, | |||
352 | unsigned char *salt; | 352 | unsigned char *salt; |
353 | const unsigned char *pbuf; | 353 | const unsigned char *pbuf; |
354 | int mdsize; | 354 | int mdsize; |
355 | int rv = 0; | 355 | int ret = 0; |
356 | 356 | ||
357 | /* Extract useful info from parameter */ | 357 | /* Extract useful info from parameter */ |
358 | if (param == NULL || param->type != V_ASN1_SEQUENCE || | 358 | if (param == NULL || param->type != V_ASN1_SEQUENCE || |
@@ -421,12 +421,13 @@ PKCS5_PBE_keyivgen(EVP_CIPHER_CTX *cctx, const char *pass, int passlen, | |||
421 | explicit_bzero(key, EVP_MAX_KEY_LENGTH); | 421 | explicit_bzero(key, EVP_MAX_KEY_LENGTH); |
422 | explicit_bzero(iv, EVP_MAX_IV_LENGTH); | 422 | explicit_bzero(iv, EVP_MAX_IV_LENGTH); |
423 | 423 | ||
424 | rv = 1; | 424 | ret = 1; |
425 | |||
425 | err: | 426 | err: |
426 | EVP_MD_CTX_cleanup(&ctx); | 427 | EVP_MD_CTX_cleanup(&ctx); |
427 | PBEPARAM_free(pbe); | 428 | PBEPARAM_free(pbe); |
428 | 429 | ||
429 | return rv; | 430 | return ret; |
430 | } | 431 | } |
431 | 432 | ||
432 | /* | 433 | /* |
@@ -528,8 +529,7 @@ PKCS5_v2_PBE_keyivgen(EVP_CIPHER_CTX *ctx, const char *pass, int passlen, | |||
528 | int plen; | 529 | int plen; |
529 | PBE2PARAM *pbe2 = NULL; | 530 | PBE2PARAM *pbe2 = NULL; |
530 | const EVP_CIPHER *cipher; | 531 | const EVP_CIPHER *cipher; |
531 | 532 | int ret = 0; | |
532 | int rv = 0; | ||
533 | 533 | ||
534 | if (param == NULL || param->type != V_ASN1_SEQUENCE || | 534 | if (param == NULL || param->type != V_ASN1_SEQUENCE || |
535 | param->value.sequence == NULL) { | 535 | param->value.sequence == NULL) { |
@@ -566,13 +566,13 @@ PKCS5_v2_PBE_keyivgen(EVP_CIPHER_CTX *ctx, const char *pass, int passlen, | |||
566 | goto err; | 566 | goto err; |
567 | } | 567 | } |
568 | 568 | ||
569 | rv = PKCS5_v2_PBKDF2_keyivgen(ctx, pass, passlen, | 569 | ret = PKCS5_v2_PBKDF2_keyivgen(ctx, pass, passlen, |
570 | pbe2->keyfunc->parameter, c, md, en_de); | 570 | pbe2->keyfunc->parameter, c, md, en_de); |
571 | 571 | ||
572 | err: | 572 | err: |
573 | PBE2PARAM_free(pbe2); | 573 | PBE2PARAM_free(pbe2); |
574 | 574 | ||
575 | return rv; | 575 | return ret; |
576 | } | 576 | } |
577 | 577 | ||
578 | int | 578 | int |
@@ -582,11 +582,11 @@ PKCS5_v2_PBKDF2_keyivgen(EVP_CIPHER_CTX *ctx, const char *pass, int passlen, | |||
582 | unsigned char *salt, key[EVP_MAX_KEY_LENGTH]; | 582 | unsigned char *salt, key[EVP_MAX_KEY_LENGTH]; |
583 | const unsigned char *pbuf; | 583 | const unsigned char *pbuf; |
584 | int saltlen, iter, plen; | 584 | int saltlen, iter, plen; |
585 | int rv = 0; | ||
586 | unsigned int keylen = 0; | 585 | unsigned int keylen = 0; |
587 | int prf_nid, hmac_md_nid; | 586 | int prf_nid, hmac_md_nid; |
588 | PBKDF2PARAM *kdf = NULL; | 587 | PBKDF2PARAM *kdf = NULL; |
589 | const EVP_MD *prfmd; | 588 | const EVP_MD *prfmd; |
589 | int ret = 0; | ||
590 | 590 | ||
591 | if (EVP_CIPHER_CTX_cipher(ctx) == NULL) { | 591 | if (EVP_CIPHER_CTX_cipher(ctx) == NULL) { |
592 | EVPerror(EVP_R_NO_CIPHER_SET); | 592 | EVPerror(EVP_R_NO_CIPHER_SET); |
@@ -653,13 +653,13 @@ PKCS5_v2_PBKDF2_keyivgen(EVP_CIPHER_CTX *ctx, const char *pass, int passlen, | |||
653 | keylen, key)) | 653 | keylen, key)) |
654 | goto err; | 654 | goto err; |
655 | 655 | ||
656 | rv = EVP_CipherInit_ex(ctx, NULL, NULL, key, NULL, en_de); | 656 | ret = EVP_CipherInit_ex(ctx, NULL, NULL, key, NULL, en_de); |
657 | 657 | ||
658 | err: | 658 | err: |
659 | explicit_bzero(key, keylen); | 659 | explicit_bzero(key, keylen); |
660 | PBKDF2PARAM_free(kdf); | 660 | PBKDF2PARAM_free(kdf); |
661 | 661 | ||
662 | return rv; | 662 | return ret; |
663 | } | 663 | } |
664 | 664 | ||
665 | void | 665 | void |