summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorjsing <>2018-01-27 15:17:13 +0000
committerjsing <>2018-01-27 15:17:13 +0000
commitcccafe604becdfd2326c3f4d1c5664d824934cb4 (patch)
tree0c80175f4743f67480fff4d6159e036922738365 /src
parent6c88052565f5aa652eb289ad03c924a369d18397 (diff)
downloadopenbsd-cccafe604becdfd2326c3f4d1c5664d824934cb4.tar.gz
openbsd-cccafe604becdfd2326c3f4d1c5664d824934cb4.tar.bz2
openbsd-cccafe604becdfd2326c3f4d1c5664d824934cb4.zip
Clarify the comment re the F5 EC curves extension bug.
Also reference the knowledge base article instead of a discussion thread.
Diffstat (limited to 'src')
-rw-r--r--src/lib/libssl/ssl_tlsext.c11
1 files changed, 6 insertions, 5 deletions
diff --git a/src/lib/libssl/ssl_tlsext.c b/src/lib/libssl/ssl_tlsext.c
index d43ebc6775..d0764af3c0 100644
--- a/src/lib/libssl/ssl_tlsext.c
+++ b/src/lib/libssl/ssl_tlsext.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: ssl_tlsext.c,v 1.18 2017/11/28 16:46:14 jsing Exp $ */ 1/* $OpenBSD: ssl_tlsext.c,v 1.19 2018/01/27 15:17:13 jsing Exp $ */
2/* 2/*
3 * Copyright (c) 2016, 2017 Joel Sing <jsing@openbsd.org> 3 * Copyright (c) 2016, 2017 Joel Sing <jsing@openbsd.org>
4 * Copyright (c) 2017 Doug Hogan <doug@openbsd.org> 4 * Copyright (c) 2017 Doug Hogan <doug@openbsd.org>
@@ -271,11 +271,12 @@ tlsext_ec_serverhello_parse(SSL *s, CBS *cbs, int *alert)
271 /* 271 /*
272 * Servers should not send this extension per the RFC. 272 * Servers should not send this extension per the RFC.
273 * 273 *
274 * However, F5 sends it by mistake (case ID 492780) so we need to skip 274 * However, certain F5 BIG-IP systems incorrectly send it. This bug is
275 * over it. This bug is from at least 2014 but as of 2017, there 275 * from at least 2014 but as of 2017, there are still large sites with
276 * are still large sites with this bug in production. 276 * this unpatched in production. As a result, we need to currently skip
277 * over the extension and ignore its content:
277 * 278 *
278 * https://devcentral.f5.com/questions/disable-supported-elliptic-curves-extension-from-server 279 * https://support.f5.com/csp/article/K37345003
279 */ 280 */
280 if (!CBS_skip(cbs, CBS_len(cbs))) { 281 if (!CBS_skip(cbs, CBS_len(cbs))) {
281 *alert = TLS1_AD_INTERNAL_ERROR; 282 *alert = TLS1_AD_INTERNAL_ERROR;