summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorjsing <>2014-12-07 16:01:03 +0000
committerjsing <>2014-12-07 16:01:03 +0000
commitd0bbacc151e9bccff4588511de44901a286322c2 (patch)
treeaa08125f3c571efbb22317034d28a793137ecd5d /src
parent7b2dca192e4d7b709c9f3f00542509fcd3b58b39 (diff)
downloadopenbsd-d0bbacc151e9bccff4588511de44901a286322c2.tar.gz
openbsd-d0bbacc151e9bccff4588511de44901a286322c2.tar.bz2
openbsd-d0bbacc151e9bccff4588511de44901a286322c2.zip
Fix a memory leak in tls_check_subject_altname() by calling
sk_GENERAL_NAME_pop_free() instead of sk_GENERAL_NAME_free(). The latter only frees the stack itself and does not free the items. From Basskrapfen on github.
Diffstat (limited to 'src')
-rw-r--r--src/lib/libtls/tls_verify.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/libtls/tls_verify.c b/src/lib/libtls/tls_verify.c
index 35a18202a9..ddc403fb10 100644
--- a/src/lib/libtls/tls_verify.c
+++ b/src/lib/libtls/tls_verify.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: tls_verify.c,v 1.3 2014/12/07 15:48:02 bcook Exp $ */ 1/* $OpenBSD: tls_verify.c,v 1.4 2014/12/07 16:01:03 jsing Exp $ */
2/* 2/*
3 * Copyright (c) 2014 Jeremie Courreges-Anglas <jca@openbsd.org> 3 * Copyright (c) 2014 Jeremie Courreges-Anglas <jca@openbsd.org>
4 * 4 *
@@ -155,7 +155,7 @@ tls_check_subject_altname(X509 *cert, const char *host)
155 } 155 }
156 } 156 }
157 157
158 sk_GENERAL_NAME_free(altname_stack); 158 sk_GENERAL_NAME_pop_free(altname_stack, GENERAL_NAME_free);
159 return rv; 159 return rv;
160} 160}
161 161