summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authortb <>2024-10-16 23:58:25 +0000
committertb <>2024-10-16 23:58:25 +0000
commitd11f92ed77a84750d747201a5ebdf6e31f5d11e7 (patch)
tree4111310b6286afb6e9a3172cb3709fed5eb00465 /src
parenta48647b52107fb4841167823522dcefbc307b626 (diff)
downloadopenbsd-d11f92ed77a84750d747201a5ebdf6e31f5d11e7.tar.gz
openbsd-d11f92ed77a84750d747201a5ebdf6e31f5d11e7.tar.bz2
openbsd-d11f92ed77a84750d747201a5ebdf6e31f5d11e7.zip
EC ASN.1: add reminder that the simple method might also want testing
Diffstat (limited to 'src')
-rw-r--r--src/regress/lib/libcrypto/ec/ec_asn1_test.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/src/regress/lib/libcrypto/ec/ec_asn1_test.c b/src/regress/lib/libcrypto/ec/ec_asn1_test.c
index cc0f0f46f4..171014bda7 100644
--- a/src/regress/lib/libcrypto/ec/ec_asn1_test.c
+++ b/src/regress/lib/libcrypto/ec/ec_asn1_test.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: ec_asn1_test.c,v 1.5 2024/10/16 23:49:49 tb Exp $ */ 1/* $OpenBSD: ec_asn1_test.c,v 1.6 2024/10/16 23:58:25 tb Exp $ */
2/* 2/*
3 * Copyright (c) 2017, 2021 Joel Sing <jsing@openbsd.org> 3 * Copyright (c) 2017, 2021 Joel Sing <jsing@openbsd.org>
4 * Copyright (c) 2024 Theo Buehler <tb@openbsd.org> 4 * Copyright (c) 2024 Theo Buehler <tb@openbsd.org>
@@ -458,6 +458,10 @@ ec_weierstrass25519(void)
458 if (BN_hex2bn(&b, wei25519.b) == 0) 458 if (BN_hex2bn(&b, wei25519.b) == 0)
459 errx(1, "BN_hex2bn(b)"); 459 errx(1, "BN_hex2bn(b)");
460 460
461 /*
462 * XXX - this uses the Montgomery method. Consider exercising the
463 * simple method as well.
464 */
461 if ((group = EC_GROUP_new_curve_GFp(p, a, b, ctx)) == NULL) { 465 if ((group = EC_GROUP_new_curve_GFp(p, a, b, ctx)) == NULL) {
462 fprintf(stderr, "FAIL: %s EC_GROUP_new_curve_GFp", __func__); 466 fprintf(stderr, "FAIL: %s EC_GROUP_new_curve_GFp", __func__);
463 goto err; 467 goto err;