summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authortedu <>2014-07-09 19:08:10 +0000
committertedu <>2014-07-09 19:08:10 +0000
commitef097ea5af990bd0eadae3434bcafd0a55d3cdfd (patch)
treef3911ecf54007d6e34b55ab97bf3bb62b1210a7a /src
parentf1e91c395f883599a7238064ecd4502e5e64a49e (diff)
downloadopenbsd-ef097ea5af990bd0eadae3434bcafd0a55d3cdfd.tar.gz
openbsd-ef097ea5af990bd0eadae3434bcafd0a55d3cdfd.tar.bz2
openbsd-ef097ea5af990bd0eadae3434bcafd0a55d3cdfd.zip
ocsp_check_ids says "If algoritm mismatch let caller deal with it" before
returning 2. The one and only caller doesn't check for that, so... Stop returning it. ok miod
Diffstat (limited to 'src')
-rw-r--r--src/lib/libcrypto/ocsp/ocsp_vfy.c7
-rw-r--r--src/lib/libssl/src/crypto/ocsp/ocsp_vfy.c7
2 files changed, 2 insertions, 12 deletions
diff --git a/src/lib/libcrypto/ocsp/ocsp_vfy.c b/src/lib/libcrypto/ocsp/ocsp_vfy.c
index 3d67f75460..b62394b765 100644
--- a/src/lib/libcrypto/ocsp/ocsp_vfy.c
+++ b/src/lib/libcrypto/ocsp/ocsp_vfy.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: ocsp_vfy.c,v 1.11 2014/06/12 15:49:30 deraadt Exp $ */ 1/* $OpenBSD: ocsp_vfy.c,v 1.12 2014/07/09 19:08:10 tedu Exp $ */
2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL 2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
3 * project 2000. 3 * project 2000.
4 */ 4 */
@@ -283,11 +283,6 @@ ocsp_check_ids(STACK_OF(OCSP_SINGLERESP) *sresp, OCSP_CERTID **ret)
283 tmpid = sk_OCSP_SINGLERESP_value(sresp, i)->certId; 283 tmpid = sk_OCSP_SINGLERESP_value(sresp, i)->certId;
284 /* Check to see if IDs match */ 284 /* Check to see if IDs match */
285 if (OCSP_id_issuer_cmp(cid, tmpid)) { 285 if (OCSP_id_issuer_cmp(cid, tmpid)) {
286 /* If algoritm mismatch let caller deal with it */
287 if (OBJ_cmp(tmpid->hashAlgorithm->algorithm,
288 cid->hashAlgorithm->algorithm))
289 return 2;
290 /* Else mismatch */
291 return 0; 286 return 0;
292 } 287 }
293 } 288 }
diff --git a/src/lib/libssl/src/crypto/ocsp/ocsp_vfy.c b/src/lib/libssl/src/crypto/ocsp/ocsp_vfy.c
index 3d67f75460..b62394b765 100644
--- a/src/lib/libssl/src/crypto/ocsp/ocsp_vfy.c
+++ b/src/lib/libssl/src/crypto/ocsp/ocsp_vfy.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: ocsp_vfy.c,v 1.11 2014/06/12 15:49:30 deraadt Exp $ */ 1/* $OpenBSD: ocsp_vfy.c,v 1.12 2014/07/09 19:08:10 tedu Exp $ */
2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL 2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
3 * project 2000. 3 * project 2000.
4 */ 4 */
@@ -283,11 +283,6 @@ ocsp_check_ids(STACK_OF(OCSP_SINGLERESP) *sresp, OCSP_CERTID **ret)
283 tmpid = sk_OCSP_SINGLERESP_value(sresp, i)->certId; 283 tmpid = sk_OCSP_SINGLERESP_value(sresp, i)->certId;
284 /* Check to see if IDs match */ 284 /* Check to see if IDs match */
285 if (OCSP_id_issuer_cmp(cid, tmpid)) { 285 if (OCSP_id_issuer_cmp(cid, tmpid)) {
286 /* If algoritm mismatch let caller deal with it */
287 if (OBJ_cmp(tmpid->hashAlgorithm->algorithm,
288 cid->hashAlgorithm->algorithm))
289 return 2;
290 /* Else mismatch */
291 return 0; 286 return 0;
292 } 287 }
293 } 288 }