summaryrefslogtreecommitdiff
path: root/src/lib
diff options
context:
space:
mode:
Diffstat (limited to 'src/lib')
-rw-r--r--src/lib/libcrypto/aes/aes_wrap.c6
-rw-r--r--src/lib/libcrypto/asn1/asn1_gen.c6
-rw-r--r--src/lib/libcrypto/asn1/bio_ndef.c3
-rw-r--r--src/lib/libcrypto/bn/bn_exp.c3
-rw-r--r--src/lib/libcrypto/bn/bn_gf2m.c15
-rw-r--r--src/lib/libcrypto/cms/cms_env.c3
-rw-r--r--src/lib/libcrypto/cms/cms_ess.c3
-rw-r--r--src/lib/libcrypto/cms/cms_sd.c3
-rw-r--r--src/lib/libcrypto/dh/dh_ameth.c3
-rw-r--r--src/lib/libcrypto/dh/dh_pmeth.c3
-rw-r--r--src/lib/libcrypto/dsa/dsa_ameth.c6
-rw-r--r--src/lib/libcrypto/dsa/dsa_pmeth.c3
-rw-r--r--src/lib/libcrypto/ec/ec_ameth.c3
-rw-r--r--src/lib/libcrypto/ec/ec_asn1.c12
-rw-r--r--src/lib/libcrypto/ecdh/ech_ossl.c2
-rw-r--r--src/lib/libcrypto/engine/eng_dyn.c3
-rw-r--r--src/lib/libcrypto/ex_data.c9
-rw-r--r--src/lib/libcrypto/pem/pvkfmt.c3
-rw-r--r--src/lib/libcrypto/pkcs7/pk7_doit.c3
-rw-r--r--src/lib/libcrypto/rsa/rsa_pss.c6
-rw-r--r--src/lib/libcrypto/stack/stack.c3
-rw-r--r--src/lib/libcrypto/store/str_mem.c2
-rw-r--r--src/lib/libcrypto/ui/ui_lib.c12
-rw-r--r--src/lib/libcrypto/x509v3/v3_conf.c3
-rw-r--r--src/lib/libcrypto/x509v3/v3_utl.c5
-rw-r--r--src/lib/libssl/src/apps/pkeyutl.c3
-rw-r--r--src/lib/libssl/src/crypto/aes/aes_wrap.c6
-rw-r--r--src/lib/libssl/src/crypto/asn1/asn1_gen.c6
-rw-r--r--src/lib/libssl/src/crypto/asn1/bio_ndef.c3
-rw-r--r--src/lib/libssl/src/crypto/bn/bn_exp.c3
-rw-r--r--src/lib/libssl/src/crypto/bn/bn_gf2m.c15
-rw-r--r--src/lib/libssl/src/crypto/cms/cms_env.c3
-rw-r--r--src/lib/libssl/src/crypto/cms/cms_ess.c3
-rw-r--r--src/lib/libssl/src/crypto/cms/cms_sd.c3
-rw-r--r--src/lib/libssl/src/crypto/dh/dh_ameth.c3
-rw-r--r--src/lib/libssl/src/crypto/dh/dh_pmeth.c3
-rw-r--r--src/lib/libssl/src/crypto/dsa/dsa_ameth.c6
-rw-r--r--src/lib/libssl/src/crypto/dsa/dsa_pmeth.c3
-rw-r--r--src/lib/libssl/src/crypto/ec/ec_ameth.c3
-rw-r--r--src/lib/libssl/src/crypto/ec/ec_asn1.c12
-rw-r--r--src/lib/libssl/src/crypto/ecdh/ech_ossl.c2
-rw-r--r--src/lib/libssl/src/crypto/engine/eng_dyn.c3
-rw-r--r--src/lib/libssl/src/crypto/ex_data.c9
-rw-r--r--src/lib/libssl/src/crypto/pem/pvkfmt.c3
-rw-r--r--src/lib/libssl/src/crypto/pkcs7/pk7_doit.c3
-rw-r--r--src/lib/libssl/src/crypto/rsa/rsa_pss.c6
-rw-r--r--src/lib/libssl/src/crypto/stack/stack.c3
-rw-r--r--src/lib/libssl/src/crypto/store/str_mem.c2
-rw-r--r--src/lib/libssl/src/crypto/ui/ui_lib.c12
-rw-r--r--src/lib/libssl/src/crypto/x509v3/v3_conf.c3
-rw-r--r--src/lib/libssl/src/crypto/x509v3/v3_utl.c5
51 files changed, 85 insertions, 164 deletions
diff --git a/src/lib/libcrypto/aes/aes_wrap.c b/src/lib/libcrypto/aes/aes_wrap.c
index 40533440bf..4a830da7e4 100644
--- a/src/lib/libcrypto/aes/aes_wrap.c
+++ b/src/lib/libcrypto/aes/aes_wrap.c
@@ -164,10 +164,8 @@ AES_wrap_unwrap_test(const unsigned char *kek, int keybits,
164 ret = 1; 164 ret = 1;
165 165
166err: 166err:
167 if (otmp) 167 free(otmp);
168 free(otmp); 168 free(ptmp);
169 if (ptmp)
170 free(ptmp);
171 169
172 return ret; 170 return ret;
173} 171}
diff --git a/src/lib/libcrypto/asn1/asn1_gen.c b/src/lib/libcrypto/asn1/asn1_gen.c
index 598a322242..7abbac6059 100644
--- a/src/lib/libcrypto/asn1/asn1_gen.c
+++ b/src/lib/libcrypto/asn1/asn1_gen.c
@@ -258,10 +258,8 @@ ASN1_generate_v3(char *str, X509V3_CTX *cnf)
258 ret = d2i_ASN1_TYPE(NULL, &cp, len); 258 ret = d2i_ASN1_TYPE(NULL, &cp, len);
259 259
260err: 260err:
261 if (orig_der) 261 free(orig_der);
262 free(orig_der); 262 free(new_der);
263 if (new_der)
264 free(new_der);
265 263
266 return ret; 264 return ret;
267} 265}
diff --git a/src/lib/libcrypto/asn1/bio_ndef.c b/src/lib/libcrypto/asn1/bio_ndef.c
index f00d38e5e4..66be025127 100644
--- a/src/lib/libcrypto/asn1/bio_ndef.c
+++ b/src/lib/libcrypto/asn1/bio_ndef.c
@@ -146,8 +146,7 @@ BIO_new_NDEF(BIO *out, ASN1_VALUE *val, const ASN1_ITEM *it)
146err: 146err:
147 if (asn_bio) 147 if (asn_bio)
148 BIO_free(asn_bio); 148 BIO_free(asn_bio);
149 if (ndef_aux) 149 free(ndef_aux);
150 free(ndef_aux);
151 return NULL; 150 return NULL;
152} 151}
153 152
diff --git a/src/lib/libcrypto/bn/bn_exp.c b/src/lib/libcrypto/bn/bn_exp.c
index 0e36e8d7b5..5d9263e01e 100644
--- a/src/lib/libcrypto/bn/bn_exp.c
+++ b/src/lib/libcrypto/bn/bn_exp.c
@@ -840,8 +840,7 @@ err:
840 BN_MONT_CTX_free(mont); 840 BN_MONT_CTX_free(mont);
841 if (powerbuf != NULL) { 841 if (powerbuf != NULL) {
842 OPENSSL_cleanse(powerbuf, powerbufLen); 842 OPENSSL_cleanse(powerbuf, powerbufLen);
843 if (powerbufFree) 843 free(powerbufFree);
844 free(powerbufFree);
845 } 844 }
846 BN_CTX_end(ctx); 845 BN_CTX_end(ctx);
847 return (ret); 846 return (ret);
diff --git a/src/lib/libcrypto/bn/bn_gf2m.c b/src/lib/libcrypto/bn/bn_gf2m.c
index 669f8c403e..4000fb8733 100644
--- a/src/lib/libcrypto/bn/bn_gf2m.c
+++ b/src/lib/libcrypto/bn/bn_gf2m.c
@@ -558,8 +558,7 @@ BN_GF2m_mod_mul(BIGNUM *r, const BIGNUM *a, const BIGNUM *b, const BIGNUM *p,
558 bn_check_top(r); 558 bn_check_top(r);
559 559
560err: 560err:
561 if (arr) 561 free(arr);
562 free(arr);
563 return ret; 562 return ret;
564} 563}
565 564
@@ -621,8 +620,7 @@ BN_GF2m_mod_sqr(BIGNUM *r, const BIGNUM *a, const BIGNUM *p, BN_CTX *ctx)
621 bn_check_top(r); 620 bn_check_top(r);
622 621
623err: 622err:
624 if (arr) 623 free(arr);
625 free(arr);
626 return ret; 624 return ret;
627} 625}
628 626
@@ -1050,8 +1048,7 @@ BN_GF2m_mod_exp(BIGNUM *r, const BIGNUM *a, const BIGNUM *b, const BIGNUM *p,
1050 bn_check_top(r); 1048 bn_check_top(r);
1051 1049
1052err: 1050err:
1053 if (arr) 1051 free(arr);
1054 free(arr);
1055 return ret; 1052 return ret;
1056} 1053}
1057 1054
@@ -1113,8 +1110,7 @@ BN_GF2m_mod_sqrt(BIGNUM *r, const BIGNUM *a, const BIGNUM *p, BN_CTX *ctx)
1113 bn_check_top(r); 1110 bn_check_top(r);
1114 1111
1115err: 1112err:
1116 if (arr) 1113 free(arr);
1117 free(arr);
1118 return ret; 1114 return ret;
1119} 1115}
1120 1116
@@ -1249,8 +1245,7 @@ BN_GF2m_mod_solve_quad(BIGNUM *r, const BIGNUM *a, const BIGNUM *p, BN_CTX *ctx)
1249 bn_check_top(r); 1245 bn_check_top(r);
1250 1246
1251err: 1247err:
1252 if (arr) 1248 free(arr);
1253 free(arr);
1254 return ret; 1249 return ret;
1255} 1250}
1256 1251
diff --git a/src/lib/libcrypto/cms/cms_env.c b/src/lib/libcrypto/cms/cms_env.c
index 78fa2aa7b7..5e6e7033b2 100644
--- a/src/lib/libcrypto/cms/cms_env.c
+++ b/src/lib/libcrypto/cms/cms_env.c
@@ -354,8 +354,7 @@ static int cms_RecipientInfo_ktri_encrypt(CMS_ContentInfo *cms,
354 err: 354 err:
355 if (pctx) 355 if (pctx)
356 EVP_PKEY_CTX_free(pctx); 356 EVP_PKEY_CTX_free(pctx);
357 if (ek) 357 free(ek);
358 free(ek);
359 return ret; 358 return ret;
360 359
361 } 360 }
diff --git a/src/lib/libcrypto/cms/cms_ess.c b/src/lib/libcrypto/cms/cms_ess.c
index 99a4da6356..8dbd56ef2b 100644
--- a/src/lib/libcrypto/cms/cms_ess.c
+++ b/src/lib/libcrypto/cms/cms_ess.c
@@ -156,8 +156,7 @@ int CMS_add1_ReceiptRequest(CMS_SignerInfo *si, CMS_ReceiptRequest *rr)
156 if (!r) 156 if (!r)
157 CMSerr(CMS_F_CMS_ADD1_RECEIPTREQUEST, ERR_R_MALLOC_FAILURE); 157 CMSerr(CMS_F_CMS_ADD1_RECEIPTREQUEST, ERR_R_MALLOC_FAILURE);
158 158
159 if (rrder) 159 free(rrder);
160 free(rrder);
161 160
162 return r; 161 return r;
163 162
diff --git a/src/lib/libcrypto/cms/cms_sd.c b/src/lib/libcrypto/cms/cms_sd.c
index d852af596d..976881743b 100644
--- a/src/lib/libcrypto/cms/cms_sd.c
+++ b/src/lib/libcrypto/cms/cms_sd.c
@@ -759,8 +759,7 @@ int CMS_SignerInfo_sign(CMS_SignerInfo *si)
759 return 1; 759 return 1;
760 760
761 err: 761 err:
762 if (abuf) 762 free(abuf);
763 free(abuf);
764 EVP_MD_CTX_cleanup(&mctx); 763 EVP_MD_CTX_cleanup(&mctx);
765 return 0; 764 return 0;
766 765
diff --git a/src/lib/libcrypto/dh/dh_ameth.c b/src/lib/libcrypto/dh/dh_ameth.c
index a22614ae0a..40e0202bff 100644
--- a/src/lib/libcrypto/dh/dh_ameth.c
+++ b/src/lib/libcrypto/dh/dh_ameth.c
@@ -167,8 +167,7 @@ static int dh_pub_encode(X509_PUBKEY *pk, const EVP_PKEY *pkey)
167 return 1; 167 return 1;
168 168
169 err: 169 err:
170 if (penc) 170 free(penc);
171 free(penc);
172 if (pval) 171 if (pval)
173 ASN1_STRING_free(pval); 172 ASN1_STRING_free(pval);
174 173
diff --git a/src/lib/libcrypto/dh/dh_pmeth.c b/src/lib/libcrypto/dh/dh_pmeth.c
index c359bb4d2b..c70feb3789 100644
--- a/src/lib/libcrypto/dh/dh_pmeth.c
+++ b/src/lib/libcrypto/dh/dh_pmeth.c
@@ -110,8 +110,7 @@ static int pkey_dh_copy(EVP_PKEY_CTX *dst, EVP_PKEY_CTX *src)
110static void pkey_dh_cleanup(EVP_PKEY_CTX *ctx) 110static void pkey_dh_cleanup(EVP_PKEY_CTX *ctx)
111 { 111 {
112 DH_PKEY_CTX *dctx = ctx->data; 112 DH_PKEY_CTX *dctx = ctx->data;
113 if (dctx) 113 free(dctx);
114 free(dctx);
115 } 114 }
116 115
117static int pkey_dh_ctrl(EVP_PKEY_CTX *ctx, int type, int p1, void *p2) 116static int pkey_dh_ctrl(EVP_PKEY_CTX *ctx, int type, int p1, void *p2)
diff --git a/src/lib/libcrypto/dsa/dsa_ameth.c b/src/lib/libcrypto/dsa/dsa_ameth.c
index ebca5ec5c5..16617d40f5 100644
--- a/src/lib/libcrypto/dsa/dsa_ameth.c
+++ b/src/lib/libcrypto/dsa/dsa_ameth.c
@@ -175,8 +175,7 @@ static int dsa_pub_encode(X509_PUBKEY *pk, const EVP_PKEY *pkey)
175 return 1; 175 return 1;
176 176
177 err: 177 err:
178 if (penc) 178 free(penc);
179 free(penc);
180 if (pval) 179 if (pval)
181 ASN1_STRING_free(pval); 180 ASN1_STRING_free(pval);
182 181
@@ -580,8 +579,7 @@ static int dsa_sig_print(BIO *bp, const X509_ALGOR *sigalg,
580 goto err; 579 goto err;
581 rv = 1; 580 rv = 1;
582 err: 581 err:
583 if (m) 582 free(m);
584 free(m);
585 DSA_SIG_free(dsa_sig); 583 DSA_SIG_free(dsa_sig);
586 return rv; 584 return rv;
587 } 585 }
diff --git a/src/lib/libcrypto/dsa/dsa_pmeth.c b/src/lib/libcrypto/dsa/dsa_pmeth.c
index 4e77c6f64b..a2b3b7f21a 100644
--- a/src/lib/libcrypto/dsa/dsa_pmeth.c
+++ b/src/lib/libcrypto/dsa/dsa_pmeth.c
@@ -113,8 +113,7 @@ static int pkey_dsa_copy(EVP_PKEY_CTX *dst, EVP_PKEY_CTX *src)
113static void pkey_dsa_cleanup(EVP_PKEY_CTX *ctx) 113static void pkey_dsa_cleanup(EVP_PKEY_CTX *ctx)
114 { 114 {
115 DSA_PKEY_CTX *dctx = ctx->data; 115 DSA_PKEY_CTX *dctx = ctx->data;
116 if (dctx) 116 free(dctx);
117 free(dctx);
118 } 117 }
119 118
120static int pkey_dsa_sign(EVP_PKEY_CTX *ctx, unsigned char *sig, size_t *siglen, 119static int pkey_dsa_sign(EVP_PKEY_CTX *ctx, unsigned char *sig, size_t *siglen,
diff --git a/src/lib/libcrypto/ec/ec_ameth.c b/src/lib/libcrypto/ec/ec_ameth.c
index 9b52c3cbfc..b41879c431 100644
--- a/src/lib/libcrypto/ec/ec_ameth.c
+++ b/src/lib/libcrypto/ec/ec_ameth.c
@@ -128,8 +128,7 @@ err:
128 ASN1_OBJECT_free(pval); 128 ASN1_OBJECT_free(pval);
129 else 129 else
130 ASN1_STRING_free(pval); 130 ASN1_STRING_free(pval);
131 if (penc) 131 free(penc);
132 free(penc);
133 return 0; 132 return 0;
134} 133}
135 134
diff --git a/src/lib/libcrypto/ec/ec_asn1.c b/src/lib/libcrypto/ec/ec_asn1.c
index 0ea0d6e2a4..2409cd0886 100644
--- a/src/lib/libcrypto/ec/ec_asn1.c
+++ b/src/lib/libcrypto/ec/ec_asn1.c
@@ -507,10 +507,8 @@ ec_asn1_group2curve(const EC_GROUP * group, X9_62_CURVE * curve)
507 507
508 ok = 1; 508 ok = 1;
509 509
510err: if (buffer_1) 510err: free(buffer_1);
511 free(buffer_1); 511 free(buffer_2);
512 if (buffer_2)
513 free(buffer_2);
514 if (tmp_1) 512 if (tmp_1)
515 BN_free(tmp_1); 513 BN_free(tmp_1);
516 if (tmp_2) 514 if (tmp_2)
@@ -610,8 +608,7 @@ err: if (!ok) {
610 } 608 }
611 if (tmp) 609 if (tmp)
612 BN_free(tmp); 610 BN_free(tmp);
613 if (buffer) 611 free(buffer);
614 free(buffer);
615 return (ret); 612 return (ret);
616} 613}
617 614
@@ -1134,8 +1131,7 @@ i2d_ECPrivateKey(EC_KEY * a, unsigned char **out)
1134 } 1131 }
1135 ok = 1; 1132 ok = 1;
1136err: 1133err:
1137 if (buffer) 1134 free(buffer);
1138 free(buffer);
1139 if (priv_key) 1135 if (priv_key)
1140 EC_PRIVATEKEY_free(priv_key); 1136 EC_PRIVATEKEY_free(priv_key);
1141 return (ok ? ret : 0); 1137 return (ok ? ret : 0);
diff --git a/src/lib/libcrypto/ecdh/ech_ossl.c b/src/lib/libcrypto/ecdh/ech_ossl.c
index 129475f7bb..0f4cdf056d 100644
--- a/src/lib/libcrypto/ecdh/ech_ossl.c
+++ b/src/lib/libcrypto/ecdh/ech_ossl.c
@@ -204,6 +204,6 @@ err:
204 if (tmp) EC_POINT_free(tmp); 204 if (tmp) EC_POINT_free(tmp);
205 if (ctx) BN_CTX_end(ctx); 205 if (ctx) BN_CTX_end(ctx);
206 if (ctx) BN_CTX_free(ctx); 206 if (ctx) BN_CTX_free(ctx);
207 if (buf) free(buf); 207 free(buf);
208 return(ret); 208 return(ret);
209 } 209 }
diff --git a/src/lib/libcrypto/engine/eng_dyn.c b/src/lib/libcrypto/engine/eng_dyn.c
index 7878bd802e..f59d768350 100644
--- a/src/lib/libcrypto/engine/eng_dyn.c
+++ b/src/lib/libcrypto/engine/eng_dyn.c
@@ -222,8 +222,7 @@ static int dynamic_set_data_ctx(ENGINE *e, dynamic_data_ctx **ctx)
222 CRYPTO_w_unlock(CRYPTO_LOCK_ENGINE); 222 CRYPTO_w_unlock(CRYPTO_LOCK_ENGINE);
223 /* If we lost the race to set the context, c is non-NULL and *ctx is the 223 /* If we lost the race to set the context, c is non-NULL and *ctx is the
224 * context of the thread that won. */ 224 * context of the thread that won. */
225 if(c) 225 free(c);
226 free(c);
227 return 1; 226 return 1;
228 } 227 }
229 228
diff --git a/src/lib/libcrypto/ex_data.c b/src/lib/libcrypto/ex_data.c
index 77a91c4b04..d8d25d320e 100644
--- a/src/lib/libcrypto/ex_data.c
+++ b/src/lib/libcrypto/ex_data.c
@@ -444,8 +444,7 @@ skip:
444 storage[i]->argl, storage[i]->argp); 444 storage[i]->argl, storage[i]->argp);
445 } 445 }
446 } 446 }
447 if (storage) 447 free(storage);
448 free(storage);
449 return 1; 448 return 1;
450} 449}
451 450
@@ -489,8 +488,7 @@ skip:
489 storage[i]->argl, storage[i]->argp); 488 storage[i]->argl, storage[i]->argp);
490 CRYPTO_set_ex_data(to, i, ptr); 489 CRYPTO_set_ex_data(to, i, ptr);
491 } 490 }
492 if (storage) 491 free(storage);
493 free(storage);
494 return 1; 492 return 1;
495} 493}
496 494
@@ -527,8 +525,7 @@ skip:
527 storage[i]->argl, storage[i]->argp); 525 storage[i]->argl, storage[i]->argp);
528 } 526 }
529 } 527 }
530 if (storage) 528 free(storage);
531 free(storage);
532 if (ad->sk) { 529 if (ad->sk) {
533 sk_void_free(ad->sk); 530 sk_void_free(ad->sk);
534 ad->sk = NULL; 531 ad->sk = NULL;
diff --git a/src/lib/libcrypto/pem/pvkfmt.c b/src/lib/libcrypto/pem/pvkfmt.c
index a7815a2372..2dca955a40 100644
--- a/src/lib/libcrypto/pem/pvkfmt.c
+++ b/src/lib/libcrypto/pem/pvkfmt.c
@@ -293,8 +293,7 @@ do_b2i_bio(BIO *in, int ispub)
293 ret = b2i_rsa(&p, length, bitlen, ispub); 293 ret = b2i_rsa(&p, length, bitlen, ispub);
294 294
295err: 295err:
296 if (buf) 296 free(buf);
297 free(buf);
298 return ret; 297 return ret;
299} 298}
300 299
diff --git a/src/lib/libcrypto/pkcs7/pk7_doit.c b/src/lib/libcrypto/pkcs7/pk7_doit.c
index 5aa4a914cf..0f5d747927 100644
--- a/src/lib/libcrypto/pkcs7/pk7_doit.c
+++ b/src/lib/libcrypto/pkcs7/pk7_doit.c
@@ -190,8 +190,7 @@ static int pkcs7_encode_rinfo(PKCS7_RECIP_INFO *ri,
190 EVP_PKEY_free(pkey); 190 EVP_PKEY_free(pkey);
191 if (pctx) 191 if (pctx)
192 EVP_PKEY_CTX_free(pctx); 192 EVP_PKEY_CTX_free(pctx);
193 if (ek) 193 free(ek);
194 free(ek);
195 return ret; 194 return ret;
196 195
197 } 196 }
diff --git a/src/lib/libcrypto/rsa/rsa_pss.c b/src/lib/libcrypto/rsa/rsa_pss.c
index bd2fde07d4..1e06014165 100644
--- a/src/lib/libcrypto/rsa/rsa_pss.c
+++ b/src/lib/libcrypto/rsa/rsa_pss.c
@@ -172,8 +172,7 @@ int RSA_verify_PKCS1_PSS_mgf1(RSA *rsa, const unsigned char *mHash,
172 ret = 1; 172 ret = 1;
173 173
174 err: 174 err:
175 if (DB) 175 free(DB);
176 free(DB);
177 EVP_MD_CTX_cleanup(&ctx); 176 EVP_MD_CTX_cleanup(&ctx);
178 177
179 return ret; 178 return ret;
@@ -284,8 +283,7 @@ int RSA_padding_add_PKCS1_PSS_mgf1(RSA *rsa, unsigned char *EM,
284 ret = 1; 283 ret = 1;
285 284
286 err: 285 err:
287 if (salt) 286 free(salt);
288 free(salt);
289 287
290 return ret; 288 return ret;
291 289
diff --git a/src/lib/libcrypto/stack/stack.c b/src/lib/libcrypto/stack/stack.c
index e50967a0f1..7eb00fd6e4 100644
--- a/src/lib/libcrypto/stack/stack.c
+++ b/src/lib/libcrypto/stack/stack.c
@@ -141,8 +141,7 @@ sk_new(int (*c)(const void *, const void *))
141 return (ret); 141 return (ret);
142 142
143err: 143err:
144 if (ret) 144 free(ret);
145 free(ret);
146 return (NULL); 145 return (NULL);
147} 146}
148 147
diff --git a/src/lib/libcrypto/store/str_mem.c b/src/lib/libcrypto/store/str_mem.c
index a73279c86b..7e2346d93d 100644
--- a/src/lib/libcrypto/store/str_mem.c
+++ b/src/lib/libcrypto/store/str_mem.c
@@ -333,7 +333,7 @@ static int mem_list_end(STORE *s, void *handle)
333 } 333 }
334 if (context && context->search_attributes) 334 if (context && context->search_attributes)
335 sk_STORE_ATTR_INFO_free(context->search_attributes); 335 sk_STORE_ATTR_INFO_free(context->search_attributes);
336 if (context) free(context); 336 free(context);
337 return 1; 337 return 1;
338 } 338 }
339static int mem_list_endp(STORE *s, void *handle) 339static int mem_list_endp(STORE *s, void *handle)
diff --git a/src/lib/libcrypto/ui/ui_lib.c b/src/lib/libcrypto/ui/ui_lib.c
index 5335b59c48..0d3a960052 100644
--- a/src/lib/libcrypto/ui/ui_lib.c
+++ b/src/lib/libcrypto/ui/ui_lib.c
@@ -328,14 +328,10 @@ UI_dup_input_boolean(UI *ui, const char *prompt, const char *action_desc,
328 result_buf); 328 result_buf);
329 329
330err: 330err:
331 if (prompt_copy) 331 free(prompt_copy);
332 free(prompt_copy); 332 free(action_desc_copy);
333 if (action_desc_copy) 333 free(ok_chars_copy);
334 free(action_desc_copy); 334 free(cancel_chars_copy);
335 if (ok_chars_copy)
336 free(ok_chars_copy);
337 if (cancel_chars_copy)
338 free(cancel_chars_copy);
339 return -1; 335 return -1;
340} 336}
341 337
diff --git a/src/lib/libcrypto/x509v3/v3_conf.c b/src/lib/libcrypto/x509v3/v3_conf.c
index e22aa50fcd..bfdb473b19 100644
--- a/src/lib/libcrypto/x509v3/v3_conf.c
+++ b/src/lib/libcrypto/x509v3/v3_conf.c
@@ -313,8 +313,7 @@ v3_generic_extension(const char *ext, char *value, int crit, int gen_type,
313err: 313err:
314 ASN1_OBJECT_free(obj); 314 ASN1_OBJECT_free(obj);
315 M_ASN1_OCTET_STRING_free(oct); 315 M_ASN1_OCTET_STRING_free(oct);
316 if (ext_der) 316 free(ext_der);
317 free(ext_der);
318 return extension; 317 return extension;
319} 318}
320 319
diff --git a/src/lib/libcrypto/x509v3/v3_utl.c b/src/lib/libcrypto/x509v3/v3_utl.c
index c3328d668d..5b064f8eb2 100644
--- a/src/lib/libcrypto/x509v3/v3_utl.c
+++ b/src/lib/libcrypto/x509v3/v3_utl.c
@@ -422,7 +422,7 @@ unsigned char *string_to_hex(const char *str, long *len)
422 return hexbuf; 422 return hexbuf;
423 423
424 err: 424 err:
425 if(hexbuf) free(hexbuf); 425 free(hexbuf);
426 X509V3err(X509V3_F_STRING_TO_HEX,ERR_R_MALLOC_FAILURE); 426 X509V3err(X509V3_F_STRING_TO_HEX,ERR_R_MALLOC_FAILURE);
427 return NULL; 427 return NULL;
428 428
@@ -623,8 +623,7 @@ ASN1_OCTET_STRING *a2i_IPADDRESS_NC(const char *ipasc)
623 return ret; 623 return ret;
624 624
625 err: 625 err:
626 if (iptmp) 626 free(iptmp);
627 free(iptmp);
628 if (ret) 627 if (ret)
629 ASN1_OCTET_STRING_free(ret); 628 ASN1_OCTET_STRING_free(ret);
630 return NULL; 629 return NULL;
diff --git a/src/lib/libssl/src/apps/pkeyutl.c b/src/lib/libssl/src/apps/pkeyutl.c
index 4f1cfed0e8..44dcca6851 100644
--- a/src/lib/libssl/src/apps/pkeyutl.c
+++ b/src/lib/libssl/src/apps/pkeyutl.c
@@ -441,8 +441,7 @@ init_ctx(int *pkeysize,
441 } 441 }
442end: 442end:
443 443
444 if (passin) 444 free(passin);
445 free(passin);
446 445
447 return ctx; 446 return ctx;
448 447
diff --git a/src/lib/libssl/src/crypto/aes/aes_wrap.c b/src/lib/libssl/src/crypto/aes/aes_wrap.c
index 40533440bf..4a830da7e4 100644
--- a/src/lib/libssl/src/crypto/aes/aes_wrap.c
+++ b/src/lib/libssl/src/crypto/aes/aes_wrap.c
@@ -164,10 +164,8 @@ AES_wrap_unwrap_test(const unsigned char *kek, int keybits,
164 ret = 1; 164 ret = 1;
165 165
166err: 166err:
167 if (otmp) 167 free(otmp);
168 free(otmp); 168 free(ptmp);
169 if (ptmp)
170 free(ptmp);
171 169
172 return ret; 170 return ret;
173} 171}
diff --git a/src/lib/libssl/src/crypto/asn1/asn1_gen.c b/src/lib/libssl/src/crypto/asn1/asn1_gen.c
index 598a322242..7abbac6059 100644
--- a/src/lib/libssl/src/crypto/asn1/asn1_gen.c
+++ b/src/lib/libssl/src/crypto/asn1/asn1_gen.c
@@ -258,10 +258,8 @@ ASN1_generate_v3(char *str, X509V3_CTX *cnf)
258 ret = d2i_ASN1_TYPE(NULL, &cp, len); 258 ret = d2i_ASN1_TYPE(NULL, &cp, len);
259 259
260err: 260err:
261 if (orig_der) 261 free(orig_der);
262 free(orig_der); 262 free(new_der);
263 if (new_der)
264 free(new_der);
265 263
266 return ret; 264 return ret;
267} 265}
diff --git a/src/lib/libssl/src/crypto/asn1/bio_ndef.c b/src/lib/libssl/src/crypto/asn1/bio_ndef.c
index f00d38e5e4..66be025127 100644
--- a/src/lib/libssl/src/crypto/asn1/bio_ndef.c
+++ b/src/lib/libssl/src/crypto/asn1/bio_ndef.c
@@ -146,8 +146,7 @@ BIO_new_NDEF(BIO *out, ASN1_VALUE *val, const ASN1_ITEM *it)
146err: 146err:
147 if (asn_bio) 147 if (asn_bio)
148 BIO_free(asn_bio); 148 BIO_free(asn_bio);
149 if (ndef_aux) 149 free(ndef_aux);
150 free(ndef_aux);
151 return NULL; 150 return NULL;
152} 151}
153 152
diff --git a/src/lib/libssl/src/crypto/bn/bn_exp.c b/src/lib/libssl/src/crypto/bn/bn_exp.c
index 0e36e8d7b5..5d9263e01e 100644
--- a/src/lib/libssl/src/crypto/bn/bn_exp.c
+++ b/src/lib/libssl/src/crypto/bn/bn_exp.c
@@ -840,8 +840,7 @@ err:
840 BN_MONT_CTX_free(mont); 840 BN_MONT_CTX_free(mont);
841 if (powerbuf != NULL) { 841 if (powerbuf != NULL) {
842 OPENSSL_cleanse(powerbuf, powerbufLen); 842 OPENSSL_cleanse(powerbuf, powerbufLen);
843 if (powerbufFree) 843 free(powerbufFree);
844 free(powerbufFree);
845 } 844 }
846 BN_CTX_end(ctx); 845 BN_CTX_end(ctx);
847 return (ret); 846 return (ret);
diff --git a/src/lib/libssl/src/crypto/bn/bn_gf2m.c b/src/lib/libssl/src/crypto/bn/bn_gf2m.c
index 669f8c403e..4000fb8733 100644
--- a/src/lib/libssl/src/crypto/bn/bn_gf2m.c
+++ b/src/lib/libssl/src/crypto/bn/bn_gf2m.c
@@ -558,8 +558,7 @@ BN_GF2m_mod_mul(BIGNUM *r, const BIGNUM *a, const BIGNUM *b, const BIGNUM *p,
558 bn_check_top(r); 558 bn_check_top(r);
559 559
560err: 560err:
561 if (arr) 561 free(arr);
562 free(arr);
563 return ret; 562 return ret;
564} 563}
565 564
@@ -621,8 +620,7 @@ BN_GF2m_mod_sqr(BIGNUM *r, const BIGNUM *a, const BIGNUM *p, BN_CTX *ctx)
621 bn_check_top(r); 620 bn_check_top(r);
622 621
623err: 622err:
624 if (arr) 623 free(arr);
625 free(arr);
626 return ret; 624 return ret;
627} 625}
628 626
@@ -1050,8 +1048,7 @@ BN_GF2m_mod_exp(BIGNUM *r, const BIGNUM *a, const BIGNUM *b, const BIGNUM *p,
1050 bn_check_top(r); 1048 bn_check_top(r);
1051 1049
1052err: 1050err:
1053 if (arr) 1051 free(arr);
1054 free(arr);
1055 return ret; 1052 return ret;
1056} 1053}
1057 1054
@@ -1113,8 +1110,7 @@ BN_GF2m_mod_sqrt(BIGNUM *r, const BIGNUM *a, const BIGNUM *p, BN_CTX *ctx)
1113 bn_check_top(r); 1110 bn_check_top(r);
1114 1111
1115err: 1112err:
1116 if (arr) 1113 free(arr);
1117 free(arr);
1118 return ret; 1114 return ret;
1119} 1115}
1120 1116
@@ -1249,8 +1245,7 @@ BN_GF2m_mod_solve_quad(BIGNUM *r, const BIGNUM *a, const BIGNUM *p, BN_CTX *ctx)
1249 bn_check_top(r); 1245 bn_check_top(r);
1250 1246
1251err: 1247err:
1252 if (arr) 1248 free(arr);
1253 free(arr);
1254 return ret; 1249 return ret;
1255} 1250}
1256 1251
diff --git a/src/lib/libssl/src/crypto/cms/cms_env.c b/src/lib/libssl/src/crypto/cms/cms_env.c
index 78fa2aa7b7..5e6e7033b2 100644
--- a/src/lib/libssl/src/crypto/cms/cms_env.c
+++ b/src/lib/libssl/src/crypto/cms/cms_env.c
@@ -354,8 +354,7 @@ static int cms_RecipientInfo_ktri_encrypt(CMS_ContentInfo *cms,
354 err: 354 err:
355 if (pctx) 355 if (pctx)
356 EVP_PKEY_CTX_free(pctx); 356 EVP_PKEY_CTX_free(pctx);
357 if (ek) 357 free(ek);
358 free(ek);
359 return ret; 358 return ret;
360 359
361 } 360 }
diff --git a/src/lib/libssl/src/crypto/cms/cms_ess.c b/src/lib/libssl/src/crypto/cms/cms_ess.c
index 99a4da6356..8dbd56ef2b 100644
--- a/src/lib/libssl/src/crypto/cms/cms_ess.c
+++ b/src/lib/libssl/src/crypto/cms/cms_ess.c
@@ -156,8 +156,7 @@ int CMS_add1_ReceiptRequest(CMS_SignerInfo *si, CMS_ReceiptRequest *rr)
156 if (!r) 156 if (!r)
157 CMSerr(CMS_F_CMS_ADD1_RECEIPTREQUEST, ERR_R_MALLOC_FAILURE); 157 CMSerr(CMS_F_CMS_ADD1_RECEIPTREQUEST, ERR_R_MALLOC_FAILURE);
158 158
159 if (rrder) 159 free(rrder);
160 free(rrder);
161 160
162 return r; 161 return r;
163 162
diff --git a/src/lib/libssl/src/crypto/cms/cms_sd.c b/src/lib/libssl/src/crypto/cms/cms_sd.c
index d852af596d..976881743b 100644
--- a/src/lib/libssl/src/crypto/cms/cms_sd.c
+++ b/src/lib/libssl/src/crypto/cms/cms_sd.c
@@ -759,8 +759,7 @@ int CMS_SignerInfo_sign(CMS_SignerInfo *si)
759 return 1; 759 return 1;
760 760
761 err: 761 err:
762 if (abuf) 762 free(abuf);
763 free(abuf);
764 EVP_MD_CTX_cleanup(&mctx); 763 EVP_MD_CTX_cleanup(&mctx);
765 return 0; 764 return 0;
766 765
diff --git a/src/lib/libssl/src/crypto/dh/dh_ameth.c b/src/lib/libssl/src/crypto/dh/dh_ameth.c
index a22614ae0a..40e0202bff 100644
--- a/src/lib/libssl/src/crypto/dh/dh_ameth.c
+++ b/src/lib/libssl/src/crypto/dh/dh_ameth.c
@@ -167,8 +167,7 @@ static int dh_pub_encode(X509_PUBKEY *pk, const EVP_PKEY *pkey)
167 return 1; 167 return 1;
168 168
169 err: 169 err:
170 if (penc) 170 free(penc);
171 free(penc);
172 if (pval) 171 if (pval)
173 ASN1_STRING_free(pval); 172 ASN1_STRING_free(pval);
174 173
diff --git a/src/lib/libssl/src/crypto/dh/dh_pmeth.c b/src/lib/libssl/src/crypto/dh/dh_pmeth.c
index c359bb4d2b..c70feb3789 100644
--- a/src/lib/libssl/src/crypto/dh/dh_pmeth.c
+++ b/src/lib/libssl/src/crypto/dh/dh_pmeth.c
@@ -110,8 +110,7 @@ static int pkey_dh_copy(EVP_PKEY_CTX *dst, EVP_PKEY_CTX *src)
110static void pkey_dh_cleanup(EVP_PKEY_CTX *ctx) 110static void pkey_dh_cleanup(EVP_PKEY_CTX *ctx)
111 { 111 {
112 DH_PKEY_CTX *dctx = ctx->data; 112 DH_PKEY_CTX *dctx = ctx->data;
113 if (dctx) 113 free(dctx);
114 free(dctx);
115 } 114 }
116 115
117static int pkey_dh_ctrl(EVP_PKEY_CTX *ctx, int type, int p1, void *p2) 116static int pkey_dh_ctrl(EVP_PKEY_CTX *ctx, int type, int p1, void *p2)
diff --git a/src/lib/libssl/src/crypto/dsa/dsa_ameth.c b/src/lib/libssl/src/crypto/dsa/dsa_ameth.c
index ebca5ec5c5..16617d40f5 100644
--- a/src/lib/libssl/src/crypto/dsa/dsa_ameth.c
+++ b/src/lib/libssl/src/crypto/dsa/dsa_ameth.c
@@ -175,8 +175,7 @@ static int dsa_pub_encode(X509_PUBKEY *pk, const EVP_PKEY *pkey)
175 return 1; 175 return 1;
176 176
177 err: 177 err:
178 if (penc) 178 free(penc);
179 free(penc);
180 if (pval) 179 if (pval)
181 ASN1_STRING_free(pval); 180 ASN1_STRING_free(pval);
182 181
@@ -580,8 +579,7 @@ static int dsa_sig_print(BIO *bp, const X509_ALGOR *sigalg,
580 goto err; 579 goto err;
581 rv = 1; 580 rv = 1;
582 err: 581 err:
583 if (m) 582 free(m);
584 free(m);
585 DSA_SIG_free(dsa_sig); 583 DSA_SIG_free(dsa_sig);
586 return rv; 584 return rv;
587 } 585 }
diff --git a/src/lib/libssl/src/crypto/dsa/dsa_pmeth.c b/src/lib/libssl/src/crypto/dsa/dsa_pmeth.c
index 4e77c6f64b..a2b3b7f21a 100644
--- a/src/lib/libssl/src/crypto/dsa/dsa_pmeth.c
+++ b/src/lib/libssl/src/crypto/dsa/dsa_pmeth.c
@@ -113,8 +113,7 @@ static int pkey_dsa_copy(EVP_PKEY_CTX *dst, EVP_PKEY_CTX *src)
113static void pkey_dsa_cleanup(EVP_PKEY_CTX *ctx) 113static void pkey_dsa_cleanup(EVP_PKEY_CTX *ctx)
114 { 114 {
115 DSA_PKEY_CTX *dctx = ctx->data; 115 DSA_PKEY_CTX *dctx = ctx->data;
116 if (dctx) 116 free(dctx);
117 free(dctx);
118 } 117 }
119 118
120static int pkey_dsa_sign(EVP_PKEY_CTX *ctx, unsigned char *sig, size_t *siglen, 119static int pkey_dsa_sign(EVP_PKEY_CTX *ctx, unsigned char *sig, size_t *siglen,
diff --git a/src/lib/libssl/src/crypto/ec/ec_ameth.c b/src/lib/libssl/src/crypto/ec/ec_ameth.c
index 9b52c3cbfc..b41879c431 100644
--- a/src/lib/libssl/src/crypto/ec/ec_ameth.c
+++ b/src/lib/libssl/src/crypto/ec/ec_ameth.c
@@ -128,8 +128,7 @@ err:
128 ASN1_OBJECT_free(pval); 128 ASN1_OBJECT_free(pval);
129 else 129 else
130 ASN1_STRING_free(pval); 130 ASN1_STRING_free(pval);
131 if (penc) 131 free(penc);
132 free(penc);
133 return 0; 132 return 0;
134} 133}
135 134
diff --git a/src/lib/libssl/src/crypto/ec/ec_asn1.c b/src/lib/libssl/src/crypto/ec/ec_asn1.c
index 0ea0d6e2a4..2409cd0886 100644
--- a/src/lib/libssl/src/crypto/ec/ec_asn1.c
+++ b/src/lib/libssl/src/crypto/ec/ec_asn1.c
@@ -507,10 +507,8 @@ ec_asn1_group2curve(const EC_GROUP * group, X9_62_CURVE * curve)
507 507
508 ok = 1; 508 ok = 1;
509 509
510err: if (buffer_1) 510err: free(buffer_1);
511 free(buffer_1); 511 free(buffer_2);
512 if (buffer_2)
513 free(buffer_2);
514 if (tmp_1) 512 if (tmp_1)
515 BN_free(tmp_1); 513 BN_free(tmp_1);
516 if (tmp_2) 514 if (tmp_2)
@@ -610,8 +608,7 @@ err: if (!ok) {
610 } 608 }
611 if (tmp) 609 if (tmp)
612 BN_free(tmp); 610 BN_free(tmp);
613 if (buffer) 611 free(buffer);
614 free(buffer);
615 return (ret); 612 return (ret);
616} 613}
617 614
@@ -1134,8 +1131,7 @@ i2d_ECPrivateKey(EC_KEY * a, unsigned char **out)
1134 } 1131 }
1135 ok = 1; 1132 ok = 1;
1136err: 1133err:
1137 if (buffer) 1134 free(buffer);
1138 free(buffer);
1139 if (priv_key) 1135 if (priv_key)
1140 EC_PRIVATEKEY_free(priv_key); 1136 EC_PRIVATEKEY_free(priv_key);
1141 return (ok ? ret : 0); 1137 return (ok ? ret : 0);
diff --git a/src/lib/libssl/src/crypto/ecdh/ech_ossl.c b/src/lib/libssl/src/crypto/ecdh/ech_ossl.c
index 129475f7bb..0f4cdf056d 100644
--- a/src/lib/libssl/src/crypto/ecdh/ech_ossl.c
+++ b/src/lib/libssl/src/crypto/ecdh/ech_ossl.c
@@ -204,6 +204,6 @@ err:
204 if (tmp) EC_POINT_free(tmp); 204 if (tmp) EC_POINT_free(tmp);
205 if (ctx) BN_CTX_end(ctx); 205 if (ctx) BN_CTX_end(ctx);
206 if (ctx) BN_CTX_free(ctx); 206 if (ctx) BN_CTX_free(ctx);
207 if (buf) free(buf); 207 free(buf);
208 return(ret); 208 return(ret);
209 } 209 }
diff --git a/src/lib/libssl/src/crypto/engine/eng_dyn.c b/src/lib/libssl/src/crypto/engine/eng_dyn.c
index 7878bd802e..f59d768350 100644
--- a/src/lib/libssl/src/crypto/engine/eng_dyn.c
+++ b/src/lib/libssl/src/crypto/engine/eng_dyn.c
@@ -222,8 +222,7 @@ static int dynamic_set_data_ctx(ENGINE *e, dynamic_data_ctx **ctx)
222 CRYPTO_w_unlock(CRYPTO_LOCK_ENGINE); 222 CRYPTO_w_unlock(CRYPTO_LOCK_ENGINE);
223 /* If we lost the race to set the context, c is non-NULL and *ctx is the 223 /* If we lost the race to set the context, c is non-NULL and *ctx is the
224 * context of the thread that won. */ 224 * context of the thread that won. */
225 if(c) 225 free(c);
226 free(c);
227 return 1; 226 return 1;
228 } 227 }
229 228
diff --git a/src/lib/libssl/src/crypto/ex_data.c b/src/lib/libssl/src/crypto/ex_data.c
index 77a91c4b04..d8d25d320e 100644
--- a/src/lib/libssl/src/crypto/ex_data.c
+++ b/src/lib/libssl/src/crypto/ex_data.c
@@ -444,8 +444,7 @@ skip:
444 storage[i]->argl, storage[i]->argp); 444 storage[i]->argl, storage[i]->argp);
445 } 445 }
446 } 446 }
447 if (storage) 447 free(storage);
448 free(storage);
449 return 1; 448 return 1;
450} 449}
451 450
@@ -489,8 +488,7 @@ skip:
489 storage[i]->argl, storage[i]->argp); 488 storage[i]->argl, storage[i]->argp);
490 CRYPTO_set_ex_data(to, i, ptr); 489 CRYPTO_set_ex_data(to, i, ptr);
491 } 490 }
492 if (storage) 491 free(storage);
493 free(storage);
494 return 1; 492 return 1;
495} 493}
496 494
@@ -527,8 +525,7 @@ skip:
527 storage[i]->argl, storage[i]->argp); 525 storage[i]->argl, storage[i]->argp);
528 } 526 }
529 } 527 }
530 if (storage) 528 free(storage);
531 free(storage);
532 if (ad->sk) { 529 if (ad->sk) {
533 sk_void_free(ad->sk); 530 sk_void_free(ad->sk);
534 ad->sk = NULL; 531 ad->sk = NULL;
diff --git a/src/lib/libssl/src/crypto/pem/pvkfmt.c b/src/lib/libssl/src/crypto/pem/pvkfmt.c
index a7815a2372..2dca955a40 100644
--- a/src/lib/libssl/src/crypto/pem/pvkfmt.c
+++ b/src/lib/libssl/src/crypto/pem/pvkfmt.c
@@ -293,8 +293,7 @@ do_b2i_bio(BIO *in, int ispub)
293 ret = b2i_rsa(&p, length, bitlen, ispub); 293 ret = b2i_rsa(&p, length, bitlen, ispub);
294 294
295err: 295err:
296 if (buf) 296 free(buf);
297 free(buf);
298 return ret; 297 return ret;
299} 298}
300 299
diff --git a/src/lib/libssl/src/crypto/pkcs7/pk7_doit.c b/src/lib/libssl/src/crypto/pkcs7/pk7_doit.c
index 5aa4a914cf..0f5d747927 100644
--- a/src/lib/libssl/src/crypto/pkcs7/pk7_doit.c
+++ b/src/lib/libssl/src/crypto/pkcs7/pk7_doit.c
@@ -190,8 +190,7 @@ static int pkcs7_encode_rinfo(PKCS7_RECIP_INFO *ri,
190 EVP_PKEY_free(pkey); 190 EVP_PKEY_free(pkey);
191 if (pctx) 191 if (pctx)
192 EVP_PKEY_CTX_free(pctx); 192 EVP_PKEY_CTX_free(pctx);
193 if (ek) 193 free(ek);
194 free(ek);
195 return ret; 194 return ret;
196 195
197 } 196 }
diff --git a/src/lib/libssl/src/crypto/rsa/rsa_pss.c b/src/lib/libssl/src/crypto/rsa/rsa_pss.c
index bd2fde07d4..1e06014165 100644
--- a/src/lib/libssl/src/crypto/rsa/rsa_pss.c
+++ b/src/lib/libssl/src/crypto/rsa/rsa_pss.c
@@ -172,8 +172,7 @@ int RSA_verify_PKCS1_PSS_mgf1(RSA *rsa, const unsigned char *mHash,
172 ret = 1; 172 ret = 1;
173 173
174 err: 174 err:
175 if (DB) 175 free(DB);
176 free(DB);
177 EVP_MD_CTX_cleanup(&ctx); 176 EVP_MD_CTX_cleanup(&ctx);
178 177
179 return ret; 178 return ret;
@@ -284,8 +283,7 @@ int RSA_padding_add_PKCS1_PSS_mgf1(RSA *rsa, unsigned char *EM,
284 ret = 1; 283 ret = 1;
285 284
286 err: 285 err:
287 if (salt) 286 free(salt);
288 free(salt);
289 287
290 return ret; 288 return ret;
291 289
diff --git a/src/lib/libssl/src/crypto/stack/stack.c b/src/lib/libssl/src/crypto/stack/stack.c
index e50967a0f1..7eb00fd6e4 100644
--- a/src/lib/libssl/src/crypto/stack/stack.c
+++ b/src/lib/libssl/src/crypto/stack/stack.c
@@ -141,8 +141,7 @@ sk_new(int (*c)(const void *, const void *))
141 return (ret); 141 return (ret);
142 142
143err: 143err:
144 if (ret) 144 free(ret);
145 free(ret);
146 return (NULL); 145 return (NULL);
147} 146}
148 147
diff --git a/src/lib/libssl/src/crypto/store/str_mem.c b/src/lib/libssl/src/crypto/store/str_mem.c
index a73279c86b..7e2346d93d 100644
--- a/src/lib/libssl/src/crypto/store/str_mem.c
+++ b/src/lib/libssl/src/crypto/store/str_mem.c
@@ -333,7 +333,7 @@ static int mem_list_end(STORE *s, void *handle)
333 } 333 }
334 if (context && context->search_attributes) 334 if (context && context->search_attributes)
335 sk_STORE_ATTR_INFO_free(context->search_attributes); 335 sk_STORE_ATTR_INFO_free(context->search_attributes);
336 if (context) free(context); 336 free(context);
337 return 1; 337 return 1;
338 } 338 }
339static int mem_list_endp(STORE *s, void *handle) 339static int mem_list_endp(STORE *s, void *handle)
diff --git a/src/lib/libssl/src/crypto/ui/ui_lib.c b/src/lib/libssl/src/crypto/ui/ui_lib.c
index 5335b59c48..0d3a960052 100644
--- a/src/lib/libssl/src/crypto/ui/ui_lib.c
+++ b/src/lib/libssl/src/crypto/ui/ui_lib.c
@@ -328,14 +328,10 @@ UI_dup_input_boolean(UI *ui, const char *prompt, const char *action_desc,
328 result_buf); 328 result_buf);
329 329
330err: 330err:
331 if (prompt_copy) 331 free(prompt_copy);
332 free(prompt_copy); 332 free(action_desc_copy);
333 if (action_desc_copy) 333 free(ok_chars_copy);
334 free(action_desc_copy); 334 free(cancel_chars_copy);
335 if (ok_chars_copy)
336 free(ok_chars_copy);
337 if (cancel_chars_copy)
338 free(cancel_chars_copy);
339 return -1; 335 return -1;
340} 336}
341 337
diff --git a/src/lib/libssl/src/crypto/x509v3/v3_conf.c b/src/lib/libssl/src/crypto/x509v3/v3_conf.c
index e22aa50fcd..bfdb473b19 100644
--- a/src/lib/libssl/src/crypto/x509v3/v3_conf.c
+++ b/src/lib/libssl/src/crypto/x509v3/v3_conf.c
@@ -313,8 +313,7 @@ v3_generic_extension(const char *ext, char *value, int crit, int gen_type,
313err: 313err:
314 ASN1_OBJECT_free(obj); 314 ASN1_OBJECT_free(obj);
315 M_ASN1_OCTET_STRING_free(oct); 315 M_ASN1_OCTET_STRING_free(oct);
316 if (ext_der) 316 free(ext_der);
317 free(ext_der);
318 return extension; 317 return extension;
319} 318}
320 319
diff --git a/src/lib/libssl/src/crypto/x509v3/v3_utl.c b/src/lib/libssl/src/crypto/x509v3/v3_utl.c
index c3328d668d..5b064f8eb2 100644
--- a/src/lib/libssl/src/crypto/x509v3/v3_utl.c
+++ b/src/lib/libssl/src/crypto/x509v3/v3_utl.c
@@ -422,7 +422,7 @@ unsigned char *string_to_hex(const char *str, long *len)
422 return hexbuf; 422 return hexbuf;
423 423
424 err: 424 err:
425 if(hexbuf) free(hexbuf); 425 free(hexbuf);
426 X509V3err(X509V3_F_STRING_TO_HEX,ERR_R_MALLOC_FAILURE); 426 X509V3err(X509V3_F_STRING_TO_HEX,ERR_R_MALLOC_FAILURE);
427 return NULL; 427 return NULL;
428 428
@@ -623,8 +623,7 @@ ASN1_OCTET_STRING *a2i_IPADDRESS_NC(const char *ipasc)
623 return ret; 623 return ret;
624 624
625 err: 625 err:
626 if (iptmp) 626 free(iptmp);
627 free(iptmp);
628 if (ret) 627 if (ret)
629 ASN1_OCTET_STRING_free(ret); 628 ASN1_OCTET_STRING_free(ret);
630 return NULL; 629 return NULL;