Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | The RSA, DH, and ECDH temporary key callbacks expect the number of keybits | guenther | 2014-07-28 | 6 | -18/+42 | |
| | | | | | | | | | | | | | for the key (expressed in RSA key bits, which makes *no sense* for ECDH) as their second argument, not zero. (jsing@ notes that the RSA callback is only invoked for 'export' ciphers, which have been removed from LibreSSL, and for the SSL_OP_EPHEMERAL_RSA option, which is makes the application non-compliant. More fuel for the tedu fire...) jasper@ noted the breakage and bisected it down to the diff that broke this ok jsing@ miod@ | |||||
* | Add missing year to copyright. | jsing | 2014-07-25 | 2 | -4/+4 | |
| | ||||||
* | BIO_free() returns immediately when the sole input is NULL. | doug | 2014-07-25 | 19 | -71/+45 | |
| | | | | | | Remove unnecessary NULL check. ok miod@ | |||||
* | level_add_node(): if a memory allocation failure causes us to attempt to clean | miod | 2014-07-23 | 1 | -4/+7 | |
| | | | | | | | up and return failure, be sure the cleanup work does NOT free objects which are still being referenced by other objects. ok guenther@ | |||||
* | Make sure PEM_def_callback() correctly handles negative buffer sizes; all uses | miod | 2014-07-23 | 1 | -10/+17 | |
| | | | | | | | within libcrypto are safe, but until we can change this function prototype to use size_t instead of int, better be safe than sorry. tweaks and ok guenther@ | |||||
* | Check the return value of the UI functions (including UI_new() which return | miod | 2014-07-23 | 1 | -6/+11 | |
| | | | | | | value is happily dereferenced without checking it for being non-NULL). ok beck@ | |||||
* | Now that DES_random_key() can be trusted, use it to generate DES keys in the | miod | 2014-07-22 | 2 | -12/+10 | |
| | | | | | | | EVP_CTRL_RAND_KEY method handlers, rather than generating a random odd key and not even checking it against the weak keys list. ok beck@ | |||||
* | In DES_random_key(), force the generated key to the odd parity before checking | miod | 2014-07-22 | 1 | -8/+8 | |
| | | | | | | | | | | | it is not one of the weak and semi-weak keys. Even though the probability of generating a weak key with incorrect parity is abysmally small, there is no reason to be correct (although, if you're in a need for fresh DES keys nowadays, you should seriously consider switching to a stronger symmetric cipher algorithm). ok beck@ | |||||
* | Handle failure of NETSCAPE_SPKI_b64_encode() and don't leak memory | guenther | 2014-07-22 | 1 | -6/+10 | |
| | | | | | | when BIO_new_{file,fp}() fails. inspired by a diff from logan@ ok miod@ | |||||
* | Kill a bunch more BUF_strdup's - these are converted to have a check for | beck | 2014-07-22 | 6 | -15/+20 | |
| | | | | | NULL before an intrinsic strdup. ok miod@ | |||||
* | Mark the format string argument to BIO_*printf as not being allowed to be NULL | guenther | 2014-07-20 | 1 | -5/+7 | |
| | | | | ok bcook@ | |||||
* | Fix strtonum range to unbreak -pass fd:0 | lteo | 2014-07-19 | 1 | -2/+2 | |
| | | | | ok deraadt@ | |||||
* | missing newline | deraadt | 2014-07-18 | 1 | -2/+2 | |
| | ||||||
* | avoid errx(); Jonas Termansen | deraadt | 2014-07-17 | 1 | -3/+5 | |
| | ||||||
* | avoid sys/param.h; Jonas Termansen | deraadt | 2014-07-17 | 3 | -7/+8 | |
| | ||||||
* | Missing bounds check in ssl3_get_certificate_request(), was not spotted in | miod | 2014-07-17 | 2 | -2/+12 | |
| | | | | 1.78; reported by Ilja Van Sprundel. | |||||
* | Free sktmp when it's no longer needed. By doing so, we fix a bunch of memory ↵ | logan | 2014-07-17 | 1 | -2/+4 | |
| | | | | | | | | leaks. From miod@ OK from miod@ and guenther@ | |||||
* | do not need a variable to track locking, since all code paths have it | deraadt | 2014-07-16 | 1 | -5/+2 | |
| | | | | locked throughout. | |||||
* | not needed anymore | deraadt | 2014-07-14 | 2 | -1173/+0 | |
| | ||||||
* | Fix memory leak upon error in ssl_parse_clienthello_use_srtp_ext(). | miod | 2014-07-14 | 2 | -12/+12 | |
| | | | | From BoringSSL. | |||||
* | whitespace | deraadt | 2014-07-14 | 45 | -172/+172 | |
| | ||||||
* | Improve RAND_write_file(), chmod crud, etc. | deraadt | 2014-07-14 | 1 | -27/+19 | |
| | | | | ok tedu | |||||
* | Stop leaking internal library pointers in error messages. | jsing | 2014-07-13 | 2 | -4/+4 | |
| | | | | Requested by miod@ | |||||
* | Explicitly initialise slen - this was not previously done due to a missing | jsing | 2014-07-13 | 2 | -2/+4 | |
| | | | | M_ASN1_D2I_begin macro. | |||||
* | Convert error handling to SSLerr and ERR_asprintf_error_data. | jsing | 2014-07-13 | 2 | -118/+108 | |
| | ||||||
* | Convert d2i_SSL_SESSION to ASN1 primitives, instead of the horrific | jsing | 2014-07-13 | 2 | -52/+594 | |
| | | | | | | | asn1_mac.h macros. This still needs a lot of improvement, but immediately becomes readable. ok miod@ (sight unseen!) | |||||
* | Remove license introduced with the PSK code, which has since been removed. | jsing | 2014-07-13 | 2 | -54/+2 | |
| | | | | ok deraadt@ | |||||
* | Another compression remnant. | jsing | 2014-07-13 | 2 | -4/+2 | |
| | ||||||
* | Expand the tlsext_sigalg macros. The end result is about the same number | jsing | 2014-07-13 | 2 | -32/+38 | |
| | | | | | | of lines and much more readable. ok miod@ | |||||
* | Rewrite i2d_SSL_SESSION to use the ASN1 primitives, rather than using the | jsing | 2014-07-13 | 2 | -150/+196 | |
| | | | | | | | | | | | horrific macros from asn1_mac.h. This is a classic example of using macros to obfuscate code, in an attempt to reduce the line count. The end result is so ridiculously convoluted that it is completely unreadable and it takes hours to deconstruct the macros and figure out what is actually going on behind the scenes. ok miod@ | |||||
* | The bell tolls for BUF_strdup - Start the migration to using | beck | 2014-07-13 | 25 | -85/+92 | |
| | | | | | | intrinsics. This is the easy ones, a few left to check one at a time. ok miod@ deraadt@ | |||||
* | Fix memory leak. | logan | 2014-07-13 | 1 | -1/+2 | |
| | | | | OK from beck@ and miod@ | |||||
* | OPENSSL_{malloc,free} -> {malloc,free} | miod | 2014-07-13 | 11 | -15/+15 | |
| | ||||||
* | Warn about the use of BUF_strdup. | miod | 2014-07-13 | 1 | -2/+4 | |
| | ||||||
* | unbreak build this needed to be an and.. | beck | 2014-07-13 | 4 | -8/+8 | |
| | | | | ok jsing@ | |||||
* | Make sure all error conditions in RSA_padding_add_PKCS1_PSS_mgf1() cause | miod | 2014-07-13 | 1 | -3/+4 | |
| | | | | EVP_MD_CTX_cleanup() to be called. | |||||
* | Possible PBEPARAM leak in the error path. | miod | 2014-07-13 | 1 | -6/+8 | |
| | ||||||
* | dsa_priv_decode(): only destroy the object we've created, and with the | miod | 2014-07-13 | 1 | -3/+5 | |
| | | | | | | appropriate function. Checking for privkey != NULL is not enough since privkey points to a member of ndsa if ndsa != NULL. dsa_priv_encode(): possible double free in error path. | |||||
* | Check X509_NAME_oneline() return value when it will have to allocate memory. | miod | 2014-07-13 | 1 | -1/+3 | |
| | ||||||
* | EVP_DigestInit_ex() may be used to recycle an existing EVP_MD_CTX without having | miod | 2014-07-13 | 1 | -3/+9 | |
| | | | | | | | | | | | | | to reinitialize all of it, especially if it is used with the same MD algorithm. However, when the MD algorithm changes, it needs to perform more cleanups. Make that code more closer to what EVP_MD_CTX_cleanup() does by: - only freeing md_data if EVP_MD_CTX_FLAG_REUSE is not set - performing an explicit_bzero of md_data before freeing it - making sure we call EVP_PKEY_CTX_free on the pctx if the allocation for the new md_data fails. ok tedu@ | |||||
* | Don't include asn1_mac.h if all you need is asn1.h. | miod | 2014-07-13 | 1 | -2/+2 | |
| | ||||||
* | Take out __bounded__ in the include files we use it in when not on OpenBSD. | beck | 2014-07-13 | 4 | -5/+16 | |
| | | | | | | | while we can take it out in portable at compile time, it is still a problem when we install this header file on a system that doesn't support __bounded__ if this is unguarded. ok miod@ bcook@ | |||||
* | No need to include evp_locl.h in there. | miod | 2014-07-13 | 6 | -18/+6 | |
| | ||||||
* | KNF and some code cleaning. | jsing | 2014-07-13 | 2 | -72/+92 | |
| | ||||||
* | remove silly cast | deraadt | 2014-07-13 | 1 | -2/+2 | |
| | ||||||
* | Another large dose of KNF. | jsing | 2014-07-13 | 2 | -472/+814 | |
| | ||||||
* | Apply a large dose of KNF. | jsing | 2014-07-12 | 2 | -252/+404 | |
| | ||||||
* | duplicate function names in head1 | miod | 2014-07-12 | 2 | -2/+2 | |
| | ||||||
* | The correct name for EDH is DHE, likewise EECDH should be ECDHE. | jsing | 2014-07-12 | 18 | -236/+236 | |
| | | | | | | Based on changes to OpenSSL trunk. ok beck@ miod@ | |||||
* | No need to include asn1_mac.h here. | miod | 2014-07-12 | 2 | -4/+2 | |
| |