summaryrefslogtreecommitdiff
path: root/src/regress/lib/libcrypto/asn1/Makefile (follow)
Commit message (Collapse)AuthorAgeFilesLines
* i2c_ASN1_BIT_STRING() vs ASN1_STRING_FLAG_BITS_LEFTtb7 days1-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A nasty quirk in the bit string handling is that the serialization produced by i2d_ASN1_BIT_STRING() depends on whether the the magic ASN1_STRING_FLAG_BITS_LEFT is set. If ASN1_STRING_FLAG_BITS_LEFT is set, the number of unused bits is carried in a->flags & 0x07 and the remainder of the bit string is in a->data. This is terrible and undocumented but handled correctly. If ASN1_STRING_FLAG_BITS_LEFT is not set, all trailing zero bits are (intended to be) chopped off with all sorts of hilarious side effects. I broke this quite thoroughly when I incorrectly ported an overflow check from BoringSSL in: https://github.com/openbsd/src/commit/f81cc285d2aed8b36615119a306533696f3eb66c The result is that we currently return ret = a->length + 1 for both NULL and non-NULL pp. The calls to asn1_ex_i2c() in asn1_i2d_ex_primitive() thus report consistent lengths back, making it succeed. asn1_i2d_ex_primitive() therefore skips a->length + 1 bytes, while i2c_ASN1_BIT_STRING() only overwrites len + 1 bytes, which are possibly fewer. So a caller passing in an output buffer containing garbage (malloc) will get some of that garbage back in the encoding. Further, i2c_ASN1_BIT_STRING() also advances that pointer by the possibly reduced len + 1, but that fortunately doesn't matter since that's an effect local to asn1_ex_i2c(), the only caller of i2c_ASN1_BIT_STRING(). The last bit is that the current behavior may set bogus unused bits coming from the scanning backward madness. I added such an example in the parent commit. The fix is simple: use len after the truncation effect was established, not the original a->length, turning this commit into what my backport should have been. This fixes the two currently failing regress tests, so remove expected failure marker again. ok jsing kenjiro
* asn1basic: switch test to expect correct encodingtb7 days1-1/+3
| | | | This test fails, so mark the asn1basic test as an expected failure
* Link x509_algor test statically and switch to the internaltb2024-02-291-1/+2
| | | | X509_ALGOR_set0_evp_md()
* Add regress coverage for the new APItb2024-02-181-1/+2
| | | | | This exercises the new API, in particular with respect to overflow behavior around the years 0/9999, which are special for GeneralizedTime/X.509.
* Remove the string_table testtb2023-12-151-2/+1
| | | | | | | | If it wasn't for security/xca, all of the ASN1_STRING_TABLE API would hit the attic before long. API design by a trained professional... The table can at least be made immutable, which in turn makes this test entirely pointless.
* Add regress coverage for X509_ALGOR_*tb2023-10-111-2/+3
| | | | | | | | | This covers the setters and getters. Serialization and deserialization as well as comparison is already well covered by the pieces of regress using certs. There is currently one printf indicating failure. This will be fixed shortly.
* Add regress coverage for {s2i,i2s}_ASN1_OCTET_STRINGtb2023-05-121-1/+2
|
* Let bsd.regress.mk take care of running teststb2022-12-021-8/+1
|
* link asn1object test statically in preparation for upcoming bumptb2022-09-111-1/+2
|
* The asn1time test no longer needs static linking.tb2022-07-121-4/+1
|
* Only asn1time needs to be static for now.tb2022-06-281-2/+4
|
* Make this regress test link staticly and use internal symbolsbeck2022-06-281-1/+2
| | | | so that it works and compiles during the tb@ pre-bump shuffle(tm).
* Drop bogus DPADD += ${LIBSSL}tb2022-06-191-2/+2
|
* Add a simple test that exercises ASN1_STRING_to_UTF8() a little.tb2022-05-161-1/+2
|
* Add regress coverage for ASN1_OBJECT public interfaces.jsing2022-02-261-1/+2
|
* Undo static linking and other workarounds that are no longer neededtb2022-01-141-3/+2
| | | | after the bump
* Fix asn1x509 build with opaque structures. Link statically for now.tb2022-01-121-2/+4
|
* Rework Makefile to use regress framework and link asn1basic statically.tb2022-01-121-13/+13
| | | | | It will need this for testing {d2i,i2d}_ASN1_BOOLEAN which will be moved to internal-only in the upcoming bump.
* Print the name of the test before we run it.jsing2021-12-241-1/+2
|
* Add regress for ASN1_tag2bit() and ASN1_tag2str()jsing2021-12-141-1/+2
|
* Merge two bugfixes in ASN1_STRING_TABLE_add(3) and ASN1_STRING_TABLE_get(3)schwarze2021-12-111-2/+3
| | | | | | | | | | | | | | | | | | | | | | from the OpenSSL 1.1.1 branch, which is still under a free license, mostly this commit: commit d35c0ff30b31be9fd5dcf3d552a16feb8de464bc Author: Dr. Stephen Henson <steve@openssl.org> Date: Fri Oct 19 15:06:31 2012 +0000 fix ASN1_STRING_TABLE_add so it can override existing string table values This fixes a segfault in ASN1_STRING_TABLE_add(3), which tried to change a static const entry when called with an nid already in the default table, and it switches the precedence of the two tables in ASN1_STRING_TABLE_get(3). In addition, it changes behaviour in the following minor ways: * Ignore negative minsize and maxsize arguments, not just -1. * Ignore a zero mask and zero flags. It's unclear whether these additional changes make the API absolutely better, but we want compatibility with OpenSSL in these functions. Tweaks & OK tb@.
* Add initial tests for coverage of ASN.1 complex/constructed types.jsing2021-12-091-1/+2
|
* Add initial tests for coverage of ASN.1 basic/primitive types.jsing2021-12-091-1/+2
|
* Add regress for {d2i,i2d}_{,DSA_,EC_,RSA_}PUBKEY{,_bio}().jsing2021-11-301-1/+2
|
* Test ASN1_STRING_copy(3).schwarze2021-11-131-1/+2
| | | | | | As a side effect, this also tests various aspects of ASN1_STRING_new(3), ASN1_STRING_set(3), ASN1_STRING_length_set(3), ASN1_STRING_get0_data(3), ASN1_STRING_length(3), and ASN1_STRING_type(3).
* Instead of enumerating the files to clean by hand, set PROGS=${TESTS}.tb2018-08-311-3/+3
| | | | Suggested by jsing
* Make sure to clean up the .d files with 'make clean'tb2018-08-301-2/+2
|
* Add regress coverage for ASN1_TYPE_{get,set}_int_octetstring()jsing2017-11-281-2/+4
|
* Add an rfc5280 test suite to test x509_cmp_time.beck2015-09-291-2/+2
| | | | | | Note some of these will yet fail with the current libcrypto as the current X509_cmp_time is not RFC5280 compliant ok jsing@
* Add initial regress tests for ASN.1 times.jsing2015-09-251-0/+21
generated by cgit v1.2.3-55-g6feb (git 2.39.1) at 2026-01-11 20:08:51 +0000