diff options
| author | kinichiro <kinichiro.inoguchi@gmail.com> | 2021-12-04 10:49:59 +0900 |
|---|---|---|
| committer | kinichiro <kinichiro.inoguchi@gmail.com> | 2021-12-04 14:36:39 +0900 |
| commit | c211d97ecb351254a1020f2a9eecd47e65ad5484 (patch) | |
| tree | 49a84019df276ce5d3cc552890dcb24cd8503133 | |
| parent | f2026bb3246cb45bb2fe0d3d93461149862d8d0b (diff) | |
| download | portable-c211d97ecb351254a1020f2a9eecd47e65ad5484.tar.gz portable-c211d97ecb351254a1020f2a9eecd47e65ad5484.tar.bz2 portable-c211d97ecb351254a1020f2a9eecd47e65ad5484.zip | |
Remove unneeded target_include_directories with cmake
This could remove recurring of the same statement for include directories.
Instead of this removals, apps/* and tests should have include path that
had been provided by INTERFACE_INCLUDE_DIRECTORIES of target libs and
internal static libs.
| -rw-r--r-- | apps/nc/CMakeLists.txt | 1 | ||||
| -rw-r--r-- | apps/ocspcheck/CMakeLists.txt | 1 | ||||
| -rw-r--r-- | apps/openssl/CMakeLists.txt | 1 | ||||
| -rw-r--r-- | crypto/CMakeLists.txt | 30 | ||||
| -rw-r--r-- | ssl/CMakeLists.txt | 12 | ||||
| -rw-r--r-- | tests/CMakeLists.txt | 1 | ||||
| -rw-r--r-- | tls/CMakeLists.txt | 12 |
7 files changed, 4 insertions, 54 deletions
diff --git a/apps/nc/CMakeLists.txt b/apps/nc/CMakeLists.txt index a241637..e873de8 100644 --- a/apps/nc/CMakeLists.txt +++ b/apps/nc/CMakeLists.txt | |||
| @@ -44,6 +44,7 @@ else() | |||
| 44 | endif() | 44 | endif() |
| 45 | 45 | ||
| 46 | add_executable(nc ${NC_SRC}) | 46 | add_executable(nc ${NC_SRC}) |
| 47 | target_include_directories(nc PUBLIC ../../include) | ||
| 47 | target_include_directories(nc PRIVATE . ./compat ../../include/compat) | 48 | target_include_directories(nc PRIVATE . ./compat ../../include/compat) |
| 48 | target_link_libraries(nc ${LIBTLS_LIBS}) | 49 | target_link_libraries(nc ${LIBTLS_LIBS}) |
| 49 | 50 | ||
diff --git a/apps/ocspcheck/CMakeLists.txt b/apps/ocspcheck/CMakeLists.txt index 43b091a..249f0f4 100644 --- a/apps/ocspcheck/CMakeLists.txt +++ b/apps/ocspcheck/CMakeLists.txt | |||
| @@ -28,6 +28,7 @@ else() | |||
| 28 | endif() | 28 | endif() |
| 29 | 29 | ||
| 30 | add_executable(ocspcheck ${OCSPCHECK_SRC}) | 30 | add_executable(ocspcheck ${OCSPCHECK_SRC}) |
| 31 | target_include_directories(ocspcheck PUBLIC ../../include) | ||
| 31 | target_include_directories(ocspcheck PRIVATE . ./compat ../../include/compat) | 32 | target_include_directories(ocspcheck PRIVATE . ./compat ../../include/compat) |
| 32 | target_link_libraries(ocspcheck tls ${OPENSSL_LIBS}) | 33 | target_link_libraries(ocspcheck tls ${OPENSSL_LIBS}) |
| 33 | 34 | ||
diff --git a/apps/openssl/CMakeLists.txt b/apps/openssl/CMakeLists.txt index c5cfbe2..bb058e1 100644 --- a/apps/openssl/CMakeLists.txt +++ b/apps/openssl/CMakeLists.txt | |||
| @@ -77,6 +77,7 @@ if(CMAKE_SYSTEM_NAME MATCHES "Darwin") | |||
| 77 | endif() | 77 | endif() |
| 78 | 78 | ||
| 79 | add_executable(openssl ${OPENSSL_SRC}) | 79 | add_executable(openssl ${OPENSSL_SRC}) |
| 80 | target_include_directories(openssl PUBLIC ../../include) | ||
| 80 | target_include_directories(openssl PRIVATE . ../../include/compat) | 81 | target_include_directories(openssl PRIVATE . ../../include/compat) |
| 81 | target_link_libraries(openssl ${OPENSSL_LIBS}) | 82 | target_link_libraries(openssl ${OPENSSL_LIBS}) |
| 82 | 83 | ||
diff --git a/crypto/CMakeLists.txt b/crypto/CMakeLists.txt index 7adb31c..75db747 100644 --- a/crypto/CMakeLists.txt +++ b/crypto/CMakeLists.txt | |||
| @@ -1003,21 +1003,6 @@ target_include_directories(crypto_obj | |||
| 1003 | ../include) | 1003 | ../include) |
| 1004 | 1004 | ||
| 1005 | add_library(crypto $<TARGET_OBJECTS:crypto_obj>) | 1005 | add_library(crypto $<TARGET_OBJECTS:crypto_obj>) |
| 1006 | target_include_directories(crypto | ||
| 1007 | PRIVATE | ||
| 1008 | . | ||
| 1009 | asn1 | ||
| 1010 | bn | ||
| 1011 | dsa | ||
| 1012 | ec | ||
| 1013 | ecdh | ||
| 1014 | ecdsa | ||
| 1015 | evp | ||
| 1016 | modes | ||
| 1017 | x509 | ||
| 1018 | ../include/compat | ||
| 1019 | PUBLIC | ||
| 1020 | ../include) | ||
| 1021 | 1006 | ||
| 1022 | export_symbol(crypto ${CMAKE_CURRENT_BINARY_DIR}/crypto_p.sym) | 1007 | export_symbol(crypto ${CMAKE_CURRENT_BINARY_DIR}/crypto_p.sym) |
| 1023 | target_link_libraries(crypto ${PLATFORM_LIBS}) | 1008 | target_link_libraries(crypto ${PLATFORM_LIBS}) |
| @@ -1042,21 +1027,6 @@ endif(ENABLE_LIBRESSL_INSTALL) | |||
| 1042 | # build static library for regression test | 1027 | # build static library for regression test |
| 1043 | if(BUILD_SHARED_LIBS) | 1028 | if(BUILD_SHARED_LIBS) |
| 1044 | add_library(crypto-static STATIC $<TARGET_OBJECTS:crypto_obj>) | 1029 | add_library(crypto-static STATIC $<TARGET_OBJECTS:crypto_obj>) |
| 1045 | target_include_directories(crypto-static | ||
| 1046 | PRIVATE | ||
| 1047 | . | ||
| 1048 | asn1 | ||
| 1049 | bn | ||
| 1050 | dsa | ||
| 1051 | ec | ||
| 1052 | ecdh | ||
| 1053 | ecdsa | ||
| 1054 | evp | ||
| 1055 | modes | ||
| 1056 | x509 | ||
| 1057 | ../include/compat | ||
| 1058 | PUBLIC | ||
| 1059 | ../include) | ||
| 1060 | target_link_libraries(crypto-static ${PLATFORM_LIBS}) | 1030 | target_link_libraries(crypto-static ${PLATFORM_LIBS}) |
| 1061 | endif() | 1031 | endif() |
| 1062 | 1032 | ||
diff --git a/ssl/CMakeLists.txt b/ssl/CMakeLists.txt index e4a3d95..039ef68 100644 --- a/ssl/CMakeLists.txt +++ b/ssl/CMakeLists.txt | |||
| @@ -63,12 +63,6 @@ target_include_directories(ssl_obj | |||
| 63 | ../include) | 63 | ../include) |
| 64 | 64 | ||
| 65 | add_library(ssl $<TARGET_OBJECTS:ssl_obj>) | 65 | add_library(ssl $<TARGET_OBJECTS:ssl_obj>) |
| 66 | target_include_directories(ssl | ||
| 67 | PRIVATE | ||
| 68 | . | ||
| 69 | ../include/compat | ||
| 70 | PUBLIC | ||
| 71 | ../include) | ||
| 72 | 66 | ||
| 73 | export_symbol(ssl ${CMAKE_CURRENT_SOURCE_DIR}/ssl.sym) | 67 | export_symbol(ssl ${CMAKE_CURRENT_SOURCE_DIR}/ssl.sym) |
| 74 | target_link_libraries(ssl crypto ${PLATFORM_LIBS}) | 68 | target_link_libraries(ssl crypto ${PLATFORM_LIBS}) |
| @@ -93,12 +87,6 @@ endif(ENABLE_LIBRESSL_INSTALL) | |||
| 93 | # build static library for regression test | 87 | # build static library for regression test |
| 94 | if(BUILD_SHARED_LIBS) | 88 | if(BUILD_SHARED_LIBS) |
| 95 | add_library(ssl-static STATIC $<TARGET_OBJECTS:ssl_obj>) | 89 | add_library(ssl-static STATIC $<TARGET_OBJECTS:ssl_obj>) |
| 96 | target_include_directories(ssl-static | ||
| 97 | PRIVATE | ||
| 98 | . | ||
| 99 | ../include/compat | ||
| 100 | PUBLIC | ||
| 101 | ../include) | ||
| 102 | target_link_libraries(ssl-static crypto-static ${PLATFORM_LIBS}) | 90 | target_link_libraries(ssl-static crypto-static ${PLATFORM_LIBS}) |
| 103 | endif() | 91 | endif() |
| 104 | 92 | ||
diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt index 4bbc512..d3725d1 100644 --- a/tests/CMakeLists.txt +++ b/tests/CMakeLists.txt | |||
| @@ -6,6 +6,7 @@ include_directories( | |||
| 6 | ../ssl | 6 | ../ssl |
| 7 | ../apps/openssl | 7 | ../apps/openssl |
| 8 | ../apps/openssl/compat | 8 | ../apps/openssl/compat |
| 9 | ../include | ||
| 9 | ../include/compat | 10 | ../include/compat |
| 10 | ) | 11 | ) |
| 11 | 12 | ||
diff --git a/tls/CMakeLists.txt b/tls/CMakeLists.txt index 17aedf0..15e5127 100644 --- a/tls/CMakeLists.txt +++ b/tls/CMakeLists.txt | |||
| @@ -48,12 +48,6 @@ target_include_directories(tls_obj | |||
| 48 | 48 | ||
| 49 | add_library(tls $<TARGET_OBJECTS:tls_obj> $<TARGET_OBJECTS:ssl_obj> | 49 | add_library(tls $<TARGET_OBJECTS:tls_obj> $<TARGET_OBJECTS:ssl_obj> |
| 50 | $<TARGET_OBJECTS:crypto_obj>) | 50 | $<TARGET_OBJECTS:crypto_obj>) |
| 51 | target_include_directories(tls | ||
| 52 | PRIVATE | ||
| 53 | . | ||
| 54 | ../include/compat | ||
| 55 | PUBLIC | ||
| 56 | ../include) | ||
| 57 | 51 | ||
| 58 | export_symbol(tls ${CMAKE_CURRENT_BINARY_DIR}/tls.sym) | 52 | export_symbol(tls ${CMAKE_CURRENT_BINARY_DIR}/tls.sym) |
| 59 | target_link_libraries(tls ${PLATFORM_LIBS}) | 53 | target_link_libraries(tls ${PLATFORM_LIBS}) |
| @@ -79,12 +73,6 @@ endif(ENABLE_LIBRESSL_INSTALL) | |||
| 79 | if(BUILD_SHARED_LIBS) | 73 | if(BUILD_SHARED_LIBS) |
| 80 | add_library(tls-static STATIC $<TARGET_OBJECTS:tls_obj> | 74 | add_library(tls-static STATIC $<TARGET_OBJECTS:tls_obj> |
| 81 | $<TARGET_OBJECTS:ssl_obj> $<TARGET_OBJECTS:crypto_obj>) | 75 | $<TARGET_OBJECTS:ssl_obj> $<TARGET_OBJECTS:crypto_obj>) |
| 82 | target_include_directories(tls-static | ||
| 83 | PRIVATE | ||
| 84 | . | ||
| 85 | ../include/compat | ||
| 86 | PUBLIC | ||
| 87 | ../include) | ||
| 88 | target_link_libraries(tls-static ${PLATFORM_LIBS}) | 76 | target_link_libraries(tls-static ${PLATFORM_LIBS}) |
| 89 | endif() | 77 | endif() |
| 90 | 78 | ||
