diff options
author | Rob Mensching <rob@firegiant.com> | 2022-10-25 11:29:34 -0700 |
---|---|---|
committer | Rob Mensching <rob@firegiant.com> | 2022-10-31 10:57:14 -0700 |
commit | 00a024e8595784e485115543f6045a0c5ea11ebc (patch) | |
tree | 0e9359de31b0f1bb4ae20873f036af957c6fa35a | |
parent | d993372ad5468cae88990bc31a2c825e742cd717 (diff) | |
download | wix-00a024e8595784e485115543f6045a0c5ea11ebc.tar.gz wix-00a024e8595784e485115543f6045a0c5ea11ebc.tar.bz2 wix-00a024e8595784e485115543f6045a0c5ea11ebc.zip |
Pack CA assembly only after it exists
Trying to pack the CA assembly before it is built reports erroneous
or redundant error messages so don't do that.
Fixes 6968
-rw-r--r-- | src/dtf/WixToolset.Dtf.CustomAction/WixToolset.Dtf.CustomAction.targets | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/dtf/WixToolset.Dtf.CustomAction/WixToolset.Dtf.CustomAction.targets b/src/dtf/WixToolset.Dtf.CustomAction/WixToolset.Dtf.CustomAction.targets index 9d63f24c..e83272a2 100644 --- a/src/dtf/WixToolset.Dtf.CustomAction/WixToolset.Dtf.CustomAction.targets +++ b/src/dtf/WixToolset.Dtf.CustomAction/WixToolset.Dtf.CustomAction.targets | |||
@@ -23,7 +23,10 @@ | |||
23 | PackCustomAction | 23 | PackCustomAction |
24 | 24 | ||
25 | Creates an MSI managed custom action package that includes the custom action assembly, | 25 | Creates an MSI managed custom action package that includes the custom action assembly, |
26 | local assembly dependencies, and project content files. | 26 | local assembly dependencies, and project content files. This target is skipped until the |
27 | custom action assembly has been built. This prevents the target from running (and failing) | ||
28 | during project restore and other scenarios where the project is executed but the assembly | ||
29 | build is skipped. | ||
27 | 30 | ||
28 | [IN] | 31 | [IN] |
29 | @(IntermediateAssembly) - Managed custom action assembly. | 32 | @(IntermediateAssembly) - Managed custom action assembly. |
@@ -36,7 +39,8 @@ | |||
36 | --> | 39 | --> |
37 | <Target Name="PackCustomAction" | 40 | <Target Name="PackCustomAction" |
38 | Inputs="@(IntermediateAssembly);@(Content);$(CustomActionContents)" | 41 | Inputs="@(IntermediateAssembly);@(Content);$(CustomActionContents)" |
39 | Outputs="$(IntermediateOutputPath)$(TargetCAFileName)"> | 42 | Outputs="$(IntermediateOutputPath)$(TargetCAFileName)" |
43 | Condition=" Exists('@(IntermediateAssembly)') "> | ||
40 | 44 | ||
41 | <!-- Find all referenced items marked CopyLocal, but exclude non-binary files. --> | 45 | <!-- Find all referenced items marked CopyLocal, but exclude non-binary files. --> |
42 | <ItemGroup> | 46 | <ItemGroup> |