aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBob Arnson <bob@firegiant.com>2020-09-19 21:20:31 -0400
committerBob Arnson <bob@firegiant.com>2020-09-19 21:24:09 -0400
commit27124207afa517da564cdce557dd21654f1a9078 (patch)
tree463cc9e3faf129fe7969f29c75a8c77f1ae21cbc
parent3f05c650723ecd0a8fe7ab151c67db6c13cb5d75 (diff)
downloadwix-27124207afa517da564cdce557dd21654f1a9078.tar.gz
wix-27124207afa517da564cdce557dd21654f1a9078.tar.bz2
wix-27124207afa517da564cdce557dd21654f1a9078.zip
Remove 32-bit ARM support.
-rw-r--r--src/WixToolset.Core.Burn/Bundles/ProcessMsiPackageCommand.cs2
-rw-r--r--src/WixToolset.Core.WindowsInstaller/Bind/BindSummaryInfoCommand.cs6
-rw-r--r--src/WixToolset.Core.WindowsInstaller/Decompile/Decompiler.cs6
-rw-r--r--src/WixToolset.Core/Compiler.cs10
-rw-r--r--src/WixToolset.Core/Compiler_2.cs21
-rw-r--r--src/WixToolset.Core/ExtensibilityServices/ParseHelper.cs12
-rw-r--r--src/WixToolset.Core/ExtensibilityServices/PreprocessHelper.cs6
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/ParseFixture.cs6
8 files changed, 8 insertions, 61 deletions
diff --git a/src/WixToolset.Core.Burn/Bundles/ProcessMsiPackageCommand.cs b/src/WixToolset.Core.Burn/Bundles/ProcessMsiPackageCommand.cs
index 3eb97ee6..7adbfcfd 100644
--- a/src/WixToolset.Core.Burn/Bundles/ProcessMsiPackageCommand.cs
+++ b/src/WixToolset.Core.Burn/Bundles/ProcessMsiPackageCommand.cs
@@ -80,7 +80,7 @@ namespace WixToolset.Core.Burn.Bundles
80 // "Elevated privileges are not required to install this package." 80 // "Elevated privileges are not required to install this package."
81 // in MSI 4.5 and below, if this bit is 0, elevation is required. 81 // in MSI 4.5 and below, if this bit is 0, elevation is required.
82 var perMachine = (0 == (sumInfo.WordCount & 8)); 82 var perMachine = (0 == (sumInfo.WordCount & 8));
83 var x64 = (sumInfo.Template.Contains("x64") || sumInfo.Template.Contains("Intel64")); 83 var x64 = sumInfo.Template.Contains("x64");
84 84
85 this.Facade.PackageSymbol.PerMachine = perMachine ? YesNoDefaultType.Yes : YesNoDefaultType.No; 85 this.Facade.PackageSymbol.PerMachine = perMachine ? YesNoDefaultType.Yes : YesNoDefaultType.No;
86 this.Facade.PackageSymbol.Win64 = x64; 86 this.Facade.PackageSymbol.Win64 = x64;
diff --git a/src/WixToolset.Core.WindowsInstaller/Bind/BindSummaryInfoCommand.cs b/src/WixToolset.Core.WindowsInstaller/Bind/BindSummaryInfoCommand.cs
index 63691016..6af2dc7a 100644
--- a/src/WixToolset.Core.WindowsInstaller/Bind/BindSummaryInfoCommand.cs
+++ b/src/WixToolset.Core.WindowsInstaller/Bind/BindSummaryInfoCommand.cs
@@ -154,15 +154,9 @@ namespace WixToolset.Core.WindowsInstaller.Bind
154 case "x64": 154 case "x64":
155 return Platform.X64; 155 return Platform.X64;
156 156
157 case "Arm":
158 return Platform.ARM;
159
160 case "Arm64": 157 case "Arm64":
161 return Platform.ARM64; 158 return Platform.ARM64;
162 159
163 case "Intel64":
164 return Platform.IA64;
165
166 case "Intel": 160 case "Intel":
167 default: 161 default:
168 return Platform.X86; 162 return Platform.X86;
diff --git a/src/WixToolset.Core.WindowsInstaller/Decompile/Decompiler.cs b/src/WixToolset.Core.WindowsInstaller/Decompile/Decompiler.cs
index e471d924..40643abd 100644
--- a/src/WixToolset.Core.WindowsInstaller/Decompile/Decompiler.cs
+++ b/src/WixToolset.Core.WindowsInstaller/Decompile/Decompiler.cs
@@ -3011,15 +3011,9 @@ namespace WixToolset.Core.WindowsInstaller
3011 case "Intel": 3011 case "Intel":
3012 xPackage.SetAttributeValue("Platform", "x86"); 3012 xPackage.SetAttributeValue("Platform", "x86");
3013 break; 3013 break;
3014 case "Intel64":
3015 xPackage.SetAttributeValue("Platform", "ia64");
3016 break;
3017 case "x64": 3014 case "x64":
3018 xPackage.SetAttributeValue("Platform", "x64"); 3015 xPackage.SetAttributeValue("Platform", "x64");
3019 break; 3016 break;
3020 case "Arm":
3021 xPackage.SetAttributeValue("Platform", "arm");
3022 break;
3023 case "Arm64": 3017 case "Arm64":
3024 xPackage.SetAttributeValue("Platform", "arm64"); 3018 xPackage.SetAttributeValue("Platform", "arm64");
3025 break; 3019 break;
diff --git a/src/WixToolset.Core/Compiler.cs b/src/WixToolset.Core/Compiler.cs
index 7be581bc..286a598b 100644
--- a/src/WixToolset.Core/Compiler.cs
+++ b/src/WixToolset.Core/Compiler.cs
@@ -82,7 +82,7 @@ namespace WixToolset.Core
82 /// Gets or sets the platform which the compiler will use when defaulting 64-bit attributes and elements. 82 /// Gets or sets the platform which the compiler will use when defaulting 64-bit attributes and elements.
83 /// </summary> 83 /// </summary>
84 /// <value>The platform which the compiler will use when defaulting 64-bit attributes and elements.</value> 84 /// <value>The platform which the compiler will use when defaulting 64-bit attributes and elements.</value>
85 public bool IsCurrentPlatform64Bit => this.Context.Platform == Platform.ARM64 || this.Context.Platform == Platform.IA64 || this.Context.Platform == Platform.X64; 85 public bool IsCurrentPlatform64Bit => this.Context.Platform == Platform.ARM64 || this.Context.Platform == Platform.X64;
86 86
87 /// <summary> 87 /// <summary>
88 /// Gets or sets the option to show pedantic messages. 88 /// Gets or sets the option to show pedantic messages.
@@ -5639,19 +5639,13 @@ namespace WixToolset.Core
5639 case "x64": 5639 case "x64":
5640 procArch = "amd64"; 5640 procArch = "amd64";
5641 break; 5641 break;
5642 case "ia64":
5643 procArch = "ia64";
5644 break;
5645 case "arm":
5646 procArch = "arm";
5647 break;
5648 case "arm64": 5642 case "arm64":
5649 procArch = "arm64"; 5643 procArch = "arm64";
5650 break; 5644 break;
5651 case "": 5645 case "":
5652 break; 5646 break;
5653 default: 5647 default:
5654 this.Core.Write(ErrorMessages.IllegalAttributeValue(sourceLineNumbers, "File", "ProcessorArchitecture", procArchValue, "msil", "x86", "x64", "ia64")); 5648 this.Core.Write(ErrorMessages.IllegalAttributeValue(sourceLineNumbers, "File", "ProcessorArchitecture", procArchValue, "msil", "x86", "x64"));
5655 break; 5649 break;
5656 } 5650 }
5657 break; 5651 break;
diff --git a/src/WixToolset.Core/Compiler_2.cs b/src/WixToolset.Core/Compiler_2.cs
index 11063bd8..204a3788 100644
--- a/src/WixToolset.Core/Compiler_2.cs
+++ b/src/WixToolset.Core/Compiler_2.cs
@@ -642,14 +642,6 @@ namespace WixToolset.Core
642 platform = "x64"; 642 platform = "x64";
643 msiVersion = 200; 643 msiVersion = 200;
644 break; 644 break;
645 case Platform.IA64:
646 platform = "Intel64";
647 msiVersion = 200;
648 break;
649 case Platform.ARM:
650 platform = "Arm";
651 msiVersion = 500;
652 break;
653 case Platform.ARM64: 645 case Platform.ARM64:
654 platform = "Arm64"; 646 platform = "Arm64";
655 msiVersion = 500; 647 msiVersion = 500;
@@ -766,15 +758,6 @@ namespace WixToolset.Core
766 case "x64": 758 case "x64":
767 platform = "x64"; 759 platform = "x64";
768 break; 760 break;
769 case "intel64":
770 this.Core.Write(WarningMessages.DeprecatedAttributeValue(sourceLineNumbers, platformValue, node.Name.LocalName, attrib.Name.LocalName, "ia64"));
771 goto case "ia64";
772 case "ia64":
773 platform = "Intel64";
774 break;
775 case "arm":
776 platform = "Arm";
777 break;
778 case "arm64": 761 case "arm64":
779 platform = "Arm64"; 762 platform = "Arm64";
780 break; 763 break;
@@ -823,13 +806,13 @@ namespace WixToolset.Core
823 this.Core.Write(ErrorMessages.IllegalAttributeWithOtherAttribute(sourceLineNumbers, node.Name.LocalName, "InstallPrivileges", "InstallScope")); 806 this.Core.Write(ErrorMessages.IllegalAttributeWithOtherAttribute(sourceLineNumbers, node.Name.LocalName, "InstallPrivileges", "InstallScope"));
824 } 807 }
825 808
826 if ((String.Equals(platform, "X64", StringComparison.OrdinalIgnoreCase) || String.Equals(platform, "Intel64", StringComparison.OrdinalIgnoreCase)) && 200 > msiVersion) 809 if (String.Equals(platform, "X64", StringComparison.OrdinalIgnoreCase) && 200 > msiVersion)
827 { 810 {
828 msiVersion = 200; 811 msiVersion = 200;
829 this.Core.Write(WarningMessages.RequiresMsi200for64bitPackage(sourceLineNumbers)); 812 this.Core.Write(WarningMessages.RequiresMsi200for64bitPackage(sourceLineNumbers));
830 } 813 }
831 814
832 if ((String.Equals(platform, "Arm", StringComparison.OrdinalIgnoreCase) || String.Equals(platform, "Arm64", StringComparison.OrdinalIgnoreCase)) && 500 > msiVersion) 815 if (String.Equals(platform, "Arm64", StringComparison.OrdinalIgnoreCase) && 500 > msiVersion)
833 { 816 {
834 msiVersion = 500; 817 msiVersion = 500;
835 this.Core.Write(WarningMessages.RequiresMsi500forArmPackage(sourceLineNumbers)); 818 this.Core.Write(WarningMessages.RequiresMsi500forArmPackage(sourceLineNumbers));
diff --git a/src/WixToolset.Core/ExtensibilityServices/ParseHelper.cs b/src/WixToolset.Core/ExtensibilityServices/ParseHelper.cs
index e75f5fe5..7f718ad4 100644
--- a/src/WixToolset.Core/ExtensibilityServices/ParseHelper.cs
+++ b/src/WixToolset.Core/ExtensibilityServices/ParseHelper.cs
@@ -138,12 +138,6 @@ namespace WixToolset.Core.ExtensibilityServices
138 suffix = "_X64"; 138 suffix = "_X64";
139 } 139 }
140 break; 140 break;
141 case Platform.ARM:
142 if ((supportedPlatforms & BurnPlatforms.ARM) == BurnPlatforms.ARM)
143 {
144 suffix = "_A32";
145 }
146 break;
147 case Platform.ARM64: 141 case Platform.ARM64:
148 if ((supportedPlatforms & BurnPlatforms.ARM64) == BurnPlatforms.ARM64) 142 if ((supportedPlatforms & BurnPlatforms.ARM64) == BurnPlatforms.ARM64)
149 { 143 {
@@ -907,12 +901,6 @@ namespace WixToolset.Core.ExtensibilityServices
907 suffix = "_X64"; 901 suffix = "_X64";
908 } 902 }
909 break; 903 break;
910 case Platform.ARM:
911 if ((supportedPlatforms & CustomActionPlatforms.ARM) == CustomActionPlatforms.ARM)
912 {
913 suffix = "_A32";
914 }
915 break;
916 case Platform.ARM64: 904 case Platform.ARM64:
917 if ((supportedPlatforms & CustomActionPlatforms.ARM64) == CustomActionPlatforms.ARM64) 905 if ((supportedPlatforms & CustomActionPlatforms.ARM64) == CustomActionPlatforms.ARM64)
918 { 906 {
diff --git a/src/WixToolset.Core/ExtensibilityServices/PreprocessHelper.cs b/src/WixToolset.Core/ExtensibilityServices/PreprocessHelper.cs
index e84bb001..df301196 100644
--- a/src/WixToolset.Core/ExtensibilityServices/PreprocessHelper.cs
+++ b/src/WixToolset.Core/ExtensibilityServices/PreprocessHelper.cs
@@ -238,12 +238,6 @@ namespace WixToolset.Core.ExtensibilityServices
238 case Platform.X64: 238 case Platform.X64:
239 return "x64"; 239 return "x64";
240 240
241 case Platform.IA64:
242 return "ia64";
243
244 case Platform.ARM:
245 return "arm";
246
247 case Platform.ARM64: 241 case Platform.ARM64:
248 return "arm64"; 242 return "arm64";
249 243
diff --git a/src/test/WixToolsetTest.CoreIntegration/ParseFixture.cs b/src/test/WixToolsetTest.CoreIntegration/ParseFixture.cs
index 83f74a47..387031b9 100644
--- a/src/test/WixToolsetTest.CoreIntegration/ParseFixture.cs
+++ b/src/test/WixToolsetTest.CoreIntegration/ParseFixture.cs
@@ -19,10 +19,10 @@ namespace WixToolsetTest.CoreIntegration
19 var section = new IntermediateSection("section", SectionType.Fragment, 0); 19 var section = new IntermediateSection("section", SectionType.Fragment, 0);
20 var parseHelper = serviceProvider.GetService<IParseHelper>(); 20 var parseHelper = serviceProvider.GetService<IParseHelper>();
21 21
22 parseHelper.CreateCustomActionReference(null, section, "CustomAction32", Platform.X86, CustomActionPlatforms.X86 | CustomActionPlatforms.ARM); 22 parseHelper.CreateCustomActionReference(null, section, "CustomAction32", Platform.X86, CustomActionPlatforms.X86);
23 parseHelper.CreateCustomActionReference(null, section, "CustomArmAction", Platform.ARM64, CustomActionPlatforms.X86 | CustomActionPlatforms.ARM); 23 parseHelper.CreateCustomActionReference(null, section, "CustomArmAction", Platform.ARM64, CustomActionPlatforms.X86);
24 parseHelper.CreateCustomActionReference(null, section, "CustomArmAction", Platform.ARM64, CustomActionPlatforms.X86 | CustomActionPlatforms.X64 | CustomActionPlatforms.ARM64); 24 parseHelper.CreateCustomActionReference(null, section, "CustomArmAction", Platform.ARM64, CustomActionPlatforms.X86 | CustomActionPlatforms.X64 | CustomActionPlatforms.ARM64);
25 parseHelper.CreateCustomActionReference(null, section, "CustomAction", Platform.X64, CustomActionPlatforms.X86 | CustomActionPlatforms.ARM); 25 parseHelper.CreateCustomActionReference(null, section, "CustomAction", Platform.X64, CustomActionPlatforms.X86);
26 parseHelper.CreateCustomActionReference(null, section, "CustomAction", Platform.X64, CustomActionPlatforms.X86 | CustomActionPlatforms.X64); 26 parseHelper.CreateCustomActionReference(null, section, "CustomAction", Platform.X64, CustomActionPlatforms.X86 | CustomActionPlatforms.X64);
27 27
28 var simpleReferences = section.Symbols.OfType<WixSimpleReferenceSymbol>(); 28 var simpleReferences = section.Symbols.OfType<WixSimpleReferenceSymbol>();