diff options
author | Rob Mensching <rob@firegiant.com> | 2022-11-17 14:11:08 -0800 |
---|---|---|
committer | Rob Mensching <rob@firegiant.com> | 2022-11-17 15:16:37 -0800 |
commit | 307e3f1bb587b93ad386bbfd9b2d4603a72d80c4 (patch) | |
tree | 0b821d9ab62e90e6a97b2013da44d836f49c4888 | |
parent | 61d12a71ca5d5b4e55800950b760331e2513802c (diff) | |
download | wix-307e3f1bb587b93ad386bbfd9b2d4603a72d80c4.tar.gz wix-307e3f1bb587b93ad386bbfd9b2d4603a72d80c4.tar.bz2 wix-307e3f1bb587b93ad386bbfd9b2d4603a72d80c4.zip |
Minor code clean up
-rw-r--r-- | src/wix/WixToolset.Core/Compiler.cs | 11 | ||||
-rw-r--r-- | src/wix/WixToolset.Core/Compiler_Package.cs | 5 |
2 files changed, 6 insertions, 10 deletions
diff --git a/src/wix/WixToolset.Core/Compiler.cs b/src/wix/WixToolset.Core/Compiler.cs index bd10fc55..60d4f10c 100644 --- a/src/wix/WixToolset.Core/Compiler.cs +++ b/src/wix/WixToolset.Core/Compiler.cs | |||
@@ -3981,7 +3981,6 @@ namespace WixToolset.Core | |||
3981 | var depth = CompilerConstants.IntegerNotSet; | 3981 | var depth = CompilerConstants.IntegerNotSet; |
3982 | string path = null; | 3982 | string path = null; |
3983 | var assignToProperty = false; | 3983 | var assignToProperty = false; |
3984 | string signature = null; | ||
3985 | 3984 | ||
3986 | foreach (var attrib in node.Attributes()) | 3985 | foreach (var attrib in node.Attributes()) |
3987 | { | 3986 | { |
@@ -4017,7 +4016,7 @@ namespace WixToolset.Core | |||
4017 | id = this.Core.CreateIdentifier("dir", path, depth.ToString()); | 4016 | id = this.Core.CreateIdentifier("dir", path, depth.ToString()); |
4018 | } | 4017 | } |
4019 | 4018 | ||
4020 | signature = id.Id; | 4019 | var signature = id.Id; |
4021 | 4020 | ||
4022 | var oneChild = false; | 4021 | var oneChild = false; |
4023 | var hasFileSearch = false; | 4022 | var hasFileSearch = false; |
@@ -4132,7 +4131,6 @@ namespace WixToolset.Core | |||
4132 | Identifier id = null; | 4131 | Identifier id = null; |
4133 | Identifier parent = null; | 4132 | Identifier parent = null; |
4134 | string path = null; | 4133 | string path = null; |
4135 | string signature = null; | ||
4136 | 4134 | ||
4137 | foreach (var attrib in node.Attributes()) | 4135 | foreach (var attrib in node.Attributes()) |
4138 | { | 4136 | { |
@@ -4177,7 +4175,7 @@ namespace WixToolset.Core | |||
4177 | id = this.Core.CreateIdentifier("dsr", parentSignature, path); | 4175 | id = this.Core.CreateIdentifier("dsr", parentSignature, path); |
4178 | } | 4176 | } |
4179 | 4177 | ||
4180 | signature = id.Id; | 4178 | var signature = id.Id; |
4181 | 4179 | ||
4182 | var oneChild = false; | 4180 | var oneChild = false; |
4183 | foreach (var child in node.Elements()) | 4181 | foreach (var child in node.Elements()) |
@@ -4258,7 +4256,6 @@ namespace WixToolset.Core | |||
4258 | var typicalDefault = FeatureTypicalDefault.Install; | 4256 | var typicalDefault = FeatureTypicalDefault.Install; |
4259 | var disallowAbsent = false; | 4257 | var disallowAbsent = false; |
4260 | var disallowAdvertise = false; | 4258 | var disallowAdvertise = false; |
4261 | var display = 0; | ||
4262 | 4259 | ||
4263 | foreach (var attrib in node.Attributes()) | 4260 | foreach (var attrib in node.Attributes()) |
4264 | { | 4261 | { |
@@ -4410,6 +4407,7 @@ namespace WixToolset.Core | |||
4410 | } | 4407 | } |
4411 | } | 4408 | } |
4412 | 4409 | ||
4410 | int display; | ||
4413 | switch (displayValue) | 4411 | switch (displayValue) |
4414 | { | 4412 | { |
4415 | case "collapse": | 4413 | case "collapse": |
@@ -6067,7 +6065,6 @@ namespace WixToolset.Core | |||
6067 | string name = null; | 6065 | string name = null; |
6068 | string section = null; | 6066 | string section = null; |
6069 | string shortName = null; | 6067 | string shortName = null; |
6070 | string signature = null; | ||
6071 | var type = 1; // default is file | 6068 | var type = 1; // default is file |
6072 | 6069 | ||
6073 | foreach (var attrib in node.Attributes()) | 6070 | foreach (var attrib in node.Attributes()) |
@@ -6145,7 +6142,7 @@ namespace WixToolset.Core | |||
6145 | id = this.Core.CreateIdentifier("ini", name, section, key, field.ToString(), type.ToString()); | 6142 | id = this.Core.CreateIdentifier("ini", name, section, key, field.ToString(), type.ToString()); |
6146 | } | 6143 | } |
6147 | 6144 | ||
6148 | signature = id.Id; | 6145 | var signature = id.Id; |
6149 | 6146 | ||
6150 | var oneChild = false; | 6147 | var oneChild = false; |
6151 | foreach (var child in node.Elements()) | 6148 | foreach (var child in node.Elements()) |
diff --git a/src/wix/WixToolset.Core/Compiler_Package.cs b/src/wix/WixToolset.Core/Compiler_Package.cs index e1bfb595..3c9e6d6a 100644 --- a/src/wix/WixToolset.Core/Compiler_Package.cs +++ b/src/wix/WixToolset.Core/Compiler_Package.cs | |||
@@ -539,8 +539,7 @@ namespace WixToolset.Core | |||
539 | switch (child.Name.LocalName) | 539 | switch (child.Name.LocalName) |
540 | { | 540 | { |
541 | case "ODBCDataSource": | 541 | case "ODBCDataSource": |
542 | string ignoredKeyPath = null; | 542 | this.ParseODBCDataSource(child, componentId, name, out _); |
543 | this.ParseODBCDataSource(child, componentId, name, out ignoredKeyPath); | ||
544 | break; | 543 | break; |
545 | case "Property": | 544 | case "Property": |
546 | this.ParseODBCProperty(child, id.Id, SymbolDefinitionType.ODBCAttribute); | 545 | this.ParseODBCProperty(child, id.Id, SymbolDefinitionType.ODBCAttribute); |
@@ -1009,7 +1008,7 @@ namespace WixToolset.Core | |||
1009 | var sourceLineNumbers = Preprocessor.GetSourceLineNumbers(node); | 1008 | var sourceLineNumbers = Preprocessor.GetSourceLineNumbers(node); |
1010 | var bits = new BitArray(32); | 1009 | var bits = new BitArray(32); |
1011 | string domain = null; | 1010 | string domain = null; |
1012 | string[] specialPermissions = null; | 1011 | string[] specialPermissions; |
1013 | string user = null; | 1012 | string user = null; |
1014 | 1013 | ||
1015 | switch (tableName) | 1014 | switch (tableName) |