aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBob Arnson <bob@firegiant.com>2021-02-23 17:43:08 -0500
committerBob Arnson <bob@firegiant.com>2021-02-23 17:48:38 -0500
commit41a337d00efa2f649ae5c1575ff55e568dc0b796 (patch)
tree626ed05cb76752862b1ab1a93983b204ee40e229
parent78837a56ad0fef5880201002a1a3a5918d688de5 (diff)
downloadwix-41a337d00efa2f649ae5c1575ff55e568dc0b796.tar.gz
wix-41a337d00efa2f649ae5c1575ff55e568dc0b796.tar.bz2
wix-41a337d00efa2f649ae5c1575ff55e568dc0b796.zip
Don't prefix custom action references.
Fixes https://github.com/wixtoolset/issues/issues/6365
-rw-r--r--src/WixToolset.Core/ExtensibilityServices/ParseHelper.cs3
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/ParseFixture.cs10
2 files changed, 6 insertions, 7 deletions
diff --git a/src/WixToolset.Core/ExtensibilityServices/ParseHelper.cs b/src/WixToolset.Core/ExtensibilityServices/ParseHelper.cs
index 6a71c4e9..ad2427e4 100644
--- a/src/WixToolset.Core/ExtensibilityServices/ParseHelper.cs
+++ b/src/WixToolset.Core/ExtensibilityServices/ParseHelper.cs
@@ -875,7 +875,6 @@ namespace WixToolset.Core.ExtensibilityServices
875 { 875 {
876 if (!this.Messaging.EncounteredError) 876 if (!this.Messaging.EncounteredError)
877 { 877 {
878 var name = String.Concat("Wix4", customAction);
879 var suffix = "_X86"; 878 var suffix = "_X86";
880 879
881 switch (currentPlatform) 880 switch (currentPlatform)
@@ -894,7 +893,7 @@ namespace WixToolset.Core.ExtensibilityServices
894 break; 893 break;
895 } 894 }
896 895
897 this.CreateSimpleReference(section, sourceLineNumbers, SymbolDefinitions.CustomAction, name + suffix); 896 this.CreateSimpleReference(section, sourceLineNumbers, SymbolDefinitions.CustomAction, customAction + suffix);
898 } 897 }
899 } 898 }
900 899
diff --git a/src/test/WixToolsetTest.CoreIntegration/ParseFixture.cs b/src/test/WixToolsetTest.CoreIntegration/ParseFixture.cs
index 387031b9..2d98a66c 100644
--- a/src/test/WixToolsetTest.CoreIntegration/ParseFixture.cs
+++ b/src/test/WixToolsetTest.CoreIntegration/ParseFixture.cs
@@ -26,11 +26,11 @@ namespace WixToolsetTest.CoreIntegration
26 parseHelper.CreateCustomActionReference(null, section, "CustomAction", Platform.X64, CustomActionPlatforms.X86 | CustomActionPlatforms.X64); 26 parseHelper.CreateCustomActionReference(null, section, "CustomAction", Platform.X64, CustomActionPlatforms.X86 | CustomActionPlatforms.X64);
27 27
28 var simpleReferences = section.Symbols.OfType<WixSimpleReferenceSymbol>(); 28 var simpleReferences = section.Symbols.OfType<WixSimpleReferenceSymbol>();
29 Assert.NotNull(simpleReferences.Where(t => t.SymbolicName == "CustomAction:Wix4CustomAction32_X86").FirstOrDefault()); 29 Assert.NotNull(simpleReferences.Where(t => t.SymbolicName == "CustomAction:CustomAction32_X86").FirstOrDefault());
30 Assert.NotNull(simpleReferences.Where(t => t.SymbolicName == "CustomAction:Wix4CustomArmAction_X86").FirstOrDefault()); 30 Assert.NotNull(simpleReferences.Where(t => t.SymbolicName == "CustomAction:CustomArmAction_X86").FirstOrDefault());
31 Assert.NotNull(simpleReferences.Where(t => t.SymbolicName == "CustomAction:Wix4CustomArmAction_A64").FirstOrDefault()); 31 Assert.NotNull(simpleReferences.Where(t => t.SymbolicName == "CustomAction:CustomArmAction_A64").FirstOrDefault());
32 Assert.NotNull(simpleReferences.Where(t => t.SymbolicName == "CustomAction:Wix4CustomAction_X86").FirstOrDefault()); 32 Assert.NotNull(simpleReferences.Where(t => t.SymbolicName == "CustomAction:CustomAction_X86").FirstOrDefault());
33 Assert.NotNull(simpleReferences.Where(t => t.SymbolicName == "CustomAction:Wix4CustomAction_X64").FirstOrDefault()); 33 Assert.NotNull(simpleReferences.Where(t => t.SymbolicName == "CustomAction:CustomAction_X64").FirstOrDefault());
34 } 34 }
35 } 35 }
36} 36}