diff options
| author | Rob Mensching <rob@firegiant.com> | 2026-02-05 14:52:18 -0800 |
|---|---|---|
| committer | Rob Mensching <rob@firegiant.com> | 2026-02-05 15:57:22 -0800 |
| commit | 52fe5c099b4f97fa43e0e683d704310712adcc2b (patch) | |
| tree | 685b56b8cb174b7919e934f9d750775564aa5839 | |
| parent | c258b72508f1b25a56e5d3ee3df08650ba1cbe36 (diff) | |
| download | wix-52fe5c099b4f97fa43e0e683d704310712adcc2b.tar.gz wix-52fe5c099b4f97fa43e0e683d704310712adcc2b.tar.bz2 wix-52fe5c099b4f97fa43e0e683d704310712adcc2b.zip | |
Update to latest sign tool and sign command-line requirements
| -rw-r--r-- | .github/workflows/build.yml | 19 | ||||
| -rw-r--r-- | src/Directory.Build.targets | 2 |
2 files changed, 16 insertions, 5 deletions
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 554d3c17..2c611356 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml | |||
| @@ -41,7 +41,7 @@ jobs: | |||
| 41 | - name: Install sign tool | 41 | - name: Install sign tool |
| 42 | if: ${{ env.SignBuild == 'true' }} | 42 | if: ${{ env.SignBuild == 'true' }} |
| 43 | shell: cmd | 43 | shell: cmd |
| 44 | run: dotnet tool install --tool-path build\.tools sign --version 0.9.1-beta.24170.3 | 44 | run: dotnet tool install --tool-path build\.tools sign --version 0.9.1-beta.25330.2 |
| 45 | 45 | ||
| 46 | - name: Configure automated logging and crash dumps | 46 | - name: Configure automated logging and crash dumps |
| 47 | shell: cmd | 47 | shell: cmd |
| @@ -63,15 +63,26 @@ jobs: | |||
| 63 | # client-id: ${{ secrets.WIX_SIGNING_CLIENTID }} | 63 | # client-id: ${{ secrets.WIX_SIGNING_CLIENTID }} |
| 64 | # tenant-id: ${{ secrets.WIX_SIGNING_TENANTID }} | 64 | # tenant-id: ${{ secrets.WIX_SIGNING_TENANTID }} |
| 65 | 65 | ||
| 66 | - name: Dump GitHub OIDC claims (diagnostic) | ||
| 67 | shell: pwsh | ||
| 68 | run: | | ||
| 69 | $token = Invoke-RestMethod ` | ||
| 70 | -Headers @{ Authorization = "Bearer $env:ACTIONS_ID_TOKEN_REQUEST_TOKEN" } ` | ||
| 71 | -Uri "$env:ACTIONS_ID_TOKEN_REQUEST_URL&audience=api://AzureADTokenExchange" | ||
| 72 | $parts = $token.value.Split('.') | ||
| 73 | $claims = [System.Text.Encoding]::UTF8.GetString([Convert]::FromBase64String($parts[1] + '==')) | ||
| 74 | Write-Host $claims | ||
| 75 | |||
| 76 | |||
| 66 | - name: Build wix7 | 77 | - name: Build wix7 |
| 67 | shell: cmd | 78 | shell: cmd |
| 68 | run: ./src/build_official.cmd | 79 | run: ./src/build_official.cmd |
| 69 | env: | 80 | env: |
| 70 | RuntimeTestsEnabled: true | 81 | RuntimeTestsEnabled: true |
| 82 | AZURE_CLIENT_ID: ${{ env.SignBuild == 'true' && secrets.WIX_SIGNING_CLIENTID || '' }} | ||
| 83 | AZURE_TENANT_ID: ${{ env.SignBuild == 'true' && secrets.WIX_SIGNING_TENANTID || '' }} | ||
| 84 | AZURE_IDENTITY_LOGGING_ENABLED: true | ||
| 71 | SigningKeyVaultUri: ${{ env.SignBuild == 'true' && secrets.WIX_SIGNING_VAULTURI || '' }} | 85 | SigningKeyVaultUri: ${{ env.SignBuild == 'true' && secrets.WIX_SIGNING_VAULTURI || '' }} |
| 72 | SigningTenantId: ${{ env.SignBuild == 'true' && secrets.WIX_SIGNING_TENANTID || '' }} | ||
| 73 | SigningClientId: ${{ env.SignBuild == 'true' && secrets.WIX_SIGNING_CLIENTID || '' }} | ||
| 74 | SigningClientSecret: ${{ env.SignBuild == 'true' && secrets.WIX_SIGNING_SECRET || '' }} | ||
| 75 | SigningCertName: ${{ env.SignBuild == 'true' && secrets.WIX_SIGNING_CERTNAME || '' }} | 86 | SigningCertName: ${{ env.SignBuild == 'true' && secrets.WIX_SIGNING_CERTNAME || '' }} |
| 76 | 87 | ||
| 77 | - name: Validate test results | 88 | - name: Validate test results |
diff --git a/src/Directory.Build.targets b/src/Directory.Build.targets index 45320d19..d22a5e36 100644 --- a/src/Directory.Build.targets +++ b/src/Directory.Build.targets | |||
| @@ -5,7 +5,7 @@ | |||
| 5 | <PropertyGroup> | 5 | <PropertyGroup> |
| 6 | <SigningToolExe>$(ToolsFolder)\sign.exe</SigningToolExe> | 6 | <SigningToolExe>$(ToolsFolder)\sign.exe</SigningToolExe> |
| 7 | <SigningCommand>code azure-key-vault</SigningCommand> | 7 | <SigningCommand>code azure-key-vault</SigningCommand> |
| 8 | <SigningConfiguration>--description "WiX Toolset" --description-url "https://wixtoolset.org/" --recurse-containers=false --azure-key-vault-url $(SigningKeyVaultUri) --azure-key-vault-tenant-id $(SigningTenantId) --azure-key-vault-client-id $(SigningClientId) --azure-key-vault-client-secret $(SigningClientSecret) --azure-key-vault-certificate $(SigningCertName) --timestamp-url "http://timestamp.digicert.com"</SigningConfiguration> | 8 | <SigningConfiguration>--publisher-name "WiX Toolset" --description "WiX Toolset" --description-url "https://wixtoolset.org/" --recurse-containers=false --azure-credential-type workload-identity --azure-key-vault-url "$(SigningKeyVaultUri)" --azure-key-vault-certificate "$(SigningCertName)"</SigningConfiguration> |
| 9 | </PropertyGroup> | 9 | </PropertyGroup> |
| 10 | 10 | ||
| 11 | <PropertyGroup Condition=" '$(IsWixTestSupportProject)'=='true' "> | 11 | <PropertyGroup Condition=" '$(IsWixTestSupportProject)'=='true' "> |
