aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBob Arnson <bob@firegiant.com>2020-12-26 21:15:06 -0600
committerSean Hall <r.sean.hall@gmail.com>2021-01-11 12:20:07 -0600
commit5bab3f6ae97b62bb6e79378010c08a13e48fde5a (patch)
tree01d648f19b9523de128686443afd407afc8db84f
parentb20a77911c6a2b096f021639e0daadae7430091c (diff)
downloadwix-5bab3f6ae97b62bb6e79378010c08a13e48fde5a.tar.gz
wix-5bab3f6ae97b62bb6e79378010c08a13e48fde5a.tar.bz2
wix-5bab3f6ae97b62bb6e79378010c08a13e48fde5a.zip
Upgrade to latest dutil as first step for x64 and ARM64
-rw-r--r--src/engine/elevation.cpp8
-rw-r--r--src/engine/embedded.cpp4
-rw-r--r--src/engine/engine.vcxproj4
-rw-r--r--src/engine/externalengine.cpp4
-rw-r--r--src/engine/packages.config2
-rw-r--r--src/engine/pipe.cpp22
-rw-r--r--src/engine/pipe.h4
-rw-r--r--src/engine/registration.cpp2
-rw-r--r--src/engine/registration.h4
-rw-r--r--src/engine/section.cpp2
-rw-r--r--src/engine/section.h2
-rw-r--r--src/engine/splashscreen.cpp2
-rw-r--r--src/engine/uithread.cpp2
-rw-r--r--src/engine/variable.cpp8
-rw-r--r--src/engine/variable.h4
-rw-r--r--src/stub/packages.config2
-rw-r--r--src/stub/stub.vcxproj4
-rw-r--r--src/test/BurnUnitTest/BurnUnitTest.vcxproj6
-rw-r--r--src/test/BurnUnitTest/packages.config2
19 files changed, 44 insertions, 44 deletions
diff --git a/src/engine/elevation.cpp b/src/engine/elevation.cpp
index af5610dc..94418dc3 100644
--- a/src/engine/elevation.cpp
+++ b/src/engine/elevation.cpp
@@ -865,7 +865,7 @@ extern "C" HRESULT ElevationExecuteMsiPackage(
865 hr = BuffWriteString(&pbData, &cbData, pExecuteAction->msiPackage.pPackage->sczId); 865 hr = BuffWriteString(&pbData, &cbData, pExecuteAction->msiPackage.pPackage->sczId);
866 ExitOnFailure(hr, "Failed to write package id to message buffer."); 866 ExitOnFailure(hr, "Failed to write package id to message buffer.");
867 867
868 hr = BuffWriteNumber(&pbData, &cbData, (DWORD)hwndParent); 868 hr = BuffWritePointer(&pbData, &cbData, (DWORD_PTR)hwndParent);
869 ExitOnFailure(hr, "Failed to write parent hwnd to message buffer."); 869 ExitOnFailure(hr, "Failed to write parent hwnd to message buffer.");
870 870
871 hr = BuffWriteString(&pbData, &cbData, pExecuteAction->msiPackage.sczLogPath); 871 hr = BuffWriteString(&pbData, &cbData, pExecuteAction->msiPackage.sczLogPath);
@@ -944,7 +944,7 @@ extern "C" HRESULT ElevationExecuteMspPackage(
944 hr = BuffWriteString(&pbData, &cbData, pExecuteAction->mspTarget.pPackage->sczId); 944 hr = BuffWriteString(&pbData, &cbData, pExecuteAction->mspTarget.pPackage->sczId);
945 ExitOnFailure(hr, "Failed to write package id to message buffer."); 945 ExitOnFailure(hr, "Failed to write package id to message buffer.");
946 946
947 hr = BuffWriteNumber(&pbData, &cbData, (DWORD)hwndParent); 947 hr = BuffWritePointer(&pbData, &cbData, (DWORD_PTR)hwndParent);
948 ExitOnFailure(hr, "Failed to write parent hwnd to message buffer."); 948 ExitOnFailure(hr, "Failed to write parent hwnd to message buffer.");
949 949
950 hr = BuffWriteString(&pbData, &cbData, pExecuteAction->mspTarget.sczTargetProductCode); 950 hr = BuffWriteString(&pbData, &cbData, pExecuteAction->mspTarget.sczTargetProductCode);
@@ -2322,7 +2322,7 @@ static HRESULT OnExecuteMsiPackage(
2322 hr = PackageFindById(pPackages, sczPackage, &executeAction.msiPackage.pPackage); 2322 hr = PackageFindById(pPackages, sczPackage, &executeAction.msiPackage.pPackage);
2323 ExitOnFailure(hr, "Failed to find package: %ls", sczPackage); 2323 ExitOnFailure(hr, "Failed to find package: %ls", sczPackage);
2324 2324
2325 hr = BuffReadNumber(pbData, cbData, &iData, (DWORD*)&hwndParent); 2325 hr = BuffReadPointer(pbData, cbData, &iData, (DWORD_PTR*)&hwndParent);
2326 ExitOnFailure(hr, "Failed to read parent hwnd."); 2326 ExitOnFailure(hr, "Failed to read parent hwnd.");
2327 2327
2328 hr = BuffReadString(pbData, cbData, &iData, &executeAction.msiPackage.sczLogPath); 2328 hr = BuffReadString(pbData, cbData, &iData, &executeAction.msiPackage.sczLogPath);
@@ -2420,7 +2420,7 @@ static HRESULT OnExecuteMspPackage(
2420 hr = PackageFindById(pPackages, sczPackage, &executeAction.mspTarget.pPackage); 2420 hr = PackageFindById(pPackages, sczPackage, &executeAction.mspTarget.pPackage);
2421 ExitOnFailure(hr, "Failed to find package: %ls", sczPackage); 2421 ExitOnFailure(hr, "Failed to find package: %ls", sczPackage);
2422 2422
2423 hr = BuffReadNumber(pbData, cbData, &iData, (DWORD*)&hwndParent); 2423 hr = BuffReadPointer(pbData, cbData, &iData, (DWORD_PTR*)&hwndParent);
2424 ExitOnFailure(hr, "Failed to read parent hwnd."); 2424 ExitOnFailure(hr, "Failed to read parent hwnd.");
2425 2425
2426 executeAction.mspTarget.fPerMachineTarget = TRUE; // we're in the elevated process, clearly we're targeting a per-machine product. 2426 executeAction.mspTarget.fPerMachineTarget = TRUE; // we're in the elevated process, clearly we're targeting a per-machine product.
diff --git a/src/engine/embedded.cpp b/src/engine/embedded.cpp
index 09666980..b512b365 100644
--- a/src/engine/embedded.cpp
+++ b/src/engine/embedded.cpp
@@ -147,7 +147,7 @@ static HRESULT OnEmbeddedErrorMessage(
147 ) 147 )
148{ 148{
149 HRESULT hr = S_OK; 149 HRESULT hr = S_OK;
150 DWORD iData = 0; 150 SIZE_T iData = 0;
151 GENERIC_EXECUTE_MESSAGE message = { }; 151 GENERIC_EXECUTE_MESSAGE message = { };
152 LPWSTR sczMessage = NULL; 152 LPWSTR sczMessage = NULL;
153 153
@@ -181,7 +181,7 @@ static HRESULT OnEmbeddedProgress(
181 ) 181 )
182{ 182{
183 HRESULT hr = S_OK; 183 HRESULT hr = S_OK;
184 DWORD iData = 0; 184 SIZE_T iData = 0;
185 GENERIC_EXECUTE_MESSAGE message = { }; 185 GENERIC_EXECUTE_MESSAGE message = { };
186 186
187 message.type = GENERIC_EXECUTE_MESSAGE_PROGRESS; 187 message.type = GENERIC_EXECUTE_MESSAGE_PROGRESS;
diff --git a/src/engine/engine.vcxproj b/src/engine/engine.vcxproj
index 3624d923..d62105ed 100644
--- a/src/engine/engine.vcxproj
+++ b/src/engine/engine.vcxproj
@@ -2,7 +2,7 @@
2<!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the Microsoft Reciprocal License. See LICENSE.TXT file in the project root for full license information. --> 2<!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the Microsoft Reciprocal License. See LICENSE.TXT file in the project root for full license information. -->
3 3
4<Project DefaultTargets="Build" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> 4<Project DefaultTargets="Build" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
5 <Import Project="..\..\packages\WixToolset.DUtil.4.0.56\build\WixToolset.DUtil.props" Condition="Exists('..\..\packages\WixToolset.DUtil.4.0.56\build\WixToolset.DUtil.props')" /> 5 <Import Project="..\..\packages\WixToolset.DUtil.4.0.59\build\WixToolset.DUtil.props" Condition="Exists('..\..\packages\WixToolset.DUtil.4.0.59\build\WixToolset.DUtil.props')" />
6 6
7 <ItemGroup Label="ProjectConfigurations"> 7 <ItemGroup Label="ProjectConfigurations">
8 <ProjectConfiguration Include="Debug|Win32"> 8 <ProjectConfiguration Include="Debug|Win32">
@@ -174,7 +174,7 @@ rc.exe -fo "$(OutDir)engine.res" "$(IntDir)engine.messages.rc"</Command>
174 <PropertyGroup> 174 <PropertyGroup>
175 <ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText> 175 <ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
176 </PropertyGroup> 176 </PropertyGroup>
177 <Error Condition="!Exists('..\..\packages\WixToolset.DUtil.4.0.56\build\WixToolset.DUtil.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\WixToolset.DUtil.4.0.56\build\WixToolset.DUtil.props'))" /> 177 <Error Condition="!Exists('..\..\packages\WixToolset.DUtil.4.0.59\build\WixToolset.DUtil.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\WixToolset.DUtil.4.0.59\build\WixToolset.DUtil.props'))" />
178 <Error Condition="!Exists('..\..\packages\Nerdbank.GitVersioning.3.3.37\build\Nerdbank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Nerdbank.GitVersioning.3.3.37\build\Nerdbank.GitVersioning.targets'))" /> 178 <Error Condition="!Exists('..\..\packages\Nerdbank.GitVersioning.3.3.37\build\Nerdbank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Nerdbank.GitVersioning.3.3.37\build\Nerdbank.GitVersioning.targets'))" />
179 </Target> 179 </Target>
180</Project> \ No newline at end of file 180</Project> \ No newline at end of file
diff --git a/src/engine/externalengine.cpp b/src/engine/externalengine.cpp
index 3d5b3696..39878c8b 100644
--- a/src/engine/externalengine.cpp
+++ b/src/engine/externalengine.cpp
@@ -194,7 +194,7 @@ HRESULT ExternalEngineSendEmbeddedError(
194{ 194{
195 HRESULT hr = S_OK; 195 HRESULT hr = S_OK;
196 BYTE* pbData = NULL; 196 BYTE* pbData = NULL;
197 DWORD cbData = 0; 197 SIZE_T cbData = 0;
198 DWORD dwResult = *pnResult = 0; 198 DWORD dwResult = *pnResult = 0;
199 199
200 if (BURN_MODE_EMBEDDED != pEngineState->mode) 200 if (BURN_MODE_EMBEDDED != pEngineState->mode)
@@ -232,7 +232,7 @@ HRESULT ExternalEngineSendEmbeddedProgress(
232{ 232{
233 HRESULT hr = S_OK; 233 HRESULT hr = S_OK;
234 BYTE* pbData = NULL; 234 BYTE* pbData = NULL;
235 DWORD cbData = 0; 235 SIZE_T cbData = 0;
236 DWORD dwResult = *pnResult = 0; 236 DWORD dwResult = *pnResult = 0;
237 237
238 if (BURN_MODE_EMBEDDED != pEngineState->mode) 238 if (BURN_MODE_EMBEDDED != pEngineState->mode)
diff --git a/src/engine/packages.config b/src/engine/packages.config
index dc425a64..f074ae43 100644
--- a/src/engine/packages.config
+++ b/src/engine/packages.config
@@ -1,5 +1,5 @@
1<?xml version="1.0" encoding="utf-8"?> 1<?xml version="1.0" encoding="utf-8"?>
2<packages> 2<packages>
3 <package id="Nerdbank.GitVersioning" version="3.3.37" targetFramework="native" developmentDependency="true" /> 3 <package id="Nerdbank.GitVersioning" version="3.3.37" targetFramework="native" developmentDependency="true" />
4 <package id="WixToolset.DUtil" version="4.0.56" targetFramework="native" /> 4 <package id="WixToolset.DUtil" version="4.0.59" targetFramework="native" />
5</packages> \ No newline at end of file 5</packages> \ No newline at end of file
diff --git a/src/engine/pipe.cpp b/src/engine/pipe.cpp
index 7ecc4859..eb3eb863 100644
--- a/src/engine/pipe.cpp
+++ b/src/engine/pipe.cpp
@@ -12,9 +12,9 @@ static const LPCWSTR CACHE_PIPE_NAME_FORMAT_STRING = L"\\\\.\\pipe\\%ls.Cache";
12static HRESULT AllocatePipeMessage( 12static HRESULT AllocatePipeMessage(
13 __in DWORD dwMessage, 13 __in DWORD dwMessage,
14 __in_bcount_opt(cbData) LPVOID pvData, 14 __in_bcount_opt(cbData) LPVOID pvData,
15 __in DWORD cbData, 15 __in SIZE_T cbData,
16 __out_bcount(cb) LPVOID* ppvMessage, 16 __out_bcount(cb) LPVOID* ppvMessage,
17 __out DWORD* cbMessage 17 __out SIZE_T* cbMessage
18 ); 18 );
19static void FreePipeMessage( 19static void FreePipeMessage(
20 __in BURN_PIPE_MESSAGE *pMsg 20 __in BURN_PIPE_MESSAGE *pMsg
@@ -23,7 +23,7 @@ static HRESULT WritePipeMessage(
23 __in HANDLE hPipe, 23 __in HANDLE hPipe,
24 __in DWORD dwMessage, 24 __in DWORD dwMessage,
25 __in_bcount_opt(cbData) LPVOID pvData, 25 __in_bcount_opt(cbData) LPVOID pvData,
26 __in DWORD cbData 26 __in SIZE_T cbData
27 ); 27 );
28static HRESULT GetPipeMessage( 28static HRESULT GetPipeMessage(
29 __in HANDLE hPipe, 29 __in HANDLE hPipe,
@@ -77,7 +77,7 @@ extern "C" HRESULT PipeSendMessage(
77 __in HANDLE hPipe, 77 __in HANDLE hPipe,
78 __in DWORD dwMessage, 78 __in DWORD dwMessage,
79 __in_bcount_opt(cbData) LPVOID pvData, 79 __in_bcount_opt(cbData) LPVOID pvData,
80 __in DWORD cbData, 80 __in SIZE_T cbData,
81 __in_opt PFN_PIPE_MESSAGE_CALLBACK pfnCallback, 81 __in_opt PFN_PIPE_MESSAGE_CALLBACK pfnCallback,
82 __in_opt LPVOID pvContext, 82 __in_opt LPVOID pvContext,
83 __out DWORD* pdwResult 83 __out DWORD* pdwResult
@@ -665,14 +665,14 @@ LExit:
665static HRESULT AllocatePipeMessage( 665static HRESULT AllocatePipeMessage(
666 __in DWORD dwMessage, 666 __in DWORD dwMessage,
667 __in_bcount_opt(cbData) LPVOID pvData, 667 __in_bcount_opt(cbData) LPVOID pvData,
668 __in DWORD cbData, 668 __in SIZE_T cbData,
669 __out_bcount(cb) LPVOID* ppvMessage, 669 __out_bcount(cb) LPVOID* ppvMessage,
670 __out DWORD* cbMessage 670 __out SIZE_T* cbMessage
671 ) 671 )
672{ 672{
673 HRESULT hr = S_OK; 673 HRESULT hr = S_OK;
674 LPVOID pv = NULL; 674 LPVOID pv = NULL;
675 DWORD cb = 0; 675 SIZE_T cb = 0;
676 676
677 // If no data was provided, ensure the count of bytes is zero. 677 // If no data was provided, ensure the count of bytes is zero.
678 if (!pvData) 678 if (!pvData)
@@ -716,22 +716,22 @@ static HRESULT WritePipeMessage(
716 __in HANDLE hPipe, 716 __in HANDLE hPipe,
717 __in DWORD dwMessage, 717 __in DWORD dwMessage,
718 __in_bcount_opt(cbData) LPVOID pvData, 718 __in_bcount_opt(cbData) LPVOID pvData,
719 __in DWORD cbData 719 __in SIZE_T cbData
720 ) 720 )
721{ 721{
722 HRESULT hr = S_OK; 722 HRESULT hr = S_OK;
723 LPVOID pv = NULL; 723 LPVOID pv = NULL;
724 DWORD cb = 0; 724 SIZE_T cb = 0;
725 725
726 hr = AllocatePipeMessage(dwMessage, pvData, cbData, &pv, &cb); 726 hr = AllocatePipeMessage(dwMessage, pvData, cbData, &pv, &cb);
727 ExitOnFailure(hr, "Failed to allocate message to write."); 727 ExitOnFailure(hr, "Failed to allocate message to write.");
728 728
729 // Write the message. 729 // Write the message.
730 DWORD cbWrote = 0; 730 DWORD cbWrote = 0;
731 DWORD cbTotalWritten = 0; 731 SIZE_T cbTotalWritten = 0;
732 while (cbTotalWritten < cb) 732 while (cbTotalWritten < cb)
733 { 733 {
734 if (!::WriteFile(hPipe, pv, cb - cbTotalWritten, &cbWrote, NULL)) 734 if (!::WriteFile(hPipe, pv, (DWORD)(cb - cbTotalWritten), &cbWrote, NULL))
735 { 735 {
736 ExitWithLastError(hr, "Failed to write message type to pipe."); 736 ExitWithLastError(hr, "Failed to write message type to pipe.");
737 } 737 }
diff --git a/src/engine/pipe.h b/src/engine/pipe.h
index b6a7742a..085c3a76 100644
--- a/src/engine/pipe.h
+++ b/src/engine/pipe.h
@@ -17,7 +17,7 @@ typedef struct _BURN_PIPE_CONNECTION
17 HANDLE hCachePipe; 17 HANDLE hCachePipe;
18} BURN_PIPE_CONNECTION; 18} BURN_PIPE_CONNECTION;
19 19
20typedef enum _BURN_PIPE_MESSAGE_TYPE 20typedef enum _BURN_PIPE_MESSAGE_TYPE : DWORD
21{ 21{
22 BURN_PIPE_MESSAGE_TYPE_LOG = 0xF0000001, 22 BURN_PIPE_MESSAGE_TYPE_LOG = 0xF0000001,
23 BURN_PIPE_MESSAGE_TYPE_COMPLETE = 0xF0000002, 23 BURN_PIPE_MESSAGE_TYPE_COMPLETE = 0xF0000002,
@@ -58,7 +58,7 @@ HRESULT PipeSendMessage(
58 __in HANDLE hPipe, 58 __in HANDLE hPipe,
59 __in DWORD dwMessage, 59 __in DWORD dwMessage,
60 __in_bcount_opt(cbData) LPVOID pvData, 60 __in_bcount_opt(cbData) LPVOID pvData,
61 __in DWORD cbData, 61 __in SIZE_T cbData,
62 __in_opt PFN_PIPE_MESSAGE_CALLBACK pfnCallback, 62 __in_opt PFN_PIPE_MESSAGE_CALLBACK pfnCallback,
63 __in_opt LPVOID pvContext, 63 __in_opt LPVOID pvContext,
64 __out DWORD* pdwResult 64 __out DWORD* pdwResult
diff --git a/src/engine/registration.cpp b/src/engine/registration.cpp
index 4e8c810d..d3732e74 100644
--- a/src/engine/registration.cpp
+++ b/src/engine/registration.cpp
@@ -982,7 +982,7 @@ LExit:
982extern "C" HRESULT RegistrationLoadState( 982extern "C" HRESULT RegistrationLoadState(
983 __in BURN_REGISTRATION* pRegistration, 983 __in BURN_REGISTRATION* pRegistration,
984 __out_bcount(*pcbBuffer) BYTE** ppbBuffer, 984 __out_bcount(*pcbBuffer) BYTE** ppbBuffer,
985 __out DWORD* pcbBuffer 985 __out SIZE_T* pcbBuffer
986 ) 986 )
987{ 987{
988 // read data from file 988 // read data from file
diff --git a/src/engine/registration.h b/src/engine/registration.h
index fa7be368..dc9bc5b7 100644
--- a/src/engine/registration.h
+++ b/src/engine/registration.h
@@ -196,12 +196,12 @@ HRESULT RegistrationSessionEnd(
196HRESULT RegistrationSaveState( 196HRESULT RegistrationSaveState(
197 __in BURN_REGISTRATION* pRegistration, 197 __in BURN_REGISTRATION* pRegistration,
198 __in_bcount_opt(cbBuffer) BYTE* pbBuffer, 198 __in_bcount_opt(cbBuffer) BYTE* pbBuffer,
199 __in_opt DWORD cbBuffer 199 __in_opt SIZE_T cbBuffer
200 ); 200 );
201HRESULT RegistrationLoadState( 201HRESULT RegistrationLoadState(
202 __in BURN_REGISTRATION* pRegistration, 202 __in BURN_REGISTRATION* pRegistration,
203 __out_bcount(*pcbBuffer) BYTE** ppbBuffer, 203 __out_bcount(*pcbBuffer) BYTE** ppbBuffer,
204 __out DWORD* pcbBuffer 204 __out SIZE_T* pcbBuffer
205 ); 205 );
206HRESULT RegistrationGetResumeCommandLine( 206HRESULT RegistrationGetResumeCommandLine(
207 __in const BURN_REGISTRATION* pRegistration, 207 __in const BURN_REGISTRATION* pRegistration,
diff --git a/src/engine/section.cpp b/src/engine/section.cpp
index 3adcdd14..3720155c 100644
--- a/src/engine/section.cpp
+++ b/src/engine/section.cpp
@@ -51,7 +51,7 @@ extern "C" HRESULT SectionInitialize(
51 DWORD dwSignatureOffset = 0; 51 DWORD dwSignatureOffset = 0;
52 DWORD cbSignature = 0; 52 DWORD cbSignature = 0;
53 IMAGE_SECTION_HEADER sectionHeader = { }; 53 IMAGE_SECTION_HEADER sectionHeader = { };
54 DWORD dwOriginalChecksumAndSignatureOffset = 0; 54 DWORD_PTR dwOriginalChecksumAndSignatureOffset = 0;
55 BURN_SECTION_HEADER* pBurnSectionHeader = NULL; 55 BURN_SECTION_HEADER* pBurnSectionHeader = NULL;
56 56
57 pSection->hEngineFile = hEngineFile; 57 pSection->hEngineFile = hEngineFile;
diff --git a/src/engine/section.h b/src/engine/section.h
index 78331469..6c62ba44 100644
--- a/src/engine/section.h
+++ b/src/engine/section.h
@@ -20,7 +20,7 @@ typedef struct _BURN_SECTION
20 20
21 DWORD dwChecksumOffset; 21 DWORD dwChecksumOffset;
22 DWORD dwCertificateTableOffset; 22 DWORD dwCertificateTableOffset;
23 DWORD dwOriginalChecksumAndSignatureOffset; 23 DWORD_PTR dwOriginalChecksumAndSignatureOffset;
24 24
25 DWORD dwOriginalChecksum; 25 DWORD dwOriginalChecksum;
26 DWORD dwOriginalSignatureOffset; 26 DWORD dwOriginalSignatureOffset;
diff --git a/src/engine/splashscreen.cpp b/src/engine/splashscreen.cpp
index cad8c88c..90bd5203 100644
--- a/src/engine/splashscreen.cpp
+++ b/src/engine/splashscreen.cpp
@@ -196,7 +196,7 @@ static LRESULT CALLBACK WndProc(
196 ) 196 )
197{ 197{
198 LRESULT lres = 0; 198 LRESULT lres = 0;
199 SPLASHSCREEN_INFO* pSplashScreen = reinterpret_cast<SPLASHSCREEN_INFO*>(::GetWindowLongW(hWnd, GWLP_USERDATA)); 199 SPLASHSCREEN_INFO* pSplashScreen = reinterpret_cast<SPLASHSCREEN_INFO*>(::GetWindowLongPtrW(hWnd, GWLP_USERDATA));
200 200
201 switch (uMsg) 201 switch (uMsg)
202 { 202 {
diff --git a/src/engine/uithread.cpp b/src/engine/uithread.cpp
index cf111745..39f92142 100644
--- a/src/engine/uithread.cpp
+++ b/src/engine/uithread.cpp
@@ -196,7 +196,7 @@ static LRESULT CALLBACK WndProc(
196 BOOL fRet = FALSE; 196 BOOL fRet = FALSE;
197 197
198 // Always block shutdown in the elevated process, but ask the BA in the non-elevated. 198 // Always block shutdown in the elevated process, but ask the BA in the non-elevated.
199 UITHREAD_INFO* pInfo = reinterpret_cast<UITHREAD_INFO*>(::GetWindowLongW(hWnd, GWLP_USERDATA)); 199 UITHREAD_INFO* pInfo = reinterpret_cast<UITHREAD_INFO*>(::GetWindowLongPtrW(hWnd, GWLP_USERDATA));
200 if (!pInfo->fElevated) 200 if (!pInfo->fElevated)
201 { 201 {
202 // TODO: instead of recommending canceling all non-critical shutdowns, maybe we should only recommend cancel 202 // TODO: instead of recommending canceling all non-critical shutdowns, maybe we should only recommend cancel
diff --git a/src/engine/variable.cpp b/src/engine/variable.cpp
index 4bf73a9b..ea84752d 100644
--- a/src/engine/variable.cpp
+++ b/src/engine/variable.cpp
@@ -53,7 +53,7 @@ static HRESULT FormatString(
53 __in BURN_VARIABLES* pVariables, 53 __in BURN_VARIABLES* pVariables,
54 __in_z LPCWSTR wzIn, 54 __in_z LPCWSTR wzIn,
55 __out_z_opt LPWSTR* psczOut, 55 __out_z_opt LPWSTR* psczOut,
56 __out_opt DWORD* pcchOut, 56 __out_opt SIZE_T* pcchOut,
57 __in BOOL fObfuscateHiddenVariables, 57 __in BOOL fObfuscateHiddenVariables,
58 __out BOOL* pfContainsHiddenVariable 58 __out BOOL* pfContainsHiddenVariable
59 ); 59 );
@@ -704,7 +704,7 @@ extern "C" HRESULT VariableFormatString(
704 __in BURN_VARIABLES* pVariables, 704 __in BURN_VARIABLES* pVariables,
705 __in_z LPCWSTR wzIn, 705 __in_z LPCWSTR wzIn,
706 __out_z_opt LPWSTR* psczOut, 706 __out_z_opt LPWSTR* psczOut,
707 __out_opt DWORD* pcchOut 707 __out_opt SIZE_T* pcchOut
708 ) 708 )
709{ 709{
710 return FormatString(pVariables, wzIn, psczOut, pcchOut, FALSE, NULL); 710 return FormatString(pVariables, wzIn, psczOut, pcchOut, FALSE, NULL);
@@ -714,7 +714,7 @@ extern "C" HRESULT VariableFormatStringObfuscated(
714 __in BURN_VARIABLES* pVariables, 714 __in BURN_VARIABLES* pVariables,
715 __in_z LPCWSTR wzIn, 715 __in_z LPCWSTR wzIn,
716 __out_z_opt LPWSTR* psczOut, 716 __out_z_opt LPWSTR* psczOut,
717 __out_opt DWORD* pcchOut 717 __out_opt SIZE_T* pcchOut
718 ) 718 )
719{ 719{
720 return FormatString(pVariables, wzIn, psczOut, pcchOut, TRUE, NULL); 720 return FormatString(pVariables, wzIn, psczOut, pcchOut, TRUE, NULL);
@@ -1085,7 +1085,7 @@ static HRESULT FormatString(
1085 __in BURN_VARIABLES* pVariables, 1085 __in BURN_VARIABLES* pVariables,
1086 __in_z LPCWSTR wzIn, 1086 __in_z LPCWSTR wzIn,
1087 __out_z_opt LPWSTR* psczOut, 1087 __out_z_opt LPWSTR* psczOut,
1088 __out_opt DWORD* pcchOut, 1088 __out_opt SIZE_T* pcchOut,
1089 __in BOOL fObfuscateHiddenVariables, 1089 __in BOOL fObfuscateHiddenVariables,
1090 __out BOOL* pfContainsHiddenVariable 1090 __out BOOL* pfContainsHiddenVariable
1091 ) 1091 )
diff --git a/src/engine/variable.h b/src/engine/variable.h
index 713fe6e3..a38c9daa 100644
--- a/src/engine/variable.h
+++ b/src/engine/variable.h
@@ -126,13 +126,13 @@ HRESULT VariableFormatString(
126 __in BURN_VARIABLES* pVariables, 126 __in BURN_VARIABLES* pVariables,
127 __in_z LPCWSTR wzIn, 127 __in_z LPCWSTR wzIn,
128 __out_z_opt LPWSTR* psczOut, 128 __out_z_opt LPWSTR* psczOut,
129 __out_opt DWORD* pcchOut 129 __out_opt SIZE_T* pcchOut
130 ); 130 );
131HRESULT VariableFormatStringObfuscated( 131HRESULT VariableFormatStringObfuscated(
132 __in BURN_VARIABLES* pVariables, 132 __in BURN_VARIABLES* pVariables,
133 __in_z LPCWSTR wzIn, 133 __in_z LPCWSTR wzIn,
134 __out_z_opt LPWSTR* psczOut, 134 __out_z_opt LPWSTR* psczOut,
135 __out_opt DWORD* pcchOut 135 __out_opt SIZE_T* pcchOut
136 ); 136 );
137HRESULT VariableEscapeString( 137HRESULT VariableEscapeString(
138 __in_z LPCWSTR wzIn, 138 __in_z LPCWSTR wzIn,
diff --git a/src/stub/packages.config b/src/stub/packages.config
index eb65b3b3..7681e32c 100644
--- a/src/stub/packages.config
+++ b/src/stub/packages.config
@@ -4,5 +4,5 @@
4 <package id="Microsoft.SourceLink.Common" version="1.0.0" targetFramework="native" developmentDependency="true" /> 4 <package id="Microsoft.SourceLink.Common" version="1.0.0" targetFramework="native" developmentDependency="true" />
5 <package id="Microsoft.SourceLink.GitHub" version="1.0.0" targetFramework="native" developmentDependency="true" /> 5 <package id="Microsoft.SourceLink.GitHub" version="1.0.0" targetFramework="native" developmentDependency="true" />
6 <package id="Nerdbank.GitVersioning" version="3.3.37" targetFramework="native" developmentDependency="true" /> 6 <package id="Nerdbank.GitVersioning" version="3.3.37" targetFramework="native" developmentDependency="true" />
7 <package id="WixToolset.DUtil" version="4.0.56" targetFramework="native" /> 7 <package id="WixToolset.DUtil" version="4.0.59" targetFramework="native" />
8</packages> \ No newline at end of file 8</packages> \ No newline at end of file
diff --git a/src/stub/stub.vcxproj b/src/stub/stub.vcxproj
index 42b614cd..aa2f964e 100644
--- a/src/stub/stub.vcxproj
+++ b/src/stub/stub.vcxproj
@@ -5,7 +5,7 @@
5 <Import Project="..\..\packages\Microsoft.SourceLink.GitHub.1.0.0\build\Microsoft.SourceLink.GitHub.props" Condition="Exists('..\..\packages\Microsoft.SourceLink.GitHub.1.0.0\build\Microsoft.SourceLink.GitHub.props')" /> 5 <Import Project="..\..\packages\Microsoft.SourceLink.GitHub.1.0.0\build\Microsoft.SourceLink.GitHub.props" Condition="Exists('..\..\packages\Microsoft.SourceLink.GitHub.1.0.0\build\Microsoft.SourceLink.GitHub.props')" />
6 <Import Project="..\..\packages\Microsoft.SourceLink.Common.1.0.0\build\Microsoft.SourceLink.Common.props" Condition="Exists('..\..\packages\Microsoft.SourceLink.Common.1.0.0\build\Microsoft.SourceLink.Common.props')" /> 6 <Import Project="..\..\packages\Microsoft.SourceLink.Common.1.0.0\build\Microsoft.SourceLink.Common.props" Condition="Exists('..\..\packages\Microsoft.SourceLink.Common.1.0.0\build\Microsoft.SourceLink.Common.props')" />
7 <Import Project="..\..\packages\Microsoft.Build.Tasks.Git.1.0.0\build\Microsoft.Build.Tasks.Git.props" Condition="Exists('..\..\packages\Microsoft.Build.Tasks.Git.1.0.0\build\Microsoft.Build.Tasks.Git.props')" /> 7 <Import Project="..\..\packages\Microsoft.Build.Tasks.Git.1.0.0\build\Microsoft.Build.Tasks.Git.props" Condition="Exists('..\..\packages\Microsoft.Build.Tasks.Git.1.0.0\build\Microsoft.Build.Tasks.Git.props')" />
8 <Import Project="..\..\packages\WixToolset.DUtil.4.0.56\build\WixToolset.DUtil.props" Condition="Exists('..\..\packages\WixToolset.DUtil.4.0.56\build\WixToolset.DUtil.props')" /> 8 <Import Project="..\..\packages\WixToolset.DUtil.4.0.59\build\WixToolset.DUtil.props" Condition="Exists('..\..\packages\WixToolset.DUtil.4.0.59\build\WixToolset.DUtil.props')" />
9 9
10 <ItemGroup Label="ProjectConfigurations"> 10 <ItemGroup Label="ProjectConfigurations">
11 <ProjectConfiguration Include="Debug|Win32"> 11 <ProjectConfiguration Include="Debug|Win32">
@@ -107,6 +107,6 @@
107 <Error Condition="!Exists('..\..\packages\Microsoft.SourceLink.GitHub.1.0.0\build\Microsoft.SourceLink.GitHub.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Microsoft.SourceLink.GitHub.1.0.0\build\Microsoft.SourceLink.GitHub.props'))" /> 107 <Error Condition="!Exists('..\..\packages\Microsoft.SourceLink.GitHub.1.0.0\build\Microsoft.SourceLink.GitHub.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Microsoft.SourceLink.GitHub.1.0.0\build\Microsoft.SourceLink.GitHub.props'))" />
108 <Error Condition="!Exists('..\..\packages\Microsoft.SourceLink.GitHub.1.0.0\build\Microsoft.SourceLink.GitHub.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Microsoft.SourceLink.GitHub.1.0.0\build\Microsoft.SourceLink.GitHub.targets'))" /> 108 <Error Condition="!Exists('..\..\packages\Microsoft.SourceLink.GitHub.1.0.0\build\Microsoft.SourceLink.GitHub.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Microsoft.SourceLink.GitHub.1.0.0\build\Microsoft.SourceLink.GitHub.targets'))" />
109 <Error Condition="!Exists('..\..\packages\Nerdbank.GitVersioning.3.3.37\build\Nerdbank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Nerdbank.GitVersioning.3.3.37\build\Nerdbank.GitVersioning.targets'))" /> 109 <Error Condition="!Exists('..\..\packages\Nerdbank.GitVersioning.3.3.37\build\Nerdbank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Nerdbank.GitVersioning.3.3.37\build\Nerdbank.GitVersioning.targets'))" />
110 <Error Condition="!Exists('..\..\packages\WixToolset.DUtil.4.0.56\build\WixToolset.DUtil.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\WixToolset.DUtil.4.0.56\build\WixToolset.DUtil.props'))" /> 110 <Error Condition="!Exists('..\..\packages\WixToolset.DUtil.4.0.59\build\WixToolset.DUtil.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\WixToolset.DUtil.4.0.59\build\WixToolset.DUtil.props'))" />
111 </Target> 111 </Target>
112</Project> \ No newline at end of file 112</Project> \ No newline at end of file
diff --git a/src/test/BurnUnitTest/BurnUnitTest.vcxproj b/src/test/BurnUnitTest/BurnUnitTest.vcxproj
index 71f3ea09..18527de5 100644
--- a/src/test/BurnUnitTest/BurnUnitTest.vcxproj
+++ b/src/test/BurnUnitTest/BurnUnitTest.vcxproj
@@ -4,7 +4,7 @@
4 4
5<Project DefaultTargets="Build" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> 5<Project DefaultTargets="Build" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
6 <Import Project="..\..\..\packages\WixBuildTools.TestSupport.Native.4.0.47\build\WixBuildTools.TestSupport.Native.props" Condition="Exists('..\..\..\packages\WixBuildTools.TestSupport.Native.4.0.47\build\WixBuildTools.TestSupport.Native.props')" /> 6 <Import Project="..\..\..\packages\WixBuildTools.TestSupport.Native.4.0.47\build\WixBuildTools.TestSupport.Native.props" Condition="Exists('..\..\..\packages\WixBuildTools.TestSupport.Native.4.0.47\build\WixBuildTools.TestSupport.Native.props')" />
7 <Import Project="..\..\..\packages\WixToolset.DUtil.4.0.56\build\WixToolset.DUtil.props" Condition="Exists('..\..\..\packages\WixToolset.DUtil.4.0.56\build\WixToolset.DUtil.props')" /> 7 <Import Project="..\..\..\packages\WixToolset.DUtil.4.0.59\build\WixToolset.DUtil.props" Condition="Exists('..\..\..\packages\WixToolset.DUtil.4.0.59\build\WixToolset.DUtil.props')" />
8 <ItemGroup Label="ProjectConfigurations"> 8 <ItemGroup Label="ProjectConfigurations">
9 <ProjectConfiguration Include="Debug|Win32"> 9 <ProjectConfiguration Include="Debug|Win32">
10 <Configuration>Debug</Configuration> 10 <Configuration>Debug</Configuration>
@@ -81,6 +81,6 @@
81 </PropertyGroup> 81 </PropertyGroup>
82 <Error Condition="!Exists('..\..\..\packages\WixBuildTools.TestSupport.Native.4.0.47\build\WixBuildTools.TestSupport.Native.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\packages\WixBuildTools.TestSupport.Native.4.0.47\build\WixBuildTools.TestSupport.Native.props'))" /> 82 <Error Condition="!Exists('..\..\..\packages\WixBuildTools.TestSupport.Native.4.0.47\build\WixBuildTools.TestSupport.Native.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\packages\WixBuildTools.TestSupport.Native.4.0.47\build\WixBuildTools.TestSupport.Native.props'))" />
83 <Error Condition="!Exists('..\..\..\packages\WixBuildTools.TestSupport.Native.4.0.47\build\WixBuildTools.TestSupport.Native.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\packages\WixBuildTools.TestSupport.Native.4.0.47\build\WixBuildTools.TestSupport.Native.targets'))" /> 83 <Error Condition="!Exists('..\..\..\packages\WixBuildTools.TestSupport.Native.4.0.47\build\WixBuildTools.TestSupport.Native.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\packages\WixBuildTools.TestSupport.Native.4.0.47\build\WixBuildTools.TestSupport.Native.targets'))" />
84 <Error Condition="!Exists('..\..\..\packages\WixToolset.DUtil.4.0.56\build\WixToolset.DUtil.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\packages\WixToolset.DUtil.4.0.56\build\WixToolset.DUtil.props'))" /> 84 <Error Condition="!Exists('..\..\..\packages\WixToolset.DUtil.4.0.59\build\WixToolset.DUtil.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\packages\WixToolset.DUtil.4.0.59\build\WixToolset.DUtil.props'))" />
85 </Target> 85 </Target>
86</Project> 86</Project> \ No newline at end of file
diff --git a/src/test/BurnUnitTest/packages.config b/src/test/BurnUnitTest/packages.config
index 472349e7..f9d0f75a 100644
--- a/src/test/BurnUnitTest/packages.config
+++ b/src/test/BurnUnitTest/packages.config
@@ -10,5 +10,5 @@
10 <package id="xunit.runner.visualstudio" version="2.4.1" /> 10 <package id="xunit.runner.visualstudio" version="2.4.1" />
11 <package id="WixBuildTools.TestSupport" version="4.0.47" /> 11 <package id="WixBuildTools.TestSupport" version="4.0.47" />
12 <package id="WixBuildTools.TestSupport.Native" version="4.0.47" /> 12 <package id="WixBuildTools.TestSupport.Native" version="4.0.47" />
13 <package id="WixToolset.DUtil" version="4.0.56" targetFramework="native" /> 13 <package id="WixToolset.DUtil" version="4.0.59" targetFramework="native" />
14</packages> \ No newline at end of file 14</packages> \ No newline at end of file