diff options
author | Sean Hall <r.sean.hall@gmail.com> | 2021-12-31 16:20:11 -0600 |
---|---|---|
committer | Sean Hall <r.sean.hall@gmail.com> | 2022-01-01 10:24:08 -0600 |
commit | 5be795c6bcbc03bc37f7cf7c758298ccfaa884ca (patch) | |
tree | f13c40af4a20cfbffaa474e656e145cdda16919e | |
parent | 37790ecdc4509d6dd3533933bb9131823f98a0ed (diff) | |
download | wix-5be795c6bcbc03bc37f7cf7c758298ccfaa884ca.tar.gz wix-5be795c6bcbc03bc37f7cf7c758298ccfaa884ca.tar.bz2 wix-5be795c6bcbc03bc37f7cf7c758298ccfaa884ca.zip |
Remove warnings and make sure more don't creep in.
Tests are not run inside of traversal projects so that skipped test warnings don't fail the build.
26 files changed, 76 insertions, 78 deletions
diff --git a/src/api/api.cmd b/src/api/api.cmd index 7a4bbb43..6a424c34 100644 --- a/src/api/api.cmd +++ b/src/api/api.cmd | |||
@@ -12,10 +12,12 @@ | |||
12 | :: build | 12 | :: build |
13 | :: pack | 13 | :: pack |
14 | 14 | ||
15 | msbuild api_t.proj -p:Configuration=%_C% -nologo -m -bl:..\..\build\logs\api_build.binlog || exit /b | 15 | msbuild api_t.proj -p:Configuration=%_C% -nologo -m -warnaserror -bl:..\..\build\logs\api_build.binlog || exit /b |
16 | 16 | ||
17 | :: test | 17 | :: test |
18 | dotnet test burn\test\WixToolsetTest.Mba.Core\WixToolsetTest.Mba.Core.csproj -c %_C% --nologo --no-build || exit /b | 18 | dotnet test burn\test\WixToolsetTest.Mba.Core\WixToolsetTest.Mba.Core.csproj -c %_C% --nologo --no-build || exit /b |
19 | msbuild burn\test\BalUtilUnitTest -t:Test -p:Configuration=%_C% -nologo || exit /b | ||
20 | msbuild burn\test\BextUtilUnitTest -t:Test -p:Configuration=%_C% -nologo || exit /b | ||
19 | dotnet test wix\api_wix.sln -c %_C% --nologo --no-build || exit /b | 21 | dotnet test wix\api_wix.sln -c %_C% --nologo --no-build || exit /b |
20 | 22 | ||
21 | @popd | 23 | @popd |
diff --git a/src/api/api_t.proj b/src/api/api_t.proj index d89feccf..d2bb8af3 100644 --- a/src/api/api_t.proj +++ b/src/api/api_t.proj | |||
@@ -1,9 +1,9 @@ | |||
1 | <Project Sdk="Microsoft.Build.Traversal"> | 1 | <Project Sdk="Microsoft.Build.Traversal"> |
2 | <ItemGroup> | 2 | <ItemGroup> |
3 | <ProjectReference Include="burn\burn_t.proj" Targets="Restore" BuildInParallel="false" /> | 3 | <ProjectReference Include="burn\api_burn_t.proj" Targets="Restore" BuildInParallel="false" /> |
4 | <ProjectReference Include="wix\wix_t.proj" Targets="Restore" BuildInParallel="false" /> | 4 | <ProjectReference Include="wix\api_wix_t.proj" Targets="Restore" BuildInParallel="false" /> |
5 | 5 | ||
6 | <ProjectReference Include="burn\burn_t.proj" /> | 6 | <ProjectReference Include="burn\api_burn_t.proj" /> |
7 | <ProjectReference Include="wix\wix_t.proj" /> | 7 | <ProjectReference Include="wix\api_wix_t.proj" /> |
8 | </ItemGroup> | 8 | </ItemGroup> |
9 | </Project> | 9 | </Project> |
diff --git a/src/api/burn/WixToolset.Mba.Core/WixToolset.Mba.Core.csproj b/src/api/burn/WixToolset.Mba.Core/WixToolset.Mba.Core.csproj index 74cbe551..990d23ab 100644 --- a/src/api/burn/WixToolset.Mba.Core/WixToolset.Mba.Core.csproj +++ b/src/api/burn/WixToolset.Mba.Core/WixToolset.Mba.Core.csproj | |||
@@ -11,6 +11,8 @@ | |||
11 | <NuspecFile>$(MSBuildThisFileName).nuspec</NuspecFile> | 11 | <NuspecFile>$(MSBuildThisFileName).nuspec</NuspecFile> |
12 | <IncludeSymbols>true</IncludeSymbols> | 12 | <IncludeSymbols>true</IncludeSymbols> |
13 | <CreateDocumentationFile>true</CreateDocumentationFile> | 13 | <CreateDocumentationFile>true</CreateDocumentationFile> |
14 | <!-- https://github.com/NuGet/Home/issues/10665 --> | ||
15 | <NoWarn>NU5128</NoWarn> | ||
14 | </PropertyGroup> | 16 | </PropertyGroup> |
15 | 17 | ||
16 | <ItemGroup Condition=" '$(NCrunch)'=='' "> | 18 | <ItemGroup Condition=" '$(NCrunch)'=='' "> |
diff --git a/src/api/burn/burn_t.proj b/src/api/burn/api_burn_t.proj index 46ccf8b2..f6918682 100644 --- a/src/api/burn/burn_t.proj +++ b/src/api/burn/api_burn_t.proj | |||
@@ -7,23 +7,25 @@ | |||
7 | <ProjectReference Include="test\BalUtilUnitTest\BalUtilUnitTest.vcxproj" Targets="Restore" BuildInParallel="false" /> | 7 | <ProjectReference Include="test\BalUtilUnitTest\BalUtilUnitTest.vcxproj" Targets="Restore" BuildInParallel="false" /> |
8 | <ProjectReference Include="test\BextUtilUnitTest\BextUtilUnitTest.vcxproj" Targets="Restore" BuildInParallel="false" /> | 8 | <ProjectReference Include="test\BextUtilUnitTest\BextUtilUnitTest.vcxproj" Targets="Restore" BuildInParallel="false" /> |
9 | 9 | ||
10 | <!-- C++/CLI projects will try to build their dependent projects in parallel with others, so they must be built first. --> | ||
11 | <ProjectReference Include="test\BalUtilUnitTest\BalUtilUnitTest.vcxproj" Properties="Platform=x86" BuildInParallel="false" /> | ||
12 | <ProjectReference Include="test\BextUtilUnitTest\BextUtilUnitTest.vcxproj" Properties="Platform=x86" BuildInParallel="false" /> | ||
13 | |||
14 | <!-- Make sure that if these rebuild balutil due to the inability for incremental build, then all shipped code uses the same binaries. --> | ||
15 | <ProjectReference Include="test\WixToolsetTest.Mba.Core\WixToolsetTest.Mba.Core.csproj" Properties="Platform=AnyCPU" BuildInParallel="false" /> | ||
16 | <ProjectReference Include="WixToolset.Mba.Core\WixToolset.Mba.Core.csproj" Properties="Platform=AnyCPU" BuildInParallel="false" /> | ||
17 | |||
10 | <!-- Build --> | 18 | <!-- Build --> |
11 | 19 | ||
12 | <ProjectReference Include="bextutil\bextutil.vcxproj" Properties="Platform=x86" /> | 20 | <!-- bextutil x86 is built by BextUtilUnitTest --> |
13 | <ProjectReference Include="bextutil\bextutil.vcxproj" Properties="Platform=x64" /> | 21 | <ProjectReference Include="bextutil\bextutil.vcxproj" Properties="Platform=x64" /> |
14 | <ProjectReference Include="bextutil\bextutil.vcxproj" Properties="Platform=ARM64" /> | 22 | <ProjectReference Include="bextutil\bextutil.vcxproj" Properties="Platform=ARM64" /> |
15 | 23 | ||
16 | <!-- Let mbanative build balutil for latest toolset. --> | ||
17 | <ProjectReference Include="mbanative\mbanative.vcxproj" Properties="Platform=x86" /> | 24 | <ProjectReference Include="mbanative\mbanative.vcxproj" Properties="Platform=x86" /> |
18 | <ProjectReference Include="mbanative\mbanative.vcxproj" Properties="Platform=x64" /> | 25 | <ProjectReference Include="mbanative\mbanative.vcxproj" Properties="Platform=x64" /> |
19 | <ProjectReference Include="mbanative\mbanative.vcxproj" Properties="Platform=ARM64" /> | 26 | <ProjectReference Include="mbanative\mbanative.vcxproj" Properties="Platform=ARM64" /> |
20 | 27 | ||
21 | <ProjectReference Include="WixToolset.Mba.Core\WixToolset.Mba.Core.csproj" Properties="Platform=AnyCPU" /> | 28 | <!-- balutil is built by multiple projects above. --> |
22 | <ProjectReference Include="test\WixToolsetTest.Mba.Core\WixToolsetTest.Mba.Core.csproj" Properties="Platform=AnyCPU" /> | ||
23 | |||
24 | <!-- Test --> | ||
25 | <ProjectReference Include="test\BalUtilUnitTest\BalUtilUnitTest.vcxproj" Targets="Test" /> | ||
26 | <ProjectReference Include="test\BextUtilUnitTest\BextUtilUnitTest.vcxproj" Targets="Test" /> | ||
27 | 29 | ||
28 | <!-- Pack --> | 30 | <!-- Pack --> |
29 | <ProjectReference Include="balutil\balutil.vcxproj" Targets="PackNative" /> | 31 | <ProjectReference Include="balutil\balutil.vcxproj" Targets="PackNative" /> |
diff --git a/src/api/burn/test/WixToolsetTest.Mba.Core/WixToolsetTest.Mba.Core.csproj b/src/api/burn/test/WixToolsetTest.Mba.Core/WixToolsetTest.Mba.Core.csproj index 8d68546f..af3a09b0 100644 --- a/src/api/burn/test/WixToolsetTest.Mba.Core/WixToolsetTest.Mba.Core.csproj +++ b/src/api/burn/test/WixToolsetTest.Mba.Core/WixToolsetTest.Mba.Core.csproj | |||
@@ -7,6 +7,7 @@ | |||
7 | <IsPackable>false</IsPackable> | 7 | <IsPackable>false</IsPackable> |
8 | <RuntimeIdentifier>win-x86</RuntimeIdentifier> | 8 | <RuntimeIdentifier>win-x86</RuntimeIdentifier> |
9 | <SignOutput>false</SignOutput> | 9 | <SignOutput>false</SignOutput> |
10 | <RollForward>Major</RollForward> | ||
10 | </PropertyGroup> | 11 | </PropertyGroup> |
11 | 12 | ||
12 | <ItemGroup> | 13 | <ItemGroup> |
diff --git a/src/api/wix/wix_t.proj b/src/api/wix/api_wix_t.proj index 174b8b0e..174b8b0e 100644 --- a/src/api/wix/wix_t.proj +++ b/src/api/wix/api_wix_t.proj | |||
diff --git a/src/burn/burn.cmd b/src/burn/burn.cmd index 8c5010b5..b7c171c5 100644 --- a/src/burn/burn.cmd +++ b/src/burn/burn.cmd | |||
@@ -12,7 +12,9 @@ | |||
12 | 12 | ||
13 | nuget restore || exit /b | 13 | nuget restore || exit /b |
14 | 14 | ||
15 | msbuild burn_t.proj -p:Configuration=%_C% -nologo -m -bl:..\..\build\logs\burn_build.binlog || exit /b | 15 | msbuild burn_t.proj -p:Configuration=%_C% -nologo -m -warnaserror -bl:..\..\build\logs\burn_build.binlog || exit /b |
16 | |||
17 | msbuild test\BurnUnitTest -t:Test -p:Configuration=%_C% -nologo || exit /b | ||
16 | 18 | ||
17 | @popd | 19 | @popd |
18 | @endlocal | 20 | @endlocal |
diff --git a/src/burn/burn.sln b/src/burn/burn.sln index 0a6227a5..c820a467 100644 --- a/src/burn/burn.sln +++ b/src/burn/burn.sln | |||
@@ -43,13 +43,14 @@ Global | |||
43 | {C38373AA-882F-4F55-B03F-2AAB4BFBE3F1}.Release|x64.Build.0 = Release|x64 | 43 | {C38373AA-882F-4F55-B03F-2AAB4BFBE3F1}.Release|x64.Build.0 = Release|x64 |
44 | {C38373AA-882F-4F55-B03F-2AAB4BFBE3F1}.Release|x86.ActiveCfg = Release|Win32 | 44 | {C38373AA-882F-4F55-B03F-2AAB4BFBE3F1}.Release|x86.ActiveCfg = Release|Win32 |
45 | {C38373AA-882F-4F55-B03F-2AAB4BFBE3F1}.Release|x86.Build.0 = Release|Win32 | 45 | {C38373AA-882F-4F55-B03F-2AAB4BFBE3F1}.Release|x86.Build.0 = Release|Win32 |
46 | {9D1F1BA3-9393-4833-87A3-D5F1FC08EF67}.Debug|ARM64.ActiveCfg = Debug|ARM64 | 46 | {9D1F1BA3-9393-4833-87A3-D5F1FC08EF67}.Debug|ARM64.ActiveCfg = Debug|x64 |
47 | {9D1F1BA3-9393-4833-87A3-D5F1FC08EF67}.Debug|x64.ActiveCfg = Debug|x64 | 47 | {9D1F1BA3-9393-4833-87A3-D5F1FC08EF67}.Debug|x64.ActiveCfg = Debug|x64 |
48 | {9D1F1BA3-9393-4833-87A3-D5F1FC08EF67}.Debug|x64.Build.0 = Debug|x64 | 48 | {9D1F1BA3-9393-4833-87A3-D5F1FC08EF67}.Debug|x64.Build.0 = Debug|x64 |
49 | {9D1F1BA3-9393-4833-87A3-D5F1FC08EF67}.Debug|x86.ActiveCfg = Debug|Win32 | 49 | {9D1F1BA3-9393-4833-87A3-D5F1FC08EF67}.Debug|x86.ActiveCfg = Debug|Win32 |
50 | {9D1F1BA3-9393-4833-87A3-D5F1FC08EF67}.Debug|x86.Build.0 = Debug|Win32 | 50 | {9D1F1BA3-9393-4833-87A3-D5F1FC08EF67}.Debug|x86.Build.0 = Debug|Win32 |
51 | {9D1F1BA3-9393-4833-87A3-D5F1FC08EF67}.Release|ARM64.ActiveCfg = Release|ARM64 | 51 | {9D1F1BA3-9393-4833-87A3-D5F1FC08EF67}.Release|ARM64.ActiveCfg = Release|x64 |
52 | {9D1F1BA3-9393-4833-87A3-D5F1FC08EF67}.Release|x64.ActiveCfg = Release|Win32 | 52 | {9D1F1BA3-9393-4833-87A3-D5F1FC08EF67}.Release|x64.ActiveCfg = Release|x64 |
53 | {9D1F1BA3-9393-4833-87A3-D5F1FC08EF67}.Release|x64.Build.0 = Release|x64 | ||
53 | {9D1F1BA3-9393-4833-87A3-D5F1FC08EF67}.Release|x86.ActiveCfg = Release|Win32 | 54 | {9D1F1BA3-9393-4833-87A3-D5F1FC08EF67}.Release|x86.ActiveCfg = Release|Win32 |
54 | {9D1F1BA3-9393-4833-87A3-D5F1FC08EF67}.Release|x86.Build.0 = Release|Win32 | 55 | {9D1F1BA3-9393-4833-87A3-D5F1FC08EF67}.Release|x86.Build.0 = Release|Win32 |
55 | EndGlobalSection | 56 | EndGlobalSection |
diff --git a/src/burn/burn_t.proj b/src/burn/burn_t.proj index 0eed26ed..ffc0c780 100644 --- a/src/burn/burn_t.proj +++ b/src/burn/burn_t.proj | |||
@@ -1,10 +1,10 @@ | |||
1 | <Project Sdk="Microsoft.Build.Traversal"> | 1 | <Project Sdk="Microsoft.Build.Traversal"> |
2 | <ItemGroup> | 2 | <ItemGroup> |
3 | <ProjectReference Include="test\BurnUnitTest\BurnUnitTest.vcxproj" Targets="Test" /> | 3 | <ProjectReference Include="test\BurnUnitTest\BurnUnitTest.vcxproj" Properties="Platform=x86" BuildInParallel="false" /> |
4 | 4 | ||
5 | <ProjectReference Include="burn.sln" Properties="Platform=x86" /> | 5 | <ProjectReference Include="stub\stub.vcxproj" Properties="Platform=x86" /> |
6 | <ProjectReference Include="burn.sln" Properties="Platform=x64" /> | 6 | <ProjectReference Include="stub\stub.vcxproj" Properties="Platform=x64" /> |
7 | <ProjectReference Include="burn.sln" Properties="Platform=ARM64" /> | 7 | <ProjectReference Include="stub\stub.vcxproj" Properties="Platform=ARM64" /> |
8 | 8 | ||
9 | <ProjectReference Include="stub\stub.vcxproj" Targets="PackNative" /> | 9 | <ProjectReference Include="stub\stub.vcxproj" Targets="PackNative" /> |
10 | </ItemGroup> | 10 | </ItemGroup> |
diff --git a/src/burn/engine/engine.vcxproj b/src/burn/engine/engine.vcxproj index ae28d728..3d6ed181 100644 --- a/src/burn/engine/engine.vcxproj +++ b/src/burn/engine/engine.vcxproj | |||
@@ -147,7 +147,7 @@ | |||
147 | <Message>Compiling message file...</Message> | 147 | <Message>Compiling message file...</Message> |
148 | <Command>mc.exe -h "$(IntDir)." -r "$(IntDir)." -A -c -z engine.messages "$(InputDir)engine.mc" | 148 | <Command>mc.exe -h "$(IntDir)." -r "$(IntDir)." -A -c -z engine.messages "$(InputDir)engine.mc" |
149 | rc.exe -fo "$(OutDir)engine.res" "$(IntDir)engine.messages.rc"</Command> | 149 | rc.exe -fo "$(OutDir)engine.res" "$(IntDir)engine.messages.rc"</Command> |
150 | <Outputs>$(IntDir)engine.messages.h;$(IntDir)engine.messages.rc;$(OutDir)engine.res</Outputs> | 150 | <Outputs>$(IntDir)engine.messages.h;$(IntDir)engine.messages.rc</Outputs> |
151 | </CustomBuild> | 151 | </CustomBuild> |
152 | </ItemGroup> | 152 | </ItemGroup> |
153 | 153 | ||
diff --git a/src/burn/test/BurnUnitTest/BurnUnitTest.vcxproj b/src/burn/test/BurnUnitTest/BurnUnitTest.vcxproj index 714b6549..248d7bbb 100644 --- a/src/burn/test/BurnUnitTest/BurnUnitTest.vcxproj +++ b/src/burn/test/BurnUnitTest/BurnUnitTest.vcxproj | |||
@@ -13,10 +13,6 @@ | |||
13 | <Configuration>Debug</Configuration> | 13 | <Configuration>Debug</Configuration> |
14 | <Platform>x64</Platform> | 14 | <Platform>x64</Platform> |
15 | </ProjectConfiguration> | 15 | </ProjectConfiguration> |
16 | <ProjectConfiguration Include="Debug|ARM64"> | ||
17 | <Configuration>Debug</Configuration> | ||
18 | <Platform>ARM64</Platform> | ||
19 | </ProjectConfiguration> | ||
20 | <ProjectConfiguration Include="Release|Win32"> | 16 | <ProjectConfiguration Include="Release|Win32"> |
21 | <Configuration>Release</Configuration> | 17 | <Configuration>Release</Configuration> |
22 | <Platform>Win32</Platform> | 18 | <Platform>Win32</Platform> |
@@ -25,10 +21,6 @@ | |||
25 | <Configuration>Release</Configuration> | 21 | <Configuration>Release</Configuration> |
26 | <Platform>x64</Platform> | 22 | <Platform>x64</Platform> |
27 | </ProjectConfiguration> | 23 | </ProjectConfiguration> |
28 | <ProjectConfiguration Include="Release|ARM64"> | ||
29 | <Configuration>Release</Configuration> | ||
30 | <Platform>ARM64</Platform> | ||
31 | </ProjectConfiguration> | ||
32 | </ItemGroup> | 24 | </ItemGroup> |
33 | 25 | ||
34 | <PropertyGroup Label="Globals"> | 26 | <PropertyGroup Label="Globals"> |
@@ -78,7 +70,6 @@ | |||
78 | </ItemGroup> | 70 | </ItemGroup> |
79 | 71 | ||
80 | <ItemGroup> | 72 | <ItemGroup> |
81 | <None Include="packages.config" /> | ||
82 | <ResourceCompile Include="BurnUnitTest.rc" /> | 73 | <ResourceCompile Include="BurnUnitTest.rc" /> |
83 | </ItemGroup> | 74 | </ItemGroup> |
84 | 75 | ||
diff --git a/src/dtf/dtf.cmd b/src/dtf/dtf.cmd index 13f97ff0..dbc67c63 100644 --- a/src/dtf/dtf.cmd +++ b/src/dtf/dtf.cmd | |||
@@ -8,7 +8,7 @@ | |||
8 | 8 | ||
9 | @echo Building dtf %_C% | 9 | @echo Building dtf %_C% |
10 | 10 | ||
11 | msbuild -Restore -t:Pack dtf.sln -p:Configuration=%_C% -nologo -m -bl:..\..\build\logs\dtf_build.binlog|| exit /b | 11 | msbuild -Restore -t:Pack dtf.sln -p:Configuration=%_C% -nologo -m -warnaserror -bl:..\..\build\logs\dtf_build.binlog || exit /b |
12 | 12 | ||
13 | @popd | 13 | @popd |
14 | @endlocal | 14 | @endlocal |
diff --git a/src/internal/WixBuildTools.TestSupport.Native/WixBuildTools.TestSupport.Native.nuspec b/src/internal/WixBuildTools.TestSupport.Native/WixBuildTools.TestSupport.Native.nuspec deleted file mode 100644 index 1dcdb78c..00000000 --- a/src/internal/WixBuildTools.TestSupport.Native/WixBuildTools.TestSupport.Native.nuspec +++ /dev/null | |||
@@ -1,26 +0,0 @@ | |||
1 | <?xml version="1.0"?> | ||
2 | <package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd"> | ||
3 | <metadata minClientVersion="4.0"> | ||
4 | <id>$id$</id> | ||
5 | <version>$version$</version> | ||
6 | <title>$title$</title> | ||
7 | <description>$description$</description> | ||
8 | <authors>$authors$</authors> | ||
9 | <license type="expression">MS-RL</license> | ||
10 | <requireLicenseAcceptance>false</requireLicenseAcceptance> | ||
11 | <copyright>$copyright$</copyright> | ||
12 | <projectUrl>$projectUrl$</projectUrl> | ||
13 | <repository type="$repositorytype$" url="$repositoryurl$" commit="$repositorycommit$" /> | ||
14 | <dependencies> | ||
15 | <group targetFramework=".NETFramework4.7.2" /> | ||
16 | </dependencies> | ||
17 | </metadata> | ||
18 | |||
19 | <files> | ||
20 | <file src="$projectFolder$\build\$id$.props" target="build" /> | ||
21 | <file src="$projectFolder$\build\$id$.targets" target="build" /> | ||
22 | |||
23 | <file src="..\x86\$id$.dll" target="lib\net472" /> | ||
24 | <file src="..\x86\$id$.pdb" target="lib\net472" /> | ||
25 | </files> | ||
26 | </package> | ||
diff --git a/src/internal/WixBuildTools.TestSupport.Native/WixBuildTools.TestSupport.Native.vcxproj b/src/internal/WixBuildTools.TestSupport.Native/WixBuildTools.TestSupport.Native.vcxproj index 282aa306..a96f8d2f 100644 --- a/src/internal/WixBuildTools.TestSupport.Native/WixBuildTools.TestSupport.Native.vcxproj +++ b/src/internal/WixBuildTools.TestSupport.Native/WixBuildTools.TestSupport.Native.vcxproj | |||
@@ -9,10 +9,18 @@ | |||
9 | <Configuration>Debug</Configuration> | 9 | <Configuration>Debug</Configuration> |
10 | <Platform>Win32</Platform> | 10 | <Platform>Win32</Platform> |
11 | </ProjectConfiguration> | 11 | </ProjectConfiguration> |
12 | <ProjectConfiguration Include="Debug|x64"> | ||
13 | <Configuration>Debug</Configuration> | ||
14 | <Platform>x64</Platform> | ||
15 | </ProjectConfiguration> | ||
12 | <ProjectConfiguration Include="Release|Win32"> | 16 | <ProjectConfiguration Include="Release|Win32"> |
13 | <Configuration>Release</Configuration> | 17 | <Configuration>Release</Configuration> |
14 | <Platform>Win32</Platform> | 18 | <Platform>Win32</Platform> |
15 | </ProjectConfiguration> | 19 | </ProjectConfiguration> |
20 | <ProjectConfiguration Include="Release|x64"> | ||
21 | <Configuration>Release</Configuration> | ||
22 | <Platform>x64</Platform> | ||
23 | </ProjectConfiguration> | ||
16 | </ItemGroup> | 24 | </ItemGroup> |
17 | 25 | ||
18 | <PropertyGroup Label="Globals"> | 26 | <PropertyGroup Label="Globals"> |
diff --git a/src/internal/WixBuildTools.TestSupport.Native/build/WixBuildTools.TestSupport.Native.targets b/src/internal/WixBuildTools.TestSupport.Native/build/WixBuildTools.TestSupport.Native.targets index 34ea148e..80b159ec 100644 --- a/src/internal/WixBuildTools.TestSupport.Native/build/WixBuildTools.TestSupport.Native.targets +++ b/src/internal/WixBuildTools.TestSupport.Native/build/WixBuildTools.TestSupport.Native.targets | |||
@@ -10,10 +10,10 @@ | |||
10 | <!-- Include these references only when not referenced by the WixBuildTools.TestSupport.Native.vcxproj --> | 10 | <!-- Include these references only when not referenced by the WixBuildTools.TestSupport.Native.vcxproj --> |
11 | <ItemGroup Condition="'$(MSBuildProjectName)'!='$(MSBuildThisFileName)'"> | 11 | <ItemGroup Condition="'$(MSBuildProjectName)'!='$(MSBuildThisFileName)'"> |
12 | <Reference Include="WixBuildTools.TestSupport"> | 12 | <Reference Include="WixBuildTools.TestSupport"> |
13 | <HintPath>$(RootBuildFolder)internal\$(Configuration)\x86\WixBuildTools.TestSupport.dll</HintPath> | 13 | <HintPath>$(RootBuildFolder)internal\$(Configuration)\$(PlatformTarget)\WixBuildTools.TestSupport.dll</HintPath> |
14 | </Reference> | 14 | </Reference> |
15 | <Reference Include="WixBuildTools.TestSupport.Native"> | 15 | <Reference Include="WixBuildTools.TestSupport.Native"> |
16 | <HintPath>$(RootBuildFolder)internal\$(Configuration)\x86\WixBuildTools.TestSupport.Native.dll</HintPath> | 16 | <HintPath>$(RootBuildFolder)internal\$(Configuration)\$(PlatformTarget)\WixBuildTools.TestSupport.Native.dll</HintPath> |
17 | </Reference> | 17 | </Reference> |
18 | </ItemGroup> | 18 | </ItemGroup> |
19 | 19 | ||
@@ -43,7 +43,7 @@ | |||
43 | </Target> | 43 | </Target> |
44 | 44 | ||
45 | <UsingTask AssemblyFile="$(RootPackagesFolder)xunit.runner.msbuild.2.4.1\build\net452\xunit.runner.msbuild.net452.dll" TaskName="Xunit.Runner.MSBuild.xunit" Architecture="x86" /> | 45 | <UsingTask AssemblyFile="$(RootPackagesFolder)xunit.runner.msbuild.2.4.1\build\net452\xunit.runner.msbuild.net452.dll" TaskName="Xunit.Runner.MSBuild.xunit" Architecture="x86" /> |
46 | <Target Name="Test" DependsOnTargets="Build"> | 46 | <Target Name="Test"> |
47 | <xunit Assemblies="$(TargetPath)" /> | 47 | <xunit Assemblies="$(TargetPath)" /> |
48 | </Target> | 48 | </Target> |
49 | </Project> | 49 | </Project> |
diff --git a/src/internal/internal.cmd b/src/internal/internal.cmd index ef465daa..8b46e77c 100644 --- a/src/internal/internal.cmd +++ b/src/internal/internal.cmd | |||
@@ -14,9 +14,10 @@ nuget restore || exit /b | |||
14 | :: dotnet pack -c %_C% WixBuildTools.MsgGen\WixBuildTools.MsgGen.csproj || exit /b | 14 | :: dotnet pack -c %_C% WixBuildTools.MsgGen\WixBuildTools.MsgGen.csproj || exit /b |
15 | :: dotnet pack -c %_C% WixBuildTools.XsdGen\WixBuildTools.XsdGen.csproj || exit /b | 15 | :: dotnet pack -c %_C% WixBuildTools.XsdGen\WixBuildTools.XsdGen.csproj || exit /b |
16 | 16 | ||
17 | msbuild -t:Pack WixBuildTools.TestSupport\WixBuildTools.TestSupport.csproj -p:Configuration=%_C% -nologo || exit /b | 17 | msbuild -t:Pack WixBuildTools.TestSupport\WixBuildTools.TestSupport.csproj -p:Configuration=%_C% -nologo -m -warnaserror -bl:..\..\build\logs\internal_build.binlog || exit /b |
18 | 18 | ||
19 | msbuild -t:Build WixBuildTools.TestSupport.Native\WixBuildTools.TestSupport.Native.vcxproj -p:Configuration=%_C% -nologo || exit /b | 19 | msbuild -t:Build WixBuildTools.TestSupport.Native\WixBuildTools.TestSupport.Native.vcxproj -p:Configuration=%_C%;Platform=x86 -nologo || exit /b |
20 | msbuild -t:Build WixBuildTools.TestSupport.Native\WixBuildTools.TestSupport.Native.vcxproj -p:Configuration=%_C%;Platform=x64 -nologo || exit /b | ||
20 | 21 | ||
21 | @popd | 22 | @popd |
22 | @endlocal | 23 | @endlocal |
diff --git a/src/libs/dutil/WixToolset.DUtil/dutil.vcxproj b/src/libs/dutil/WixToolset.DUtil/dutil.vcxproj index cf38e8ae..ba9e801e 100644 --- a/src/libs/dutil/WixToolset.DUtil/dutil.vcxproj +++ b/src/libs/dutil/WixToolset.DUtil/dutil.vcxproj | |||
@@ -33,7 +33,6 @@ | |||
33 | <ProjectGuid>{1244E671-F108-4334-BA52-8A7517F26ECD}</ProjectGuid> | 33 | <ProjectGuid>{1244E671-F108-4334-BA52-8A7517F26ECD}</ProjectGuid> |
34 | <ConfigurationType>StaticLibrary</ConfigurationType> | 34 | <ConfigurationType>StaticLibrary</ConfigurationType> |
35 | <TargetName>dutil</TargetName> | 35 | <TargetName>dutil</TargetName> |
36 | <MultiTargetLibrary>true</MultiTargetLibrary> | ||
37 | <CharacterSet>MultiByte</CharacterSet> | 36 | <CharacterSet>MultiByte</CharacterSet> |
38 | <Description>WiX Toolset native library foundation</Description> | 37 | <Description>WiX Toolset native library foundation</Description> |
39 | <PackageId>WixToolset.DUtil</PackageId> | 38 | <PackageId>WixToolset.DUtil</PackageId> |
diff --git a/src/libs/dutil/dutil_t.proj b/src/libs/dutil/dutil_t.proj index 90d66440..ee33dae1 100644 --- a/src/libs/dutil/dutil_t.proj +++ b/src/libs/dutil/dutil_t.proj | |||
@@ -1,11 +1,9 @@ | |||
1 | <Project Sdk="Microsoft.Build.Traversal"> | 1 | <Project Sdk="Microsoft.Build.Traversal"> |
2 | <ItemGroup> | 2 | <ItemGroup> |
3 | <ProjectReference Include="WixToolset.DUtil\dutil.vcxproj" Properties="Platform=x86" /> | 3 | <ProjectReference Include="test\DUtilUnitTest\DUtilUnitTest.vcxproj" Properties="Platform=x86" /> |
4 | <ProjectReference Include="WixToolset.DUtil\dutil.vcxproj" Properties="Platform=x64" /> | 4 | <ProjectReference Include="WixToolset.DUtil\dutil.vcxproj" Properties="Platform=x64" /> |
5 | <ProjectReference Include="WixToolset.DUtil\dutil.vcxproj" Properties="Platform=ARM64" /> | 5 | <ProjectReference Include="WixToolset.DUtil\dutil.vcxproj" Properties="Platform=ARM64" /> |
6 | 6 | ||
7 | <ProjectReference Include="test\DUtilUnitTest\DUtilUnitTest.vcxproj" Targets="Test" /> | ||
8 | |||
9 | <ProjectReference Include="WixToolset.DUtil\dutil.vcxproj" Targets="PackNative" /> | 7 | <ProjectReference Include="WixToolset.DUtil\dutil.vcxproj" Targets="PackNative" /> |
10 | </ItemGroup> | 8 | </ItemGroup> |
11 | </Project> | 9 | </Project> |
diff --git a/src/libs/dutil/test/DUtilUnitTest/DUtilUnitTest.vcxproj b/src/libs/dutil/test/DUtilUnitTest/DUtilUnitTest.vcxproj index cd8d16c4..9fca2608 100644 --- a/src/libs/dutil/test/DUtilUnitTest/DUtilUnitTest.vcxproj +++ b/src/libs/dutil/test/DUtilUnitTest/DUtilUnitTest.vcxproj | |||
@@ -9,10 +9,18 @@ | |||
9 | <Configuration>Debug</Configuration> | 9 | <Configuration>Debug</Configuration> |
10 | <Platform>Win32</Platform> | 10 | <Platform>Win32</Platform> |
11 | </ProjectConfiguration> | 11 | </ProjectConfiguration> |
12 | <ProjectConfiguration Include="Debug|x64"> | ||
13 | <Configuration>Debug</Configuration> | ||
14 | <Platform>x64</Platform> | ||
15 | </ProjectConfiguration> | ||
12 | <ProjectConfiguration Include="Release|Win32"> | 16 | <ProjectConfiguration Include="Release|Win32"> |
13 | <Configuration>Release</Configuration> | 17 | <Configuration>Release</Configuration> |
14 | <Platform>Win32</Platform> | 18 | <Platform>Win32</Platform> |
15 | </ProjectConfiguration> | 19 | </ProjectConfiguration> |
20 | <ProjectConfiguration Include="Release|x64"> | ||
21 | <Configuration>Release</Configuration> | ||
22 | <Platform>x64</Platform> | ||
23 | </ProjectConfiguration> | ||
16 | </ItemGroup> | 24 | </ItemGroup> |
17 | 25 | ||
18 | <PropertyGroup Label="Globals"> | 26 | <PropertyGroup Label="Globals"> |
diff --git a/src/libs/libs.cmd b/src/libs/libs.cmd index ddc2e1d6..2cc56239 100644 --- a/src/libs/libs.cmd +++ b/src/libs/libs.cmd | |||
@@ -8,7 +8,9 @@ | |||
8 | 8 | ||
9 | @echo Building libs %_C% | 9 | @echo Building libs %_C% |
10 | 10 | ||
11 | msbuild -Restore libs_t.proj -p:Configuration=%_C% -nologo -m -bl:..\..\build\logs\libs_build.binlog || exit /b | 11 | msbuild -Restore libs_t.proj -p:Configuration=%_C% -nologo -m -warnaserror -bl:..\..\build\logs\libs_build.binlog || exit /b |
12 | |||
13 | msbuild dutil\test\DutilUnitTest -t:Test -p:Configuration=%_C% -nologo || exit /b | ||
12 | 14 | ||
13 | @popd | 15 | @popd |
14 | @endlocal | 16 | @endlocal |
diff --git a/src/samples/samples.cmd b/src/samples/samples.cmd index 0321f75e..5d77270e 100644 --- a/src/samples/samples.cmd +++ b/src/samples/samples.cmd | |||
@@ -12,7 +12,7 @@ | |||
12 | 12 | ||
13 | nuget restore || exit /b | 13 | nuget restore || exit /b |
14 | 14 | ||
15 | msbuild -t:Build -p:Configuration=%_C% -bl:..\..\build\logs\samples_build.binlog || exit /b | 15 | msbuild -t:Build -p:Configuration=%_C% -nologo -m -warnaserror -bl:..\..\build\logs\samples_build.binlog || exit /b |
16 | 16 | ||
17 | @popd | 17 | @popd |
18 | @endlocal | 18 | @endlocal |
diff --git a/src/wix/WixToolset.Converters.Symbolizer/WixToolset.Converters.Symbolizer.csproj b/src/wix/WixToolset.Converters.Symbolizer/WixToolset.Converters.Symbolizer.csproj index 0c3ba4f0..51463f2a 100644 --- a/src/wix/WixToolset.Converters.Symbolizer/WixToolset.Converters.Symbolizer.csproj +++ b/src/wix/WixToolset.Converters.Symbolizer/WixToolset.Converters.Symbolizer.csproj | |||
@@ -15,7 +15,7 @@ | |||
15 | 15 | ||
16 | <ItemGroup> | 16 | <ItemGroup> |
17 | <Reference Include="wix" HintPath="..\deps\wix.dll" /> | 17 | <Reference Include="wix" HintPath="..\deps\wix.dll" /> |
18 | <None Include="..\deps\wix.dll" Pack="true" PackagePath="lib\net472" /> | 18 | <None Condition=" '$(Configuration)'=='Release' " Include="..\deps\wix.dll" Pack="true" PackagePath="lib\net472" /> |
19 | <None Include="..\deps\wix.dll" Pack="true" PackagePath="lib\netstandard2.0" /> | 19 | <None Include="..\deps\wix.dll" Pack="true" PackagePath="lib\netstandard2.0" /> |
20 | </ItemGroup> | 20 | </ItemGroup> |
21 | 21 | ||
diff --git a/src/wix/WixToolset.Converters/WixConverter.cs b/src/wix/WixToolset.Converters/WixConverter.cs index ea8e9b88..7bd2f81a 100644 --- a/src/wix/WixToolset.Converters/WixConverter.cs +++ b/src/wix/WixToolset.Converters/WixConverter.cs | |||
@@ -15,6 +15,7 @@ namespace WixToolset.Converters | |||
15 | using WixToolset.Data.WindowsInstaller; | 15 | using WixToolset.Data.WindowsInstaller; |
16 | using WixToolset.Extensibility.Services; | 16 | using WixToolset.Extensibility.Services; |
17 | 17 | ||
18 | #pragma warning disable 1591 // TODO: add documentation | ||
18 | /// <summary> | 19 | /// <summary> |
19 | /// How to convert CustomTable elements. | 20 | /// How to convert CustomTable elements. |
20 | /// </summary> | 21 | /// </summary> |
diff --git a/src/wix/test/WixToolsetTest.Sdk/MsbuildFixture.cs b/src/wix/test/WixToolsetTest.Sdk/MsbuildFixture.cs index 2c9b3252..696c73ee 100644 --- a/src/wix/test/WixToolsetTest.Sdk/MsbuildFixture.cs +++ b/src/wix/test/WixToolsetTest.Sdk/MsbuildFixture.cs | |||
@@ -44,6 +44,7 @@ namespace WixToolsetTest.Sdk | |||
44 | } | 44 | } |
45 | } | 45 | } |
46 | 46 | ||
47 | [Theory(Skip = "https://github.com/wixtoolset/issues/issues/6407")] | ||
47 | [InlineData(BuildSystem.DotNetCoreSdk)] | 48 | [InlineData(BuildSystem.DotNetCoreSdk)] |
48 | [InlineData(BuildSystem.MSBuild)] | 49 | [InlineData(BuildSystem.MSBuild)] |
49 | [InlineData(BuildSystem.MSBuild64)] | 50 | [InlineData(BuildSystem.MSBuild64)] |
diff --git a/src/wix/wix.cmd b/src/wix/wix.cmd index cd81dfce..7c4c1c18 100644 --- a/src/wix/wix.cmd +++ b/src/wix/wix.cmd | |||
@@ -13,15 +13,13 @@ | |||
13 | @echo Building wix %_C% | 13 | @echo Building wix %_C% |
14 | 14 | ||
15 | :: Restore | 15 | :: Restore |
16 | msbuild -t:Restore wix.sln -p:Configuration=%_C% -nologo -m -bl:..\..\build\logs\wix_restore.binlog || exit /b | 16 | msbuild -t:Restore wix.sln -p:Configuration=%_C% -nologo -m -warnaserror -bl:..\..\build\logs\wix_restore.binlog || exit /b |
17 | 17 | ||
18 | 18 | ||
19 | :: Build | 19 | :: Build |
20 | msbuild wixnative\wixnative.vcxproj -p:Configuration=%_C% -nologo -p:Platform=x86 || exit /b | 20 | msbuild wixnative\wixnative_t.proj -p:Configuration=%_C% -nologo -m -warnaserror -bl:..\..\build\logs\wixnative_build.binlog || exit /b |
21 | msbuild wixnative\wixnative.vcxproj -p:Configuration=%_C% -nologo -p:Platform=x64 || exit /b | ||
22 | msbuild wixnative\wixnative.vcxproj -p:Configuration=%_C% -nologo -p:Platform=ARM64 || exit /b | ||
23 | 21 | ||
24 | msbuild wix.sln -p:Configuration=%_C% -nologo -m -bl:..\..\build\logs\wix_build.binlog || exit /b | 22 | msbuild wix.sln -p:Configuration=%_C% -nologo -m -warnaserror -bl:..\..\build\logs\wix_build.binlog || exit /b |
25 | 23 | ||
26 | 24 | ||
27 | :: Pre-Publish Test | 25 | :: Pre-Publish Test |
@@ -34,7 +32,7 @@ dotnet test -c %_C% --no-build --nologo test\WixToolsetTest.Heat || exit /b | |||
34 | 32 | ||
35 | 33 | ||
36 | :: Publish | 34 | :: Publish |
37 | msbuild publish_t.proj -p:Configuration=%_C% -nologo -bl:..\..\build\logs\wix_publish.binlog || exit /b | 35 | msbuild publish_t.proj -p:Configuration=%_C% -nologo -warnaserror -bl:..\..\build\logs\wix_publish.binlog || exit /b |
38 | 36 | ||
39 | robocopy %_P_OBJ%\WixToolset.Sdk\separate\net472\x86\buildtasks %_P%\WixToolset.Sdk\tools\net472\x86 %_RCO% /XF Microsoft.Build.*.dll | 37 | robocopy %_P_OBJ%\WixToolset.Sdk\separate\net472\x86\buildtasks %_P%\WixToolset.Sdk\tools\net472\x86 %_RCO% /XF Microsoft.Build.*.dll |
40 | robocopy %_P_OBJ%\WixToolset.Sdk\separate\net472\x86\heat %_P%\WixToolset.Sdk\tools\net472\x86 %_RCO% | 38 | robocopy %_P_OBJ%\WixToolset.Sdk\separate\net472\x86\heat %_P%\WixToolset.Sdk\tools\net472\x86 %_RCO% |
@@ -48,7 +46,7 @@ robocopy %_P_OBJ%\WixToolset.Sdk\separate\netcoreapp3.1\buildtasks %_P%\WixTools | |||
48 | robocopy %_P_OBJ%\WixToolset.Sdk\separate\netcoreapp3.1\heat %_P%\WixToolset.Sdk\tools\netcoreapp3.1 %_RCO% | 46 | robocopy %_P_OBJ%\WixToolset.Sdk\separate\netcoreapp3.1\heat %_P%\WixToolset.Sdk\tools\netcoreapp3.1 %_RCO% |
49 | robocopy %_P_OBJ%\WixToolset.Sdk\separate\netcoreapp3.1\wix %_P%\WixToolset.Sdk\tools\netcoreapp3.1 %_RCO% | 47 | robocopy %_P_OBJ%\WixToolset.Sdk\separate\netcoreapp3.1\wix %_P%\WixToolset.Sdk\tools\netcoreapp3.1 %_RCO% |
50 | 48 | ||
51 | msbuild -t:Publish -p:Configuration=%_C% -nologo -p:PublishDir=%_P%WixToolset.Sdk\ WixToolset.Sdk\WixToolset.Sdk.csproj || exit /b | 49 | msbuild -t:Publish -p:Configuration=%_C% -nologo -warnaserror -p:PublishDir=%_P%WixToolset.Sdk\ WixToolset.Sdk\WixToolset.Sdk.csproj || exit /b |
52 | 50 | ||
53 | :: TODO - used by MsbuildFixture.ReportsInnerExceptionForUnexpectedExceptions test | 51 | :: TODO - used by MsbuildFixture.ReportsInnerExceptionForUnexpectedExceptions test |
54 | :: msbuild -t:Publish -Restore -p:Configuration=%_C% -p:TargetFramework=net472 -p:RuntimeIdentifier=linux-x86 -p:PublishDir=%_P%WixToolset.Sdk\broken\net472\ wix\wix.csproj || exit /b | 52 | :: msbuild -t:Publish -Restore -p:Configuration=%_C% -p:TargetFramework=net472 -p:RuntimeIdentifier=linux-x86 -p:PublishDir=%_P%WixToolset.Sdk\broken\net472\ wix\wix.csproj || exit /b |
@@ -59,7 +57,7 @@ dotnet test -c %_C% --no-build --nologo test\WixToolsetTest.BuildTasks || exit / | |||
59 | dotnet test -c %_C% --no-build --nologo test\WixToolsetTest.Sdk || exit /b | 57 | dotnet test -c %_C% --no-build --nologo test\WixToolsetTest.Sdk || exit /b |
60 | 58 | ||
61 | :: Pack | 59 | :: Pack |
62 | msbuild pack_t.proj -p:Configuration=%_C% -nologo -m -bl:..\..\build\logs\wix_pack.binlog || exit /b | 60 | msbuild pack_t.proj -p:Configuration=%_C% -nologo -m -warnaserror -bl:..\..\build\logs\wix_pack.binlog || exit /b |
63 | 61 | ||
64 | @popd | 62 | @popd |
65 | @endlocal | 63 | @endlocal |
diff --git a/src/wix/wixnative/wixnative_t.proj b/src/wix/wixnative/wixnative_t.proj new file mode 100644 index 00000000..db10d0ec --- /dev/null +++ b/src/wix/wixnative/wixnative_t.proj | |||
@@ -0,0 +1,7 @@ | |||
1 | <Project Sdk="Microsoft.Build.Traversal"> | ||
2 | <ItemGroup> | ||
3 | <ProjectReference Include="wixnative.vcxproj" Properties="Platform=x86" /> | ||
4 | <ProjectReference Include="wixnative.vcxproj" Properties="Platform=x64" /> | ||
5 | <ProjectReference Include="wixnative.vcxproj" Properties="Platform=ARM64" /> | ||
6 | </ItemGroup> | ||
7 | </Project> | ||