aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSean Hall <r.sean.hall@gmail.com>2021-01-27 16:23:19 -0600
committerSean Hall <r.sean.hall@gmail.com>2021-01-27 20:38:48 -0600
commit84e3b69bdd1b6811dec8041ebc2a23020ac4c179 (patch)
treeb2ae65f40b8a14635a8854e52193977bb1aed4cb
parenta563fb99daca852422d61ae8599a3dc32fa1bfe6 (diff)
downloadwix-84e3b69bdd1b6811dec8041ebc2a23020ac4c179.tar.gz
wix-84e3b69bdd1b6811dec8041ebc2a23020ac4c179.tar.bz2
wix-84e3b69bdd1b6811dec8041ebc2a23020ac4c179.zip
Always call PlanDump, and make it log at the REPORT_DEBUG level.
Fixes #6327.
-rw-r--r--src/engine/core.cpp2
-rw-r--r--src/engine/plan.cpp91
-rw-r--r--src/engine/plan.h3
3 files changed, 44 insertions, 52 deletions
diff --git a/src/engine/core.cpp b/src/engine/core.cpp
index d157d3b3..5b2454dc 100644
--- a/src/engine/core.cpp
+++ b/src/engine/core.cpp
@@ -491,9 +491,7 @@ extern "C" HRESULT CorePlan(
491 // Finally, display all packages and related bundles in the log. 491 // Finally, display all packages and related bundles in the log.
492 LogPackages(pUpgradeBundlePackage, pForwardCompatibleBundlePackage, &pEngineState->packages, &pEngineState->registration.relatedBundles, action); 492 LogPackages(pUpgradeBundlePackage, pForwardCompatibleBundlePackage, &pEngineState->packages, &pEngineState->registration.relatedBundles, action);
493 493
494#ifdef DEBUG
495 PlanDump(&pEngineState->plan); 494 PlanDump(&pEngineState->plan);
496#endif
497 495
498LExit: 496LExit:
499 if (fActivated) 497 if (fActivated)
diff --git a/src/engine/plan.cpp b/src/engine/plan.cpp
index 0dba36c6..ffbe495f 100644
--- a/src/engine/plan.cpp
+++ b/src/engine/plan.cpp
@@ -2,6 +2,8 @@
2 2
3#include "precomp.h" 3#include "precomp.h"
4 4
5#define PlanDumpLevel REPORT_DEBUG
6
5// internal struct definitions 7// internal struct definitions
6 8
7struct PLAN_NONPERMANENT_PACKAGE_INDICES 9struct PLAN_NONPERMANENT_PACKAGE_INDICES
@@ -3041,9 +3043,6 @@ LExit:
3041 return hr; 3043 return hr;
3042} 3044}
3043 3045
3044
3045#ifdef DEBUG
3046
3047static void CacheActionLog( 3046static void CacheActionLog(
3048 __in DWORD iAction, 3047 __in DWORD iAction,
3049 __in BURN_CACHE_ACTION* pAction, 3048 __in BURN_CACHE_ACTION* pAction,
@@ -3054,59 +3053,59 @@ static void CacheActionLog(
3054 switch (pAction->type) 3053 switch (pAction->type)
3055 { 3054 {
3056 case BURN_CACHE_ACTION_TYPE_ACQUIRE_CONTAINER: 3055 case BURN_CACHE_ACTION_TYPE_ACQUIRE_CONTAINER:
3057 LogStringLine(REPORT_STANDARD, "%ls action[%u]: ACQUIRE_CONTAINER id: %ls, source path: %ls, working path: %ls, skip until retried: %hs", wzBase, iAction, pAction->resolveContainer.pContainer->sczId, pAction->resolveContainer.pContainer->sczSourcePath, pAction->resolveContainer.sczUnverifiedPath, LoggingBoolToString(pAction->fSkipUntilRetried)); 3056 LogStringLine(PlanDumpLevel, "%ls action[%u]: ACQUIRE_CONTAINER id: %ls, source path: %ls, working path: %ls, skip until retried: %hs", wzBase, iAction, pAction->resolveContainer.pContainer->sczId, pAction->resolveContainer.pContainer->sczSourcePath, pAction->resolveContainer.sczUnverifiedPath, LoggingBoolToString(pAction->fSkipUntilRetried));
3058 break; 3057 break;
3059 3058
3060 case BURN_CACHE_ACTION_TYPE_ACQUIRE_PAYLOAD: 3059 case BURN_CACHE_ACTION_TYPE_ACQUIRE_PAYLOAD:
3061 LogStringLine(REPORT_STANDARD, "%ls action[%u]: ACQUIRE_PAYLOAD package id: %ls, payload id: %ls, source path: %ls, working path: %ls, skip until retried: %hs", wzBase, iAction, pAction->resolvePayload.pPackage ? pAction->resolvePayload.pPackage->sczId : L"", pAction->resolvePayload.pPayload->sczKey, pAction->resolvePayload.pPayload->sczSourcePath, pAction->resolvePayload.sczUnverifiedPath, LoggingBoolToString(pAction->fSkipUntilRetried)); 3060 LogStringLine(PlanDumpLevel, "%ls action[%u]: ACQUIRE_PAYLOAD package id: %ls, payload id: %ls, source path: %ls, working path: %ls, skip until retried: %hs", wzBase, iAction, pAction->resolvePayload.pPackage ? pAction->resolvePayload.pPackage->sczId : L"", pAction->resolvePayload.pPayload->sczKey, pAction->resolvePayload.pPayload->sczSourcePath, pAction->resolvePayload.sczUnverifiedPath, LoggingBoolToString(pAction->fSkipUntilRetried));
3062 break; 3061 break;
3063 3062
3064 case BURN_CACHE_ACTION_TYPE_CACHE_PAYLOAD: 3063 case BURN_CACHE_ACTION_TYPE_CACHE_PAYLOAD:
3065 LogStringLine(REPORT_STANDARD, "%ls action[%u]: CACHE_PAYLOAD package id: %ls, payload id: %ls, working path: %ls, operation: %ls, skip until retried: %hs, retry action: %u", wzBase, iAction, pAction->cachePayload.pPackage->sczId, pAction->cachePayload.pPayload->sczKey, pAction->cachePayload.sczUnverifiedPath, pAction->cachePayload.fMove ? L"move" : L"copy", LoggingBoolToString(pAction->fSkipUntilRetried), pAction->cachePayload.iTryAgainAction); 3064 LogStringLine(PlanDumpLevel, "%ls action[%u]: CACHE_PAYLOAD package id: %ls, payload id: %ls, working path: %ls, operation: %ls, skip until retried: %hs, retry action: %u", wzBase, iAction, pAction->cachePayload.pPackage->sczId, pAction->cachePayload.pPayload->sczKey, pAction->cachePayload.sczUnverifiedPath, pAction->cachePayload.fMove ? L"move" : L"copy", LoggingBoolToString(pAction->fSkipUntilRetried), pAction->cachePayload.iTryAgainAction);
3066 break; 3065 break;
3067 3066
3068 case BURN_CACHE_ACTION_TYPE_CHECKPOINT: 3067 case BURN_CACHE_ACTION_TYPE_CHECKPOINT:
3069 LogStringLine(REPORT_STANDARD, "%ls action[%u]: CHECKPOINT id: %u", wzBase, iAction, pAction->checkpoint.dwId); 3068 LogStringLine(PlanDumpLevel, "%ls action[%u]: CHECKPOINT id: %u", wzBase, iAction, pAction->checkpoint.dwId);
3070 break; 3069 break;
3071 3070
3072 case BURN_CACHE_ACTION_TYPE_EXTRACT_CONTAINER: 3071 case BURN_CACHE_ACTION_TYPE_EXTRACT_CONTAINER:
3073 LogStringLine(REPORT_STANDARD, "%ls action[%u]: EXTRACT_CONTAINER id: %ls, working path: %ls, skip until retried: %hs, skip until acquired by action: %u", wzBase, iAction, pAction->extractContainer.pContainer->sczId, pAction->extractContainer.sczContainerUnverifiedPath, LoggingBoolToString(pAction->fSkipUntilRetried), pAction->extractContainer.iSkipUntilAcquiredByAction); 3072 LogStringLine(PlanDumpLevel, "%ls action[%u]: EXTRACT_CONTAINER id: %ls, working path: %ls, skip until retried: %hs, skip until acquired by action: %u", wzBase, iAction, pAction->extractContainer.pContainer->sczId, pAction->extractContainer.sczContainerUnverifiedPath, LoggingBoolToString(pAction->fSkipUntilRetried), pAction->extractContainer.iSkipUntilAcquiredByAction);
3074 for (DWORD j = 0; j < pAction->extractContainer.cPayloads; j++) 3073 for (DWORD j = 0; j < pAction->extractContainer.cPayloads; j++)
3075 { 3074 {
3076 LogStringLine(REPORT_STANDARD, " extract package id: %ls, payload id: %ls, working path: %ls", pAction->extractContainer.rgPayloads[j].pPackage->sczId, pAction->extractContainer.rgPayloads[j].pPayload->sczKey, pAction->extractContainer.rgPayloads[j].sczUnverifiedPath); 3075 LogStringLine(PlanDumpLevel, " extract package id: %ls, payload id: %ls, working path: %ls", pAction->extractContainer.rgPayloads[j].pPackage->sczId, pAction->extractContainer.rgPayloads[j].pPayload->sczKey, pAction->extractContainer.rgPayloads[j].sczUnverifiedPath);
3077 } 3076 }
3078 break; 3077 break;
3079 3078
3080 case BURN_CACHE_ACTION_TYPE_LAYOUT_BUNDLE: 3079 case BURN_CACHE_ACTION_TYPE_LAYOUT_BUNDLE:
3081 LogStringLine(REPORT_STANDARD, "%ls action[%u]: LAYOUT_BUNDLE working path: %ls, layout directory: %ls, exe name: %ls, skip until retried: %hs", wzBase, iAction, pAction->bundleLayout.sczUnverifiedPath, pAction->bundleLayout.sczLayoutDirectory, pAction->bundleLayout.sczExecutableName, LoggingBoolToString(pAction->fSkipUntilRetried)); 3080 LogStringLine(PlanDumpLevel, "%ls action[%u]: LAYOUT_BUNDLE working path: %ls, layout directory: %ls, exe name: %ls, skip until retried: %hs", wzBase, iAction, pAction->bundleLayout.sczUnverifiedPath, pAction->bundleLayout.sczLayoutDirectory, pAction->bundleLayout.sczExecutableName, LoggingBoolToString(pAction->fSkipUntilRetried));
3082 break; 3081 break;
3083 3082
3084 case BURN_CACHE_ACTION_TYPE_LAYOUT_CONTAINER: 3083 case BURN_CACHE_ACTION_TYPE_LAYOUT_CONTAINER:
3085 LogStringLine(REPORT_STANDARD, "%ls action[%u]: LAYOUT_CONTAINER package id: %ls, container id: %ls, working path: %ls, layout directory: %ls, operation: %ls, skip until retried: %hs, retry action: %u", wzBase, iAction, pAction->layoutContainer.pPackage ? pAction->layoutContainer.pPackage->sczId : L"", pAction->layoutContainer.pContainer->sczId, pAction->layoutContainer.sczUnverifiedPath, pAction->layoutContainer.sczLayoutDirectory, pAction->layoutContainer.fMove ? L"move" : L"copy", LoggingBoolToString(pAction->fSkipUntilRetried), pAction->layoutContainer.iTryAgainAction); 3084 LogStringLine(PlanDumpLevel, "%ls action[%u]: LAYOUT_CONTAINER package id: %ls, container id: %ls, working path: %ls, layout directory: %ls, operation: %ls, skip until retried: %hs, retry action: %u", wzBase, iAction, pAction->layoutContainer.pPackage ? pAction->layoutContainer.pPackage->sczId : L"", pAction->layoutContainer.pContainer->sczId, pAction->layoutContainer.sczUnverifiedPath, pAction->layoutContainer.sczLayoutDirectory, pAction->layoutContainer.fMove ? L"move" : L"copy", LoggingBoolToString(pAction->fSkipUntilRetried), pAction->layoutContainer.iTryAgainAction);
3086 break; 3085 break;
3087 3086
3088 case BURN_CACHE_ACTION_TYPE_LAYOUT_PAYLOAD: 3087 case BURN_CACHE_ACTION_TYPE_LAYOUT_PAYLOAD:
3089 LogStringLine(REPORT_STANDARD, "%ls action[%u]: LAYOUT_PAYLOAD package id: %ls, payload id: %ls, working path: %ls, layout directory: %ls, operation: %ls, skip until retried: %hs, retry action: %u", wzBase, iAction, pAction->layoutPayload.pPackage ? pAction->layoutPayload.pPackage->sczId : L"", pAction->layoutPayload.pPayload->sczKey, pAction->layoutPayload.sczUnverifiedPath, pAction->layoutPayload.sczLayoutDirectory, pAction->layoutPayload.fMove ? L"move" : L"copy", LoggingBoolToString(pAction->fSkipUntilRetried), pAction->layoutPayload.iTryAgainAction); 3088 LogStringLine(PlanDumpLevel, "%ls action[%u]: LAYOUT_PAYLOAD package id: %ls, payload id: %ls, working path: %ls, layout directory: %ls, operation: %ls, skip until retried: %hs, retry action: %u", wzBase, iAction, pAction->layoutPayload.pPackage ? pAction->layoutPayload.pPackage->sczId : L"", pAction->layoutPayload.pPayload->sczKey, pAction->layoutPayload.sczUnverifiedPath, pAction->layoutPayload.sczLayoutDirectory, pAction->layoutPayload.fMove ? L"move" : L"copy", LoggingBoolToString(pAction->fSkipUntilRetried), pAction->layoutPayload.iTryAgainAction);
3090 break; 3089 break;
3091 3090
3092 case BURN_CACHE_ACTION_TYPE_PACKAGE_START: 3091 case BURN_CACHE_ACTION_TYPE_PACKAGE_START:
3093 LogStringLine(REPORT_STANDARD, "%ls action[%u]: PACKAGE_START id: %ls, plan index for skip: %u, payloads to cache: %u, bytes to cache: %llu, skip until retried: %hs", wzBase, iAction, pAction->packageStart.pPackage->sczId, pAction->packageStart.iPackageCompleteAction, pAction->packageStart.cCachePayloads, pAction->packageStart.qwCachePayloadSizeTotal, LoggingBoolToString(pAction->fSkipUntilRetried)); 3092 LogStringLine(PlanDumpLevel, "%ls action[%u]: PACKAGE_START id: %ls, plan index for skip: %u, payloads to cache: %u, bytes to cache: %llu, skip until retried: %hs", wzBase, iAction, pAction->packageStart.pPackage->sczId, pAction->packageStart.iPackageCompleteAction, pAction->packageStart.cCachePayloads, pAction->packageStart.qwCachePayloadSizeTotal, LoggingBoolToString(pAction->fSkipUntilRetried));
3094 break; 3093 break;
3095 3094
3096 case BURN_CACHE_ACTION_TYPE_PACKAGE_STOP: 3095 case BURN_CACHE_ACTION_TYPE_PACKAGE_STOP:
3097 LogStringLine(REPORT_STANDARD, "%ls action[%u]: PACKAGE_STOP id: %ls, skip until retried: %hs", wzBase, iAction, pAction->packageStop.pPackage->sczId, LoggingBoolToString(pAction->fSkipUntilRetried)); 3096 LogStringLine(PlanDumpLevel, "%ls action[%u]: PACKAGE_STOP id: %ls, skip until retried: %hs", wzBase, iAction, pAction->packageStop.pPackage->sczId, LoggingBoolToString(pAction->fSkipUntilRetried));
3098 break; 3097 break;
3099 3098
3100 case BURN_CACHE_ACTION_TYPE_ROLLBACK_PACKAGE: 3099 case BURN_CACHE_ACTION_TYPE_ROLLBACK_PACKAGE:
3101 LogStringLine(REPORT_STANDARD, "%ls action[%u]: ROLLBACK_PACKAGE id: %ls, skip until retried: %hs", wzBase, iAction, pAction->rollbackPackage.pPackage->sczId, LoggingBoolToString(pAction->fSkipUntilRetried)); 3100 LogStringLine(PlanDumpLevel, "%ls action[%u]: ROLLBACK_PACKAGE id: %ls, skip until retried: %hs", wzBase, iAction, pAction->rollbackPackage.pPackage->sczId, LoggingBoolToString(pAction->fSkipUntilRetried));
3102 break; 3101 break;
3103 3102
3104 case BURN_CACHE_ACTION_TYPE_SIGNAL_SYNCPOINT: 3103 case BURN_CACHE_ACTION_TYPE_SIGNAL_SYNCPOINT:
3105 LogStringLine(REPORT_STANDARD, "%ls action[%u]: SIGNAL_SYNCPOINT event handle: 0x%p, skip until retried: %hs", wzBase, iAction, pAction->syncpoint.hEvent, LoggingBoolToString(pAction->fSkipUntilRetried)); 3104 LogStringLine(PlanDumpLevel, "%ls action[%u]: SIGNAL_SYNCPOINT event handle: 0x%p, skip until retried: %hs", wzBase, iAction, pAction->syncpoint.hEvent, LoggingBoolToString(pAction->fSkipUntilRetried));
3106 break; 3105 break;
3107 3106
3108 case BURN_CACHE_ACTION_TYPE_TRANSACTION_BOUNDARY: 3107 case BURN_CACHE_ACTION_TYPE_TRANSACTION_BOUNDARY:
3109 LogStringLine(REPORT_STANDARD, "%ls action[%u]: TRANSACTION_BOUNDARY id: %ls, event handle: 0x%p, vital: %ls, transaction: %ls", wzBase, iAction, pAction->rollbackBoundary.pRollbackBoundary->sczId, pAction->rollbackBoundary.hEvent, pAction->rollbackBoundary.pRollbackBoundary->fVital ? L"yes" : L"no", pAction->rollbackBoundary.pRollbackBoundary->fTransaction ? L"yes" : L"no"); 3108 LogStringLine(PlanDumpLevel, "%ls action[%u]: TRANSACTION_BOUNDARY id: %ls, event handle: 0x%p, vital: %ls, transaction: %ls", wzBase, iAction, pAction->rollbackBoundary.pRollbackBoundary->sczId, pAction->rollbackBoundary.hEvent, pAction->rollbackBoundary.pRollbackBoundary->fVital ? L"yes" : L"no", pAction->rollbackBoundary.pRollbackBoundary->fTransaction ? L"yes" : L"no");
3110 break; 3109 break;
3111 3110
3112 default: 3111 default:
@@ -3125,67 +3124,67 @@ static void ExecuteActionLog(
3125 switch (pAction->type) 3124 switch (pAction->type)
3126 { 3125 {
3127 case BURN_EXECUTE_ACTION_TYPE_CHECKPOINT: 3126 case BURN_EXECUTE_ACTION_TYPE_CHECKPOINT:
3128 LogStringLine(REPORT_STANDARD, "%ls action[%u]: CHECKPOINT id: %u, msi transaction id: %ls", wzBase, iAction, pAction->checkpoint.dwId, pAction->checkpoint.pActiveRollbackBoundary && pAction->checkpoint.pActiveRollbackBoundary->fTransaction ? pAction->checkpoint.pActiveRollbackBoundary->sczId : L"(none)"); 3127 LogStringLine(PlanDumpLevel, "%ls action[%u]: CHECKPOINT id: %u, msi transaction id: %ls", wzBase, iAction, pAction->checkpoint.dwId, pAction->checkpoint.pActiveRollbackBoundary && pAction->checkpoint.pActiveRollbackBoundary->fTransaction ? pAction->checkpoint.pActiveRollbackBoundary->sczId : L"(none)");
3129 break; 3128 break;
3130 3129
3131 case BURN_EXECUTE_ACTION_TYPE_PACKAGE_PROVIDER: 3130 case BURN_EXECUTE_ACTION_TYPE_PACKAGE_PROVIDER:
3132 LogStringLine(REPORT_STANDARD, "%ls action[%u]: PACKAGE_PROVIDER package id: %ls, action: %hs", wzBase, iAction, pAction->packageProvider.pPackage->sczId, LoggingDependencyActionToString(pAction->packageProvider.action)); 3131 LogStringLine(PlanDumpLevel, "%ls action[%u]: PACKAGE_PROVIDER package id: %ls, action: %hs", wzBase, iAction, pAction->packageProvider.pPackage->sczId, LoggingDependencyActionToString(pAction->packageProvider.action));
3133 break; 3132 break;
3134 3133
3135 case BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY: 3134 case BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY:
3136 LogStringLine(REPORT_STANDARD, "%ls action[%u]: PACKAGE_DEPENDENCY package id: %ls, bundle provider key: %ls, action: %hs", wzBase, iAction, pAction->packageDependency.pPackage->sczId, pAction->packageDependency.sczBundleProviderKey, LoggingDependencyActionToString(pAction->packageDependency.action)); 3135 LogStringLine(PlanDumpLevel, "%ls action[%u]: PACKAGE_DEPENDENCY package id: %ls, bundle provider key: %ls, action: %hs", wzBase, iAction, pAction->packageDependency.pPackage->sczId, pAction->packageDependency.sczBundleProviderKey, LoggingDependencyActionToString(pAction->packageDependency.action));
3137 break; 3136 break;
3138 3137
3139 case BURN_EXECUTE_ACTION_TYPE_EXE_PACKAGE: 3138 case BURN_EXECUTE_ACTION_TYPE_EXE_PACKAGE:
3140 LogStringLine(REPORT_STANDARD, "%ls action[%u]: EXE_PACKAGE package id: %ls, action: %hs, ignore dependencies: %ls", wzBase, iAction, pAction->exePackage.pPackage->sczId, LoggingActionStateToString(pAction->exePackage.action), pAction->exePackage.sczIgnoreDependencies); 3139 LogStringLine(PlanDumpLevel, "%ls action[%u]: EXE_PACKAGE package id: %ls, action: %hs, ignore dependencies: %ls", wzBase, iAction, pAction->exePackage.pPackage->sczId, LoggingActionStateToString(pAction->exePackage.action), pAction->exePackage.sczIgnoreDependencies);
3141 break; 3140 break;
3142 3141
3143 case BURN_EXECUTE_ACTION_TYPE_MSI_PACKAGE: 3142 case BURN_EXECUTE_ACTION_TYPE_MSI_PACKAGE:
3144 LogStringLine(REPORT_STANDARD, "%ls action[%u]: MSI_PACKAGE package id: %ls, action: %hs, action msi property: %ls, ui level: %u, disable externaluihandler: %ls, log path: %ls, logging attrib: %u", wzBase, iAction, pAction->msiPackage.pPackage->sczId, LoggingActionStateToString(pAction->msiPackage.action), LoggingBurnMsiPropertyToString(pAction->msiPackage.actionMsiProperty), pAction->msiPackage.uiLevel, pAction->msiPackage.fDisableExternalUiHandler ? L"yes" : L"no", pAction->msiPackage.sczLogPath, pAction->msiPackage.dwLoggingAttributes); 3143 LogStringLine(PlanDumpLevel, "%ls action[%u]: MSI_PACKAGE package id: %ls, action: %hs, action msi property: %ls, ui level: %u, disable externaluihandler: %ls, log path: %ls, logging attrib: %u", wzBase, iAction, pAction->msiPackage.pPackage->sczId, LoggingActionStateToString(pAction->msiPackage.action), LoggingBurnMsiPropertyToString(pAction->msiPackage.actionMsiProperty), pAction->msiPackage.uiLevel, pAction->msiPackage.fDisableExternalUiHandler ? L"yes" : L"no", pAction->msiPackage.sczLogPath, pAction->msiPackage.dwLoggingAttributes);
3145 for (DWORD j = 0; j < pAction->msiPackage.cPatches; ++j) 3144 for (DWORD j = 0; j < pAction->msiPackage.cPatches; ++j)
3146 { 3145 {
3147 LogStringLine(REPORT_STANDARD, " Patch[%u]: order: %u, msp package id: %ls", j, pAction->msiPackage.rgOrderedPatches[j].dwOrder, pAction->msiPackage.rgOrderedPatches[j].pPackage->sczId); 3146 LogStringLine(PlanDumpLevel, " Patch[%u]: order: %u, msp package id: %ls", j, pAction->msiPackage.rgOrderedPatches[j].dwOrder, pAction->msiPackage.rgOrderedPatches[j].pPackage->sczId);
3148 } 3147 }
3149 break; 3148 break;
3150 3149
3151 case BURN_EXECUTE_ACTION_TYPE_MSP_TARGET: 3150 case BURN_EXECUTE_ACTION_TYPE_MSP_TARGET:
3152 LogStringLine(REPORT_STANDARD, "%ls action[%u]: MSP_TARGET package id: %ls, action: %hs, target product code: %ls, target per-machine: %ls, action msi property: %ls, ui level: %u, disable externaluihandler: %ls, log path: %ls", wzBase, iAction, pAction->mspTarget.pPackage->sczId, LoggingActionStateToString(pAction->mspTarget.action), pAction->mspTarget.sczTargetProductCode, pAction->mspTarget.fPerMachineTarget ? L"yes" : L"no", LoggingBurnMsiPropertyToString(pAction->mspTarget.actionMsiProperty), pAction->mspTarget.uiLevel, pAction->mspTarget.fDisableExternalUiHandler ? L"yes" : L"no", pAction->mspTarget.sczLogPath); 3151 LogStringLine(PlanDumpLevel, "%ls action[%u]: MSP_TARGET package id: %ls, action: %hs, target product code: %ls, target per-machine: %ls, action msi property: %ls, ui level: %u, disable externaluihandler: %ls, log path: %ls", wzBase, iAction, pAction->mspTarget.pPackage->sczId, LoggingActionStateToString(pAction->mspTarget.action), pAction->mspTarget.sczTargetProductCode, pAction->mspTarget.fPerMachineTarget ? L"yes" : L"no", LoggingBurnMsiPropertyToString(pAction->mspTarget.actionMsiProperty), pAction->mspTarget.uiLevel, pAction->mspTarget.fDisableExternalUiHandler ? L"yes" : L"no", pAction->mspTarget.sczLogPath);
3153 for (DWORD j = 0; j < pAction->mspTarget.cOrderedPatches; ++j) 3152 for (DWORD j = 0; j < pAction->mspTarget.cOrderedPatches; ++j)
3154 { 3153 {
3155 LogStringLine(REPORT_STANDARD, " Patch[%u]: order: %u, msp package id: %ls", j, pAction->mspTarget.rgOrderedPatches[j].dwOrder, pAction->mspTarget.rgOrderedPatches[j].pPackage->sczId); 3154 LogStringLine(PlanDumpLevel, " Patch[%u]: order: %u, msp package id: %ls", j, pAction->mspTarget.rgOrderedPatches[j].dwOrder, pAction->mspTarget.rgOrderedPatches[j].pPackage->sczId);
3156 } 3155 }
3157 break; 3156 break;
3158 3157
3159 case BURN_EXECUTE_ACTION_TYPE_MSU_PACKAGE: 3158 case BURN_EXECUTE_ACTION_TYPE_MSU_PACKAGE:
3160 LogStringLine(REPORT_STANDARD, "%ls action[%u]: MSU_PACKAGE package id: %ls, action: %hs, log path: %ls", wzBase, iAction, pAction->msuPackage.pPackage->sczId, LoggingActionStateToString(pAction->msuPackage.action), pAction->msuPackage.sczLogPath); 3159 LogStringLine(PlanDumpLevel, "%ls action[%u]: MSU_PACKAGE package id: %ls, action: %hs, log path: %ls", wzBase, iAction, pAction->msuPackage.pPackage->sczId, LoggingActionStateToString(pAction->msuPackage.action), pAction->msuPackage.sczLogPath);
3161 break; 3160 break;
3162 3161
3163 case BURN_EXECUTE_ACTION_TYPE_REGISTRATION: 3162 case BURN_EXECUTE_ACTION_TYPE_REGISTRATION:
3164 LogStringLine(REPORT_STANDARD, "%ls action[%u]: REGISTRATION keep: %ls", wzBase, iAction, pAction->registration.fKeep ? L"yes" : L"no"); 3163 LogStringLine(PlanDumpLevel, "%ls action[%u]: REGISTRATION keep: %ls", wzBase, iAction, pAction->registration.fKeep ? L"yes" : L"no");
3165 break; 3164 break;
3166 3165
3167 case BURN_EXECUTE_ACTION_TYPE_ROLLBACK_BOUNDARY: 3166 case BURN_EXECUTE_ACTION_TYPE_ROLLBACK_BOUNDARY:
3168 LogStringLine(REPORT_STANDARD, "%ls action[%u]: ROLLBACK_BOUNDARY id: %ls, vital: %ls", wzBase, iAction, pAction->rollbackBoundary.pRollbackBoundary->sczId, pAction->rollbackBoundary.pRollbackBoundary->fVital ? L"yes" : L"no"); 3167 LogStringLine(PlanDumpLevel, "%ls action[%u]: ROLLBACK_BOUNDARY id: %ls, vital: %ls", wzBase, iAction, pAction->rollbackBoundary.pRollbackBoundary->sczId, pAction->rollbackBoundary.pRollbackBoundary->fVital ? L"yes" : L"no");
3169 break; 3168 break;
3170 3169
3171 case BURN_EXECUTE_ACTION_TYPE_WAIT_SYNCPOINT: 3170 case BURN_EXECUTE_ACTION_TYPE_WAIT_SYNCPOINT:
3172 LogStringLine(REPORT_STANDARD, "%ls action[%u]: WAIT_SYNCPOINT event handle: 0x%p", wzBase, iAction, pAction->syncpoint.hEvent); 3171 LogStringLine(PlanDumpLevel, "%ls action[%u]: WAIT_SYNCPOINT event handle: 0x%p", wzBase, iAction, pAction->syncpoint.hEvent);
3173 break; 3172 break;
3174 3173
3175 case BURN_EXECUTE_ACTION_TYPE_UNCACHE_PACKAGE: 3174 case BURN_EXECUTE_ACTION_TYPE_UNCACHE_PACKAGE:
3176 LogStringLine(REPORT_STANDARD, "%ls action[%u]: UNCACHE_PACKAGE id: %ls", wzBase, iAction, pAction->uncachePackage.pPackage->sczId); 3175 LogStringLine(PlanDumpLevel, "%ls action[%u]: UNCACHE_PACKAGE id: %ls", wzBase, iAction, pAction->uncachePackage.pPackage->sczId);
3177 break; 3176 break;
3178 3177
3179 case BURN_EXECUTE_ACTION_TYPE_COMPATIBLE_PACKAGE: 3178 case BURN_EXECUTE_ACTION_TYPE_COMPATIBLE_PACKAGE:
3180 LogStringLine(REPORT_STANDARD, "%ls action[%u]: COMPATIBLE_PACKAGE reference id: %ls, installed ProductCode: %ls", wzBase, iAction, pAction->compatiblePackage.pReferencePackage->sczId, pAction->compatiblePackage.sczInstalledProductCode); 3179 LogStringLine(PlanDumpLevel, "%ls action[%u]: COMPATIBLE_PACKAGE reference id: %ls, installed ProductCode: %ls", wzBase, iAction, pAction->compatiblePackage.pReferencePackage->sczId, pAction->compatiblePackage.sczInstalledProductCode);
3181 break; 3180 break;
3182 3181
3183 case BURN_EXECUTE_ACTION_TYPE_BEGIN_MSI_TRANSACTION: 3182 case BURN_EXECUTE_ACTION_TYPE_BEGIN_MSI_TRANSACTION:
3184 LogStringLine(REPORT_STANDARD, "%ls action[%u]: BEGIN_MSI_TRANSACTION id: %ls", wzBase, iAction, pAction->msiTransaction.pRollbackBoundary->sczId); 3183 LogStringLine(PlanDumpLevel, "%ls action[%u]: BEGIN_MSI_TRANSACTION id: %ls", wzBase, iAction, pAction->msiTransaction.pRollbackBoundary->sczId);
3185 break; 3184 break;
3186 3185
3187 case BURN_EXECUTE_ACTION_TYPE_COMMIT_MSI_TRANSACTION: 3186 case BURN_EXECUTE_ACTION_TYPE_COMMIT_MSI_TRANSACTION:
3188 LogStringLine(REPORT_STANDARD, "%ls action[%u]: COMMIT_MSI_TRANSACTION id: %ls", wzBase, iAction, pAction->msiTransaction.pRollbackBoundary->sczId); 3187 LogStringLine(PlanDumpLevel, "%ls action[%u]: COMMIT_MSI_TRANSACTION id: %ls", wzBase, iAction, pAction->msiTransaction.pRollbackBoundary->sczId);
3189 break; 3188 break;
3190 3189
3191 default: 3190 default:
@@ -3198,15 +3197,15 @@ extern "C" void PlanDump(
3198 __in BURN_PLAN* pPlan 3197 __in BURN_PLAN* pPlan
3199 ) 3198 )
3200{ 3199{
3201 LogStringLine(REPORT_STANDARD, "--- Begin plan dump ---"); 3200 LogStringLine(PlanDumpLevel, "--- Begin plan dump ---");
3202 3201
3203 LogStringLine(REPORT_STANDARD, "Plan action: %hs", LoggingBurnActionToString(pPlan->action)); 3202 LogStringLine(PlanDumpLevel, "Plan action: %hs", LoggingBurnActionToString(pPlan->action));
3204 LogStringLine(REPORT_STANDARD, " per-machine: %hs", LoggingTrueFalseToString(pPlan->fPerMachine)); 3203 LogStringLine(PlanDumpLevel, " per-machine: %hs", LoggingTrueFalseToString(pPlan->fPerMachine));
3205 LogStringLine(REPORT_STANDARD, " disable-rollback: %hs", LoggingTrueFalseToString(pPlan->fDisableRollback)); 3204 LogStringLine(PlanDumpLevel, " disable-rollback: %hs", LoggingTrueFalseToString(pPlan->fDisableRollback));
3206 LogStringLine(REPORT_STANDARD, " keep registration by default: %hs", LoggingTrueFalseToString(pPlan->fKeepRegistrationDefault)); 3205 LogStringLine(PlanDumpLevel, " keep registration by default: %hs", LoggingTrueFalseToString(pPlan->fKeepRegistrationDefault));
3207 LogStringLine(REPORT_STANDARD, " estimated size: %llu", pPlan->qwEstimatedSize); 3206 LogStringLine(PlanDumpLevel, " estimated size: %llu", pPlan->qwEstimatedSize);
3208 3207
3209 LogStringLine(REPORT_STANDARD, "Plan cache size: %llu", pPlan->qwCacheSizeTotal); 3208 LogStringLine(PlanDumpLevel, "Plan cache size: %llu", pPlan->qwCacheSizeTotal);
3210 for (DWORD i = 0; i < pPlan->cCacheActions; ++i) 3209 for (DWORD i = 0; i < pPlan->cCacheActions; ++i)
3211 { 3210 {
3212 CacheActionLog(i, pPlan->rgCacheActions + i, FALSE); 3211 CacheActionLog(i, pPlan->rgCacheActions + i, FALSE);
@@ -3217,8 +3216,8 @@ extern "C" void PlanDump(
3217 CacheActionLog(i, pPlan->rgRollbackCacheActions + i, TRUE); 3216 CacheActionLog(i, pPlan->rgRollbackCacheActions + i, TRUE);
3218 } 3217 }
3219 3218
3220 LogStringLine(REPORT_STANDARD, "Plan execute package count: %u", pPlan->cExecutePackagesTotal); 3219 LogStringLine(PlanDumpLevel, "Plan execute package count: %u", pPlan->cExecutePackagesTotal);
3221 LogStringLine(REPORT_STANDARD, " overall progress ticks: %u", pPlan->cOverallProgressTicksTotal); 3220 LogStringLine(PlanDumpLevel, " overall progress ticks: %u", pPlan->cOverallProgressTicksTotal);
3222 for (DWORD i = 0; i < pPlan->cExecuteActions; ++i) 3221 for (DWORD i = 0; i < pPlan->cExecuteActions; ++i)
3223 { 3222 {
3224 ExecuteActionLog(i, pPlan->rgExecuteActions + i, FALSE); 3223 ExecuteActionLog(i, pPlan->rgExecuteActions + i, FALSE);
@@ -3231,15 +3230,13 @@ extern "C" void PlanDump(
3231 3230
3232 for (DWORD i = 0; i < pPlan->cCleanActions; ++i) 3231 for (DWORD i = 0; i < pPlan->cCleanActions; ++i)
3233 { 3232 {
3234 LogStringLine(REPORT_STANDARD, " Clean action[%u]: CLEAN_PACKAGE package id: %ls", i, pPlan->rgCleanActions[i].pPackage->sczId); 3233 LogStringLine(PlanDumpLevel, " Clean action[%u]: CLEAN_PACKAGE package id: %ls", i, pPlan->rgCleanActions[i].pPackage->sczId);
3235 } 3234 }
3236 3235
3237 for (DWORD i = 0; i < pPlan->cPlannedProviders; ++i) 3236 for (DWORD i = 0; i < pPlan->cPlannedProviders; ++i)
3238 { 3237 {
3239 LogStringLine(REPORT_STANDARD, " Dependency action[%u]: PLANNED_PROVIDER key: %ls, name: %ls", i, pPlan->rgPlannedProviders[i].sczKey, pPlan->rgPlannedProviders[i].sczName); 3238 LogStringLine(PlanDumpLevel, " Dependency action[%u]: PLANNED_PROVIDER key: %ls, name: %ls", i, pPlan->rgPlannedProviders[i].sczKey, pPlan->rgPlannedProviders[i].sczName);
3240 } 3239 }
3241 3240
3242 LogStringLine(REPORT_STANDARD, "--- End plan dump ---"); 3241 LogStringLine(PlanDumpLevel, "--- End plan dump ---");
3243} 3242}
3244
3245#endif
diff --git a/src/engine/plan.h b/src/engine/plan.h
index 9d7debe1..dad436d4 100644
--- a/src/engine/plan.h
+++ b/src/engine/plan.h
@@ -550,12 +550,9 @@ HRESULT PlanSetResumeCommand(
550 __in BOOTSTRAPPER_COMMAND* pCommand, 550 __in BOOTSTRAPPER_COMMAND* pCommand,
551 __in BURN_LOGGING* pLog 551 __in BURN_LOGGING* pLog
552 ); 552 );
553
554#ifdef DEBUG
555void PlanDump( 553void PlanDump(
556 __in BURN_PLAN* pPlan 554 __in BURN_PLAN* pPlan
557 ); 555 );
558#endif
559 556
560#if defined(__cplusplus) 557#if defined(__cplusplus)
561} 558}