Stop encrypting hidden variables.

They were persisted in plaintext, and always had to be decrypted and sent to a separate process to actually be used.

1 files changed, 0 insertions, 4 deletions

diff --git a/src/WixToolset.BootstrapperCore.Native/inc/BootstrapperEngine.h b/src/WixToolset.BootstrapperCore.Native/inc/BootstrapperEngine.h
index 13229c29..98a9d77d 100644
--- a/src/WixToolset.BootstrapperCore.Native/inc/BootstrapperEngine.h
+++ b/src/WixToolset.BootstrapperCore.Native/inc/BootstrapperEngine.h
@@ -218,7 +218,6 @@ typedef struct _BAENGINE_FORMATSTRING_ARGS
 typedef struct _BAENGINE_FORMATSTRING_RESULTS
 {
     DWORD cbSize;
-    // The contents of wzOut may be sensitive, should keep encrypted and SecureZeroFree.
     LPWSTR wzOut;
     // Should be initialized to the size of wzOut.
     DWORD cchOut;
@@ -244,7 +243,6 @@ typedef struct _BAENGINE_GETVARIABLENUMERIC_ARGS
 typedef struct _BAENGINE_GETVARIABLENUMERIC_RESULTS
 {
     DWORD cbSize;
-    // The contents of llValue may be sensitive, if variable is hidden should keep value encrypted and SecureZeroMemory.
     LONGLONG llValue;
 } BAENGINE_GETVARIABLENUMERIC_RESULTS;
 
@@ -257,7 +255,6 @@ typedef struct _BAENGINE_GETVARIABLESTRING_ARGS
 typedef struct _BAENGINE_GETVARIABLESTRING_RESULTS
 {
     DWORD cbSize;
-    // The contents of wzValue may be sensitive, if variable is hidden should keep value encrypted and SecureZeroFree.
     LPWSTR wzValue;
     // Should be initialized to the size of wzValue.
     DWORD cchValue;
@@ -272,7 +269,6 @@ typedef struct _BAENGINE_GETVARIABLEVERSION_ARGS
 typedef struct _BAENGINE_GETVARIABLEVERSION_RESULTS
 {
     DWORD cbSize;
-    // The contents of wzValue may be sensitive, if variable is hidden should keep value encrypted and SecureZeroFree.
     LPWSTR wzValue;
     // Should be initialized to the size of wzValue.
     DWORD cchValue;