Refactor and remove code from WixToolset.BuildTask

1 files changed, 9 insertions, 23 deletions

diff --git a/src/WixToolset.BuildTasks/CreateItemAvoidingInference.cs b/src/WixToolset.BuildTasks/CreateItemAvoidingInference.cs
index 84816cac..3441bd85 100644
--- a/src/WixToolset.BuildTasks/CreateItemAvoidingInference.cs
+++ b/src/WixToolset.BuildTasks/CreateItemAvoidingInference.cs
@@ -3,11 +3,7 @@
 namespace WixToolset.BuildTasks
 {
     using System;
-    using System.Collections;
     using System.Collections.Generic;
-    using System.Globalization;
-    using System.IO;
-    using System.Xml;
     using Microsoft.Build.Framework;
     using Microsoft.Build.Utilities;
 
@@ -17,27 +13,17 @@ namespace WixToolset.BuildTasks
     /// </summary>
     public class CreateItemAvoidingInference : Task
     {
-        private string inputProperties;
-        private ITaskItem[] outputItems;
-
         /// <summary>
-        /// The output items.
+        /// The properties to converty to items.
         /// </summary>
-        [Output]
-        public ITaskItem[] OuputItems
-        {
-            get { return this.outputItems; }
-        }
+        [Required]
+        public string InputProperties { get; set; }
 
         /// <summary>
-        /// The properties to converty to items.
+        /// The output items.
         /// </summary>
-        [Required]
-        public string InputProperties
-        {
-            get { return this.inputProperties; }
-            set { this.inputProperties = value; }
-        }
+        [Output]
+        public ITaskItem[] OuputItems { get; private set; }
 
         /// <summary>
         /// Gets a complete list of external cabs referenced by the given installer database file.
@@ -45,14 +31,14 @@ namespace WixToolset.BuildTasks
         /// <returns>True upon completion of the task execution.</returns>
         public override bool Execute()
         {
-            List<ITaskItem> newItems = new List<ITaskItem>();
+            var newItems = new List<ITaskItem>();
 
-            foreach (string property in this.inputProperties.Split(new char[] { ';' }, StringSplitOptions.RemoveEmptyEntries))
+            foreach (var property in this.InputProperties.Split(new char[] { ';' }, StringSplitOptions.RemoveEmptyEntries))
             {
                 newItems.Add(new TaskItem(property));
             }
 
-            this.outputItems = newItems.ToArray();
+            this.OuputItems = newItems.ToArray();
 
             return true;
         }