Add failing tests for package description and packages sharing payloads

In Core projects, treat warnings as errors.

1 files changed, 4 insertions, 5 deletions

diff --git a/src/WixToolset.Core.Burn/Bundles/CreateBootstrapperApplicationManifestCommand.cs b/src/WixToolset.Core.Burn/Bundles/CreateBootstrapperApplicationManifestCommand.cs
index f85a5b62..a24137f3 100644
--- a/src/WixToolset.Core.Burn/Bundles/CreateBootstrapperApplicationManifestCommand.cs
+++ b/src/WixToolset.Core.Burn/Bundles/CreateBootstrapperApplicationManifestCommand.cs
@@ -211,7 +211,9 @@ namespace WixToolset.Core.Burn.Bundles
 
         private void WritePayloadInfo(XmlTextWriter writer)
         {
-            var payloadSymbols = this.Section.Symbols.OfType<WixBundlePayloadSymbol>();
+            // TODO: check v3 - should this be only include package payloads or include all non-UX container payloads?
+            var payloadSymbols = this.Section.Symbols.OfType<WixBundlePayloadSymbol>()
+                                                     .Where(p => !String.IsNullOrEmpty(p.PackageRef));
 
             foreach (var payloadSymbol in payloadSymbols)
             {
@@ -219,10 +221,7 @@ namespace WixToolset.Core.Burn.Bundles
 
                 writer.WriteAttributeString("Payload", payloadSymbol.Id.Id);
 
-                if (!String.IsNullOrEmpty(payloadSymbol.PackageRef))
-                {
-                    writer.WriteAttributeString("Package", payloadSymbol.PackageRef);
-                }
+                writer.WriteAttributeString("Package", payloadSymbol.PackageRef);
 
                 if (!String.IsNullOrEmpty(payloadSymbol.ContainerRef))
                 {