diff options
| author | Sean Hall <r.sean.hall@gmail.com> | 2020-04-11 21:49:09 +1000 |
|---|---|---|
| committer | Sean Hall <r.sean.hall@gmail.com> | 2020-04-12 12:46:21 +1000 |
| commit | 6d8b6f79b44b6a41a630aa3aad5a3c7f16701798 (patch) | |
| tree | b82ede9934cb7777a19e74a912c68481e76c21cd /src/WixToolset.Core.WindowsInstaller/Bind/AddCreateFoldersCommand.cs | |
| parent | df69d4172d3117d8b66ba51fa5ae7f4be538700d (diff) | |
| download | wix-6d8b6f79b44b6a41a630aa3aad5a3c7f16701798.tar.gz wix-6d8b6f79b44b6a41a630aa3aad5a3c7f16701798.tar.bz2 wix-6d8b6f79b44b6a41a630aa3aad5a3c7f16701798.zip | |
General cleanup.
Try not to send strings to specify the tuple or table.
Try to avoid using the Set method on tuples.
Always create new tuples and add them to the section in the same line.
Diffstat (limited to 'src/WixToolset.Core.WindowsInstaller/Bind/AddCreateFoldersCommand.cs')
| -rw-r--r-- | src/WixToolset.Core.WindowsInstaller/Bind/AddCreateFoldersCommand.cs | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/WixToolset.Core.WindowsInstaller/Bind/AddCreateFoldersCommand.cs b/src/WixToolset.Core.WindowsInstaller/Bind/AddCreateFoldersCommand.cs index 6cc4153f..ba844da4 100644 --- a/src/WixToolset.Core.WindowsInstaller/Bind/AddCreateFoldersCommand.cs +++ b/src/WixToolset.Core.WindowsInstaller/Bind/AddCreateFoldersCommand.cs | |||
| @@ -26,13 +26,11 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 26 | { | 26 | { |
| 27 | if (!createFolderTuplesByComponentRef.Contains(componentTuple.Id.Id)) | 27 | if (!createFolderTuplesByComponentRef.Contains(componentTuple.Id.Id)) |
| 28 | { | 28 | { |
| 29 | var createFolderTuple = new CreateFolderTuple(componentTuple.SourceLineNumbers) | 29 | this.Section.AddTuple(new CreateFolderTuple(componentTuple.SourceLineNumbers) |
| 30 | { | 30 | { |
| 31 | DirectoryRef = componentTuple.DirectoryRef, | 31 | DirectoryRef = componentTuple.DirectoryRef, |
| 32 | ComponentRef = componentTuple.Id.Id, | 32 | ComponentRef = componentTuple.Id.Id, |
| 33 | }; | 33 | }); |
| 34 | |||
| 35 | this.Section.Tuples.Add(createFolderTuple); | ||
| 36 | } | 34 | } |
| 37 | } | 35 | } |
| 38 | } | 36 | } |
