aboutsummaryrefslogtreecommitdiff
path: root/src/WixToolset.Core.WindowsInstaller/Bind/CreateCabinetsCommand.cs
diff options
context:
space:
mode:
authorRob Mensching <rob@firegiant.com>2020-05-22 14:47:36 -0700
committerRob Mensching <rob@firegiant.com>2020-05-22 15:25:19 -0700
commite8030ca17ff96a794a3fecd66bb01b81581a5451 (patch)
tree6f05c2356882f33b375e2372efecf3d60830686b /src/WixToolset.Core.WindowsInstaller/Bind/CreateCabinetsCommand.cs
parentd84ed7360adec89569eaab3793e9723f38d2a855 (diff)
downloadwix-e8030ca17ff96a794a3fecd66bb01b81581a5451.tar.gz
wix-e8030ca17ff96a794a3fecd66bb01b81581a5451.tar.bz2
wix-e8030ca17ff96a794a3fecd66bb01b81581a5451.zip
Fix naming of file in a merge module's cabinet
The file was stored in the merge module's cabinet with plain FileId, without the modularization GUID. This change fixes the cabinet builder so that it adds the modularization GUID when creating the cabinet.
Diffstat (limited to 'src/WixToolset.Core.WindowsInstaller/Bind/CreateCabinetsCommand.cs')
-rw-r--r--src/WixToolset.Core.WindowsInstaller/Bind/CreateCabinetsCommand.cs7
1 files changed, 4 insertions, 3 deletions
diff --git a/src/WixToolset.Core.WindowsInstaller/Bind/CreateCabinetsCommand.cs b/src/WixToolset.Core.WindowsInstaller/Bind/CreateCabinetsCommand.cs
index 2536eeac..6852772e 100644
--- a/src/WixToolset.Core.WindowsInstaller/Bind/CreateCabinetsCommand.cs
+++ b/src/WixToolset.Core.WindowsInstaller/Bind/CreateCabinetsCommand.cs
@@ -75,6 +75,8 @@ namespace WixToolset.Core.WindowsInstaller.Bind
75 75
76 public bool Compressed { private get; set; } 76 public bool Compressed { private get; set; }
77 77
78 public string ModularizationSuffix { private get; set; }
79
78 public Dictionary<MediaTuple, IEnumerable<FileFacade>> FileRowsByCabinet { private get; set; } 80 public Dictionary<MediaTuple, IEnumerable<FileFacade>> FileRowsByCabinet { private get; set; }
79 81
80 public Func<MediaTuple, string, string, string> ResolveMedia { private get; set; } 82 public Func<MediaTuple, string, string, string> ResolveMedia { private get; set; }
@@ -214,9 +216,8 @@ namespace WixToolset.Core.WindowsInstaller.Bind
214 // create a cabinet work item if it's not being skipped 216 // create a cabinet work item if it's not being skipped
215 if (CabinetBuildOption.BuildAndCopy == resolvedCabinet.BuildOption || CabinetBuildOption.BuildAndMove == resolvedCabinet.BuildOption) 217 if (CabinetBuildOption.BuildAndCopy == resolvedCabinet.BuildOption || CabinetBuildOption.BuildAndMove == resolvedCabinet.BuildOption)
216 { 218 {
217 int maxThreshold = 0; // default to the threshold for best smartcabbing (makes smallest cabinet). 219 // Default to the threshold for best smartcabbing (makes smallest cabinet).
218 220 cabinetWorkItem = new CabinetWorkItem(fileFacades, resolvedCabinet.Path, maxThreshold: 0, compressionLevel, this.ModularizationSuffix /*, this.FileManager*/);
219 cabinetWorkItem = new CabinetWorkItem(fileFacades, resolvedCabinet.Path, maxThreshold, compressionLevel/*, this.FileManager*/);
220 } 221 }
221 else // reuse the cabinet from the cabinet cache. 222 else // reuse the cabinet from the cabinet cache.
222 { 223 {