diff options
| author | Sean Hall <r.sean.hall@gmail.com> | 2020-04-11 21:49:09 +1000 |
|---|---|---|
| committer | Sean Hall <r.sean.hall@gmail.com> | 2020-04-12 12:46:21 +1000 |
| commit | 6d8b6f79b44b6a41a630aa3aad5a3c7f16701798 (patch) | |
| tree | b82ede9934cb7777a19e74a912c68481e76c21cd /src/WixToolset.Core.WindowsInstaller/Bind/CreateSpecialPropertiesCommand.cs | |
| parent | df69d4172d3117d8b66ba51fa5ae7f4be538700d (diff) | |
| download | wix-6d8b6f79b44b6a41a630aa3aad5a3c7f16701798.tar.gz wix-6d8b6f79b44b6a41a630aa3aad5a3c7f16701798.tar.bz2 wix-6d8b6f79b44b6a41a630aa3aad5a3c7f16701798.zip | |
General cleanup.
Try not to send strings to specify the tuple or table.
Try to avoid using the Set method on tuples.
Always create new tuples and add them to the section in the same line.
Diffstat (limited to 'src/WixToolset.Core.WindowsInstaller/Bind/CreateSpecialPropertiesCommand.cs')
| -rw-r--r-- | src/WixToolset.Core.WindowsInstaller/Bind/CreateSpecialPropertiesCommand.cs | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/src/WixToolset.Core.WindowsInstaller/Bind/CreateSpecialPropertiesCommand.cs b/src/WixToolset.Core.WindowsInstaller/Bind/CreateSpecialPropertiesCommand.cs index 0d165f80..5b4fe9e5 100644 --- a/src/WixToolset.Core.WindowsInstaller/Bind/CreateSpecialPropertiesCommand.cs +++ b/src/WixToolset.Core.WindowsInstaller/Bind/CreateSpecialPropertiesCommand.cs | |||
| @@ -57,26 +57,26 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 57 | 57 | ||
| 58 | if (0 < adminProperties.Count) | 58 | if (0 < adminProperties.Count) |
| 59 | { | 59 | { |
| 60 | var tuple = new PropertyTuple(null, new Identifier(AccessModifier.Private, "AdminProperties")); | 60 | this.Section.AddTuple(new PropertyTuple(null, new Identifier(AccessModifier.Private, "AdminProperties")) |
| 61 | tuple.Value = String.Join(";", adminProperties); | 61 | { |
| 62 | 62 | Value = String.Join(";", adminProperties), | |
| 63 | this.Section.Tuples.Add(tuple); | 63 | }); |
| 64 | } | 64 | } |
| 65 | 65 | ||
| 66 | if (0 < secureProperties.Count) | 66 | if (0 < secureProperties.Count) |
| 67 | { | 67 | { |
| 68 | var tuple = new PropertyTuple(null, new Identifier(AccessModifier.Private, "SecureCustomProperties")); | 68 | this.Section.AddTuple(new PropertyTuple(null, new Identifier(AccessModifier.Private, "SecureCustomProperties")) |
| 69 | tuple.Value = String.Join(";", secureProperties); | 69 | { |
| 70 | 70 | Value = String.Join(";", secureProperties), | |
| 71 | this.Section.Tuples.Add(tuple); | 71 | }); |
| 72 | } | 72 | } |
| 73 | 73 | ||
| 74 | if (0 < hiddenProperties.Count) | 74 | if (0 < hiddenProperties.Count) |
| 75 | { | 75 | { |
| 76 | var tuple = new PropertyTuple(null, new Identifier(AccessModifier.Private, "MsiHiddenProperties")); | 76 | this.Section.AddTuple(new PropertyTuple(null, new Identifier(AccessModifier.Private, "MsiHiddenProperties")) |
| 77 | tuple.Value = String.Join(";", hiddenProperties); | 77 | { |
| 78 | 78 | Value = String.Join(";", hiddenProperties) | |
| 79 | this.Section.Tuples.Add(tuple); | 79 | }); |
| 80 | } | 80 | } |
| 81 | } | 81 | } |
| 82 | } | 82 | } |
