aboutsummaryrefslogtreecommitdiff
path: root/src/WixToolset.Core.WindowsInstaller/Bind/ExtractMergeModuleFilesCommand.cs
diff options
context:
space:
mode:
authorRob Mensching <rob@firegiant.com>2020-06-25 14:43:50 -0700
committerRob Mensching <rob@firegiant.com>2020-06-25 14:50:31 -0700
commit38afa9e7bc7eacc021f8805f607368a05751e3c3 (patch)
tree803b0a8d9a06a7d6f7c4df408437017ae21a883e /src/WixToolset.Core.WindowsInstaller/Bind/ExtractMergeModuleFilesCommand.cs
parent8968578d50858721317d410549a9f9b5c62bf1f7 (diff)
downloadwix-38afa9e7bc7eacc021f8805f607368a05751e3c3.tar.gz
wix-38afa9e7bc7eacc021f8805f607368a05751e3c3.tar.bz2
wix-38afa9e7bc7eacc021f8805f607368a05751e3c3.zip
The Great Tuple to Symbol Rename (tm)
Diffstat (limited to 'src/WixToolset.Core.WindowsInstaller/Bind/ExtractMergeModuleFilesCommand.cs')
-rw-r--r--src/WixToolset.Core.WindowsInstaller/Bind/ExtractMergeModuleFilesCommand.cs26
1 files changed, 13 insertions, 13 deletions
diff --git a/src/WixToolset.Core.WindowsInstaller/Bind/ExtractMergeModuleFilesCommand.cs b/src/WixToolset.Core.WindowsInstaller/Bind/ExtractMergeModuleFilesCommand.cs
index 792a13a9..37bda235 100644
--- a/src/WixToolset.Core.WindowsInstaller/Bind/ExtractMergeModuleFilesCommand.cs
+++ b/src/WixToolset.Core.WindowsInstaller/Bind/ExtractMergeModuleFilesCommand.cs
@@ -12,7 +12,7 @@ namespace WixToolset.Core.WindowsInstaller.Bind
12 using WixToolset.Data; 12 using WixToolset.Data;
13 using WixToolset.Core.Native; 13 using WixToolset.Core.Native;
14 using WixToolset.Core.Bind; 14 using WixToolset.Core.Bind;
15 using WixToolset.Data.Tuples; 15 using WixToolset.Data.Symbols;
16 using WixToolset.Extensibility.Services; 16 using WixToolset.Extensibility.Services;
17 using WixToolset.Core.WindowsInstaller.Msi; 17 using WixToolset.Core.WindowsInstaller.Msi;
18 18
@@ -21,10 +21,10 @@ namespace WixToolset.Core.WindowsInstaller.Bind
21 /// </summary> 21 /// </summary>
22 internal class ExtractMergeModuleFilesCommand 22 internal class ExtractMergeModuleFilesCommand
23 { 23 {
24 public ExtractMergeModuleFilesCommand(IMessaging messaging, IEnumerable<WixMergeTuple> wixMergeTuples, IEnumerable<FileFacade> fileFacades, int installerVersion, string intermediateFolder, bool suppressLayout) 24 public ExtractMergeModuleFilesCommand(IMessaging messaging, IEnumerable<WixMergeSymbol> wixMergeSymbols, IEnumerable<FileFacade> fileFacades, int installerVersion, string intermediateFolder, bool suppressLayout)
25 { 25 {
26 this.Messaging = messaging; 26 this.Messaging = messaging;
27 this.WixMergeTuples = wixMergeTuples; 27 this.WixMergeSymbols = wixMergeSymbols;
28 this.FileFacades = fileFacades; 28 this.FileFacades = fileFacades;
29 this.OutputInstallerVersion = installerVersion; 29 this.OutputInstallerVersion = installerVersion;
30 this.IntermediateFolder = intermediateFolder; 30 this.IntermediateFolder = intermediateFolder;
@@ -33,7 +33,7 @@ namespace WixToolset.Core.WindowsInstaller.Bind
33 33
34 private IMessaging Messaging { get; } 34 private IMessaging Messaging { get; }
35 35
36 private IEnumerable<WixMergeTuple> WixMergeTuples { get; } 36 private IEnumerable<WixMergeSymbol> WixMergeSymbols { get; }
37 37
38 private IEnumerable<FileFacade> FileFacades { get; } 38 private IEnumerable<FileFacade> FileFacades { get; }
39 39
@@ -61,7 +61,7 @@ namespace WixToolset.Core.WindowsInstaller.Bind
61 // is a lot more costly for the common cases. 61 // is a lot more costly for the common cases.
62 var indexedFileFacades = this.FileFacades.ToDictionary(f => f.Id, StringComparer.Ordinal); 62 var indexedFileFacades = this.FileFacades.ToDictionary(f => f.Id, StringComparer.Ordinal);
63 63
64 foreach (var wixMergeRow in this.WixMergeTuples) 64 foreach (var wixMergeRow in this.WixMergeSymbols)
65 { 65 {
66 var containsFiles = this.CreateFacadesForMergeModuleFiles(wixMergeRow, mergeModulesFileFacades, indexedFileFacades); 66 var containsFiles = this.CreateFacadesForMergeModuleFiles(wixMergeRow, mergeModulesFileFacades, indexedFileFacades);
67 67
@@ -75,7 +75,7 @@ namespace WixToolset.Core.WindowsInstaller.Bind
75 this.MergeModulesFileFacades = mergeModulesFileFacades; 75 this.MergeModulesFileFacades = mergeModulesFileFacades;
76 } 76 }
77 77
78 private bool CreateFacadesForMergeModuleFiles(WixMergeTuple wixMergeRow, List<FileFacade> mergeModulesFileFacades, Dictionary<string, FileFacade> indexedFileFacades) 78 private bool CreateFacadesForMergeModuleFiles(WixMergeSymbol wixMergeRow, List<FileFacade> mergeModulesFileFacades, Dictionary<string, FileFacade> indexedFileFacades)
79 { 79 {
80 var containsFiles = false; 80 var containsFiles = false;
81 81
@@ -96,13 +96,13 @@ namespace WixToolset.Core.WindowsInstaller.Bind
96 // NOTE: this is very tricky - the merge module file rows are not added to the 96 // NOTE: this is very tricky - the merge module file rows are not added to the
97 // file table because they should not be created via idt import. Instead, these 97 // file table because they should not be created via idt import. Instead, these
98 // rows are created by merging in the actual modules. 98 // rows are created by merging in the actual modules.
99 var fileTuple = new FileTuple(wixMergeRow.SourceLineNumbers, new Identifier(AccessModifier.Private, record[1])); 99 var fileSymbol = new FileSymbol(wixMergeRow.SourceLineNumbers, new Identifier(AccessModifier.Private, record[1]));
100 fileTuple.Attributes = wixMergeRow.FileAttributes; 100 fileSymbol.Attributes = wixMergeRow.FileAttributes;
101 fileTuple.DirectoryRef = record[2]; 101 fileSymbol.DirectoryRef = record[2];
102 fileTuple.DiskId = wixMergeRow.DiskId; 102 fileSymbol.DiskId = wixMergeRow.DiskId;
103 fileTuple.Source = new IntermediateFieldPathValue { Path = Path.Combine(this.IntermediateFolder, wixMergeRow.Id.Id, record[1]) }; 103 fileSymbol.Source = new IntermediateFieldPathValue { Path = Path.Combine(this.IntermediateFolder, wixMergeRow.Id.Id, record[1]) };
104 104
105 var mergeModuleFileFacade = new FileFacade(true, fileTuple); 105 var mergeModuleFileFacade = new FileFacade(true, fileSymbol);
106 106
107 // If case-sensitive collision with another merge module or a user-authored file identifier. 107 // If case-sensitive collision with another merge module or a user-authored file identifier.
108 if (indexedFileFacades.TryGetValue(mergeModuleFileFacade.Id, out var collidingFacade)) 108 if (indexedFileFacades.TryGetValue(mergeModuleFileFacade.Id, out var collidingFacade))
@@ -159,7 +159,7 @@ namespace WixToolset.Core.WindowsInstaller.Bind
159 return containsFiles; 159 return containsFiles;
160 } 160 }
161 161
162 private void ExtractFilesFromMergeModule(IMsmMerge2 merge, WixMergeTuple wixMergeRow) 162 private void ExtractFilesFromMergeModule(IMsmMerge2 merge, WixMergeSymbol wixMergeRow)
163 { 163 {
164 var moduleOpen = false; 164 var moduleOpen = false;
165 short mergeLanguage; 165 short mergeLanguage;