aboutsummaryrefslogtreecommitdiff
path: root/src/WixToolset.Core.WindowsInstaller/Bind/UpdateFileFacadesCommand.cs
diff options
context:
space:
mode:
authorRob Mensching <rob@firegiant.com>2019-05-22 14:48:20 -0700
committerRob Mensching <rob@firegiant.com>2019-05-23 16:02:37 -0700
commit3859a8cd7d6001f7b49c22065e33242ddb486fbb (patch)
tree5e347f24751b0776bf60b311f4f6548030084625 /src/WixToolset.Core.WindowsInstaller/Bind/UpdateFileFacadesCommand.cs
parentfcba5d0d1cdd052ed0c960d435d5dcb62d22840d (diff)
downloadwix-3859a8cd7d6001f7b49c22065e33242ddb486fbb.tar.gz
wix-3859a8cd7d6001f7b49c22065e33242ddb486fbb.tar.bz2
wix-3859a8cd7d6001f7b49c22065e33242ddb486fbb.zip
Adopt "Ref" as reference convention over "_"
Diffstat (limited to 'src/WixToolset.Core.WindowsInstaller/Bind/UpdateFileFacadesCommand.cs')
-rw-r--r--src/WixToolset.Core.WindowsInstaller/Bind/UpdateFileFacadesCommand.cs26
1 files changed, 13 insertions, 13 deletions
diff --git a/src/WixToolset.Core.WindowsInstaller/Bind/UpdateFileFacadesCommand.cs b/src/WixToolset.Core.WindowsInstaller/Bind/UpdateFileFacadesCommand.cs
index c8451a1e..0d15bf2e 100644
--- a/src/WixToolset.Core.WindowsInstaller/Bind/UpdateFileFacadesCommand.cs
+++ b/src/WixToolset.Core.WindowsInstaller/Bind/UpdateFileFacadesCommand.cs
@@ -53,7 +53,7 @@ namespace WixToolset.Core.WindowsInstaller.Bind
53 var assemblyNameTuples = new Dictionary<string, MsiAssemblyNameTuple>(); 53 var assemblyNameTuples = new Dictionary<string, MsiAssemblyNameTuple>();
54 foreach (var assemblyTuple in this.Section.Tuples.OfType<MsiAssemblyNameTuple>()) 54 foreach (var assemblyTuple in this.Section.Tuples.OfType<MsiAssemblyNameTuple>())
55 { 55 {
56 assemblyNameTuples.Add(assemblyTuple.Component_ + "/" + assemblyTuple.Name, assemblyTuple); 56 assemblyNameTuples.Add(assemblyTuple.ComponentRef + "/" + assemblyTuple.Name, assemblyTuple);
57 } 57 }
58 58
59 FileInfo fileInfo = null; 59 FileInfo fileInfo = null;
@@ -79,7 +79,7 @@ namespace WixToolset.Core.WindowsInstaller.Bind
79 79
80 if (!fileInfo.Exists) 80 if (!fileInfo.Exists)
81 { 81 {
82 this.Messaging.Write(ErrorMessages.CannotFindFile(file.File.SourceLineNumbers, file.File.Id.Id, file.File.LongFileName, file.WixFile.Source.Path)); 82 this.Messaging.Write(ErrorMessages.CannotFindFile(file.File.SourceLineNumbers, file.File.Id.Id, file.File.Name, file.WixFile.Source.Path));
83 return; 83 return;
84 } 84 }
85 85
@@ -162,7 +162,7 @@ namespace WixToolset.Core.WindowsInstaller.Bind
162 this.Section.Tuples.Add(file.Hash); 162 this.Section.Tuples.Add(file.Hash);
163 } 163 }
164 164
165 file.Hash.File_ = file.File.Id.Id; 165 file.Hash.FileRef = file.File.Id.Id;
166 file.Hash.Options = 0; 166 file.Hash.Options = 0;
167 file.Hash.HashPart1 = hash[0]; 167 file.Hash.HashPart1 = hash[0];
168 file.Hash.HashPart2 = hash[1]; 168 file.Hash.HashPart2 = hash[1];
@@ -243,9 +243,9 @@ namespace WixToolset.Core.WindowsInstaller.Bind
243 { 243 {
244 this.SetMsiAssemblyName(assemblyNameTuples, file, "publicKeyToken", assemblyName.PublicKeyToken); 244 this.SetMsiAssemblyName(assemblyNameTuples, file, "publicKeyToken", assemblyName.PublicKeyToken);
245 } 245 }
246 else if (file.WixFile.File_AssemblyApplication == null) 246 else if (file.WixFile.AssemblyApplicationFileRef == null)
247 { 247 {
248 throw new WixException(ErrorMessages.GacAssemblyNoStrongName(file.File.SourceLineNumbers, fileInfo.FullName, file.File.Component_)); 248 throw new WixException(ErrorMessages.GacAssemblyNoStrongName(file.File.SourceLineNumbers, fileInfo.FullName, file.File.ComponentRef));
249 } 249 }
250 250
251 if (!String.IsNullOrEmpty(assemblyName.FileVersion)) 251 if (!String.IsNullOrEmpty(assemblyName.FileVersion))
@@ -269,10 +269,10 @@ namespace WixToolset.Core.WindowsInstaller.Bind
269 // TODO: Consider passing in the this.FileFacades as an indexed collection instead of searching through 269 // TODO: Consider passing in the this.FileFacades as an indexed collection instead of searching through
270 // all files like this. Even though this is a rare case it looks like we might be able to index the 270 // all files like this. Even though this is a rare case it looks like we might be able to index the
271 // file earlier. 271 // file earlier.
272 var fileManifest = this.FileFacades.FirstOrDefault(r => r.File.Id.Id.Equals(file.WixFile.File_AssemblyManifest, StringComparison.Ordinal)); 272 var fileManifest = this.FileFacades.FirstOrDefault(r => r.File.Id.Id.Equals(file.WixFile.AssemblyManifestFileRef, StringComparison.Ordinal));
273 if (null == fileManifest) 273 if (null == fileManifest)
274 { 274 {
275 this.Messaging.Write(ErrorMessages.MissingManifestForWin32Assembly(file.File.SourceLineNumbers, file.File.Id.Id, file.WixFile.File_AssemblyManifest)); 275 this.Messaging.Write(ErrorMessages.MissingManifestForWin32Assembly(file.File.SourceLineNumbers, file.File.Id.Id, file.WixFile.AssemblyManifestFileRef));
276 } 276 }
277 277
278 try 278 try
@@ -324,24 +324,24 @@ namespace WixToolset.Core.WindowsInstaller.Bind
324 // check for null value (this can occur when grabbing the file version from an assembly without one) 324 // check for null value (this can occur when grabbing the file version from an assembly without one)
325 if (String.IsNullOrEmpty(value)) 325 if (String.IsNullOrEmpty(value))
326 { 326 {
327 this.Messaging.Write(WarningMessages.NullMsiAssemblyNameValue(file.File.SourceLineNumbers, file.File.Component_, name)); 327 this.Messaging.Write(WarningMessages.NullMsiAssemblyNameValue(file.File.SourceLineNumbers, file.File.ComponentRef, name));
328 } 328 }
329 else 329 else
330 { 330 {
331 // if the assembly will be GAC'd and the name in the file table doesn't match the name in the MsiAssemblyName table, error because the install will fail. 331 // if the assembly will be GAC'd and the name in the file table doesn't match the name in the MsiAssemblyName table, error because the install will fail.
332 if ("name" == name && FileAssemblyType.DotNetAssembly == file.WixFile.AssemblyType && 332 if ("name" == name && FileAssemblyType.DotNetAssembly == file.WixFile.AssemblyType &&
333 String.IsNullOrEmpty(file.WixFile.File_AssemblyApplication) && 333 String.IsNullOrEmpty(file.WixFile.AssemblyApplicationFileRef) &&
334 !String.Equals(Path.GetFileNameWithoutExtension(file.File.LongFileName), value, StringComparison.OrdinalIgnoreCase)) 334 !String.Equals(Path.GetFileNameWithoutExtension(file.File.Name), value, StringComparison.OrdinalIgnoreCase))
335 { 335 {
336 this.Messaging.Write(ErrorMessages.GACAssemblyIdentityWarning(file.File.SourceLineNumbers, Path.GetFileNameWithoutExtension(file.File.LongFileName), value)); 336 this.Messaging.Write(ErrorMessages.GACAssemblyIdentityWarning(file.File.SourceLineNumbers, Path.GetFileNameWithoutExtension(file.File.Name), value));
337 } 337 }
338 338
339 // override directly authored value 339 // override directly authored value
340 var lookup = String.Concat(file.File.Component_, "/", name); 340 var lookup = String.Concat(file.File.ComponentRef, "/", name);
341 if (!assemblyNameTuples.TryGetValue(lookup, out var assemblyNameRow)) 341 if (!assemblyNameTuples.TryGetValue(lookup, out var assemblyNameRow))
342 { 342 {
343 assemblyNameRow = new MsiAssemblyNameTuple(file.File.SourceLineNumbers); 343 assemblyNameRow = new MsiAssemblyNameTuple(file.File.SourceLineNumbers);
344 assemblyNameRow.Component_ = file.File.Component_; 344 assemblyNameRow.ComponentRef = file.File.ComponentRef;
345 assemblyNameRow.Name = name; 345 assemblyNameRow.Name = name;
346 assemblyNameRow.Value = value; 346 assemblyNameRow.Value = value;
347 347