diff options
| author | Rob Mensching <rob@firegiant.com> | 2020-06-25 14:43:50 -0700 |
|---|---|---|
| committer | Rob Mensching <rob@firegiant.com> | 2020-06-25 14:50:31 -0700 |
| commit | 38afa9e7bc7eacc021f8805f607368a05751e3c3 (patch) | |
| tree | 803b0a8d9a06a7d6f7c4df408437017ae21a883e /src/WixToolset.Core.WindowsInstaller/Bind/UpdateFileFacadesCommand.cs | |
| parent | 8968578d50858721317d410549a9f9b5c62bf1f7 (diff) | |
| download | wix-38afa9e7bc7eacc021f8805f607368a05751e3c3.tar.gz wix-38afa9e7bc7eacc021f8805f607368a05751e3c3.tar.bz2 wix-38afa9e7bc7eacc021f8805f607368a05751e3c3.zip | |
The Great Tuple to Symbol Rename (tm)
Diffstat (limited to 'src/WixToolset.Core.WindowsInstaller/Bind/UpdateFileFacadesCommand.cs')
| -rw-r--r-- | src/WixToolset.Core.WindowsInstaller/Bind/UpdateFileFacadesCommand.cs | 50 |
1 files changed, 25 insertions, 25 deletions
diff --git a/src/WixToolset.Core.WindowsInstaller/Bind/UpdateFileFacadesCommand.cs b/src/WixToolset.Core.WindowsInstaller/Bind/UpdateFileFacadesCommand.cs index 75bcfe17..938627ed 100644 --- a/src/WixToolset.Core.WindowsInstaller/Bind/UpdateFileFacadesCommand.cs +++ b/src/WixToolset.Core.WindowsInstaller/Bind/UpdateFileFacadesCommand.cs | |||
| @@ -11,7 +11,7 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 11 | using WixToolset.Core.Bind; | 11 | using WixToolset.Core.Bind; |
| 12 | using WixToolset.Core.WindowsInstaller.Msi; | 12 | using WixToolset.Core.WindowsInstaller.Msi; |
| 13 | using WixToolset.Data; | 13 | using WixToolset.Data; |
| 14 | using WixToolset.Data.Tuples; | 14 | using WixToolset.Data.Symbols; |
| 15 | using WixToolset.Extensibility.Services; | 15 | using WixToolset.Extensibility.Services; |
| 16 | 16 | ||
| 17 | /// <summary> | 17 | /// <summary> |
| @@ -43,15 +43,15 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 43 | 43 | ||
| 44 | public void Execute() | 44 | public void Execute() |
| 45 | { | 45 | { |
| 46 | var assemblyNameTuples = this.Section.Tuples.OfType<MsiAssemblyNameTuple>().ToDictionary(t => t.Id.Id); | 46 | var assemblyNameSymbols = this.Section.Symbols.OfType<MsiAssemblyNameSymbol>().ToDictionary(t => t.Id.Id); |
| 47 | 47 | ||
| 48 | foreach (var file in this.UpdateFileFacades) | 48 | foreach (var file in this.UpdateFileFacades) |
| 49 | { | 49 | { |
| 50 | this.UpdateFileFacade(file, assemblyNameTuples); | 50 | this.UpdateFileFacade(file, assemblyNameSymbols); |
| 51 | } | 51 | } |
| 52 | } | 52 | } |
| 53 | 53 | ||
| 54 | private void UpdateFileFacade(FileFacade facade, Dictionary<string, MsiAssemblyNameTuple> assemblyNameTuples) | 54 | private void UpdateFileFacade(FileFacade facade, Dictionary<string, MsiAssemblyNameSymbol> assemblyNameSymbols) |
| 55 | { | 55 | { |
| 56 | FileInfo fileInfo = null; | 56 | FileInfo fileInfo = null; |
| 57 | try | 57 | try |
| @@ -155,7 +155,7 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 155 | 155 | ||
| 156 | if (null == facade.Hash) | 156 | if (null == facade.Hash) |
| 157 | { | 157 | { |
| 158 | facade.Hash = this.Section.AddTuple(new MsiFileHashTuple(facade.SourceLineNumber, facade.Identifier)); | 158 | facade.Hash = this.Section.AddSymbol(new MsiFileHashSymbol(facade.SourceLineNumber, facade.Identifier)); |
| 159 | } | 159 | } |
| 160 | 160 | ||
| 161 | facade.Hash.Options = 0; | 161 | facade.Hash.Options = 0; |
| @@ -220,23 +220,23 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 220 | { | 220 | { |
| 221 | var assemblyName = AssemblyNameReader.ReadAssembly(facade.SourceLineNumber, fileInfo.FullName, version); | 221 | var assemblyName = AssemblyNameReader.ReadAssembly(facade.SourceLineNumber, fileInfo.FullName, version); |
| 222 | 222 | ||
| 223 | this.SetMsiAssemblyName(assemblyNameTuples, facade, "name", assemblyName.Name); | 223 | this.SetMsiAssemblyName(assemblyNameSymbols, facade, "name", assemblyName.Name); |
| 224 | this.SetMsiAssemblyName(assemblyNameTuples, facade, "culture", assemblyName.Culture); | 224 | this.SetMsiAssemblyName(assemblyNameSymbols, facade, "culture", assemblyName.Culture); |
| 225 | this.SetMsiAssemblyName(assemblyNameTuples, facade, "version", assemblyName.Version); | 225 | this.SetMsiAssemblyName(assemblyNameSymbols, facade, "version", assemblyName.Version); |
| 226 | 226 | ||
| 227 | if (!String.IsNullOrEmpty(assemblyName.Architecture)) | 227 | if (!String.IsNullOrEmpty(assemblyName.Architecture)) |
| 228 | { | 228 | { |
| 229 | this.SetMsiAssemblyName(assemblyNameTuples, facade, "processorArchitecture", assemblyName.Architecture); | 229 | this.SetMsiAssemblyName(assemblyNameSymbols, facade, "processorArchitecture", assemblyName.Architecture); |
| 230 | } | 230 | } |
| 231 | // TODO: WiX v3 seemed to do this but not clear it should actually be done. | 231 | // TODO: WiX v3 seemed to do this but not clear it should actually be done. |
| 232 | //else if (!String.IsNullOrEmpty(file.WixFile.ProcessorArchitecture)) | 232 | //else if (!String.IsNullOrEmpty(file.WixFile.ProcessorArchitecture)) |
| 233 | //{ | 233 | //{ |
| 234 | // this.SetMsiAssemblyName(assemblyNameTuples, file, "processorArchitecture", file.WixFile.ProcessorArchitecture); | 234 | // this.SetMsiAssemblyName(assemblyNameSymbols, file, "processorArchitecture", file.WixFile.ProcessorArchitecture); |
| 235 | //} | 235 | //} |
| 236 | 236 | ||
| 237 | if (assemblyName.StrongNamedSigned) | 237 | if (assemblyName.StrongNamedSigned) |
| 238 | { | 238 | { |
| 239 | this.SetMsiAssemblyName(assemblyNameTuples, facade, "publicKeyToken", assemblyName.PublicKeyToken); | 239 | this.SetMsiAssemblyName(assemblyNameSymbols, facade, "publicKeyToken", assemblyName.PublicKeyToken); |
| 240 | } | 240 | } |
| 241 | else if (facade.AssemblyApplicationFileRef == null) | 241 | else if (facade.AssemblyApplicationFileRef == null) |
| 242 | { | 242 | { |
| @@ -245,7 +245,7 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 245 | 245 | ||
| 246 | if (!String.IsNullOrEmpty(assemblyName.FileVersion)) | 246 | if (!String.IsNullOrEmpty(assemblyName.FileVersion)) |
| 247 | { | 247 | { |
| 248 | this.SetMsiAssemblyName(assemblyNameTuples, facade, "fileVersion", assemblyName.FileVersion); | 248 | this.SetMsiAssemblyName(assemblyNameSymbols, facade, "fileVersion", assemblyName.FileVersion); |
| 249 | } | 249 | } |
| 250 | 250 | ||
| 251 | // add the assembly name to the information cache | 251 | // add the assembly name to the information cache |
| @@ -276,27 +276,27 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 276 | 276 | ||
| 277 | if (!String.IsNullOrEmpty(assemblyName.Name)) | 277 | if (!String.IsNullOrEmpty(assemblyName.Name)) |
| 278 | { | 278 | { |
| 279 | this.SetMsiAssemblyName(assemblyNameTuples, facade, "name", assemblyName.Name); | 279 | this.SetMsiAssemblyName(assemblyNameSymbols, facade, "name", assemblyName.Name); |
| 280 | } | 280 | } |
| 281 | 281 | ||
| 282 | if (!String.IsNullOrEmpty(assemblyName.Version)) | 282 | if (!String.IsNullOrEmpty(assemblyName.Version)) |
| 283 | { | 283 | { |
| 284 | this.SetMsiAssemblyName(assemblyNameTuples, facade, "version", assemblyName.Version); | 284 | this.SetMsiAssemblyName(assemblyNameSymbols, facade, "version", assemblyName.Version); |
| 285 | } | 285 | } |
| 286 | 286 | ||
| 287 | if (!String.IsNullOrEmpty(assemblyName.Type)) | 287 | if (!String.IsNullOrEmpty(assemblyName.Type)) |
| 288 | { | 288 | { |
| 289 | this.SetMsiAssemblyName(assemblyNameTuples, facade, "type", assemblyName.Type); | 289 | this.SetMsiAssemblyName(assemblyNameSymbols, facade, "type", assemblyName.Type); |
| 290 | } | 290 | } |
| 291 | 291 | ||
| 292 | if (!String.IsNullOrEmpty(assemblyName.Architecture)) | 292 | if (!String.IsNullOrEmpty(assemblyName.Architecture)) |
| 293 | { | 293 | { |
| 294 | this.SetMsiAssemblyName(assemblyNameTuples, facade, "processorArchitecture", assemblyName.Architecture); | 294 | this.SetMsiAssemblyName(assemblyNameSymbols, facade, "processorArchitecture", assemblyName.Architecture); |
| 295 | } | 295 | } |
| 296 | 296 | ||
| 297 | if (!String.IsNullOrEmpty(assemblyName.PublicKeyToken)) | 297 | if (!String.IsNullOrEmpty(assemblyName.PublicKeyToken)) |
| 298 | { | 298 | { |
| 299 | this.SetMsiAssemblyName(assemblyNameTuples, facade, "publicKeyToken", assemblyName.PublicKeyToken); | 299 | this.SetMsiAssemblyName(assemblyNameSymbols, facade, "publicKeyToken", assemblyName.PublicKeyToken); |
| 300 | } | 300 | } |
| 301 | } | 301 | } |
| 302 | catch (WixException e) | 302 | catch (WixException e) |
| @@ -310,11 +310,11 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 310 | /// Set an MsiAssemblyName row. If it was directly authored, override the value, otherwise | 310 | /// Set an MsiAssemblyName row. If it was directly authored, override the value, otherwise |
| 311 | /// create a new row. | 311 | /// create a new row. |
| 312 | /// </summary> | 312 | /// </summary> |
| 313 | /// <param name="assemblyNameTuples">MsiAssemblyName table.</param> | 313 | /// <param name="assemblyNameSymbols">MsiAssemblyName table.</param> |
| 314 | /// <param name="facade">FileFacade containing the assembly read for the MsiAssemblyName row.</param> | 314 | /// <param name="facade">FileFacade containing the assembly read for the MsiAssemblyName row.</param> |
| 315 | /// <param name="name">MsiAssemblyName name.</param> | 315 | /// <param name="name">MsiAssemblyName name.</param> |
| 316 | /// <param name="value">MsiAssemblyName value.</param> | 316 | /// <param name="value">MsiAssemblyName value.</param> |
| 317 | private void SetMsiAssemblyName(Dictionary<string, MsiAssemblyNameTuple> assemblyNameTuples, FileFacade facade, string name, string value) | 317 | private void SetMsiAssemblyName(Dictionary<string, MsiAssemblyNameSymbol> assemblyNameSymbols, FileFacade facade, string name, string value) |
| 318 | { | 318 | { |
| 319 | // check for null value (this can occur when grabbing the file version from an assembly without one) | 319 | // check for null value (this can occur when grabbing the file version from an assembly without one) |
| 320 | if (String.IsNullOrEmpty(value)) | 320 | if (String.IsNullOrEmpty(value)) |
| @@ -333,9 +333,9 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 333 | 333 | ||
| 334 | // override directly authored value | 334 | // override directly authored value |
| 335 | var lookup = String.Concat(facade.ComponentRef, "/", name); | 335 | var lookup = String.Concat(facade.ComponentRef, "/", name); |
| 336 | if (!assemblyNameTuples.TryGetValue(lookup, out var assemblyNameTuple)) | 336 | if (!assemblyNameSymbols.TryGetValue(lookup, out var assemblyNameSymbol)) |
| 337 | { | 337 | { |
| 338 | assemblyNameTuple = this.Section.AddTuple(new MsiAssemblyNameTuple(facade.SourceLineNumber, new Identifier(AccessModifier.Private, facade.ComponentRef, name)) | 338 | assemblyNameSymbol = this.Section.AddSymbol(new MsiAssemblyNameSymbol(facade.SourceLineNumber, new Identifier(AccessModifier.Private, facade.ComponentRef, name)) |
| 339 | { | 339 | { |
| 340 | ComponentRef = facade.ComponentRef, | 340 | ComponentRef = facade.ComponentRef, |
| 341 | Name = name, | 341 | Name = name, |
| @@ -344,15 +344,15 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 344 | 344 | ||
| 345 | if (null == facade.AssemblyNames) | 345 | if (null == facade.AssemblyNames) |
| 346 | { | 346 | { |
| 347 | facade.AssemblyNames = new List<MsiAssemblyNameTuple>(); | 347 | facade.AssemblyNames = new List<MsiAssemblyNameSymbol>(); |
| 348 | } | 348 | } |
| 349 | 349 | ||
| 350 | facade.AssemblyNames.Add(assemblyNameTuple); | 350 | facade.AssemblyNames.Add(assemblyNameSymbol); |
| 351 | 351 | ||
| 352 | assemblyNameTuples.Add(assemblyNameTuple.Id.Id, assemblyNameTuple); | 352 | assemblyNameSymbols.Add(assemblyNameSymbol.Id.Id, assemblyNameSymbol); |
| 353 | } | 353 | } |
| 354 | 354 | ||
| 355 | assemblyNameTuple.Value = value; | 355 | assemblyNameSymbol.Value = value; |
| 356 | 356 | ||
| 357 | if (this.VariableCache != null) | 357 | if (this.VariableCache != null) |
| 358 | { | 358 | { |
