aboutsummaryrefslogtreecommitdiff
path: root/src/WixToolset.Core.WindowsInstaller/Validator.cs
diff options
context:
space:
mode:
authorRob Mensching <rob@firegiant.com>2021-03-14 07:38:48 -0700
committerRob Mensching <rob@firegiant.com>2021-03-14 07:47:48 -0700
commit3ccd5e439da4296d6f2b66ce47075ab20d039676 (patch)
treeb5546552613b869367d09f444492a0bbcfadcfe0 /src/WixToolset.Core.WindowsInstaller/Validator.cs
parent574785ab1421c9b67336c13ade5c2263e665ca07 (diff)
downloadwix-3ccd5e439da4296d6f2b66ce47075ab20d039676.tar.gz
wix-3ccd5e439da4296d6f2b66ce47075ab20d039676.tar.bz2
wix-3ccd5e439da4296d6f2b66ce47075ab20d039676.zip
Minimize public surface area of Core
Fixes wixtoolset/issues#6374
Diffstat (limited to 'src/WixToolset.Core.WindowsInstaller/Validator.cs')
-rw-r--r--src/WixToolset.Core.WindowsInstaller/Validator.cs13
1 files changed, 3 insertions, 10 deletions
diff --git a/src/WixToolset.Core.WindowsInstaller/Validator.cs b/src/WixToolset.Core.WindowsInstaller/Validator.cs
index e8117de7..a6a41bd7 100644
--- a/src/WixToolset.Core.WindowsInstaller/Validator.cs
+++ b/src/WixToolset.Core.WindowsInstaller/Validator.cs
@@ -25,10 +25,10 @@ namespace WixToolset.Core.WindowsInstaller
25 internal sealed class Validator 25 internal sealed class Validator
26 { 26 {
27 private string actionName; 27 private string actionName;
28 private StringCollection cubeFiles; 28 private readonly StringCollection cubeFiles;
29 private ValidatorExtension extension; 29 private ValidatorExtension extension;
30 private WindowsInstallerData output; 30 private WindowsInstallerData output;
31 private InstallUIHandler validationUIHandler; 31 private readonly InstallUIHandler validationUIHandler;
32 private bool validationSessionComplete; 32 private bool validationSessionComplete;
33 private readonly IMessaging messaging; 33 private readonly IMessaging messaging;
34 34
@@ -57,7 +57,6 @@ namespace WixToolset.Core.WindowsInstaller
57 /// Gets or sets the list of ICEs to run. 57 /// Gets or sets the list of ICEs to run.
58 /// </summary> 58 /// </summary>
59 /// <value>The list of ICEs.</value> 59 /// <value>The list of ICEs.</value>
60 [SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
61 public ISet<string> ICEs { get; set; } 60 public ISet<string> ICEs { get; set; }
62 61
63 /// <summary> 62 /// <summary>
@@ -75,7 +74,6 @@ namespace WixToolset.Core.WindowsInstaller
75 /// Gets or sets the suppressed ICEs. 74 /// Gets or sets the suppressed ICEs.
76 /// </summary> 75 /// </summary>
77 /// <value>The suppressed ICEs.</value> 76 /// <value>The suppressed ICEs.</value>
78 [SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
79 public ISet<string> SuppressedICEs { get; set; } 77 public ISet<string> SuppressedICEs { get; set; }
80 78
81 /// <summary> 79 /// <summary>
@@ -103,13 +101,8 @@ namespace WixToolset.Core.WindowsInstaller
103 IntPtr previousHwnd = IntPtr.Zero; 101 IntPtr previousHwnd = IntPtr.Zero;
104 InstallUIHandler previousUIHandler = null; 102 InstallUIHandler previousUIHandler = null;
105 103
106 if (null == databaseFile)
107 {
108 throw new ArgumentNullException("databaseFile");
109 }
110
111 // initialize the validator extension 104 // initialize the validator extension
112 this.extension.DatabaseFile = databaseFile; 105 this.extension.DatabaseFile = databaseFile ?? throw new ArgumentNullException(nameof(databaseFile));
113 this.extension.Output = this.output; 106 this.extension.Output = this.output;
114 this.extension.InitializeValidator(); 107 this.extension.InitializeValidator();
115 108